1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
|
package git
import (
"bytes"
"fmt"
"strconv"
"strings"
)
// minimumVersion is the minimum required Git version. If updating this version, be sure to
// also update the following locations:
// - https://gitlab.com/gitlab-org/gitaly/blob/master/README.md#installation
// - https://gitlab.com/gitlab-org/gitaly/blob/master/.gitlab-ci.yml
// - https://docs.gitlab.com/ee/install/installation.html#software-requirements
// - https://docs.gitlab.com/ee/update/ (see e.g. https://docs.gitlab.com/ee/update/#1440)
var minimumVersion = Version{
versionString: "2.38.0",
major: 2,
minor: 38,
patch: 0,
rc: false,
// gl is the GitLab patch level.
gl: 0,
}
// Version represents the version of git itself.
type Version struct {
// versionString is the string representation of the version. The string representation is
// not directly derived from the parsed version information because we do not extract all
// information from the original version string. Deriving it from parsed information would
// thus potentially lose information.
versionString string
major, minor, patch uint32
rc bool
gl uint32
}
// NewVersion constructs a new Git version from the given components.
func NewVersion(major, minor, patch, gl uint32) Version {
return Version{
versionString: fmt.Sprintf("%d.%d.%d.gl%d", major, minor, patch, gl),
major: major,
minor: minor,
patch: patch,
gl: gl,
}
}
// parseVersionOutput parses output returned by git-version(1). It is expected to be in the format
// "git version 2.39.1.gl1".
func parseVersionOutput(versionOutput []byte) (Version, error) {
trimmedVersionOutput := string(bytes.Trim(versionOutput, " \n"))
versionString := strings.SplitN(trimmedVersionOutput, " ", 3)
if len(versionString) != 3 {
return Version{}, fmt.Errorf("invalid version format: %q", string(versionOutput))
}
version, err := parseVersion(versionString[2])
if err != nil {
return Version{}, fmt.Errorf("cannot parse git version: %w", err)
}
return version, nil
}
// String returns the string representation of the version.
func (v Version) String() string {
return v.versionString
}
// IsSupported checks if a version string corresponds to a Git version
// supported by Gitaly.
func (v Version) IsSupported() bool {
return !v.LessThan(minimumVersion)
}
// HashObjectFsck detects whether or not the given Git version will do fsck
// checks when git-hash-object writes objects.
func (v Version) HashObjectFsck() bool {
return !v.LessThan(Version{
major: 2, minor: 40, patch: 0,
})
}
// PatchIDRespectsBinaries detects whether the given Git version correctly handles binary diffs when
// computing a patch ID. Previous to Git v2.39.0, git-patch-id(1) just completely ignored any binary
// diffs and thus would consider two diffs the same even if a binary changed.
func (v Version) PatchIDRespectsBinaries() bool {
return !v.LessThan(Version{
major: 2, minor: 39, patch: 0,
})
}
// MidxDeletesRedundantBitmaps detects whether the given Git version deletes redundant pack-based
// bitmaps when writing multi-pack-indices. This feature has been added via 55d902cd61
// (builtin/repack.c: remove redundant pack-based bitmaps, 2022-10-17), which is part of Git
// v2.39.0 and newer.
func (v Version) MidxDeletesRedundantBitmaps() bool {
return !v.LessThan(Version{
major: 2, minor: 39, patch: 0,
})
}
// GeometricRepackingSupportsAlternates detects whether the given Git version knows to perform
// geometric repacking in repositories which are connected to an alternate object database. This
// used to not work due to various different bugs which have been fixed via de56e80363 (Merge branch
// 'ps/fix-geom-repack-with-alternates' into next, 2023-04-18).
//
// The patches will be part of Git v2.41.0 and have been backported to Git v2.40.0.gl1.
func (v Version) GeometricRepackingSupportsAlternates() bool {
if v.major == 2 && v.minor == 40 && v.gl > 0 {
return true
}
return !v.LessThan(Version{
major: 2, minor: 41,
})
}
// LessThan determines whether the version is older than another version.
func (v Version) LessThan(other Version) bool {
switch {
case v.major < other.major:
return true
case v.major > other.major:
return false
case v.minor < other.minor:
return true
case v.minor > other.minor:
return false
case v.patch < other.patch:
return true
case v.patch > other.patch:
return false
case v.rc && !other.rc:
return true
case !v.rc && other.rc:
return false
case v.gl < other.gl:
return true
case v.gl > other.gl:
return false
default:
// this should only be reachable when versions are equal
return false
}
}
func parseVersion(versionStr string) (Version, error) {
versionSplit := strings.SplitN(versionStr, ".", 4)
if len(versionSplit) < 3 {
return Version{}, fmt.Errorf("expected major.minor.patch in %q", versionStr)
}
ver := Version{
versionString: versionStr,
}
for i, v := range []*uint32{&ver.major, &ver.minor, &ver.patch} {
var n64 uint64
if versionSplit[i] == "GIT" {
// Git falls back to vx.x.GIT if it's unable to describe the current version
// or if there's a version file. We should just treat this as "0", even
// though it may have additional commits on top.
n64 = 0
} else {
rcSplit := strings.SplitN(versionSplit[i], "-", 2)
var err error
n64, err = strconv.ParseUint(rcSplit[0], 10, 32)
if err != nil {
return Version{}, err
}
if len(rcSplit) == 2 && strings.HasPrefix(rcSplit[1], "rc") {
ver.rc = true
}
}
*v = uint32(n64)
}
if len(versionSplit) == 4 {
if strings.HasPrefix(versionSplit[3], "rc") {
ver.rc = true
} else if strings.HasPrefix(versionSplit[3], "gl") {
gitlabPatchLevel := versionSplit[3][2:]
gl, err := strconv.ParseUint(gitlabPatchLevel, 10, 32)
if err != nil {
return Version{}, err
}
ver.gl = uint32(gl)
}
}
return ver, nil
}
|
