1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
|
package objectpool
import (
"os"
"path/filepath"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v16/internal/git"
"gitlab.com/gitlab-org/gitaly/v16/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v16/internal/git/localrepo"
"gitlab.com/gitlab-org/gitaly/v16/internal/gitaly/storage"
"gitlab.com/gitlab-org/gitaly/v16/internal/helper/perm"
"gitlab.com/gitlab-org/gitaly/v16/internal/structerr"
"gitlab.com/gitlab-org/gitaly/v16/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v16/internal/testhelper/testserver"
"gitlab.com/gitlab-org/gitaly/v16/proto/go/gitalypb"
)
func TestLink(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg, repo, _, _, client := setup(t, ctx, testserver.WithDisablePraefect())
localRepo := localrepo.NewTestRepo(t, cfg, repo)
poolProto, _, poolPath := createObjectPool(t, ctx, cfg, repo)
// Mock object in the pool, which should be available to the pool members
// after linking
poolCommitID := gittest.WriteCommit(t, cfg, poolPath,
gittest.WithBranch("pool-test-branch"))
for _, tc := range []struct {
desc string
request *gitalypb.LinkRepositoryToObjectPoolRequest
expectedErr error
}{
{
desc: "unset repository",
request: &gitalypb.LinkRepositoryToObjectPoolRequest{
Repository: nil,
ObjectPool: poolProto,
},
expectedErr: structerr.NewInvalidArgument("%w", storage.ErrRepositoryNotSet),
},
{
desc: "unset object pool",
request: &gitalypb.LinkRepositoryToObjectPoolRequest{
Repository: repo,
ObjectPool: nil,
},
expectedErr: structerr.NewInvalidArgument("%w", storage.ErrRepositoryNotSet),
},
{
desc: "successful",
request: &gitalypb.LinkRepositoryToObjectPoolRequest{
Repository: repo,
ObjectPool: poolProto,
},
},
} {
t.Run(tc.desc, func(t *testing.T) {
_, err := client.LinkRepositoryToObjectPool(ctx, tc.request)
testhelper.RequireGrpcError(t, tc.expectedErr, err)
if tc.expectedErr != nil {
return
}
commit, err := localRepo.ReadCommit(ctx, git.Revision(poolCommitID))
require.NoError(t, err)
require.NotNil(t, commit)
require.Equal(t, poolCommitID.String(), commit.Id)
})
}
}
func TestLink_idempotent(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg, repoProto, _, _, client := setup(t, ctx)
poolProto, _, _ := createObjectPool(t, ctx, cfg, repoProto)
request := &gitalypb.LinkRepositoryToObjectPoolRequest{
Repository: repoProto,
ObjectPool: poolProto,
}
_, err := client.LinkRepositoryToObjectPool(ctx, request)
require.NoError(t, err)
_, err = client.LinkRepositoryToObjectPool(ctx, request)
require.NoError(t, err)
}
func TestLink_noClobber(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg, repoProto, repoPath, _, client := setup(t, ctx)
poolProto, _, _ := createObjectPool(t, ctx, cfg, repoProto)
alternatesFile := filepath.Join(repoPath, "objects/info/alternates")
require.NoFileExists(t, alternatesFile)
contentBefore := "mock/objects\n"
require.NoError(t, os.WriteFile(alternatesFile, []byte(contentBefore), perm.SharedFile))
request := &gitalypb.LinkRepositoryToObjectPoolRequest{
Repository: repoProto,
ObjectPool: poolProto,
}
_, err := client.LinkRepositoryToObjectPool(ctx, request)
testhelper.RequireGrpcError(t, structerr.NewInternal("unexpected alternates content: %q", "mock/objects"), err)
contentAfter := testhelper.MustReadFile(t, alternatesFile)
require.Equal(t, contentBefore, string(contentAfter), "contents of existing alternates file should not have changed")
}
func TestLink_noPool(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg, repo, _, _, client := setup(t, ctx)
poolRelativePath := gittest.NewObjectPoolName(t)
_, err := client.LinkRepositoryToObjectPool(ctx, &gitalypb.LinkRepositoryToObjectPoolRequest{
Repository: repo,
ObjectPool: &gitalypb.ObjectPool{
Repository: &gitalypb.Repository{
StorageName: cfg.Storages[0].Name,
RelativePath: poolRelativePath,
},
},
})
testhelper.RequireGrpcError(t, testhelper.GitalyOrPraefect(
structerr.NewFailedPrecondition("object pool is not a valid git repository"),
testhelper.WithInterceptedMetadataItems(
structerr.NewNotFound("mutator call: route repository mutator: resolve additional replica path: additional repository not found"),
structerr.MetadataItem{Key: "relative_path", Value: poolRelativePath},
structerr.MetadataItem{Key: "storage_name", Value: cfg.Storages[0].Name},
),
), err)
}
|
