1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
|
package repository
import (
"context"
"fmt"
"io/ioutil"
"os"
"path/filepath"
"testing"
"time"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v14/internal/git"
"gitlab.com/gitlab-org/gitaly/v14/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v14/internal/git/localrepo"
"gitlab.com/gitlab-org/gitaly/v14/internal/git/stats"
"gitlab.com/gitlab-org/gitaly/v14/internal/gitaly/config"
"gitlab.com/gitlab-org/gitaly/v14/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v14/proto/go/gitalypb"
)
func TestMidxWrite(t *testing.T) {
cfg, repo, repoPath, client := setupRepositoryService(t)
ctx, cancel := testhelper.Context()
defer cancel()
_, err := client.MidxRepack(ctx, &gitalypb.MidxRepackRequest{Repository: repo})
assert.NoError(t, err)
require.FileExists(t,
filepath.Join(repoPath, MidxRelPath),
"multi-pack-index should exist after running MidxRepack",
)
repoCfgPath := filepath.Join(repoPath, "config")
cfgF, err := os.Open(repoCfgPath)
require.NoError(t, err)
defer cfgF.Close()
cfgCmd, err := localrepo.NewTestRepo(t, cfg, repo).Config().GetRegexp(ctx, "core.multipackindex", git.ConfigGetRegexpOpts{})
require.NoError(t, err)
require.Equal(t, []git.ConfigPair{{Key: "core.multipackindex", Value: "true"}}, cfgCmd)
}
func TestMidxRewrite(t *testing.T) {
_, repo, repoPath, client := setupRepositoryService(t)
ctx, cancel := testhelper.Context()
defer cancel()
midxPath := filepath.Join(repoPath, MidxRelPath)
// Create an invalid multi-pack-index file
// with mtime update being the basis for comparison
require.NoError(t, ioutil.WriteFile(midxPath, nil, 0644))
require.NoError(t, os.Chtimes(midxPath, time.Time{}, time.Time{}))
info, err := os.Stat(midxPath)
require.NoError(t, err)
mt := info.ModTime()
_, err = client.MidxRepack(ctx, &gitalypb.MidxRepackRequest{Repository: repo})
require.NoError(t, err)
require.FileExists(t,
filepath.Join(repoPath, MidxRelPath),
"multi-pack-index should exist after running MidxRepack",
)
assertModTimeAfter(t, mt, midxPath)
}
func TestMidxRepack(t *testing.T) {
cfg, repo, repoPath, client := setupRepositoryService(t)
ctx, cancel := testhelper.Context()
defer cancel()
// add some pack files with different sizes
packsAdded := 5
addPackFiles(t, ctx, cfg, client, repo, repoPath, packsAdded, true)
// record pack count
actualCount, err := stats.PackfilesCount(repoPath)
require.NoError(t, err)
require.Equal(t,
packsAdded+1, // expect
actualCount, // actual
"New pack files should have been created",
)
_, err = client.MidxRepack(
ctx,
&gitalypb.MidxRepackRequest{
Repository: repo,
},
)
require.NoError(t, err)
actualCount, err = stats.PackfilesCount(repoPath)
require.NoError(t, err)
require.Equal(t,
packsAdded+2, // expect
actualCount, // actual
"At least 1 pack file should have been created",
)
newPackFile := findNewestPackFile(t, repoPath)
assert.True(t, newPackFile.ModTime().After(time.Time{}))
}
func TestMidxRepackExpire(t *testing.T) {
cfg, client := setupRepositoryServiceWithoutRepo(t)
for _, packsAdded := range []int{3, 5, 11, 20} {
t.Run(fmt.Sprintf("Test repack expire with %d added packs", packsAdded),
func(t *testing.T) {
repo, repoPath, cleanupFn := gittest.CloneRepoAtStorage(t, cfg, cfg.Storages[0], t.Name())
t.Cleanup(cleanupFn)
ctx, cancel := testhelper.Context()
defer cancel()
// add some pack files with different sizes
addPackFiles(t, ctx, cfg, client, repo, repoPath, packsAdded, false)
// record pack count
actualCount, err := stats.PackfilesCount(repoPath)
require.NoError(t, err)
require.Equal(t,
packsAdded+1, // expect
actualCount, // actual
"New pack files should have been created",
)
// here we assure that for n packCount
// we should need no more than n interation(s)
// for the pack files to be consolidated into
// a new second biggest pack
i := 0
packCount := packsAdded + 1
for {
if i > packsAdded+1 {
break
}
i++
_, err := client.MidxRepack(
ctx,
&gitalypb.MidxRepackRequest{
Repository: repo,
},
)
require.NoError(t, err)
packCount, err = stats.PackfilesCount(repoPath)
require.NoError(t, err)
if packCount == 2 {
break
}
}
require.Equal(t,
2, // expect
packCount, // actual
fmt.Sprintf(
"all small packs should be consolidated to a second biggest pack "+
"after at most %d iterations (actual %d))",
packCount,
i,
),
)
})
}
}
// findNewestPackFile returns the latest created pack file in repo's odb
func findNewestPackFile(t *testing.T, repoPath string) os.FileInfo {
t.Helper()
files, err := stats.GetPackfiles(repoPath)
require.NoError(t, err)
var newestPack os.FileInfo
for _, f := range files {
if newestPack == nil || f.ModTime().After(newestPack.ModTime()) {
newestPack = f
}
}
require.NotNil(t, newestPack)
return newestPack
}
// addPackFiles creates some packfiles by
// creating some commits objects and repack them.
func addPackFiles(
t *testing.T,
ctx context.Context,
cfg config.Cfg,
client gitalypb.RepositoryServiceClient,
repo *gitalypb.Repository,
repoPath string,
packCount int,
resetModTime bool,
) {
t.Helper()
// do a full repack to ensure we start with 1 pack
_, err := client.RepackFull(ctx, &gitalypb.RepackFullRequest{Repository: repo, CreateBitmap: true})
require.NoError(t, err)
// create some pack files with different sizes
for i := 0; i < packCount; i++ {
for y := packCount + 1 - i; y > 0; y-- {
branch := fmt.Sprintf("branch-%d-%d", i, y)
gittest.WriteCommit(t, cfg, repoPath, gittest.WithMessage(branch), gittest.WithBranch(branch))
}
_, err = client.RepackIncremental(ctx, &gitalypb.RepackIncrementalRequest{Repository: repo})
require.NoError(t, err)
}
// reset mtime of packfile to mark them separately
// for comparison purpose
if resetModTime {
packDir := filepath.Join(repoPath, "objects/pack/")
files, err := stats.GetPackfiles(repoPath)
require.NoError(t, err)
for _, f := range files {
require.NoError(t, os.Chtimes(filepath.Join(packDir, f.Name()), time.Time{}, time.Time{}))
}
}
}
|