1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
|
package repository
import (
"bytes"
"encoding/json"
"os/exec"
"path/filepath"
"strings"
"testing"
"time"
"github.com/sirupsen/logrus"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v14/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v14/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v14/internal/testhelper/testserver"
"gitlab.com/gitlab-org/gitaly/v14/proto/go/gitalypb"
"google.golang.org/grpc/codes"
)
func TestRepackIncrementalSuccess(t *testing.T) {
_, repo, repoPath, client := setupRepositoryService(t)
packPath := filepath.Join(repoPath, "objects", "pack")
// Reset mtime to a long while ago since some filesystems don't have sub-second
// precision on `mtime`.
// Stamp taken from https://golang.org/pkg/time/#pkg-constants
testhelper.MustRunCommand(t, nil, "touch", "-t", testTimeString, filepath.Join(packPath, "*"))
testTime := time.Date(2006, 01, 02, 15, 04, 05, 0, time.UTC)
ctx, cancel := testhelper.Context()
defer cancel()
c, err := client.RepackIncremental(ctx, &gitalypb.RepackIncrementalRequest{Repository: repo})
assert.NoError(t, err)
assert.NotNil(t, c)
// Entire `path`-folder gets updated so this is fine :D
assertModTimeAfter(t, testTime, packPath)
assert.FileExistsf(t,
filepath.Join(repoPath, CommitGraphChainRelPath),
"pre-computed commit-graph should exist after running incremental repack",
)
}
func TestRepackIncrementalCollectLogStatistics(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
logBuffer := &bytes.Buffer{}
logger := &logrus.Logger{Out: logBuffer, Formatter: &logrus.JSONFormatter{}, Level: logrus.InfoLevel}
_, repo, _, client := setupRepositoryService(t, testserver.WithLogger(logger))
_, err := client.RepackIncremental(ctx, &gitalypb.RepackIncrementalRequest{Repository: repo})
assert.NoError(t, err)
mustCountObjectLog(t, logBuffer.String())
}
func TestRepackLocal(t *testing.T) {
cfg, repo, repoPath, client := setupRepositoryServiceWithWorktree(t)
commiterArgs := []string{"-c", "user.name=Scrooge McDuck", "-c", "user.email=scrooge@mcduck.com"}
cmdArgs := append(commiterArgs, "-C", repoPath, "commit", "--allow-empty", "-m", "An empty commit")
cmd := exec.Command(cfg.Git.BinPath, cmdArgs...)
altObjectsDir := "./alt-objects"
altDirsCommit := gittest.CreateCommitInAlternateObjectDirectory(t, cfg.Git.BinPath, repoPath, altObjectsDir, cmd)
repoCommit := gittest.WriteCommit(t, cfg, repoPath, gittest.WithBranch(t.Name()))
ctx, cancelFn := testhelper.Context()
defer cancelFn()
// Set GIT_ALTERNATE_OBJECT_DIRECTORIES on the outgoing request. The
// intended use case of the behavior we're testing here is that
// alternates are found through the objects/info/alternates file instead
// of GIT_ALTERNATE_OBJECT_DIRECTORIES. But for the purpose of this test
// it doesn't matter.
repo.GitAlternateObjectDirectories = []string{altObjectsDir}
_, err := client.RepackFull(ctx, &gitalypb.RepackFullRequest{Repository: repo})
require.NoError(t, err)
packFiles, err := filepath.Glob(filepath.Join(repoPath, ".git", "objects", "pack", "pack-*.pack"))
require.NoError(t, err)
require.Len(t, packFiles, 1)
packContents := gittest.Exec(t, cfg, "-C", repoPath, "verify-pack", "-v", packFiles[0])
require.NotContains(t, string(packContents), string(altDirsCommit))
require.Contains(t, string(packContents), repoCommit)
}
func TestRepackIncrementalFailure(t *testing.T) {
cfg, client := setupRepositoryServiceWithoutRepo(t)
tests := []struct {
repo *gitalypb.Repository
code codes.Code
desc string
}{
{desc: "nil repo", repo: nil, code: codes.InvalidArgument},
{desc: "invalid storage name", repo: &gitalypb.Repository{StorageName: "foo"}, code: codes.InvalidArgument},
{desc: "no storage name", repo: &gitalypb.Repository{RelativePath: "bar"}, code: codes.InvalidArgument},
{desc: "non-existing repo", repo: &gitalypb.Repository{StorageName: cfg.Storages[0].Name, RelativePath: "bar"}, code: codes.NotFound},
}
for _, test := range tests {
t.Run(test.desc, func(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
_, err := client.RepackIncremental(ctx, &gitalypb.RepackIncrementalRequest{Repository: test.repo})
testhelper.RequireGrpcError(t, err, test.code)
})
}
}
func TestRepackFullSuccess(t *testing.T) {
cfg, client := setupRepositoryServiceWithoutRepo(t)
tests := []struct {
req *gitalypb.RepackFullRequest
desc string
}{
{req: &gitalypb.RepackFullRequest{CreateBitmap: true}, desc: "with bitmap"},
{req: &gitalypb.RepackFullRequest{CreateBitmap: false}, desc: "without bitmap"},
}
for _, test := range tests {
t.Run(test.desc, func(t *testing.T) {
var repoPath string
test.req.Repository, repoPath, _ = gittest.CloneRepoAtStorage(t, cfg, cfg.Storages[0], t.Name())
// Reset mtime to a long while ago since some filesystems don't have sub-second
// precision on `mtime`.
packPath := filepath.Join(repoPath, "objects", "pack")
testhelper.MustRunCommand(t, nil, "touch", "-t", testTimeString, packPath)
testTime := time.Date(2006, 01, 02, 15, 04, 05, 0, time.UTC)
ctx, cancel := testhelper.Context()
defer cancel()
c, err := client.RepackFull(ctx, test.req)
assert.NoError(t, err)
assert.NotNil(t, c)
// Entire `path`-folder gets updated so this is fine :D
assertModTimeAfter(t, testTime, packPath)
bmPath, err := filepath.Glob(filepath.Join(packPath, "pack-*.bitmap"))
if err != nil {
t.Fatalf("Error globbing bitmaps: %v", err)
}
if test.req.GetCreateBitmap() {
if len(bmPath) == 0 {
t.Errorf("No bitmaps found")
}
doBitmapsContainHashCache(t, bmPath)
} else {
if len(bmPath) != 0 {
t.Errorf("Bitmap found: %v", bmPath)
}
}
assert.FileExistsf(t,
filepath.Join(repoPath, CommitGraphChainRelPath),
"pre-computed commit-graph should exist after running full repack",
)
})
}
}
func TestRepackFullCollectLogStatistics(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
logBuffer := &bytes.Buffer{}
logger := &logrus.Logger{Out: logBuffer, Formatter: &logrus.JSONFormatter{}, Level: logrus.InfoLevel}
_, repo, _, client := setupRepositoryService(t, testserver.WithLogger(logger))
_, err := client.RepackFull(ctx, &gitalypb.RepackFullRequest{Repository: repo})
require.NoError(t, err)
mustCountObjectLog(t, logBuffer.String())
}
func mustCountObjectLog(t testing.TB, logData string) {
t.Helper()
msgs := strings.Split(logData, "\n")
const key = "count_objects"
for _, msg := range msgs {
if strings.Contains(msg, key) {
var out map[string]interface{}
require.NoError(t, json.NewDecoder(strings.NewReader(msg)).Decode(&out))
require.Contains(t, out, "grpc.request.glProjectPath")
require.Contains(t, out, "grpc.request.glRepository")
require.Contains(t, out, key, "there is no any information about statistics")
countObjects := out[key].(map[string]interface{})
require.Contains(t, countObjects, "count")
return
}
}
require.FailNow(t, "no info about statistics")
}
func doBitmapsContainHashCache(t *testing.T, bitmapPaths []string) {
// for each bitmap file, check the 2-byte flag as documented in
// https://github.com/git/git/blob/master/Documentation/technical/bitmap-format.txt
for _, bitmapPath := range bitmapPaths {
gittest.TestBitmapHasHashcache(t, bitmapPath)
}
}
func TestRepackFullFailure(t *testing.T) {
cfg, client := setupRepositoryServiceWithoutRepo(t)
tests := []struct {
repo *gitalypb.Repository
code codes.Code
desc string
}{
{desc: "nil repo", repo: nil, code: codes.InvalidArgument},
{desc: "invalid storage name", repo: &gitalypb.Repository{StorageName: "foo"}, code: codes.InvalidArgument},
{desc: "no storage name", repo: &gitalypb.Repository{RelativePath: "bar"}, code: codes.InvalidArgument},
{desc: "non-existing repo", repo: &gitalypb.Repository{StorageName: cfg.Storages[0].Name, RelativePath: "bar"}, code: codes.NotFound},
}
for _, test := range tests {
t.Run(test.desc, func(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
_, err := client.RepackFull(ctx, &gitalypb.RepackFullRequest{Repository: test.repo})
testhelper.RequireGrpcError(t, err, test.code)
})
}
}
func TestRepackFullDeltaIslands(t *testing.T) {
cfg, repo, repoPath, client := setupRepositoryService(t)
ctx, cancel := testhelper.Context()
defer cancel()
gittest.TestDeltaIslands(t, cfg, repoPath, func() error {
_, err := client.RepackFull(ctx, &gitalypb.RepackFullRequest{Repository: repo})
return err
})
}
func TestLog2Threads(t *testing.T) {
for _, tt := range []struct {
cpus int
threads string
}{
{1, "1"},
{2, "1"},
{3, "1"},
{4, "2"},
{8, "3"},
{9, "3"},
{13, "3"},
{16, "4"},
{27, "4"},
{32, "5"},
} {
actualThreads := log2Threads(tt.cpus)
require.Equal(t, tt.threads, actualThreads.Value)
}
}
|
