Add latest changes from gitlab-org/gitlab@master

7 files changed, 0 insertions, 34 deletions

diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml
index 2b01db2e440..a18dec335d1 100644
--- a/.rubocop_todo/rails/file_path.yml
+++ b/.rubocop_todo/rails/file_path.yml
@@ -3,10 +3,8 @@ Rails/FilePath:
   Exclude:
     - 'app/controllers/help_controller.rb'
     - 'app/helpers/startupjs_helper.rb'
-    - 'app/models/clusters/applications/cert_manager.rb'
     - 'app/models/clusters/concerns/application_data.rb'
     - 'app/models/concerns/cross_database_modification.rb'
-    - 'app/models/release_highlight.rb'
     - 'app/serializers/review_app_setup_entity.rb'
     - 'app/services/metrics/sample_metrics_service.rb'
     - 'app/services/projects/readme_renderer_service.rb'
@@ -15,7 +13,6 @@ Rails/FilePath:
     - 'config/initializers/7_prometheus_metrics.rb'
     - 'config/initializers/lograge.rb'
     - 'config/initializers_before_autoloader/001_fast_gettext.rb'
-    - 'db/post_migrate/20210630025020_migrate_push_event_payloads_event_id_back_to_integer_for_gitlab_com.rb'
     - 'ee/app/helpers/ee/application_helper.rb'
     - 'ee/app/services/security/security_orchestration_policies/project_create_service.rb'
     - 'ee/lib/ee/feature/definition.rb'
@@ -118,7 +115,6 @@ Rails/FilePath:
     - 'spec/lib/gitlab/project_transfer_spec.rb'
     - 'spec/lib/gitlab/sanitizers/svg_spec.rb'
     - 'spec/metrics_server/metrics_server_spec.rb'
-    - 'spec/models/clusters/applications/cert_manager_spec.rb'
     - 'spec/models/release_highlight_spec.rb'
     - 'spec/requests/api/internal/mail_room_spec.rb'
     - 'spec/requests/api/usage_data_queries_spec.rb'
diff --git a/.rubocop_todo/rails/helper_instance_variable.yml b/.rubocop_todo/rails/helper_instance_variable.yml
index 4ac41a14039..13c681a634a 100644
--- a/.rubocop_todo/rails/helper_instance_variable.yml
+++ b/.rubocop_todo/rails/helper_instance_variable.yml
@@ -43,7 +43,6 @@ Rails/HelperInstanceVariable:
     - 'app/helpers/routing/pseudonymization_helper.rb'
     - 'app/helpers/routing/snippets_helper.rb'
     - 'app/helpers/search_helper.rb'
-    - 'app/helpers/selects_helper.rb'
     - 'app/helpers/startupjs_helper.rb'
     - 'app/helpers/submodule_helper.rb'
     - 'app/helpers/tab_helper.rb'
diff --git a/.rubocop_todo/rails/inverse_of.yml b/.rubocop_todo/rails/inverse_of.yml
index 28817bebc48..31535699d2e 100644
--- a/.rubocop_todo/rails/inverse_of.yml
+++ b/.rubocop_todo/rails/inverse_of.yml
@@ -3,7 +3,6 @@ Rails/InverseOf:
   Exclude:
     - 'app/models/alert_management/alert.rb'
     - 'app/models/alert_management/alert_assignee.rb'
-    - 'app/models/analytics/cycle_analytics/project_stage.rb'
     - 'app/models/application_setting.rb'
     - 'app/models/audit_event.rb'
     - 'app/models/board.rb'
diff --git a/.rubocop_todo/rails/lexically_scoped_action_filter.yml b/.rubocop_todo/rails/lexically_scoped_action_filter.yml
index dde0da13d3c..1620fbd39b7 100644
--- a/.rubocop_todo/rails/lexically_scoped_action_filter.yml
+++ b/.rubocop_todo/rails/lexically_scoped_action_filter.yml
@@ -21,7 +21,6 @@ Rails/LexicallyScopedActionFilter:
     - 'app/controllers/import/base_controller.rb'
     - 'app/controllers/oauth/applications_controller.rb'
     - 'app/controllers/passwords_controller.rb'
-    - 'app/controllers/projects/analytics/cycle_analytics/stages_controller.rb'
     - 'app/controllers/projects/badges_controller.rb'
     - 'app/controllers/projects/branches_controller.rb'
     - 'app/controllers/projects/environments_controller.rb'
diff --git a/.rubocop_todo/rails/negate_include.yml b/.rubocop_todo/rails/negate_include.yml
index 14e5ceae628..48a1e4483b9 100644
--- a/.rubocop_todo/rails/negate_include.yml
+++ b/.rubocop_todo/rails/negate_include.yml
@@ -16,7 +16,6 @@ Rails/NegateInclude:
     - 'app/services/work_items/parent_links/create_service.rb'
     - 'config/application.rb'
     - 'config/initializers/1_settings.rb'
-    - 'danger/roulette/Dangerfile'
     - 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb'
     - 'ee/app/models/ee/vulnerability.rb'
     - 'ee/app/services/epic_issues/create_service.rb'
@@ -34,22 +33,10 @@ Rails/NegateInclude:
     - 'lib/gitlab/import_export/attributes_permitter.rb'
     - 'lib/gitlab/search_results.rb'
     - 'lib/gitlab/task_helpers.rb'
-    - 'lib/gitlab/url_blocker.rb'
-    - 'lib/gitlab_edition.rb'
-    - 'qa/qa/page/merge_request/show.rb'
-    - 'qa/qa/runtime/ip_address.rb'
-    - 'qa/qa/support/run.rb'
     - 'qa/qa/tools/delete_test_users.rb'
-    - 'rubocop/cop/gitlab/feature_available_usage.rb'
-    - 'rubocop/cop/graphql/id_type.rb'
-    - 'rubocop/cop/migration/add_reference.rb'
-    - 'rubocop/cop/rspec/factory_bot/inline_association.rb'
-    - 'scripts/lib/gitlab.rb'
-    - 'scripts/static-analysis'
     - 'spec/lib/container_registry/blob_spec.rb'
     - 'spec/lib/container_registry/client_spec.rb'
     - 'spec/lib/gitlab/metrics/dashboard/stages/metric_endpoint_inserter_spec.rb'
     - 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb'
     - 'spec/support/matchers/pushed_frontend_feature_flags_matcher.rb'
     - 'spec/uploaders/object_storage_spec.rb'
-    - 'tooling/danger/specs.rb'
diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml
index 307e6f59800..7e4af1ef3f9 100644
--- a/.rubocop_todo/rails/pluck.yml
+++ b/.rubocop_todo/rails/pluck.yml
@@ -12,19 +12,16 @@ Rails/Pluck:
     - 'app/models/integrations/chat_message/pipeline_message.rb'
     - 'app/models/list.rb'
     - 'app/models/packages/go/module_version.rb'
-    - 'app/models/work_items/parent_link.rb'
     - 'app/services/ci/pipeline_processing/atomic_processing_service/status_collection.rb'
     - 'app/services/feature_flags/update_service.rb'
     - 'app/services/todos/destroy/destroyed_issuable_service.rb'
     - 'app/workers/database/ci_namespace_mirrors_consistency_check_worker.rb'
     - 'app/workers/database/ci_project_mirrors_consistency_check_worker.rb'
-    - 'db/post_migrate/20210811122206_update_external_project_bots.rb'
     - 'ee/app/graphql/mutations/incident_management/escalation_policy/base.rb'
     - 'ee/app/graphql/mutations/incident_management/oncall_rotation/base.rb'
     - 'ee/app/models/boards/epic_list.rb'
     - 'ee/app/models/concerns/geo/verification_state.rb'
     - 'ee/app/services/concerns/incident_management/oncall_rotations/shared_rotation_logic.rb'
-    - 'ee/app/workers/geo/registry_sync_worker.rb'
     - 'ee/app/workers/geo/repository_shard_sync_worker.rb'
     - 'ee/app/workers/geo/repository_verification/secondary/shard_worker.rb'
     - 'ee/app/workers/geo/scheduler/scheduler_worker.rb'
@@ -34,7 +31,6 @@ Rails/Pluck:
     - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb'
     - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb'
     - 'ee/lib/elastic/latest/custom_language_analyzers.rb'
-    - 'ee/lib/gitlab/ci/reports/license_scanning/report.rb'
     - 'ee/lib/gitlab/search/index_curator.rb'
     - 'ee/spec/controllers/autocomplete_controller_spec.rb'
     - 'ee/spec/controllers/countries_controller_spec.rb'
@@ -46,7 +42,6 @@ Rails/Pluck:
     - 'ee/spec/controllers/projects/security/configuration_controller_spec.rb'
     - 'ee/spec/features/projects/new_project_spec.rb'
     - 'ee/spec/graphql/api/vulnerabilities_spec.rb'
-    - 'ee/spec/graphql/types/vulnerability_scanner_type_spec.rb'
     - 'ee/spec/helpers/ee/geo_helper_spec.rb'
     - 'ee/spec/helpers/ee/operations_helper_spec.rb'
     - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb'
@@ -96,7 +91,6 @@ Rails/Pluck:
     - 'ee/spec/requests/ee/groups/autocomplete_sources_spec.rb'
     - 'ee/spec/requests/groups/protected_environments_controller_spec.rb'
     - 'ee/spec/requests/projects/issue_feature_flags_controller_spec.rb'
-    - 'ee/spec/services/analytics/cycle_analytics/stages/update_service_spec.rb'
     - 'ee/spec/services/analytics/cycle_analytics/value_streams/create_service_spec.rb'
     - 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb'
     - 'ee/spec/services/ee/groups/autocomplete_service_spec.rb'
@@ -134,7 +128,6 @@ Rails/Pluck:
     - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb'
     - 'lib/gitlab/zentao/client.rb'
     - 'lib/tasks/gitlab/info.rake'
-    - 'qa/qa/specs/features/api/1_manage/import/import_github_repo_spec.rb'
     - 'qa/qa/specs/features/api/1_manage/migration/gitlab_migration_mr_spec.rb'
     - 'qa/qa/specs/features/browser_ui/1_manage/integrations/jira/jira_basic_integration_spec.rb'
     - 'qa/qa/tools/ci/qa_changes.rb'
@@ -180,7 +173,6 @@ Rails/Pluck:
     - 'spec/lib/gitlab/ci/ansi2json/line_spec.rb'
     - 'spec/lib/gitlab/ci/yaml_processor_spec.rb'
     - 'spec/lib/gitlab/conflict/file_spec.rb'
-    - 'spec/lib/gitlab/database/load_balancing/transaction_leaking_spec.rb'
     - 'spec/lib/gitlab/database/similarity_score_spec.rb'
     - 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb'
     - 'spec/lib/gitlab/git/blame_spec.rb'
@@ -197,7 +189,6 @@ Rails/Pluck:
     - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/client_spec.rb'
     - 'spec/lib/gitlab/tree_summary_spec.rb'
     - 'spec/lib/peek/views/rugged_spec.rb'
-    - 'spec/migrations/20210713042000_fix_ci_sources_pipelines_index_names_spec.rb'
     - 'spec/models/bulk_imports/entity_spec.rb'
     - 'spec/models/ci/bridge_spec.rb'
     - 'spec/models/ci/build_spec.rb'
@@ -225,7 +216,6 @@ Rails/Pluck:
     - 'spec/requests/api/graphql/boards/board_list_issues_query_spec.rb'
     - 'spec/requests/api/graphql/ci/manual_variables_spec.rb'
     - 'spec/requests/api/graphql/ci/pipelines_spec.rb'
-    - 'spec/requests/api/graphql/ci/runners_spec.rb'
     - 'spec/requests/api/graphql/group/timelogs_spec.rb'
     - 'spec/requests/api/graphql/group_query_spec.rb'
     - 'spec/requests/api/graphql/mutations/design_management/move_spec.rb'
@@ -234,7 +224,6 @@ Rails/Pluck:
     - 'spec/requests/api/graphql/project/base_service_spec.rb'
     - 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb'
     - 'spec/requests/api/graphql/project/issue/designs/designs_spec.rb'
-    - 'spec/requests/api/graphql/project/issues_spec.rb'
     - 'spec/requests/api/graphql/project/jira_import_spec.rb'
     - 'spec/requests/api/graphql/project/jira_projects_spec.rb'
     - 'spec/requests/api/graphql/project/release_spec.rb'
@@ -292,7 +281,6 @@ Rails/Pluck:
     - 'spec/support/shared_examples/graphql/mutation_shared_examples.rb'
     - 'spec/support/shared_examples/requests/api/container_repositories_shared_examples.rb'
     - 'spec/support/shared_examples/requests/api/custom_attributes_shared_examples.rb'
-    - 'spec/support/shared_examples/requests/api/graphql/issue_list_shared_examples.rb'
     - 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb'
     - 'spec/support/shared_examples/requests/api/graphql/packages/package_details_shared_examples.rb'
     - 'spec/support/shared_examples/requests/api/labels_api_shared_examples.rb'
@@ -301,5 +289,4 @@ Rails/Pluck:
     - 'spec/support/shared_examples/requests/api/repository_storage_moves_shared_examples.rb'
     - 'spec/support/shared_examples/services/packages_shared_examples.rb'
     - 'spec/tooling/docs/deprecation_handling_spec.rb'
-    - 'tooling/danger/sidekiq_queues.rb'
     - 'tooling/docs/deprecation_handling.rb'
diff --git a/.rubocop_todo/rails/time_zone.yml b/.rubocop_todo/rails/time_zone.yml
index 378c00c1063..220a6f39550 100644
--- a/.rubocop_todo/rails/time_zone.yml
+++ b/.rubocop_todo/rails/time_zone.yml
@@ -77,7 +77,6 @@ Rails/TimeZone:
     - 'spec/lib/gitlab/external_authorization/cache_spec.rb'
     - 'spec/lib/gitlab/external_authorization/logger_spec.rb'
     - 'spec/lib/gitlab/fogbugz_import/importer_spec.rb'
-    - 'spec/lib/gitlab/git/commit_spec.rb'
     - 'spec/lib/gitlab/github_import/importer/issue_importer_spec.rb'
     - 'spec/lib/gitlab/github_import/importer/issues_importer_spec.rb'
     - 'spec/lib/gitlab/github_import/importer/milestones_importer_spec.rb'