Add latest changes from gitlab-org/gitlab@master

6 files changed, 0 insertions, 50 deletions

diff --git a/.rubocop_todo/rspec/any_instance_of.yml b/.rubocop_todo/rspec/any_instance_of.yml
index 49699f09787..2cc2478e530 100644
--- a/.rubocop_todo/rspec/any_instance_of.yml
+++ b/.rubocop_todo/rspec/any_instance_of.yml
@@ -47,7 +47,6 @@ RSpec/AnyInstanceOf:
   - ee/spec/lib/gitlab/ci/templates/Jobs/load_performance_testing_gitlab_ci_yaml_spec.rb
   - ee/spec/lib/gitlab/ci/templates/Verify/browser_performance_testing_gitlab_ci_yaml_spec.rb
   - ee/spec/lib/gitlab/ci/templates/Verify/load_performance_testing_gitlab_ci_yaml_spec.rb
-  - ee/spec/lib/gitlab/ci/templates/api_fuzzing_gitlab_ci_yaml_spec.rb
   - ee/spec/lib/gitlab/ci/templates/container_scanning_gitlab_ci_yaml_spec.rb
   - ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_gitlab_ci_yaml_spec.rb
   - ee/spec/lib/gitlab/ci/templates/dast_gitlab_ci_yaml_spec.rb
@@ -59,14 +58,7 @@ RSpec/AnyInstanceOf:
   - ee/spec/lib/gitlab/geo/log_cursor/daemon_spec.rb
   - ee/spec/lib/gitlab/legacy_github_import/project_creator_spec.rb
   - ee/spec/lib/omni_auth/strategies/group_saml_spec.rb
-  - ee/spec/lib/security/ci_configuration/sast_build_actions_spec.rb
   - ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb
-  - ee/spec/migrations/schedule_populate_resolved_on_default_branch_column_spec.rb
-  - ee/spec/migrations/update_location_fingerprint_column_for_cs_spec.rb
-  - ee/spec/migrations/update_occurrence_severity_column_spec.rb
-  - ee/spec/migrations/update_undefined_confidence_from_occurrences_spec.rb
-  - ee/spec/migrations/update_undefined_confidence_from_vulnerabilities_spec.rb
-  - ee/spec/migrations/update_vulnerability_severity_column_spec.rb
   - ee/spec/models/ee/namespace_spec.rb
   - ee/spec/models/geo_node_status_spec.rb
   - ee/spec/models/issue_spec.rb
@@ -74,23 +66,18 @@ RSpec/AnyInstanceOf:
   - ee/spec/models/project_import_state_spec.rb
   - ee/spec/models/push_rule_spec.rb
   - ee/spec/presenters/ci/pipeline_presenter_spec.rb
-  - ee/spec/presenters/projects/security/configuration_presenter_spec.rb
   - ee/spec/requests/api/geo_nodes_spec.rb
   - ee/spec/requests/api/graphql/mutations/dast_on_demand_scans/create_spec.rb
   - ee/spec/requests/api/graphql/mutations/dast_site_profiles/delete_spec.rb
-  - ee/spec/requests/api/graphql/mutations/pipelines/run_dast_scan_spec.rb
   - ee/spec/requests/api/issues_spec.rb
   - ee/spec/requests/api/projects_spec.rb
   - ee/spec/requests/git_http_spec.rb
   - ee/spec/requests/groups_controller_spec.rb
   - ee/spec/requests/omniauth_kerberos_spnego_spec.rb
   - ee/spec/requests/repositories/git_http_controller_spec.rb
-  - ee/spec/services/ci/expire_pipeline_cache_service_spec.rb
-  - ee/spec/services/ci/run_dast_scan_service_spec.rb
   - ee/spec/services/ee/git/branch_push_service_spec.rb
   - ee/spec/services/ee/merge_requests/create_from_vulnerability_data_service_spec.rb
   - ee/spec/services/ee/merge_requests/refresh_service_spec.rb
-  - ee/spec/services/ee/security/ingress_modsecurity_usage_service_spec.rb
   - ee/spec/services/ee/users/create_service_spec.rb
   - ee/spec/services/ee/users/destroy_service_spec.rb
   - ee/spec/services/geo/container_repository_sync_service_spec.rb
@@ -118,7 +105,6 @@ RSpec/AnyInstanceOf:
   - ee/spec/support/shared_examples/models/member_shared_examples.rb
   - ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb
   - ee/spec/support/shared_examples/services/geo/geo_request_service_shared_examples.rb
-  - ee/spec/workers/build_finished_worker_spec.rb
   - ee/spec/workers/concerns/elastic/indexing_control_spec.rb
   - ee/spec/workers/elastic_commit_indexer_worker_spec.rb
   - ee/spec/workers/geo/design_repository_shard_sync_worker_spec.rb
@@ -155,7 +141,6 @@ RSpec/AnyInstanceOf:
   - spec/controllers/projects/settings/integration_hook_logs_controller_spec.rb
   - spec/controllers/projects/settings/integrations_controller_spec.rb
   - spec/controllers/projects/tags_controller_spec.rb
-  - spec/controllers/registrations/experience_levels_controller_spec.rb
   - spec/controllers/registrations_controller_spec.rb
   - spec/controllers/sessions_controller_spec.rb
   - spec/controllers/snippets/notes_controller_spec.rb
@@ -176,7 +161,6 @@ RSpec/AnyInstanceOf:
   - spec/features/projects/files/user_browses_lfs_files_spec.rb
   - spec/features/projects/jobs_spec.rb
   - spec/features/projects/navbar_spec.rb
-  - spec/features/projects/pages_spec.rb
   - spec/features/projects/settings/service_desk_setting_spec.rb
   - spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb
   - spec/features/snippets/embedded_snippet_spec.rb
@@ -190,7 +174,6 @@ RSpec/AnyInstanceOf:
   - spec/graphql/mutations/alert_management/prometheus_integration/create_spec.rb
   - spec/graphql/mutations/alert_management/prometheus_integration/reset_token_spec.rb
   - spec/graphql/mutations/alert_management/prometheus_integration/update_spec.rb
-  - spec/helpers/analytics/unique_visits_helper_spec.rb
   - spec/helpers/projects_helper_spec.rb
   - spec/initializers/lograge_spec.rb
   - spec/lib/api/entities/merge_request_basic_spec.rb
@@ -211,8 +194,6 @@ RSpec/AnyInstanceOf:
   - spec/lib/gitlab/auth/blocked_user_tracker_spec.rb
   - spec/lib/gitlab/auth/request_authenticator_spec.rb
   - spec/lib/gitlab/auth_spec.rb
-  - spec/lib/gitlab/background_migration/populate_personal_snippet_statistics_spec.rb
-  - spec/lib/gitlab/background_migration/populate_project_snippet_statistics_spec.rb
   - spec/lib/gitlab/checks/diff_check_spec.rb
   - spec/lib/gitlab/checks/lfs_check_spec.rb
   - spec/lib/gitlab/checks/lfs_integrity_spec.rb
@@ -231,8 +212,6 @@ RSpec/AnyInstanceOf:
   - spec/lib/gitlab/ci/templates/npm_spec.rb
   - spec/lib/gitlab/ci/trace_spec.rb
   - spec/lib/gitlab/current_settings_spec.rb
-  - spec/lib/gitlab/cycle_analytics/base_event_fetcher_spec.rb
-  - spec/lib/gitlab/database/multi_threaded_migration_spec.rb
   - spec/lib/gitlab/diff/highlight_cache_spec.rb
   - spec/lib/gitlab/diff/highlight_spec.rb
   - spec/lib/gitlab/diff/position_spec.rb
@@ -272,10 +251,8 @@ RSpec/AnyInstanceOf:
   - spec/lib/gitlab/metrics/rack_middleware_spec.rb
   - spec/lib/gitlab/metrics/subscribers/active_record_spec.rb
   - spec/lib/gitlab/metrics_spec.rb
-  - spec/lib/gitlab/patch/action_dispatch_journey_formatter_spec.rb
   - spec/lib/gitlab/sidekiq_daemon/monitor_spec.rb
   - spec/lib/gitlab/sidekiq_middleware_spec.rb
-  - spec/lib/gitlab/tracking/destinations/product_analytics_spec.rb
   - spec/lib/gitlab/tracking/destinations/snowplow_spec.rb
   - spec/lib/gitlab/tracking_spec.rb
   - spec/lib/gitlab/usage_data_spec.rb
@@ -335,20 +312,17 @@ RSpec/AnyInstanceOf:
   - spec/requests/git_http_spec.rb
   - spec/requests/import/gitlab_projects_controller_spec.rb
   - spec/routing/routing_spec.rb
-  - spec/serializers/analytics_stage_serializer_spec.rb
   - spec/serializers/merge_request_poll_cached_widget_entity_spec.rb
   - spec/serializers/merge_request_poll_widget_entity_spec.rb
   - spec/services/application_settings/update_service_spec.rb
   - spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb
   - spec/services/boards/lists/update_service_spec.rb
   - spec/services/ci/create_pipeline_service_spec.rb
-  - spec/services/ci/destroy_expired_job_artifacts_service_spec.rb
   - spec/services/ci/expire_pipeline_cache_service_spec.rb
   - spec/services/ci/list_config_variables_service_spec.rb
   - spec/services/ci/register_job_service_spec.rb
   - spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb
   - spec/services/ci/retry_pipeline_service_spec.rb
-  - spec/services/ci/stop_environments_service_spec.rb
   - spec/services/clusters/applications/create_service_spec.rb
   - spec/services/clusters/cleanup/project_namespace_service_spec.rb
   - spec/services/clusters/cleanup/service_account_service_spec.rb
@@ -379,7 +353,6 @@ RSpec/AnyInstanceOf:
   - spec/services/packages/conan/create_package_file_service_spec.rb
   - spec/services/packages/nuget/metadata_extraction_service_spec.rb
   - spec/services/packages/nuget/update_package_from_metadata_service_spec.rb
-  - spec/services/pages/delete_services_spec.rb
   - spec/services/post_receive_service_spec.rb
   - spec/services/projects/after_rename_service_spec.rb
   - spec/services/projects/container_repository/cleanup_tags_service_spec.rb
@@ -448,7 +421,6 @@ RSpec/AnyInstanceOf:
   - spec/support/shared_examples/uploaders/object_storage_shared_examples.rb
   - spec/support/shared_examples/workers/authorized_projects_worker_shared_example.rb
   - spec/support/shared_examples/workers/reactive_cacheable_shared_examples.rb
-  - spec/support/snowplow.rb
   - spec/tasks/gitlab/cleanup_rake_spec.rb
   - spec/tasks/gitlab/container_registry_rake_spec.rb
   - spec/tasks/gitlab/db_rake_spec.rb
@@ -462,9 +434,7 @@ RSpec/AnyInstanceOf:
   - spec/views/layouts/_head.html.haml_spec.rb
   - spec/views/projects/artifacts/_artifact.html.haml_spec.rb
   - spec/workers/archive_trace_worker_spec.rb
-  - spec/workers/build_coverage_worker_spec.rb
   - spec/workers/build_hooks_worker_spec.rb
-  - spec/workers/build_trace_sections_worker_spec.rb
   - spec/workers/ci/build_schedule_worker_spec.rb
   - spec/workers/ci/daily_build_group_report_results_worker_spec.rb
   - spec/workers/cluster_configure_istio_worker_spec.rb
@@ -484,7 +454,6 @@ RSpec/AnyInstanceOf:
   - spec/workers/new_note_worker_spec.rb
   - spec/workers/object_pool/create_worker_spec.rb
   - spec/workers/packages/nuget/extraction_worker_spec.rb
-  - spec/workers/pages_remove_worker_spec.rb
   - spec/workers/pipeline_hooks_worker_spec.rb
   - spec/workers/pipeline_process_worker_spec.rb
   - spec/workers/pipeline_schedule_worker_spec.rb
diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml
index 7becad56886..a51ba5e930b 100644
--- a/.rubocop_todo/rspec/context_wording.yml
+++ b/.rubocop_todo/rspec/context_wording.yml
@@ -871,7 +871,6 @@ RSpec/ContextWording:
     - 'ee/spec/services/ee/integrations/test/project_service_spec.rb'
     - 'ee/spec/services/ee/ip_restrictions/update_service_spec.rb'
     - 'ee/spec/services/ee/issuable/bulk_update_service_spec.rb'
-    - 'ee/spec/services/ee/issuable/clone/attributes_rewriter_spec.rb'
     - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb'
     - 'ee/spec/services/ee/issues/clone_service_spec.rb'
     - 'ee/spec/services/ee/issues/close_service_spec.rb'
@@ -978,7 +977,6 @@ RSpec/ContextWording:
     - 'ee/spec/services/merge_requests/merge_service_spec.rb'
     - 'ee/spec/services/merge_requests/update_blocks_service_spec.rb'
     - 'ee/spec/services/milestones/update_service_spec.rb'
-    - 'ee/spec/services/namespaces/check_storage_size_service_spec.rb'
     - 'ee/spec/services/namespaces/in_product_marketing_emails_service_spec.rb'
     - 'ee/spec/services/namespaces/storage/email_notification_service_spec.rb'
     - 'ee/spec/services/personal_access_tokens/revoke_invalid_tokens_spec.rb'
@@ -3306,7 +3304,6 @@ RSpec/ContextWording:
     - 'spec/services/incident_management/issuable_escalation_statuses/create_service_spec.rb'
     - 'spec/services/integrations/propagate_service_spec.rb'
     - 'spec/services/integrations/test/project_service_spec.rb'
-    - 'spec/services/issuable/clone/attributes_rewriter_spec.rb'
     - 'spec/services/issuable/common_system_notes_service_spec.rb'
     - 'spec/services/issue_links/list_service_spec.rb'
     - 'spec/services/issues/build_service_spec.rb'
@@ -3657,7 +3654,6 @@ RSpec/ContextWording:
     - 'spec/support/shared_examples/models/cluster_application_helm_cert_shared_examples.rb'
     - 'spec/support/shared_examples/models/cluster_application_status_shared_examples.rb'
     - 'spec/support/shared_examples/models/cluster_application_version_shared_examples.rb'
-    - 'spec/support/shared_examples/models/clusters/elastic_stack_client_shared.rb'
     - 'spec/support/shared_examples/models/clusters/prometheus_client_shared.rb'
     - 'spec/support/shared_examples/models/concerns/can_move_repository_storage_shared_examples.rb'
     - 'spec/support/shared_examples/models/concerns/composite_id_shared_examples.rb'
diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml
index ef8897100e3..b08830bd5a3 100644
--- a/.rubocop_todo/rspec/expect_change.yml
+++ b/.rubocop_todo/rspec/expect_change.yml
@@ -151,7 +151,6 @@ RSpec/ExpectChange:
     - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb'
     - 'ee/spec/services/ee/groups/deploy_tokens/destroy_service_spec.rb'
     - 'ee/spec/services/ee/groups/deploy_tokens/revoke_service_spec.rb'
-    - 'ee/spec/services/ee/issuable/clone/attributes_rewriter_spec.rb'
     - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb'
     - 'ee/spec/services/ee/issues/create_service_spec.rb'
     - 'ee/spec/services/ee/issues/update_service_spec.rb'
diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml
index 56b3f48c670..cd73b76b14e 100644
--- a/.rubocop_todo/rspec/expect_in_hook.yml
+++ b/.rubocop_todo/rspec/expect_in_hook.yml
@@ -88,7 +88,6 @@ RSpec/ExpectInHook:
     - 'ee/spec/services/groups/update_repository_storage_service_spec.rb'
     - 'ee/spec/services/members/activate_service_spec.rb'
     - 'ee/spec/services/merge_requests/approval_service_spec.rb'
-    - 'ee/spec/services/namespaces/check_storage_size_service_spec.rb'
     - 'ee/spec/services/projects/create_from_template_service_spec.rb'
     - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb'
     - 'ee/spec/services/projects/update_mirror_service_spec.rb'
diff --git a/.rubocop_todo/rspec/multiple_memoized_helpers.yml b/.rubocop_todo/rspec/multiple_memoized_helpers.yml
index 2f6d390bec2..8330d768794 100644
--- a/.rubocop_todo/rspec/multiple_memoized_helpers.yml
+++ b/.rubocop_todo/rspec/multiple_memoized_helpers.yml
@@ -1,11 +1,9 @@
 ---
 RSpec/MultipleMemoizedHelpers:
   Exclude:
-  - spec/lib/gitlab/background_migration/populate_finding_uuid_for_vulnerability_feedback_spec.rb
   - spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb
   - spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb
   - spec/requests/api/ci/runner/jobs_artifacts_spec.rb
   - ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb
   - ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb
   - ee/spec/services/ee/boards/issues/move_service_spec.rb
-  - ee/spec/services/security/store_report_service_spec.rb
diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml
index 420b51316c3..84e862ff48b 100644
--- a/.rubocop_todo/rspec/verified_doubles.yml
+++ b/.rubocop_todo/rspec/verified_doubles.yml
@@ -85,14 +85,12 @@ RSpec/VerifiedDoubles:
     - ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb
     - ee/spec/lib/gitlab/import_export/group/relation_factory_spec.rb
     - ee/spec/lib/gitlab/middleware/ip_restrictor_spec.rb
-    - ee/spec/lib/gitlab/patch/legacy_database_config_spec.rb
     - ee/spec/lib/gitlab/prometheus/queries/cluster_query_spec.rb
     - ee/spec/lib/gitlab/subscription_portal/clients/rest_spec.rb
     - ee/spec/lib/sidebars/groups/menus/analytics_menu_spec.rb
     - ee/spec/lib/system_check/geo/geo_database_configured_check_spec.rb
     - ee/spec/models/app_sec/fuzzing/api/ci_configuration_spec.rb
     - ee/spec/models/approvable_spec.rb
-    - ee/spec/models/concerns/ee/sha_attribute_spec.rb
     - ee/spec/models/concerns/geo/verification_state_spec.rb
     - ee/spec/models/ee/ci/job_artifact_spec.rb
     - ee/spec/models/ee/user_spec.rb
@@ -247,7 +245,6 @@ RSpec/VerifiedDoubles:
     - qa/spec/support/formatters/allure_metadata_formatter_spec.rb
     - qa/spec/support/page_error_checker_spec.rb
     - qa/spec/support/run_spec.rb
-    - qa/spec/support/shared_examples/scenario_shared_examples.rb
     - qa/spec/tools/long_running_spec_reporter_spec.rb
     - spec/benchmarks/banzai_benchmark.rb
     - spec/bin/feature_flag_spec.rb
@@ -377,7 +374,6 @@ RSpec/VerifiedDoubles:
     - spec/lib/api/helpers_spec.rb
     - spec/lib/atlassian/jira_connect/client_spec.rb
     - spec/lib/backup/files_spec.rb
-    - spec/lib/backup/gitaly_rpc_backup_spec.rb
     - spec/lib/backup/repositories_spec.rb
     - spec/lib/banzai/cross_project_reference_spec.rb
     - spec/lib/banzai/filter/gollum_tags_filter_spec.rb
@@ -400,7 +396,6 @@ RSpec/VerifiedDoubles:
     - spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb
     - spec/lib/bulk_imports/projects/transformers/project_attributes_transformer_spec.rb
     - spec/lib/constraints/admin_constrainer_spec.rb
-    - spec/lib/constraints/feature_constrainer_spec.rb
     - spec/lib/constraints/group_url_constrainer_spec.rb
     - spec/lib/constraints/jira_encoded_url_constrainer_spec.rb
     - spec/lib/constraints/project_url_constrainer_spec.rb
@@ -646,7 +641,6 @@ RSpec/VerifiedDoubles:
     - spec/lib/gitlab/grape_logging/loggers/urgency_logger_spec.rb
     - spec/lib/gitlab/graphql/authorize/object_authorization_spec.rb
     - spec/lib/gitlab/graphql/batch_key_spec.rb
-    - spec/lib/gitlab/graphql/find_argument_in_parent_spec.rb
     - spec/lib/gitlab/graphql/generic_tracing_spec.rb
     - spec/lib/gitlab/graphql/lazy_spec.rb
     - spec/lib/gitlab/graphql/loaders/issuable_loader_spec.rb
@@ -707,7 +701,6 @@ RSpec/VerifiedDoubles:
     - spec/lib/gitlab/metrics/elasticsearch_rack_middleware_spec.rb
     - spec/lib/gitlab/metrics/exporter/base_exporter_spec.rb
     - spec/lib/gitlab/metrics/exporter/gc_request_middleware_spec.rb
-    - spec/lib/gitlab/metrics/exporter/health_checks_middleware_spec.rb
     - spec/lib/gitlab/metrics/exporter/metrics_middleware_spec.rb
     - spec/lib/gitlab/metrics/rack_middleware_spec.rb
     - spec/lib/gitlab/metrics/requests_rack_middleware_spec.rb
@@ -835,7 +828,6 @@ RSpec/VerifiedDoubles:
     - spec/models/concerns/atomic_internal_id_spec.rb
     - spec/models/concerns/legacy_bulk_insert_spec.rb
     - spec/models/concerns/prometheus_adapter_spec.rb
-    - spec/models/concerns/sha256_attribute_spec.rb
     - spec/models/concerns/sha_attribute_spec.rb
     - spec/models/concerns/token_authenticatable_strategies/base_spec.rb
     - spec/models/concerns/token_authenticatable_strategies/encrypted_spec.rb
@@ -988,7 +980,6 @@ RSpec/VerifiedDoubles:
     - spec/services/ide/schemas_config_service_spec.rb
     - spec/services/import/bitbucket_server_service_spec.rb
     - spec/services/import/github_service_spec.rb
-    - spec/services/import/gitlab_projects/create_project_from_remote_file_service_spec.rb
     - spec/services/issues/create_service_spec.rb
     - spec/services/issues/related_branches_service_spec.rb
     - spec/services/jira_connect_subscriptions/create_service_spec.rb
@@ -1007,7 +998,6 @@ RSpec/VerifiedDoubles:
     - spec/services/metrics/users_starred_dashboards/create_service_spec.rb
     - spec/services/milestones/update_service_spec.rb
     - spec/services/namespaces/in_product_marketing_emails_service_spec.rb
-    - spec/services/namespaces/invite_team_email_service_spec.rb
     - spec/services/notes/create_service_spec.rb
     - spec/services/notes/render_service_spec.rb
     - spec/services/notification_service_spec.rb
@@ -1030,7 +1020,6 @@ RSpec/VerifiedDoubles:
     - spec/services/projects/update_service_spec.rb
     - spec/services/repositories/changelog_service_spec.rb
     - spec/services/search_service_spec.rb
-    - spec/services/service_ping/build_payload_service_spec.rb
     - spec/services/service_ping/submit_service_ping_service_spec.rb
     - spec/services/snippets/update_repository_storage_service_spec.rb
     - spec/services/spam/akismet_mark_as_spam_service_spec.rb