Add latest changes from gitlab-org/gitlab@master

2 files changed, 207 insertions, 0 deletions

diff --git a/.rubocop_todo/rails/pick.yml b/.rubocop_todo/rails/pick.yml
new file mode 100644
index 00000000000..95ed3e61cb5
--- /dev/null
+++ b/.rubocop_todo/rails/pick.yml
@@ -0,0 +1,43 @@
+---
+# Cop supports --auto-correct.
+Rails/Pick:
+  # Offense count: 42
+  # Temporarily disabled due to too many offenses
+  Enabled: false
+  Exclude:
+    - 'app/models/ci/pipeline.rb'
+    - 'app/models/merge_request.rb'
+    - 'app/models/merge_request/metrics.rb'
+    - 'app/models/merge_request_diff.rb'
+    - 'db/post_migrate/20210825193652_backfill_cadence_id_for_boards_scoped_to_iteration.rb'
+    - 'db/post_migrate/20220213103859_remove_integrations_type.rb'
+    - 'db/post_migrate/20220412143552_consume_remaining_encrypt_integration_property_jobs.rb'
+    - 'ee/app/models/concerns/epic_tree_sorting.rb'
+    - 'ee/app/models/ee/group.rb'
+    - 'ee/app/models/ee/namespace.rb'
+    - 'ee/app/models/geo/project_registry.rb'
+    - 'ee/lib/analytics/merge_request_metrics_calculator.rb'
+    - 'ee/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb'
+    - 'ee/lib/ee/gitlab/background_migration/populate_status_column_of_security_scans.rb'
+    - 'ee/spec/finders/security/findings_finder_spec.rb'
+    - 'lib/gitlab/background_migration/backfill_ci_namespace_mirrors.rb'
+    - 'lib/gitlab/background_migration/backfill_ci_project_mirrors.rb'
+    - 'lib/gitlab/background_migration/backfill_integrations_type_new.rb'
+    - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb'
+    - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb'
+    - 'lib/gitlab/background_migration/backfill_work_item_type_id_for_issues.rb'
+    - 'lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy.rb'
+    - 'lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy.rb'
+    - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb'
+    - 'lib/gitlab/background_migration/drop_invalid_security_findings.rb'
+    - 'lib/gitlab/background_migration/encrypt_static_object_token.rb'
+    - 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb'
+    - 'lib/gitlab/background_migration/populate_vulnerability_reads.rb'
+    - 'lib/gitlab/background_migration/update_timelogs_null_spent_at.rb'
+    - 'lib/gitlab/database/dynamic_model_helpers.rb'
+    - 'lib/gitlab/database/migrations/background_migration_helpers.rb'
+    - 'lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table.rb'
+    - 'lib/gitlab/github_import/user_finder.rb'
+    - 'lib/gitlab/relative_positioning/item_context.rb'
+    - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb'
+    - 'spec/requests/projects/cycle_analytics_events_spec.rb'
diff --git a/.rubocop_todo/style/redundant_interpolation.yml b/.rubocop_todo/style/redundant_interpolation.yml
new file mode 100644
index 00000000000..fb190ff2100
--- /dev/null
+++ b/.rubocop_todo/style/redundant_interpolation.yml
@@ -0,0 +1,164 @@
+---
+# Cop supports --auto-correct.
+Style/RedundantInterpolation:
+  # Offense count: 285
+  # Temporarily disabled due to too many offenses
+  Enabled: false
+  Exclude:
+    - 'app/components/diffs/stats_component.rb'
+    - 'app/helpers/blob_helper.rb'
+    - 'app/helpers/ci/runners_helper.rb'
+    - 'app/helpers/commits_helper.rb'
+    - 'app/helpers/dropdowns_helper.rb'
+    - 'app/helpers/environments_helper.rb'
+    - 'app/helpers/icons_helper.rb'
+    - 'app/helpers/issuables_helper.rb'
+    - 'app/helpers/search_helper.rb'
+    - 'app/models/concerns/issuable.rb'
+    - 'app/models/integrations/base_chat_notification.rb'
+    - 'app/models/integrations/hangouts_chat.rb'
+    - 'app/models/integrations/microsoft_teams.rb'
+    - 'app/models/integrations/pushover.rb'
+    - 'app/models/merge_request.rb'
+    - 'app/services/jira_import/start_import_service.rb'
+    - 'app/services/users/approve_service.rb'
+    - 'app/services/users/banned_user_base_service.rb'
+    - 'app/services/users/reject_service.rb'
+    - 'ee/app/graphql/types/compliance_management/merge_requests/compliance_violation_reason_enum.rb'
+    - 'ee/app/graphql/types/incident_management/oncall_rotation_length_unit_enum.rb'
+    - 'ee/app/helpers/ee/ci/runners_helper.rb'
+    - 'ee/app/helpers/ee/geo_helper.rb'
+    - 'ee/app/services/geo/event_store.rb'
+    - 'ee/app/services/geo/repository_updated_service.rb'
+    - 'ee/app/services/security/security_orchestration_policies/create_pipeline_service.rb'
+    - 'ee/db/fixtures/development/31_devops_adoption.rb'
+    - 'ee/spec/features/epics/epic_issues_spec.rb'
+    - 'ee/spec/features/projects/requirements_management/requirements_list_spec.rb'
+    - 'ee/spec/features/registrations/one_trust_spec.rb'
+    - 'ee/spec/graphql/ee/mutations/boards/lists/create_spec.rb'
+    - 'ee/spec/lib/banzai/filter/issuable_reference_expansion_filter_spec.rb'
+    - 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb'
+    - 'ee/spec/lib/ee/audit/protected_branches_changes_auditor_spec.rb'
+    - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb'
+    - 'ee/spec/mailers/ci_minutes_usage_mailer_spec.rb'
+    - 'ee/spec/mailers/emails/namespace_storage_usage_mailer_spec.rb'
+    - 'ee/spec/mailers/notify_spec.rb'
+    - 'ee/spec/models/incident_management/issuable_escalation_status_spec.rb'
+    - 'ee/spec/requests/api/issues_spec.rb'
+    - 'ee/spec/requests/api/search_spec.rb'
+    - 'ee/spec/services/search_service_spec.rb'
+    - 'ee/spec/services/timebox_report_service_spec.rb'
+    - 'ee/spec/support/shared_examples/lib/gitlab/elastic/standalone_indices_shared_examples.rb'
+    - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb'
+    - 'lib/backup/manager.rb'
+    - 'lib/backup/task.rb'
+    - 'lib/gitlab/application_rate_limiter.rb'
+    - 'lib/gitlab/chat/responder/mattermost.rb'
+    - 'lib/gitlab/ci/build/releaser.rb'
+    - 'lib/gitlab/ci/reports/test_suite.rb'
+    - 'lib/gitlab/ci/runner_instructions.rb'
+    - 'lib/gitlab/console.rb'
+    - 'lib/gitlab/metrics/web_transaction.rb'
+    - 'lib/gitlab/pagination/keyset/in_operator_optimization/strategies/record_loader_strategy.rb'
+    - 'lib/gitlab/prometheus_client.rb'
+    - 'lib/gitlab/repository_cache.rb'
+    - 'lib/gitlab/repository_cache_adapter.rb'
+    - 'lib/gitlab/repository_hash_cache.rb'
+    - 'lib/gitlab/repository_set_cache.rb'
+    - 'lib/gitlab/usage/metrics/names_suggestions/relation_parsers/constraints.rb'
+    - 'lib/gitlab/usage/metrics/names_suggestions/relation_parsers/joins.rb'
+    - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb'
+    - 'lib/gitlab/usage_data_counters/search_counter.rb'
+    - 'lib/gitlab/utils.rb'
+    - 'lib/kramdown/converter/commonmark.rb'
+    - 'lib/tasks/gettext.rake'
+    - 'qa/qa/ee/page/merge_request/new.rb'
+    - 'qa/qa/ee/page/project/issue/show.rb'
+    - 'qa/qa/resource/events/base.rb'
+    - 'qa/qa/service/praefect_manager.rb'
+    - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_multiple_files_from_a_project_spec.rb'
+    - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/parent_child_pipelines_dependent_relationship_spec.rb'
+    - 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_spec.rb'
+    - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb'
+    - 'qa/qa/tools/generate_perf_testdata.rb'
+    - 'scripts/changed-feature-flags'
+    - 'scripts/perf/gc/print_gc_stats.rb'
+    - 'scripts/qa/testcases-check'
+    - 'spec/controllers/admin/integrations_controller_spec.rb'
+    - 'spec/features/commits_spec.rb'
+    - 'spec/features/issues/user_edits_issue_spec.rb'
+    - 'spec/features/merge_request/user_scrolls_to_note_on_load_spec.rb'
+    - 'spec/features/merge_request/user_sees_deployment_widget_spec.rb'
+    - 'spec/features/one_trust_spec.rb'
+    - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb'
+    - 'spec/features/projects/jobs/user_browses_jobs_spec.rb'
+    - 'spec/graphql/resolvers/container_repositories_resolver_spec.rb'
+    - 'spec/helpers/environments_helper_spec.rb'
+    - 'spec/lib/api/helpers/packages/dependency_proxy_helpers_spec.rb'
+    - 'spec/lib/api/validations/validators/git_ref_spec.rb'
+    - 'spec/lib/api/validations/validators/limit_spec.rb'
+    - 'spec/lib/backup/database_backup_error_spec.rb'
+    - 'spec/lib/backup/file_backup_error_spec.rb'
+    - 'spec/lib/banzai/filter/autolink_filter_spec.rb'
+    - 'spec/lib/banzai/filter/issuable_reference_expansion_filter_spec.rb'
+    - 'spec/lib/banzai/filter/references/alert_reference_filter_spec.rb'
+    - 'spec/lib/banzai/filter/references/commit_reference_filter_spec.rb'
+    - 'spec/lib/banzai/filter/references/issue_reference_filter_spec.rb'
+    - 'spec/lib/banzai/filter/references/label_reference_filter_spec.rb'
+    - 'spec/lib/banzai/filter/references/milestone_reference_filter_spec.rb'
+    - 'spec/lib/banzai/filter/references/project_reference_filter_spec.rb'
+    - 'spec/lib/banzai/filter/references/user_reference_filter_spec.rb'
+    - 'spec/lib/feature_spec.rb'
+    - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb'
+    - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb'
+    - 'spec/lib/gitlab/ci/config/entry/job_spec.rb'
+    - 'spec/lib/gitlab/ci/config/entry/processable_spec.rb'
+    - 'spec/lib/gitlab/ci/reports/test_suite_spec.rb'
+    - 'spec/lib/gitlab/database/batch_count_spec.rb'
+    - 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb'
+    - 'spec/lib/gitlab/import_export/group/tree_saver_spec.rb'
+    - 'spec/lib/gitlab/metrics/dashboard/url_spec.rb'
+    - 'spec/lib/grafana/client_spec.rb'
+    - 'spec/mailers/notify_spec.rb'
+    - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb'
+    - 'spec/models/active_session_spec.rb'
+    - 'spec/models/clusters/platforms/kubernetes_spec.rb'
+    - 'spec/models/diff_discussion_spec.rb'
+    - 'spec/models/namespace_spec.rb'
+    - 'spec/presenters/project_presenter_spec.rb'
+    - 'spec/rack_servers/configs/config.ru'
+    - 'spec/requests/api/alert_management_alerts_spec.rb'
+    - 'spec/requests/api/markdown_spec.rb'
+    - 'spec/requests/api/merge_requests_spec.rb'
+    - 'spec/requests/api/metrics/dashboard/annotations_spec.rb'
+    - 'spec/requests/api/tags_spec.rb'
+    - 'spec/requests/api/terraform/state_spec.rb'
+    - 'spec/requests/projects/google_cloud/deployments_controller_spec.rb'
+    - 'spec/requests/projects/google_cloud/service_accounts_controller_spec.rb'
+    - 'spec/requests/projects/google_cloud_controller_spec.rb'
+    - 'spec/routing/project_routing_spec.rb'
+    - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb'
+    - 'spec/services/groups/transfer_service_spec.rb'
+    - 'spec/services/members/invite_service_spec.rb'
+    - 'spec/services/todo_service_spec.rb'
+    - 'spec/services/todos/destroy/entity_leave_service_spec.rb'
+    - 'spec/services/users/approve_service_spec.rb'
+    - 'spec/services/users/ban_service_spec.rb'
+    - 'spec/services/users/reject_service_spec.rb'
+    - 'spec/services/users/unban_service_spec.rb'
+    - 'spec/support/google_api/cloud_platform_helpers.rb'
+    - 'spec/support/helpers/features/releases_helpers.rb'
+    - 'spec/support/helpers/graphql_helpers.rb'
+    - 'spec/support/helpers/kubernetes_helpers.rb'
+    - 'spec/support/matchers/exceed_query_limit.rb'
+    - 'spec/support/shared_examples/graphql/notes_creation_shared_examples.rb'
+    - 'spec/support/shared_examples/graphql/resolvers/packages_resolvers_shared_examples.rb'
+    - 'spec/support/shared_examples/lib/sentry/client_shared_examples.rb'
+    - 'spec/support/shared_examples/mailers/notify_shared_examples.rb'
+    - 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb'
+    - 'spec/support/shared_examples/requests/api/issues_shared_examples.rb'
+    - 'spec/support/shared_examples/requests/api/notes_shared_examples.rb'
+    - 'spec/support/shared_examples/services/users/dismiss_user_callout_service_shared_examples.rb'
+    - 'spec/support_specs/graphql/arguments_spec.rb'
+    - 'spec/views/projects/commit/_commit_box.html.haml_spec.rb'
+    - 'tooling/rspec_flaky/flaky_example.rb'