Add latest changes from gitlab-org/gitlab@master

10 files changed, 0 insertions, 72 deletions

diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml
index 052a1b1bb7e..55d6c9799bb 100644
--- a/.rubocop_todo/layout/argument_alignment.yml
+++ b/.rubocop_todo/layout/argument_alignment.yml
@@ -510,21 +510,8 @@ Layout/ArgumentAlignment:
     - 'config/initializers/rack_timeout.rb'
     - 'config/initializers/rest-client-hostname_override.rb'
     - 'config/initializers/zz_metrics.rb'
-    - 'db/migrate/20220711142148_add_invitation_flow_enforcement_to_application_settings.rb'
-    - 'db/migrate/20220816135816_create_sbom_vulnerable_component_versions.rb'
     - 'db/migrate/20220824082427_remove_tmp_idx_vulnerability_occurrences_on_id_and_scanner_id.rb'
-    - 'db/migrate/20220828131848_create_packages_rpm_metadata.rb'
-    - 'db/migrate/20220913043728_create_user_phone_number_validations.rb'
-    - 'db/migrate/20220923103006_add_ci_pipeline_metadata_title.rb'
-    - 'db/migrate/20221003151747_create_audit_events_streaming_event_type_filters.rb'
-    - 'db/migrate/20221008032350_add_password_expiration_migration.rb'
-    - 'db/migrate/20221009085130_add_mr_checks_columns_to_namespace_settings.rb'
-    - 'db/migrate/20221014031033_add_temp_index_to_project_features_where_releases_access_level_gt_repository.rb'
-    - 'db/migrate/20221020124018_add_delete_started_at_to_container_repositories.rb'
-    - 'db/migrate/20221025043930_change_default_value_on_password_last_changed_at_to_user_details.rb'
-    - 'db/migrate/20221025145452_change_vulnerability_feedback_unique_idx.rb'
     - 'db/migrate/20221103205317_create_dast_pre_scan_verification.rb'
-    - 'db/migrate/20221104061320_add_disable_download_button_into_application_settings.rb'
     - 'db/migrate/20221111142921_add_hierarchy_restrictions.rb'
     - 'db/migrate/20221116160204_create_ml_experiment_metadata_and_ml_candidate_metadata.rb'
     - 'db/migrate/20221121091238_add_work_item_progress.rb'
@@ -542,22 +529,8 @@ Layout/ArgumentAlignment:
     - 'db/migrate/20230124193917_add_index_for_protected_tag_create_access_levels.rb'
     - 'db/migrate/20230127151529_add_project_pointer_for_analytics_dashboard.rb'
     - 'db/migrate/20230127151531_change_dashboard_analytics_project_pointer_project_null.rb'
-    - 'db/post_migrate/20220606054503_add_tmp_index_job_artifacts_id_and_expire_at.rb'
-    - 'db/post_migrate/20220616171355_update_vulnerabilities_project_id_id_active_cis_index.rb'
-    - 'db/post_migrate/20220726225114_remove_tmp_index_group_membership_namespace_id_column.rb'
-    - 'db/post_migrate/20220820221036_update_tmp_non_migrated_index_on_container_repositories.rb'
     - 'db/post_migrate/20220826152430_remove_container_repository_deprecated_geo_fields.rb'
     - 'db/post_migrate/20220826152432_remove_container_repository_updated_events.rb'
-    - 'db/post_migrate/20220916112841_remove_unused_aggregation_columns.rb'
-    - 'db/post_migrate/20220919080303_delete_migrate_shared_vulnerability_scanners.rb'
-    - 'db/post_migrate/20220929081645_tmp_idx_null_member_namespace_id.rb'
-    - 'db/post_migrate/20221003192827_add_index_resolved_on_default_branch_to_vulnerabilities_read.rb'
-    - 'db/post_migrate/20221004092038_tmp_index_members_on_id_where_namespace_id_null.rb'
-    - 'db/post_migrate/20221010123040_add_compliance_framework_fk_to_namespace_settings.rb'
-    - 'db/post_migrate/20221021082720_drop_index_on_ci_runners_token.rb'
-    - 'db/post_migrate/20221021082734_drop_index_on_ci_runners_token_encrypted.rb'
-    - 'db/post_migrate/20221021160735_add_index_for_common_finder_query_desc_with_namespace_id.rb'
-    - 'db/post_migrate/20221108222015_remove_temp_index_on_project_features_where_releases_access_level_gt_repository.rb'
     - 'db/post_migrate/20221110190340_add_partial_legacy_open_source_license_available_project_id_index.rb'
     - 'db/post_migrate/20221114142044_delete_experiments_foreign_keys.rb'
     - 'db/post_migrate/20221116105434_remove_index_project_settings_on_legacy_open_source_license_available.rb'
diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml
index b0ddd74796d..409acc4b5c1 100644
--- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml
+++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml
@@ -127,8 +127,6 @@ Layout/EmptyLineAfterMagicComment:
     - 'danger/ce_ee_vue_templates/Dangerfile'
     - 'danger/feature_flag/Dangerfile'
     - 'danger/pajamas/Dangerfile'
-    - 'db/migrate/20221107115247_change_scim_identity_group_id_remove_null.rb'
-    - 'db/migrate/20221107115413_change_scim_oauth_access_token_group_id_remove_null.rb'
     - 'db/migrate/20221116134507_add_projects_emails_enabled_column.rb'
     - 'db/migrate/20221116134539_add_namespaces_emails_enabled_column.rb'
     - 'db/migrate/20221202202351_remove_index_i_ci_job_token_project_scope_links_on_source_and_target_project.rb'
@@ -136,10 +134,6 @@ Layout/EmptyLineAfterMagicComment:
     - 'db/migrate/20221219103007_add_name_to_ml_candidates.rb'
     - 'db/migrate/20221219122320_copy_clickhouse_connection_string_to_encrypted_var.rb'
     - 'db/migrate/20230111124512_remove_tmp_index_vulns_on_report_type.rb'
-    - 'db/post_migrate/20220901071355_cleanup_attention_request_user_callouts.rb'
-    - 'db/post_migrate/20220929091500_add_tmp_index_vulns_on_report_type.rb'
-    - 'db/post_migrate/20221004094814_schedule_destroy_invalid_members.rb'
-    - 'db/post_migrate/20221104170500_add_vulnerability_reads_all_status_index.rb'
     - 'db/post_migrate/20221116134611_add_namespaces_emails_enabled_column_data.rb'
     - 'db/post_migrate/20221116134633_add_projects_emails_enabled_column_data.rb'
     - 'db/post_migrate/20221210154044_update_active_billable_users_index.rb'
diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml
index 68d0f57006e..7bc8d095585 100644
--- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml
+++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml
@@ -39,7 +39,6 @@ Layout/LineEndStringConcatenationIndentation:
     - 'config/initializers/wikicloth_redos_patch.rb'
     - 'config/initializers/wikicloth_ruby_3_patch.rb'
     - 'danger/database/Dangerfile'
-    - 'db/post_migrate/20220920081631_prepare_ci_builds_metadata_for_partitioning_primary_key.rb'
     - 'ee/app/components/namespaces/free_user_cap/usage_quota_alert_component.rb'
     - 'ee/app/controllers/admin/licenses_controller.rb'
     - 'ee/app/controllers/concerns/insights_actions.rb'
diff --git a/.rubocop_todo/layout/trailing_whitespace.yml b/.rubocop_todo/layout/trailing_whitespace.yml
index 26d0b8f5f13..c7162b7c15a 100644
--- a/.rubocop_todo/layout/trailing_whitespace.yml
+++ b/.rubocop_todo/layout/trailing_whitespace.yml
@@ -3,8 +3,6 @@
 Layout/TrailingWhitespace:
   Exclude:
     - 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb'
-    - 'db/migrate/20220913082728_drop_index_cadence_create_iterations_automation.rb'
-    - 'db/post_migrate/20220816163444_update_start_date_for_iterations_cadences.rb'
     - 'lib/gitlab/pagination/keyset/sql_type_missing_error.rb'
     - 'spec/services/suggestions/apply_service_spec.rb'
     - 'spec/support/helpers/x509_helpers.rb'
diff --git a/.rubocop_todo/lint/assignment_in_condition.yml b/.rubocop_todo/lint/assignment_in_condition.yml
index 4d2158b7a9d..20a51d0c774 100644
--- a/.rubocop_todo/lint/assignment_in_condition.yml
+++ b/.rubocop_todo/lint/assignment_in_condition.yml
@@ -94,7 +94,6 @@ Lint/AssignmentInCondition:
     - 'config/initializers/peek.rb'
     - 'config/initializers/validate_database_config.rb'
     - 'config/initializers/zz_metrics.rb'
-    - 'db/post_migrate/20220919080303_delete_migrate_shared_vulnerability_scanners.rb'
     - 'ee/app/controllers/concerns/gitlab_subscriptions/seat_count_alert.rb'
     - 'ee/app/controllers/omniauth_kerberos_controller.rb'
     - 'ee/app/controllers/users/identity_verification_controller.rb'
diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml
index a369c527104..38c75390cc8 100644
--- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml
+++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml
@@ -76,7 +76,6 @@ Lint/RedundantCopDisableDirective:
     - 'config/initializers/wikicloth_redos_patch.rb'
     - 'config/initializers/wikicloth_ruby_3_patch.rb'
     - 'config/routes/api.rb'
-    - 'db/post_migrate/20220902204048_move_security_findings_table_to_gitlab_partitions_dynamic_schema.rb'
     - 'db/post_migrate/20221102231131_remove_temp_index_for_user_details_fields.rb'
     - 'db/post_migrate/20230104103748_remove_new_amount_used_column.rb'
     - 'db/post_migrate/20230105180002_remove_new_amount_used_column_on_ci_namespace_monthly_usages.rb'
@@ -240,7 +239,6 @@ Lint/RedundantCopDisableDirective:
     - 'spec/helpers/releases_helper_spec.rb'
     - 'spec/lib/gitlab/avatar_cache_spec.rb'
     - 'spec/lib/gitlab/background_migration/backfill_cluster_agents_has_vulnerabilities_spec.rb'
-    - 'spec/lib/gitlab/background_migration/backfill_project_member_namespace_id_spec.rb'
     - 'spec/lib/gitlab/background_migration/backfill_vulnerability_reads_cluster_agent_spec.rb'
     - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_statistics_with_container_registry_size_batching_strategy_spec.rb'
     - 'spec/lib/gitlab/background_migration/batching_strategies/remove_backfilled_job_artifacts_expire_at_batching_strategy_spec.rb'
diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml
index fbd8acaf14c..235ee63b230 100644
--- a/.rubocop_todo/rspec/expect_change.yml
+++ b/.rubocop_todo/rspec/expect_change.yml
@@ -238,11 +238,6 @@ RSpec/ExpectChange:
     - 'spec/lib/gitlab/legacy_github_import/project_creator_spec.rb'
     - 'spec/lib/gitlab/query_limiting/transaction_spec.rb'
     - 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb'
-    - 'spec/migrations/20221018050323_add_objective_and_keyresult_to_work_item_types_spec.rb'
-    - 'spec/migrations/20221018193635_ensure_task_note_renaming_background_migration_finished_spec.rb'
-    - 'spec/migrations/20221102090940_create_next_ci_partitions_record_spec.rb'
-    - 'spec/migrations/cleanup_vulnerability_state_transitions_with_same_from_state_to_state_spec.rb'
-    - 'spec/migrations/delete_migrate_shared_vulnerability_scanners_spec.rb'
     - 'spec/models/ci/build_metadata_spec.rb'
     - 'spec/models/ci/build_spec.rb'
     - 'spec/models/ci/job_artifact_spec.rb'
diff --git a/.rubocop_todo/rspec/feature_category.yml b/.rubocop_todo/rspec/feature_category.yml
index fb8e7eecc64..ad42026a079 100644
--- a/.rubocop_todo/rspec/feature_category.yml
+++ b/.rubocop_todo/rspec/feature_category.yml
@@ -2791,7 +2791,6 @@ RSpec/FeatureCategory:
     - 'spec/lib/gitlab/background_migration/backfill_note_discussion_id_spec.rb'
     - 'spec/lib/gitlab/background_migration/backfill_project_feature_package_registry_access_level_spec.rb'
     - 'spec/lib/gitlab/background_migration/backfill_project_import_level_spec.rb'
-    - 'spec/lib/gitlab/background_migration/backfill_project_member_namespace_id_spec.rb'
     - 'spec/lib/gitlab/background_migration/backfill_project_namespace_details_spec.rb'
     - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb'
     - 'spec/lib/gitlab/background_migration/backfill_topics_title_spec.rb'
@@ -2808,9 +2807,7 @@ RSpec/FeatureCategory:
     - 'spec/lib/gitlab/background_migration/delete_orphaned_operational_vulnerabilities_spec.rb'
     - 'spec/lib/gitlab/background_migration/delete_orphans_approval_merge_request_rules_spec.rb'
     - 'spec/lib/gitlab/background_migration/delete_orphans_approval_project_rules_spec.rb'
-    - 'spec/lib/gitlab/background_migration/destroy_invalid_group_members_spec.rb'
     - 'spec/lib/gitlab/background_migration/destroy_invalid_members_spec.rb'
-    - 'spec/lib/gitlab/background_migration/destroy_invalid_project_members_spec.rb'
     - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_licence_for_recent_public_projects_spec.rb'
     - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_inactive_public_projects_spec.rb'
     - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_no_issues_no_repo_projects_spec.rb'
diff --git a/.rubocop_todo/rspec/named_subject.yml b/.rubocop_todo/rspec/named_subject.yml
index 2c8c6dfd87a..152d2068e0c 100644
--- a/.rubocop_todo/rspec/named_subject.yml
+++ b/.rubocop_todo/rspec/named_subject.yml
@@ -2578,8 +2578,6 @@ RSpec/NamedSubject:
     - 'spec/mailers/emails/merge_requests_spec.rb'
     - 'spec/mailers/notify_spec.rb'
     - 'spec/metrics_server/metrics_server_spec.rb'
-    - 'spec/migrations/20221028022627_add_index_on_password_last_changed_at_to_user_details_spec.rb'
-    - 'spec/migrations/20221101032600_add_text_limit_to_default_preferred_language_on_application_settings_spec.rb'
     - 'spec/migrations/20221210154044_update_active_billable_users_index_spec.rb'
     - 'spec/migrations/20221221110733_remove_temp_index_for_project_statistics_upload_size_migration_spec.rb'
     - 'spec/migrations/20230714015909_add_index_for_member_expiring_query_spec.rb'
diff --git a/.rubocop_todo/style/inline_disable_annotation.yml b/.rubocop_todo/style/inline_disable_annotation.yml
index 31641ee0dd8..644c6fa726b 100644
--- a/.rubocop_todo/style/inline_disable_annotation.yml
+++ b/.rubocop_todo/style/inline_disable_annotation.yml
@@ -1120,16 +1120,6 @@ Style/InlineDisableAnnotation:
     - 'config/routes/project.rb'
     - 'danger/ce_ee_vue_templates/Dangerfile'
     - 'danger/roulette/Dangerfile'
-    - 'db/migrate/20220802200719_add_user_details_profile_fields.rb'
-    - 'db/migrate/20220818125332_add_jitsu_tracking_columns_to_application_settings.rb'
-    - 'db/migrate/20220825105631_add_cube_api_key_to_application_settings.rb'
-    - 'db/migrate/20220902065317_add_partition_id_to_ci_builds.rb'
-    - 'db/migrate/20220914130800_add_jitsu_key_to_projects.rb'
-    - 'db/migrate/20220920135632_add_jira_connect_proxy_url_setting.rb'
-    - 'db/migrate/20220926023734_add_mirror_branch_regex_to_project_settings.rb'
-    - 'db/migrate/20221014034338_populate_releases_access_level_from_repository.rb'
-    - 'db/migrate/20221025043930_change_default_value_on_password_last_changed_at_to_user_details.rb'
-    - 'db/migrate/20221101032521_add_default_preferred_language_to_application_settings.rb'
     - 'db/migrate/20221111123146_add_onboarding_in_progress_to_users.rb'
     - 'db/migrate/20221111123147_add_onboarding_step_url_to_user_details.rb'
     - 'db/migrate/20221114131943_add_short_title_to_appearances.rb'
@@ -1190,16 +1180,6 @@ Style/InlineDisableAnnotation:
     - 'db/migrate/20231017135207_add_fields_to_ml_model.rb'
     - 'db/migrate/20231019180421_add_name_description_to_catalog_resources.rb'
     - 'db/migrate/20231024142236_add_fields_to_bulk_import_failures.rb'
-    - 'db/post_migrate/20220822090656_drop_build_coverage_regex_from_project.rb'
-    - 'db/post_migrate/20220830061704_orphaned_invited_members_cleanup.rb'
-    - 'db/post_migrate/20220901071355_cleanup_attention_request_user_callouts.rb'
-    - 'db/post_migrate/20220902204048_move_security_findings_table_to_gitlab_partitions_dynamic_schema.rb'
-    - 'db/post_migrate/20220919023208_drop_unused_fields_from_merge_request_assignees.rb'
-    - 'db/post_migrate/20220919080303_delete_migrate_shared_vulnerability_scanners.rb'
-    - 'db/post_migrate/20220920135356_tiebreak_user_type_index.rb'
-    - 'db/post_migrate/20221006172302_adjust_task_note_rename_background_migration_values.rb'
-    - 'db/post_migrate/20221013154159_update_invalid_dormant_user_setting.rb'
-    - 'db/post_migrate/20221018232820_add_temp_index_for_user_details_fields.rb'
     - 'db/post_migrate/20221102231131_remove_temp_index_for_user_details_fields.rb'
     - 'db/post_migrate/20221115184525_remove_namespaces_tmp_project_id_column.rb'
     - 'db/post_migrate/20221220131020_bump_default_partition_id_value_for_ci_tables.rb'
@@ -2912,7 +2892,6 @@ Style/InlineDisableAnnotation:
     - 'spec/lib/gitlab/background_migration/backfill_has_merge_request_of_vulnerability_reads_spec.rb'
     - 'spec/lib/gitlab/background_migration/backfill_missing_ci_cd_settings_spec.rb'
     - 'spec/lib/gitlab/background_migration/backfill_project_import_level_spec.rb'
-    - 'spec/lib/gitlab/background_migration/backfill_project_member_namespace_id_spec.rb'
     - 'spec/lib/gitlab/background_migration/backfill_project_namespace_on_issues_spec.rb'
     - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb'
     - 'spec/lib/gitlab/background_migration/backfill_resource_link_events_spec.rb'
@@ -2927,9 +2906,7 @@ Style/InlineDisableAnnotation:
     - 'spec/lib/gitlab/background_migration/convert_credit_card_validation_data_to_hashes_spec.rb'
     - 'spec/lib/gitlab/background_migration/delete_orphans_approval_merge_request_rules2_spec.rb'
     - 'spec/lib/gitlab/background_migration/delete_orphans_approval_project_rules2_spec.rb'
-    - 'spec/lib/gitlab/background_migration/destroy_invalid_group_members_spec.rb'
     - 'spec/lib/gitlab/background_migration/destroy_invalid_members_spec.rb'
-    - 'spec/lib/gitlab/background_migration/destroy_invalid_project_members_spec.rb'
     - 'spec/lib/gitlab/background_migration/fix_allow_descendants_override_disabled_shared_runners_spec.rb'
     - 'spec/lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics_spec.rb'
     - 'spec/lib/gitlab/background_migration/fix_vulnerability_reads_has_issues_spec.rb'