diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-08-04 18:11:28 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-08-04 18:11:28 +0300 |
commit | f805496e2f458cc234ac5e52d09fa6d787ccaa97 (patch) | |
tree | c714517ee5ac4b03a762188af2c423e2aae0c363 /.rubocop_todo | |
parent | 39e07b68051f93f95d11b8607dfaa8ae87458bb7 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to '.rubocop_todo')
-rw-r--r-- | .rubocop_todo/capybara/visibility_matcher.yml | 21 | ||||
-rw-r--r-- | .rubocop_todo/layout/first_array_element_indentation.yml | 62 | ||||
-rw-r--r-- | .rubocop_todo/layout/first_hash_element_indentation.yml | 126 | ||||
-rw-r--r-- | .rubocop_todo/layout/multiline_operation_indentation.yml | 34 | ||||
-rw-r--r-- | .rubocop_todo/layout/space_inside_block_braces.yml | 38 | ||||
-rw-r--r-- | .rubocop_todo/rails/rake_environment.yml | 25 |
6 files changed, 215 insertions, 91 deletions
diff --git a/.rubocop_todo/capybara/visibility_matcher.yml b/.rubocop_todo/capybara/visibility_matcher.yml index 90d71fe2d3a..e236be2593e 100644 --- a/.rubocop_todo/capybara/visibility_matcher.yml +++ b/.rubocop_todo/capybara/visibility_matcher.yml @@ -1,24 +1,23 @@ --- Capybara/VisibilityMatcher: - # Offense count: 213 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - - 'ee/spec/features/billings/billing_plans_spec.rb' - 'ee/spec/features/boards/sidebar_spec.rb' - 'ee/spec/features/epics/epic_show_spec.rb' - 'ee/spec/features/epics/todo_spec.rb' + - 'ee/spec/features/epics/update_epic_spec.rb' - 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb' - 'ee/spec/features/groups/issues_spec.rb' - 'ee/spec/features/groups/saml_enforcement_spec.rb' + - 'ee/spec/features/groups/settings/protected_environments_spec.rb' - 'ee/spec/features/issues/related_issues_spec.rb' - 'ee/spec/features/projects/integrations/user_activates_jira_spec.rb' - - 'ee/spec/features/projects/path_locks_spec.rb' - 'ee/spec/features/projects/quality/test_case_show_spec.rb' - 'ee/spec/features/projects/requirements_management/requirements_list_spec.rb' - 'ee/spec/features/projects/settings/ee/repository_mirrors_settings_spec.rb' - 'ee/spec/features/promotion_spec.rb' - 'ee/spec/features/registrations/welcome_spec.rb' + - 'ee/spec/support/helpers/billing_plans_helpers.rb' + - 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb' - 'ee/spec/support/shared_examples/views/issuable_bulk_dropdown_shared_examples.rb' - 'ee/spec/views/layouts/_search.html.haml_spec.rb' - 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb' @@ -26,13 +25,6 @@ Capybara/VisibilityMatcher: - 'spec/features/dashboard/merge_requests_spec.rb' - 'spec/features/dashboard/todos/todos_spec.rb' - 'spec/features/groups/group_settings_spec.rb' - - 'spec/features/issues/filtered_search/dropdown_assignee_spec.rb' - - 'spec/features/issues/filtered_search/dropdown_author_spec.rb' - - 'spec/features/issues/filtered_search/dropdown_emoji_spec.rb' - - 'spec/features/issues/filtered_search/dropdown_hint_spec.rb' - - 'spec/features/issues/filtered_search/recent_searches_spec.rb' - - 'spec/features/issues/filtered_search/search_bar_spec.rb' - - 'spec/features/issues/filtered_search/visual_tokens_spec.rb' - 'spec/features/issues/service_desk_spec.rb' - 'spec/features/issues/todo_spec.rb' - 'spec/features/issues/user_creates_branch_and_merge_request_spec.rb' @@ -48,17 +40,19 @@ Capybara/VisibilityMatcher: - 'spec/features/projects/blobs/user_follows_pipeline_suggest_nudge_spec.rb' - 'spec/features/projects/ci/lint_spec.rb' - 'spec/features/projects/commit/comments/user_adds_comment_spec.rb' + - 'spec/features/projects/commits/multi_view_diff_spec.rb' - 'spec/features/projects/commits/user_browses_commits_spec.rb' - 'spec/features/projects/integrations/user_activates_jira_spec.rb' - 'spec/features/projects/issues/design_management/user_views_designs_with_svg_xss_spec.rb' - 'spec/features/projects/jobs_spec.rb' - 'spec/features/projects/network_graph_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipeline_spec.rb' - 'spec/features/projects/pipelines/pipeline_spec.rb' - 'spec/features/projects/settings/lfs_settings_spec.rb' - 'spec/features/projects/settings/packages_settings_spec.rb' + - 'spec/features/projects/settings/repository_settings_spec.rb' - 'spec/features/projects/settings/visibility_settings_spec.rb' - 'spec/features/projects/show/user_manages_notifications_spec.rb' - - 'spec/features/projects/tags/user_edits_tags_spec.rb' - 'spec/features/projects/user_changes_project_visibility_spec.rb' - 'spec/features/projects/user_sees_user_popover_spec.rb' - 'spec/features/search/user_searches_for_commits_spec.rb' @@ -66,6 +60,7 @@ Capybara/VisibilityMatcher: - 'spec/features/task_lists_spec.rb' - 'spec/features/u2f_spec.rb' - 'spec/features/uploads/user_uploads_file_to_note_spec.rb' + - 'spec/features/users/email_verification_on_login_spec.rb' - 'spec/features/users/overview_spec.rb' - 'spec/features/users/user_browses_projects_on_user_page_spec.rb' - 'spec/features/webauthn_spec.rb' diff --git a/.rubocop_todo/layout/first_array_element_indentation.yml b/.rubocop_todo/layout/first_array_element_indentation.yml index e3bbf9dc25a..84e367e0514 100644 --- a/.rubocop_todo/layout/first_array_element_indentation.yml +++ b/.rubocop_todo/layout/first_array_element_indentation.yml @@ -1,9 +1,6 @@ --- # Cop supports --auto-correct. Layout/FirstArrayElementIndentation: - # Offense count: 1133 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/controllers/abuse_reports_controller.rb' - 'app/controllers/admin/application_settings_controller.rb' @@ -22,10 +19,12 @@ Layout/FirstArrayElementIndentation: - 'app/helpers/search_helper.rb' - 'app/models/ci/job_token/scope.rb' - 'app/models/container_repository.rb' + - 'app/models/customer_relations/contact.rb' + - 'app/models/customer_relations/organization.rb' - 'app/models/group.rb' - 'app/models/integration.rb' - - 'app/models/integrations/bamboo.rb' - 'app/models/internal_id.rb' + - 'app/models/issue.rb' - 'app/models/member.rb' - 'app/models/merge_request.rb' - 'app/models/namespace.rb' @@ -40,6 +39,7 @@ Layout/FirstArrayElementIndentation: - 'app/workers/ssh_keys/expired_notification_worker.rb' - 'config/initializers/postgres_partitioning.rb' - 'db/post_migrate/20210812013042_remove_duplicate_project_authorizations.rb' + - 'ee/app/controllers/groups/settings/reporting_controller.rb' - 'ee/app/controllers/projects/vulnerability_feedback_controller.rb' - 'ee/app/finders/autocomplete/project_invited_groups_finder.rb' - 'ee/app/finders/geo/project_registry_finder.rb' @@ -47,14 +47,19 @@ Layout/FirstArrayElementIndentation: - 'ee/app/graphql/mutations/vulnerabilities/create.rb' - 'ee/app/helpers/ee/application_settings_helper.rb' - 'ee/app/helpers/ee/trial_helper.rb' + - 'ee/app/models/analytics/devops_adoption/enabled_namespace.rb' - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/ee/project.rb' - 'ee/app/models/ee/user.rb' + - 'ee/app/models/ee/vulnerability.rb' - 'ee/app/models/protected_environment.rb' + - 'ee/app/models/vulnerabilities/read.rb' - 'ee/app/serializers/dashboard_environments_serializer.rb' - 'ee/app/services/app_sec/dast/profiles/update_service.rb' - 'ee/app/services/vulnerabilities/create_service_base.rb' - 'ee/lib/ee/api/helpers/award_emoji.rb' - 'ee/lib/ee/gitlab/geo_git_access.rb' + - 'ee/lib/gitlab/contribution_analytics/data_collector.rb' - 'ee/lib/gitlab/elastic/helper.rb' - 'ee/lib/gitlab/sitemaps/url_extractor.rb' - 'ee/lib/tasks/gitlab/seed/metrics.rake' @@ -65,14 +70,17 @@ Layout/FirstArrayElementIndentation: - 'ee/spec/controllers/projects/merge_requests_controller_spec.rb' - 'ee/spec/features/admin/admin_dev_ops_reports_spec.rb' - 'ee/spec/features/boards/boards_licensed_features_spec.rb' + - 'ee/spec/features/groups/analytics/cycle_analytics/charts_spec.rb' - 'ee/spec/features/groups/group_roadmap_spec.rb' - 'ee/spec/finders/billed_users_finder_spec.rb' - 'ee/spec/finders/merge_requests/by_approvers_finder_spec.rb' - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' + - 'ee/spec/finders/security/scan_execution_policies_finder_spec.rb' - 'ee/spec/frontend/fixtures/dast_profiles.rb' - 'ee/spec/frontend/fixtures/search.rb' - 'ee/spec/graphql/mutations/incident_management/escalation_policy/create_spec.rb' - 'ee/spec/graphql/resolvers/dora_metrics_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/security_orchestration/scan_execution_policy_resolver_spec.rb' - 'ee/spec/graphql/resolvers/timebox_report_resolver_spec.rb' - 'ee/spec/graphql/types/ci/pipeline_type_spec.rb' - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb' @@ -89,6 +97,7 @@ Layout/FirstArrayElementIndentation: - 'ee/spec/lib/gitlab/ci/templates/Jobs/load_performance_testing_gitlab_ci_yaml_spec.rb' - 'ee/spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/epic_node_spec.rb' + - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_links_aggregate_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/issues/lazy_links_aggregate_spec.rb' - 'ee/spec/lib/gitlab/graphql/loaders/bulk_epic_aggregate_loader_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_ci_builds_metric_spec.rb' @@ -104,6 +113,7 @@ Layout/FirstArrayElementIndentation: - 'ee/spec/models/ee/namespace_spec.rb' - 'ee/spec/models/ee/release_spec.rb' - 'ee/spec/models/group_wiki_repository_spec.rb' + - 'ee/spec/models/namespace_setting_spec.rb' - 'ee/spec/models/project_spec.rb' - 'ee/spec/models/requirements_management/test_report_spec.rb' - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' @@ -123,6 +133,7 @@ Layout/FirstArrayElementIndentation: - 'ee/spec/requests/api/graphql/project/alert_management/payload_fields_spec.rb' - 'ee/spec/requests/api/graphql/project/incident_management/escalation_policy/rules_spec.rb' - 'ee/spec/requests/api/graphql/project/merge_requests_spec.rb' + - 'ee/spec/requests/api/internal/kubernetes_spec.rb' - 'ee/spec/requests/api/ldap_group_links_spec.rb' - 'ee/spec/requests/api/members_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb' @@ -130,16 +141,16 @@ Layout/FirstArrayElementIndentation: - 'ee/spec/services/gitlab_subscriptions/fetch_purchase_eligible_namespaces_service_spec.rb' - 'ee/spec/services/groups/seat_usage_export_service_spec.rb' - 'ee/spec/services/iterations/cadences/create_iterations_in_advance_service_spec.rb' - - 'ee/spec/services/iterations/cadences/create_service_spec.rb' - 'ee/spec/services/protected_environments/base_service_spec.rb' - 'ee/spec/services/search_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/hooks_execution_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/process_scan_result_policy_service_spec.rb' - 'ee/spec/services/security/store_findings_metadata_service_spec.rb' - 'ee/spec/services/timebox_report_service_spec.rb' - 'ee/spec/services/user_permissions/export_service_spec.rb' - 'ee/spec/support/shared_examples/services/search_notes_shared_examples.rb' - 'ee/spec/workers/geo/scheduler/scheduler_worker_spec.rb' - - 'lib/gitlab/background_migration/fix_merge_request_diff_commit_users.rb' + - 'lib/event_filter.rb' - 'lib/gitlab/database/migration_helpers.rb' - 'lib/gitlab/email/message/in_product_marketing/team.rb' - 'lib/gitlab/email/message/in_product_marketing/trial.rb' @@ -153,25 +164,27 @@ Layout/FirstArrayElementIndentation: - 'lib/gitlab/usage_data.rb' - 'lib/system_check/app/authorized_keys_permission_check.rb' - 'qa/qa/resource/protected_branch.rb' + - 'qa/qa/specs/features/api/1_manage/group_access_token_spec.rb' - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' + - 'qa/qa/specs/features/api/1_manage/user_inherited_access_spec.rb' - 'qa/qa/specs/features/api/3_create/gitaly/automatic_failover_and_recovery_spec.rb' + - 'qa/qa/specs/features/api/3_create/gitaly/changing_repository_storage_spec.rb' - 'qa/qa/specs/features/api/3_create/gitaly/gitaly_mtls_spec.rb' - 'qa/qa/specs/features/api/3_create/gitaly/praefect_dataloss_spec.rb' + - 'qa/qa/specs/features/api/3_create/repository/commit_to_templated_project_spec.rb' + - 'qa/qa/specs/features/browser_ui/1_manage/group/transfer_project_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/custom_issue_template_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/cherry_pick/cherry_pick_commit_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_via_template_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/revert/revert_commit_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/branch_with_unusual_name_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/snippet/copy_snippet_file_contents_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/add_new_directory_in_web_ide_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_web_ide_from_diff_tab_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/helm_registry_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_group_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_project_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven_gradle_repository_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_instance_level_spec.rb' - - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_project_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb' - 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb' @@ -189,12 +202,14 @@ Layout/FirstArrayElementIndentation: - 'spec/controllers/projects/pipelines_controller_spec.rb' - 'spec/deprecation_toolkit_env.rb' - 'spec/features/clusters/create_agent_spec.rb' - - 'spec/features/issues/filtered_search/filter_issues_spec.rb' - - 'spec/features/issues/filtered_search/visual_tokens_spec.rb' + - 'spec/finders/bulk_imports/entities_finder_spec.rb' - 'spec/finders/ci/daily_build_group_report_results_finder_spec.rb' - 'spec/finders/deploy_tokens/tokens_finder_spec.rb' + - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_direct_membership_finder_spec.rb' + - 'spec/finders/groups/projects_requiring_authorizations_refresh/on_transfer_finder_spec.rb' - 'spec/frontend/fixtures/search.rb' - 'spec/graphql/mutations/commits/create_spec.rb' + - 'spec/graphql/mutations/environments/canary_ingress/update_spec.rb' - 'spec/graphql/resolvers/ci/test_suite_resolver_spec.rb' - 'spec/graphql/types/ci/runner_architecture_type_spec.rb' - 'spec/graphql/types/ci/runner_platform_type_spec.rb' @@ -217,8 +232,10 @@ Layout/FirstArrayElementIndentation: - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/lib/gitlab/ci/ansi2json_spec.rb' - 'spec/lib/gitlab/ci/config/entry/product/parallel_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/root_spec.rb' + - 'spec/lib/gitlab/ci/config/external/file/artifact_spec.rb' + - 'spec/lib/gitlab/ci/config/external/file/project_spec.rb' - 'spec/lib/gitlab/ci/config/external/mapper_spec.rb' + - 'spec/lib/gitlab/ci/parsers/sbom/validators/cyclonedx_schema_validator_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - 'spec/lib/gitlab/ci/reports/codequality_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/codequality_reports_spec.rb' @@ -241,9 +258,13 @@ Layout/FirstArrayElementIndentation: - 'spec/lib/gitlab/diff/char_diff_spec.rb' - 'spec/lib/gitlab/diff/file_collection_sorter_spec.rb' - 'spec/lib/gitlab/error_tracking/stack_trace_highlight_decorator_spec.rb' + - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/gitaly_client/blob_service_spec.rb' + - 'spec/lib/gitlab/github_import/importer/diff_notes_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/issues_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/lfs_objects_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/notes_importer_spec.rb' - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb' - - 'spec/lib/gitlab/gitlab_import/importer_spec.rb' - 'spec/lib/gitlab/grape_logging/formatters/lograge_with_timestamp_spec.rb' - 'spec/lib/gitlab/hook_data/release_builder_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' @@ -263,13 +284,16 @@ Layout/FirstArrayElementIndentation: - 'spec/lib/gitlab/search/abuse_detection_spec.rb' - 'spec/lib/gitlab/search/found_blob_spec.rb' - 'spec/lib/gitlab/serializer/ci/variables_spec.rb' + - 'spec/lib/gitlab/sidekiq_config_spec.rb' - 'spec/lib/gitlab/ssh_public_key_spec.rb' - 'spec/lib/gitlab/usage_data/topology_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils_spec.rb' - 'spec/lib/gitlab/webpack/manifest_spec.rb' + - 'spec/lib/google_api/cloud_platform/client_spec.rb' - 'spec/lib/peek/views/bullet_detailed_spec.rb' - 'spec/lib/system_check/incoming_email_check_spec.rb' + - 'spec/lib/unnested_in_filters/rewriter_spec.rb' - 'spec/migrations/add_premium_and_ultimate_plan_limits_spec.rb' - 'spec/migrations/backfill_escalation_policies_for_oncall_schedules_spec.rb' - 'spec/migrations/slice_merge_request_diff_commit_migrations_spec.rb' @@ -279,6 +303,7 @@ Layout/FirstArrayElementIndentation: - 'spec/models/ci/build_trace_spec.rb' - 'spec/models/ci/daily_build_group_report_result_spec.rb' - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/ci/runner_version_spec.rb' - 'spec/models/ci/unit_test_spec.rb' - 'spec/models/clusters/applications/cert_manager_spec.rb' - 'spec/models/clusters/platforms/kubernetes_spec.rb' @@ -293,6 +318,7 @@ Layout/FirstArrayElementIndentation: - 'spec/models/integration_spec.rb' - 'spec/models/integrations/chat_message/issue_message_spec.rb' - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' + - 'spec/models/integrations/jira_spec.rb' - 'spec/models/label_note_spec.rb' - 'spec/models/merge_request/cleanup_schedule_spec.rb' - 'spec/models/merge_request_diff_spec.rb' @@ -300,6 +326,8 @@ Layout/FirstArrayElementIndentation: - 'spec/models/operations/feature_flags/strategy_spec.rb' - 'spec/models/project_group_link_spec.rb' - 'spec/models/repository_spec.rb' + - 'spec/models/user_preference_spec.rb' + - 'spec/models/user_spec.rb' - 'spec/models/wiki_directory_spec.rb' - 'spec/policies/concerns/crud_policy_helpers_spec.rb' - 'spec/presenters/ci/build_runner_presenter_spec.rb' @@ -309,24 +337,30 @@ Layout/FirstArrayElementIndentation: - 'spec/requests/api/deploy_tokens_spec.rb' - 'spec/requests/api/graphql/ci/config_spec.rb' - 'spec/requests/api/graphql/ci/jobs_spec.rb' + - 'spec/requests/api/graphql/mutations/uploads/delete_spec.rb' - 'spec/requests/api/graphql/project/cluster_agents_spec.rb' - 'spec/requests/api/graphql/project/issue/designs/designs_spec.rb' - 'spec/requests/api/graphql/project/milestones_spec.rb' - 'spec/requests/api/graphql/usage_trends_measurements_spec.rb' + - 'spec/requests/api/graphql/work_item_spec.rb' - 'spec/requests/api/issues/post_projects_issues_spec.rb' - 'spec/requests/api/issues/put_projects_issues_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/task_completion_status_spec.rb' - 'spec/requests/projects/ci/promeheus_metrics/histograms_controller_spec.rb' - 'spec/requests/projects/issues_controller_spec.rb' + - 'spec/requests/projects/merge_requests_controller_spec.rb' - 'spec/serializers/build_trace_entity_spec.rb' - 'spec/serializers/ci/daily_build_group_report_result_serializer_spec.rb' - 'spec/serializers/merge_request_poll_widget_entity_spec.rb' - 'spec/services/award_emojis/copy_service_spec.rb' + - 'spec/services/bulk_update_integration_service_spec.rb' - 'spec/services/ci/compare_test_reports_service_spec.rb' + - 'spec/services/ci/create_pipeline_service/rules_spec.rb' - 'spec/services/ci/find_exposed_artifacts_service_spec.rb' - 'spec/services/design_management/move_designs_service_spec.rb' - 'spec/services/git/tag_hooks_service_spec.rb' + - 'spec/services/google_cloud/setup_cloudsql_instance_service_spec.rb' - 'spec/services/import/gitlab_projects/create_project_service_spec.rb' - 'spec/services/jira_connect/sync_service_spec.rb' - 'spec/services/merge_requests/link_lfs_objects_service_spec.rb' @@ -338,9 +372,9 @@ Layout/FirstArrayElementIndentation: - 'spec/simplecov_env.rb' - 'spec/support/atlassian/jira_connect/schemata.rb' - 'spec/support/capybara.rb' + - 'spec/support/helpers/project_template_test_helper.rb' - 'spec/support/helpers/test_env.rb' - 'spec/support/helpers/usage_data_helpers.rb' - - 'spec/support/matchers/background_migrations_matchers.rb' - 'spec/support/matchers/exceed_query_limit.rb' - 'spec/support/migrations_helpers/vulnerabilities_findings_helper.rb' - 'spec/support/prometheus/additional_metrics_shared_examples.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index 8f4d05b36ae..94ad3fde252 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -1,10 +1,9 @@ --- # Cop supports --auto-correct. Layout/FirstHashElementIndentation: - # Offense count: 1995 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: + - 'app/components/diffs/stats_component.rb' + - 'app/controllers/admin/ci/variables_controller.rb' - 'app/controllers/admin/system_info_controller.rb' - 'app/controllers/boards/issues_controller.rb' - 'app/controllers/concerns/issuable_actions.rb' @@ -13,7 +12,6 @@ Layout/FirstHashElementIndentation: - 'app/controllers/concerns/sourcegraph_decorator.rb' - 'app/controllers/profiles/two_factor_auths_controller.rb' - 'app/controllers/projects/badges_controller.rb' - - 'app/controllers/projects/merge_requests_controller.rb' - 'app/controllers/repositories/lfs_locks_api_controller.rb' - 'app/experiments/concerns/project_commit_count.rb' - 'app/graphql/mutations/clusters/agent_tokens/create.rb' @@ -26,12 +24,12 @@ Layout/FirstHashElementIndentation: - 'app/helpers/breadcrumbs_helper.rb' - 'app/helpers/broadcast_messages_helper.rb' - 'app/helpers/commits_helper.rb' - - 'app/helpers/diff_helper.rb' - 'app/helpers/environments_helper.rb' - 'app/helpers/icons_helper.rb' - 'app/helpers/keyset_helper.rb' - 'app/helpers/listbox_helper.rb' - 'app/helpers/page_layout_helper.rb' + - 'app/helpers/projects/project_members_helper.rb' - 'app/helpers/search_helper.rb' - 'app/helpers/sorting_helper.rb' - 'app/helpers/ssh_keys_helper.rb' @@ -45,6 +43,7 @@ Layout/FirstHashElementIndentation: - 'app/models/ci/build_metadata.rb' - 'app/models/ci/runner.rb' - 'app/models/clusters/applications/crossplane.rb' + - 'app/models/clusters/platforms/kubernetes.rb' - 'app/models/concerns/cross_database_modification.rb' - 'app/models/concerns/featurable.rb' - 'app/models/concerns/has_wiki_page_slug_attributes.rb' @@ -65,14 +64,27 @@ Layout/FirstHashElementIndentation: - 'app/serializers/cluster_serializer.rb' - 'app/serializers/detailed_status_entity.rb' - 'app/services/award_emojis/base_service.rb' + - 'app/services/ci/runners/reconcile_existing_runner_versions_service.rb' - 'app/services/google_cloud/create_service_accounts_service.rb' - 'app/services/members/create_service.rb' - 'app/services/notification_service.rb' - 'app/services/packages/composer/create_package_service.rb' + - 'app/services/pages/delete_service.rb' + - 'app/services/projects/after_rename_service.rb' + - 'app/services/projects/create_service.rb' + - 'app/services/projects/destroy_service.rb' + - 'app/services/projects/transfer_service.rb' + - 'app/services/projects/update_pages_service.rb' + - 'app/services/projects/update_service.rb' - 'app/services/resource_events/change_milestone_service.rb' - 'app/services/spam/ham_service.rb' + - 'app/services/timelogs/base_service.rb' - 'app/validators/addressable_url_validator.rb' - 'app/workers/concerns/cluster_cleanup_methods.rb' + - 'ee/app/components/namespaces/free_user_cap/alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/personal_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/personal_preview_alert_component.rb' + - 'ee/app/components/namespaces/free_user_cap/preview_alert_component.rb' - 'ee/app/controllers/groups/analytics/tasks_by_type_controller.rb' - 'ee/app/graphql/mutations/boards/epic_lists/destroy.rb' - 'ee/app/graphql/mutations/boards/epics/create.rb' @@ -81,9 +93,12 @@ Layout/FirstHashElementIndentation: - 'ee/app/graphql/mutations/iterations/update.rb' - 'ee/app/graphql/mutations/projects/set_compliance_framework.rb' - 'ee/app/graphql/mutations/security_policy/commit_scan_execution_policy.rb' + - 'ee/app/helpers/ee/application_settings_helper.rb' - 'ee/app/helpers/ee/ci/jobs_helper.rb' - 'ee/app/helpers/ee/geo_helper.rb' - 'ee/app/helpers/ee/groups/group_members_helper.rb' + - 'ee/app/helpers/ee/members_helper.rb' + - 'ee/app/helpers/ee/namespaces_helper.rb' - 'ee/app/helpers/ee/projects_helper.rb' - 'ee/app/helpers/ee/sidebars_helper.rb' - 'ee/app/helpers/ee/tree_helper.rb' @@ -96,19 +111,22 @@ Layout/FirstHashElementIndentation: - 'ee/app/serializers/ee/environment_serializer.rb' - 'ee/app/services/app_sec/dast/profiles/update_service.rb' - 'ee/app/services/app_sec/dast/site_profiles/update_service.rb' + - 'ee/app/services/audit_events/build_service.rb' - 'ee/app/services/ee/auth/container_registry_authentication_service.rb' - 'ee/app/services/ee/ci/register_job_service.rb' - 'ee/app/services/ee/issues/export_csv_service.rb' - 'ee/app/services/elastic/cluster_reindexing_service.rb' - 'ee/app/services/gitlab_subscriptions/plan_upgrade_service.rb' + - 'ee/app/services/incident_management/issuable_resource_links/base_service.rb' - 'ee/app/services/jira/requests/issues/list_service.rb' - - 'ee/app/services/projects/slack_application_install_service.rb' - 'ee/app/services/security/token_revocation_service.rb' - 'ee/app/services/timebox_report_service.rb' - 'ee/app/workers/elastic_delete_project_worker.rb' - 'ee/app/workers/groups/create_event_worker.rb' - 'ee/lib/api/epic_links.rb' + - 'ee/lib/ee/api/geo.rb' - 'ee/lib/ee/container_registry/client.rb' + - 'ee/lib/ee/gitlab/application_rate_limiter.rb' - 'ee/lib/ee/gitlab/ci/parsers.rb' - 'ee/lib/ee/gitlab/usage_data.rb' - 'ee/lib/elastic/latest/application_class_proxy.rb' @@ -122,20 +140,23 @@ Layout/FirstHashElementIndentation: - 'ee/spec/controllers/boards/users_controller_spec.rb' - 'ee/spec/controllers/ee/projects/jobs_controller_spec.rb' - 'ee/spec/controllers/ee/projects/variables_controller_spec.rb' + - 'ee/spec/controllers/groups/analytics/cycle_analytics/summary_controller_spec.rb' - 'ee/spec/controllers/groups/epic_boards_controller_spec.rb' - 'ee/spec/controllers/groups/issues_controller_spec.rb' - 'ee/spec/controllers/projects/boards_controller_spec.rb' - 'ee/spec/controllers/projects/feature_flag_issues_controller_spec.rb' - 'ee/spec/controllers/projects/imports_controller_spec.rb' + - 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb' - 'ee/spec/controllers/projects/licenses_controller_spec.rb' - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' - 'ee/spec/controllers/security/projects_controller_spec.rb' - - 'ee/spec/elastic/migrate/20210421140400_add_new_data_to_merge_requests_documents_spec.rb' - - 'ee/spec/elastic/migrate/20210623081800_add_upvotes_to_issues_spec.rb' + - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/factories/dependencies.rb' - 'ee/spec/factories/licenses.rb' + - 'ee/spec/features/registrations/saas_user_registration_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' + - 'ee/spec/finders/security/scan_execution_policies_finder_spec.rb' - 'ee/spec/frontend/fixtures/dast_profiles.rb' - 'ee/spec/frontend/fixtures/on_demand_dast_scans.rb' - 'ee/spec/frontend/fixtures/search.rb' @@ -143,9 +164,14 @@ Layout/FirstHashElementIndentation: - 'ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb' - 'ee/spec/helpers/billing_plans_helper_spec.rb' - 'ee/spec/helpers/ee/access_tokens_helper_spec.rb' + - 'ee/spec/helpers/ee/groups_helper_spec.rb' + - 'ee/spec/helpers/ee/invite_members_helper_spec.rb' - 'ee/spec/helpers/ee/labels_helper_spec.rb' + - 'ee/spec/helpers/ee/namespaces_helper_spec.rb' + - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/sast_configuration_helper_spec.rb' + - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb' - 'ee/spec/helpers/groups/sso_helper_spec.rb' - 'ee/spec/helpers/nav/new_dropdown_helper_spec.rb' - 'ee/spec/helpers/projects_helper_spec.rb' @@ -154,17 +180,19 @@ Layout/FirstHashElementIndentation: - 'ee/spec/helpers/security_helper_spec.rb' - 'ee/spec/helpers/trial_registrations/reassurances_helper_spec.rb' - 'ee/spec/lib/container_registry/client_spec.rb' - - 'ee/spec/lib/ee/audit/project_changes_auditor_spec.rb' + - 'ee/spec/lib/ee/backup/repositories_spec.rb' - 'ee/spec/lib/ee/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb' - 'ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/config/entry/bridge_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/parsers/security/common_spec.rb' + - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary_spec.rb' - 'ee/spec/lib/gitlab/analytics/type_of_work/tasks_by_type_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/membership_updater_spec.rb' + - 'ee/spec/lib/gitlab/auth/saml/membership_updater_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/san_extension_spec.rb' - 'ee/spec/lib/gitlab/ci/config/entry/job_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' @@ -173,9 +201,11 @@ Layout/FirstHashElementIndentation: - 'ee/spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'ee/spec/lib/gitlab/contribution_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/elastic/indexer_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/lease_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - 'ee/spec/lib/gitlab/subscription_portal/clients/graphql_spec.rb' - 'ee/spec/lib/gitlab/web_ide/config/entry/schemas_spec.rb' + - 'ee/spec/lib/system_check/app/search_check_spec.rb' - 'ee/spec/mailers/credentials_inventory_mailer_spec.rb' - 'ee/spec/mailers/emails/requirements_spec.rb' - 'ee/spec/models/analytics/cycle_analytics/project_stage_spec.rb' @@ -186,25 +216,28 @@ Layout/FirstHashElementIndentation: - 'ee/spec/models/security/finding_spec.rb' - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' - 'ee/spec/requests/api/experiments_spec.rb' + - 'ee/spec/requests/api/geo_spec.rb' - 'ee/spec/requests/api/graphql/app_sec/fuzzing/api/ci_configuration_type_spec.rb' - 'ee/spec/requests/api/graphql/app_sec/fuzzing/coverage/corpus_type_spec.rb' - 'ee/spec/requests/api/graphql/ci/minutes/usage_spec.rb' - - 'ee/spec/requests/api/graphql/merge_requests/approval_state_spec.rb' - 'ee/spec/requests/api/graphql/milestone_spec.rb' - 'ee/spec/requests/api/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/gitlab_subscriptions/activate_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/issues/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/timelogs/create_spec.rb' - 'ee/spec/requests/api/internal/base_spec.rb' - 'ee/spec/requests/api/internal/upcoming_reconciliations_spec.rb' - 'ee/spec/requests/api/members_spec.rb' - 'ee/spec/requests/api/merge_requests_spec.rb' - 'ee/spec/requests/groups/group_members_controller_spec.rb' + - 'ee/spec/requests/groups/usage_quotas_spec.rb' - 'ee/spec/requests/projects/issue_feature_flags_controller_spec.rb' - 'ee/spec/requests/projects/mirrors_controller_spec.rb' - 'ee/spec/serializers/issues/linked_issue_feature_flag_entity_spec.rb' - 'ee/spec/serializers/license_entity_spec.rb' - 'ee/spec/serializers/linked_feature_flag_issue_entity_spec.rb' + - 'ee/spec/serializers/security/vulnerability_report_data_entity_spec.rb' + - 'ee/spec/services/analytics/cycle_analytics/consistency_check_service_spec.rb' - 'ee/spec/services/analytics/cycle_analytics/data_loader_service_spec.rb' - 'ee/spec/services/app_sec/dast/profile_schedules/audit/update_service_spec.rb' - 'ee/spec/services/app_sec/dast/profiles/audit/update_service_spec.rb' @@ -220,19 +253,29 @@ Layout/FirstHashElementIndentation: - 'ee/spec/services/app_sec/fuzzing/coverage/corpuses/create_service_spec.rb' - 'ee/spec/services/approval_rules/create_service_spec.rb' - 'ee/spec/services/approval_rules/update_service_spec.rb' + - 'ee/spec/services/arkose/user_verification_service_spec.rb' - 'ee/spec/services/audit_event_service_spec.rb' - 'ee/spec/services/ci/create_pipeline_service_spec.rb' + - 'ee/spec/services/ci/runners/stale_group_runners_prune_service_spec.rb' - 'ee/spec/services/ee/alert_management/http_integrations/create_service_spec.rb' - 'ee/spec/services/ee/alert_management/http_integrations/update_service_spec.rb' - 'ee/spec/services/ee/merge_requests/create_pipeline_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/update_service_spec.rb' - 'ee/spec/services/ee/post_receive_service_spec.rb' + - 'ee/spec/services/external_status_checks/create_service_spec.rb' - 'ee/spec/services/geo/node_status_request_service_spec.rb' - 'ee/spec/services/geo/registry_consistency_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/check_future_renewal_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/create_trial_or_lead_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/plan_upgrade_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/preview_billable_user_change_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/reconciliations/check_seat_usage_alerts_eligibility_service_spec.rb' - 'ee/spec/services/groups/create_service_spec.rb' - 'ee/spec/services/groups/destroy_service_spec.rb' - 'ee/spec/services/iterations/create_service_spec.rb' + - 'ee/spec/services/namespaces/free_user_cap/deactivate_members_over_limit_service_spec.rb' + - 'ee/spec/services/namespaces/free_user_cap/remove_group_group_links_outside_hierarchy_service_spec.rb' - 'ee/spec/services/projects/create_service_spec.rb' - 'ee/spec/services/projects/group_links/create_service_spec.rb' - 'ee/spec/services/projects/group_links/destroy_service_spec.rb' @@ -242,9 +285,16 @@ Layout/FirstHashElementIndentation: - 'ee/spec/services/security/token_revocation_service_spec.rb' - 'ee/spec/services/security/track_scan_service_spec.rb' - 'ee/spec/services/timebox_report_service_spec.rb' + - 'ee/spec/services/users/abuse/excessive_projects_download_ban_service_spec.rb' + - 'ee/spec/services/users/abuse/git_abuse/namespace_throttle_service_spec.rb' - 'ee/spec/support/helpers/ee/login_helpers.rb' - 'ee/spec/support/shared_contexts/fixtures/analytics_shared_context.rb' - 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb' + - 'ee/spec/support/shared_examples/controllers/namespace_storage_limit_alert_shared_examples.rb' + - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' + - 'ee/spec/workers/analytics/cycle_analytics/consistency_worker_spec.rb' + - 'ee/spec/workers/ci/runners/stale_group_runners_prune_cron_worker_spec.rb' + - 'ee/spec/workers/gitlab_subscriptions/notify_seats_exceeded_worker_spec.rb' - 'lib/api/admin/instance_clusters.rb' - 'lib/api/group_clusters.rb' - 'lib/api/project_clusters.rb' @@ -264,6 +314,7 @@ Layout/FirstHashElementIndentation: - 'lib/gitlab/github_import/importer/diff_note_importer.rb' - 'lib/gitlab/github_import/importer/pull_request_merged_by_importer.rb' - 'lib/gitlab/gitlab_import/client.rb' + - 'lib/gitlab/graphql/query_analyzers/ast/logger_analyzer.rb' - 'lib/gitlab/hook_data/issue_builder.rb' - 'lib/gitlab/hook_data/release_builder.rb' - 'lib/gitlab/kubernetes.rb' @@ -279,10 +330,9 @@ Layout/FirstHashElementIndentation: - 'qa/qa/ee/resource/board/board_list/project/assignee_board_list.rb' - 'qa/qa/ee/resource/board/board_list/project/milestone_board_list.rb' - 'qa/qa/resource/snippet.rb' + - 'qa/qa/specs/features/api/3_create/repository/commit_to_templated_project_spec.rb' - 'qa/qa/specs/features/api/5_package/container_registry_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_protected_branch_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/snippet/copy_snippet_file_contents_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_fork_in_web_ide_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_web_ide_from_diff_tab_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_omnibus_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_spec.rb' @@ -294,8 +344,11 @@ Layout/FirstHashElementIndentation: - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_project_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/new_discussion_not_dropping_merge_trains_mr_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/9_enablement/elasticsearch/elasticsearch_reindexing_spec.rb' + - 'spec/components/diffs/stats_component_spec.rb' + - 'spec/components/pajamas/component_spec.rb' - 'spec/config/object_store_settings_spec.rb' - 'spec/config/smime_signature_settings_spec.rb' - 'spec/controllers/admin/groups_controller_spec.rb' @@ -319,7 +372,6 @@ Layout/FirstHashElementIndentation: - 'spec/controllers/projects/environments_controller_spec.rb' - 'spec/controllers/projects/feature_flags_controller_spec.rb' - 'spec/controllers/projects/grafana_api_controller_spec.rb' - - 'spec/controllers/projects/group_links_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/jobs_controller_spec.rb' - 'spec/controllers/projects/merge_requests/creations_controller_spec.rb' @@ -336,26 +388,31 @@ Layout/FirstHashElementIndentation: - 'spec/controllers/projects/web_ide_terminals_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' - 'spec/factories/ci/builds.rb' - - 'spec/factories/container_repositories.rb' - 'spec/factories/packages/debian/file_metadatum.rb' - 'spec/features/gitlab_experiments_spec.rb' - 'spec/frontend/fixtures/autocomplete_sources.rb' - 'spec/frontend/fixtures/blob.rb' + - 'spec/frontend/fixtures/jobs.rb' + - 'spec/frontend/fixtures/runner.rb' - 'spec/graphql/mutations/release_asset_links/create_spec.rb' - 'spec/graphql/resolvers/concerns/caching_array_resolver_spec.rb' + - 'spec/graphql/resolvers/crm/organizations_resolver_spec.rb' - 'spec/graphql/types/ci/detailed_status_type_spec.rb' + - 'spec/helpers/access_tokens_helper_spec.rb' + - 'spec/helpers/admin/application_settings/settings_helper_spec.rb' - 'spec/helpers/admin/deploy_key_helper_spec.rb' - 'spec/helpers/analytics/cycle_analytics_helper_spec.rb' - 'spec/helpers/ci/builds_helper_spec.rb' - 'spec/helpers/ci/jobs_helper_spec.rb' - 'spec/helpers/ci/pipeline_editor_helper_spec.rb' - - 'spec/helpers/ci/runners_helper_spec.rb' - 'spec/helpers/deploy_tokens_helper_spec.rb' - 'spec/helpers/groups/settings_helper_spec.rb' + - 'spec/helpers/groups_helper_spec.rb' - 'spec/helpers/issuables_helper_spec.rb' - 'spec/helpers/namespaces_helper_spec.rb' - 'spec/helpers/page_layout_helper_spec.rb' - 'spec/helpers/projects/cluster_agents_helper_spec.rb' + - 'spec/helpers/projects/pipeline_helper_spec.rb' - 'spec/helpers/releases_helper_spec.rb' - 'spec/helpers/routing/pseudonymization_helper_spec.rb' - 'spec/helpers/search_helper_spec.rb' @@ -366,14 +423,18 @@ Layout/FirstHashElementIndentation: - 'spec/lib/api/entities/design_management/design_spec.rb' - 'spec/lib/api/entities/merge_request_approvals_spec.rb' - 'spec/lib/api/entities/personal_access_token_spec.rb' + - 'spec/lib/api/entities/personal_access_token_with_details_spec.rb' - 'spec/lib/atlassian/jira_connect/client_spec.rb' - 'spec/lib/backup/database_spec.rb' + - 'spec/lib/backup/repositories_spec.rb' - 'spec/lib/banzai/filter/audio_link_filter_spec.rb' - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' - 'spec/lib/banzai/filter/video_link_filter_spec.rb' - 'spec/lib/bulk_imports/common/pipelines/milestones_pipeline_spec.rb' - 'spec/lib/bulk_imports/groups/pipelines/project_entities_pipeline_spec.rb' - 'spec/lib/bulk_imports/groups/pipelines/subgroup_entities_pipeline_spec.rb' + - 'spec/lib/bulk_imports/groups/stage_spec.rb' + - 'spec/lib/bulk_imports/groups/transformers/group_attributes_transformer_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/container_expiration_policy_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_feature_pipeline_spec.rb' - 'spec/lib/container_registry/client_spec.rb' @@ -401,9 +462,11 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/ci/config/yaml/tags/resolver_spec.rb' - 'spec/lib/gitlab/ci/config_spec.rb' - 'spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb' + - 'spec/lib/gitlab/ci/parsers/sbom/source/dependency_scanning_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/populate_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build/cache_spec.rb' + - 'spec/lib/gitlab/ci/reports/coverage_report_spec.rb' - 'spec/lib/gitlab/ci/reports/security/identifier_spec.rb' - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' - 'spec/lib/gitlab/ci/reports/terraform_reports_spec.rb' @@ -411,11 +474,15 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/config_checker/external_database_checker_spec.rb' - 'spec/lib/gitlab/config_checker/puma_rugged_checker_spec.rb' - 'spec/lib/gitlab/data_builder/build_spec.rb' + - 'spec/lib/gitlab/data_builder/issuable_spec.rb' - 'spec/lib/gitlab/data_builder/pipeline_spec.rb' - 'spec/lib/gitlab/database/load_balancing/setup_spec.rb' + - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/database_spec.rb' - 'spec/lib/gitlab/diff/position_spec.rb' + - 'spec/lib/gitlab/error_tracking/error_repository/open_api_strategy_spec.rb' + - 'spec/lib/gitlab/error_tracking_spec.rb' - 'spec/lib/gitlab/experimentation/controller_concern_spec.rb' - 'spec/lib/gitlab/experimentation_spec.rb' - 'spec/lib/gitlab/git/conflict/file_spec.rb' @@ -427,6 +494,7 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/github_import/logger_spec.rb' - 'spec/lib/gitlab/github_import/object_counter_spec.rb' - 'spec/lib/gitlab/gpg_spec.rb' + - 'spec/lib/gitlab/graphql/query_analyzers/ast/logger_analyzer_spec.rb' - 'spec/lib/gitlab/graphql/tracers/logger_tracer_spec.rb' - 'spec/lib/gitlab/graphql/tracers/timer_tracer_spec.rb' - 'spec/lib/gitlab/http_spec.rb' @@ -438,6 +506,7 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' - 'spec/lib/gitlab/kubernetes/rollout_instances_spec.rb' - 'spec/lib/gitlab/legacy_github_import/label_formatter_spec.rb' + - 'spec/lib/gitlab/memory/watchdog_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/action_cable_spec.rb' - 'spec/lib/gitlab/middleware/multipart/handler_spec.rb' @@ -447,7 +516,6 @@ Layout/FirstHashElementIndentation: - 'spec/lib/gitlab/push_options_spec.rb' - 'spec/lib/gitlab/submodule_links_spec.rb' - 'spec/lib/gitlab/usage_data/topology_spec.rb' - - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils_spec.rb' - 'spec/lib/gitlab/web_ide/config/entry/global_spec.rb' - 'spec/lib/mattermost/team_spec.rb' @@ -455,11 +523,13 @@ Layout/FirstHashElementIndentation: - 'spec/lib/peek/views/memory_spec.rb' - 'spec/mailers/emails/merge_requests_spec.rb' - 'spec/models/active_session_spec.rb' + - 'spec/models/analytics/cycle_analytics/aggregation_spec.rb' - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/ci_platform_metric_spec.rb' - 'spec/models/clusters/applications/prometheus_spec.rb' - 'spec/models/event_spec.rb' - 'spec/models/gpg_key_spec.rb' + - 'spec/models/instance_configuration_spec.rb' - 'spec/models/integrations/base_chat_notification_spec.rb' - 'spec/models/integrations/chat_message/deployment_message_spec.rb' - 'spec/models/integrations/chat_message/issue_message_spec.rb' @@ -479,12 +549,14 @@ Layout/FirstHashElementIndentation: - 'spec/requests/api/feature_flags_spec.rb' - 'spec/requests/api/feature_flags_user_lists_spec.rb' - 'spec/requests/api/graphql/ci/config_spec.rb' + - 'spec/requests/api/graphql/ci/group_variables_spec.rb' + - 'spec/requests/api/graphql/ci/instance_variables_spec.rb' + - 'spec/requests/api/graphql/ci/project_variables_spec.rb' - 'spec/requests/api/graphql/group/milestones_spec.rb' - 'spec/requests/api/graphql/metrics/dashboard/annotations_spec.rb' + - 'spec/requests/api/graphql/mutations/timelogs/create_spec.rb' - 'spec/requests/api/graphql/project/cluster_agents_spec.rb' - 'spec/requests/api/graphql/project/release_spec.rb' - - 'spec/requests/api/graphql/project/terraform/state_spec.rb' - - 'spec/requests/api/graphql/project/terraform/states_spec.rb' - 'spec/requests/api/graphql/project_query_spec.rb' - 'spec/requests/api/internal/base_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' @@ -502,19 +574,29 @@ Layout/FirstHashElementIndentation: - 'spec/requests/jira_connect/installations_controller_spec.rb' - 'spec/requests/lfs_http_spec.rb' - 'spec/serializers/blob_entity_spec.rb' + - 'spec/serializers/integrations/harbor_serializers/artifact_entity_spec.rb' + - 'spec/serializers/integrations/harbor_serializers/repository_entity_spec.rb' + - 'spec/serializers/integrations/harbor_serializers/tag_entity_spec.rb' + - 'spec/services/bulk_imports/create_pipeline_trackers_service_spec.rb' - 'spec/services/ci/create_pipeline_service/custom_yaml_tags_spec.rb' - 'spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb' - 'spec/services/ci/create_pipeline_service_spec.rb' - 'spec/services/ci/find_exposed_artifacts_service_spec.rb' - 'spec/services/ci/play_manual_stage_service_spec.rb' + - 'spec/services/ci/runners/reconcile_existing_runner_versions_service_spec.rb' - 'spec/services/clusters/agents/create_service_spec.rb' - 'spec/services/clusters/applications/check_ingress_ip_address_service_spec.rb' - 'spec/services/clusters/aws/authorize_role_service_spec.rb' - 'spec/services/clusters/update_service_spec.rb' - 'spec/services/commits/tag_service_spec.rb' + - 'spec/services/database/consistency_check_service_spec.rb' - 'spec/services/git/branch_push_service_spec.rb' + - 'spec/services/google_cloud/create_cloudsql_instance_service_spec.rb' + - 'spec/services/import/fogbugz_service_spec.rb' - 'spec/services/import/github_service_spec.rb' - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_spec.rb' + - 'spec/services/markdown_content_rewriter_service_spec.rb' + - 'spec/services/merge_requests/build_service_spec.rb' - 'spec/services/merge_requests/create_service_spec.rb' - 'spec/services/merge_requests/get_urls_service_spec.rb' - 'spec/services/merge_requests/refresh_service_spec.rb' @@ -527,6 +609,7 @@ Layout/FirstHashElementIndentation: - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' - 'spec/services/projects/operations/update_service_spec.rb' - 'spec/services/projects/update_service_spec.rb' + - 'spec/services/service_ping/submit_service_ping_service_spec.rb' - 'spec/services/snippets/count_service_spec.rb' - 'spec/sidekiq_cluster/sidekiq_cluster_spec.rb' - 'spec/support/atlassian/jira_connect/schemata.rb' @@ -540,6 +623,9 @@ Layout/FirstHashElementIndentation: - 'spec/support/shared_contexts/fixtures/analytics_shared_context.rb' - 'spec/support/shared_contexts/lib/container_registry/client_shared_context.rb' - 'spec/support/shared_examples/graphql/spam_protection_shared_examples.rb' + - 'spec/support/shared_examples/harbor/artifacts_controller_shared_examples.rb' + - 'spec/support/shared_examples/harbor/repositories_controller_shared_examples.rb' + - 'spec/support/shared_examples/harbor/tags_controller_shared_examples.rb' - 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb' - 'spec/support/shared_examples/models/clusters/prometheus_client_shared.rb' - 'spec/support/shared_examples/models/cycle_analytics_stage_shared_examples.rb' @@ -550,4 +636,6 @@ Layout/FirstHashElementIndentation: - 'spec/tasks/gitlab/backup_rake_spec.rb' - 'spec/tooling/danger/datateam_spec.rb' - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb' + - 'spec/views/projects/issues/_issue.html.haml_spec.rb' + - 'spec/workers/ci/runners/reconcile_existing_runner_versions_cron_worker_spec.rb' - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' diff --git a/.rubocop_todo/layout/multiline_operation_indentation.yml b/.rubocop_todo/layout/multiline_operation_indentation.yml index 51ecf97d318..c67120a7951 100644 --- a/.rubocop_todo/layout/multiline_operation_indentation.yml +++ b/.rubocop_todo/layout/multiline_operation_indentation.yml @@ -1,77 +1,91 @@ --- # Cop supports --auto-correct. Layout/MultilineOperationIndentation: - # Offense count: 252 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: + - 'app/components/pajamas/concerns/checkbox_radio_label_with_help_text.rb' - 'app/controllers/projects/application_controller.rb' - 'app/controllers/repositories/git_http_client_controller.rb' - 'app/controllers/sent_notifications_controller.rb' - 'app/graphql/types/ci/stage_type.rb' - - 'app/helpers/application_settings_helper.rb' - 'app/helpers/auth_helper.rb' - 'app/helpers/issuables_helper.rb' - 'app/helpers/mirror_helper.rb' - 'app/helpers/packages_helper.rb' - 'app/helpers/projects_helper.rb' - - 'app/helpers/storage_helper.rb' - 'app/helpers/visibility_level_helper.rb' - 'app/helpers/whats_new_helper.rb' - 'app/models/concerns/admin_changed_password_notifier.rb' - 'app/models/integrations/prometheus.rb' + - 'app/models/merge_request_diff_file.rb' - 'app/models/namespaces/traversal/linear_scopes.rb' - 'app/models/packages/conan/metadatum.rb' - 'app/models/packages/sem_ver.rb' - 'app/models/project.rb' - 'app/models/project_statistics.rb' - 'app/models/user.rb' + - 'app/models/work_items/parent_link.rb' + - 'app/policies/project_policy.rb' + - 'app/serializers/deploy_keys/deploy_key_entity.rb' - 'app/services/ci/create_downstream_pipeline_service.rb' - 'app/services/ci/create_pipeline_service.rb' - 'app/services/git/branch_hooks_service.rb' - - 'app/services/groups/group_links/create_service.rb' - 'app/services/groups/transfer_service.rb' - 'app/services/issues/update_service.rb' - 'app/services/labels/promote_service.rb' - 'app/services/labels/transfer_service.rb' + - 'app/services/members/approve_access_request_service.rb' - 'app/services/projects/container_repository/cleanup_tags_service.rb' - 'app/services/webauthn/authenticate_service.rb' - 'app/validators/feature_flag_strategies_validator.rb' - 'app/workers/container_expiration_policies/cleanup_container_repository_worker.rb' + - 'app/workers/container_registry/migration/guard_worker.rb' - 'config/initializers/devise_dynamic_password_length_validation.rb' - 'danger/utility_css/Dangerfile' + - 'ee/app/controllers/ee/admin/application_settings_controller.rb' + - 'ee/app/controllers/projects/integrations/jira/issues_controller.rb' - 'ee/app/controllers/smartcard_controller.rb' - 'ee/app/graphql/resolvers/boards/epic_lists_resolver.rb' - 'ee/app/helpers/ee/application_settings_helper.rb' - 'ee/app/helpers/ee/boards_helper.rb' + - 'ee/app/helpers/ee/groups/group_members_helper.rb' + - 'ee/app/helpers/ee/groups/reporting_helper.rb' + - 'ee/app/helpers/ee/projects/project_members_helper.rb' - 'ee/app/helpers/groups/security_features_helper.rb' - 'ee/app/helpers/groups/sso_helper.rb' + - 'ee/app/models/approval_project_rule.rb' + - 'ee/app/models/concerns/ee/issuable.rb' - 'ee/app/models/ee/namespace.rb' - 'ee/app/models/ee/namespace/root_storage_size.rb' - 'ee/app/models/ee/project.rb' - 'ee/app/models/ee/user.rb' - 'ee/app/models/vulnerabilities/finding_signature.rb' - 'ee/app/policies/ee/base_policy.rb' + - 'ee/app/policies/ee/merge_request_policy.rb' - 'ee/app/services/analytics/cycle_analytics/value_streams/update_service.rb' - 'ee/app/services/ee/merge_requests/build_service.rb' - 'ee/app/services/ee/projects/operations/update_service.rb' + - 'ee/app/workers/elastic/project_transfer_worker.rb' - 'ee/lib/ee/api/entities/group.rb' + - 'ee/lib/ee/api/geo.rb' - 'ee/lib/ee/api/helpers.rb' + - 'ee/lib/ee/api/settings.rb' + - 'ee/lib/ee/gitlab/git_access_project.rb' - 'ee/lib/ee/gitlab/middleware/read_only/controller.rb' - 'ee/lib/ee/gitlab/quick_actions/issue_actions.rb' - 'ee/lib/ee/sidebars/projects/menus/ci_cd_menu.rb' - 'ee/lib/ee/sidebars/projects/menus/issues_menu.rb' - - 'ee/lib/elastic/latest/issue_class_proxy.rb' + - 'ee/lib/gitlab/incident_management.rb' - 'ee/lib/sidebars/groups/menus/analytics_menu.rb' - 'ee/lib/sidebars/groups/menus/security_compliance_menu.rb' - 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb' - 'lib/api/maven_packages.rb' - 'lib/api/users.rb' - 'lib/api/validations/validators/array_none_any.rb' + - 'lib/gitlab/auth/o_auth/user.rb' - 'lib/gitlab/ci/reports/security/finding_key.rb' - 'lib/gitlab/database/load_balancing/connection_proxy.rb' - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - - 'lib/gitlab/form_builders/gitlab_ui_form_builder.rb' + - 'lib/gitlab/error_tracking/error_repository/open_api_strategy.rb' - 'lib/gitlab/git_access.rb' - 'lib/gitlab/gl_repository/repo_type.rb' - 'lib/gitlab/jwt_token.rb' @@ -82,6 +96,8 @@ Layout/MultilineOperationIndentation: - 'lib/gitlab/pagination/cursor_based_keyset.rb' - 'lib/gitlab/quick_actions/issue_and_merge_request_actions.rb' - 'lib/gitlab/rack_attack/request.rb' + - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' + - 'lib/gitlab/sidekiq_status.rb' - 'lib/gitlab/x509/signature.rb' - 'lib/gitlab_edition.rb' - 'lib/kramdown/converter/commonmark.rb' @@ -90,12 +106,12 @@ Layout/MultilineOperationIndentation: - 'lib/sidebars/projects/menus/deployments_menu.rb' - 'lib/sidebars/projects/menus/hidden_menu.rb' - 'lib/sidebars/projects/menus/monitor_menu.rb' - - 'lib/sidebars/projects/menus/settings_menu.rb' - 'qa/qa/ee/page/group/roadmap.rb' - 'qa/qa/page/component/snippet.rb' - 'qa/qa/runtime/api/repository_storage_moves.rb' - 'rubocop/cop/gitlab/keys_first_and_values_first.rb' - 'rubocop/migration_helpers.rb' + - 'spec/controllers/graphql_controller_spec.rb' - 'spec/frontend/fixtures/tabs.rb' - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' - 'spec/services/ci/create_pipeline_service_spec.rb' diff --git a/.rubocop_todo/layout/space_inside_block_braces.yml b/.rubocop_todo/layout/space_inside_block_braces.yml index 38ee4c862ca..d8454708d82 100644 --- a/.rubocop_todo/layout/space_inside_block_braces.yml +++ b/.rubocop_todo/layout/space_inside_block_braces.yml @@ -1,10 +1,6 @@ --- # Cop supports --auto-correct. Layout/SpaceInsideBlockBraces: - # Offense count: 1508 - # Temporarily disabled due to too many offenses - Enabled: false - EnforcedStyle: space Exclude: - 'app/controllers/groups/boards_controller.rb' - 'app/controllers/profiles/two_factor_auths_controller.rb' @@ -16,8 +12,6 @@ Layout/SpaceInsideBlockBraces: - 'app/helpers/todos_helper.rb' - 'app/models/authentication_event.rb' - 'app/models/bulk_imports/entity.rb' - - 'app/models/ci/pipeline.rb' - - 'app/models/concerns/cache_markdown_field.rb' - 'app/models/concerns/featurable.rb' - 'app/models/integrations/bamboo.rb' - 'app/models/integrations/buildkite.rb' @@ -41,7 +35,9 @@ Layout/SpaceInsideBlockBraces: - 'ee/app/models/compliance_management/framework.rb' - 'ee/app/models/dora/daily_metrics.rb' - 'ee/app/models/ee/application_setting.rb' + - 'ee/app/models/ee/deployment.rb' - 'ee/app/models/ee/member.rb' + - 'ee/app/models/vulnerabilities/feedback.rb' - 'ee/app/models/vulnerabilities/identifier.rb' - 'ee/app/serializers/vulnerabilities/finding_entity.rb' - 'ee/app/services/elastic/cluster_reindexing_service.rb' @@ -51,6 +47,7 @@ Layout/SpaceInsideBlockBraces: - 'ee/lib/elastic/latest/git_class_proxy.rb' - 'ee/lib/gitlab/auth/smartcard/san_extension.rb' - 'ee/lib/world.rb' + - 'ee/spec/features/admin/admin_runners_spec.rb' - 'lib/api/commits.rb' - 'lib/api/helpers/merge_requests_helpers.rb' - 'lib/backup/manager.rb' @@ -60,8 +57,10 @@ Layout/SpaceInsideBlockBraces: - 'lib/bitbucket_server/representation/base.rb' - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - 'lib/gitlab/contributions_calendar.rb' - - 'lib/gitlab/database/migrations/test_background_runner.rb' + - 'lib/gitlab/database/migrations/base_background_runner.rb' - 'lib/gitlab/database/postgres_hll/buckets.rb' + - 'lib/gitlab/diff/rendered/notebook/diff_file.rb' + - 'lib/gitlab/diff/rendered/notebook/diff_file_helper.rb' - 'lib/gitlab/email/message/in_product_marketing/helper.rb' - 'lib/gitlab/issues/rebalancing/state.rb' - 'lib/gitlab/profiler.rb' @@ -74,12 +73,14 @@ Layout/SpaceInsideBlockBraces: - 'lib/tasks/gitlab/shell.rake' - 'lib/tasks/gitlab/tw/codeowners.rake' - 'rubocop/cop/migration/add_limit_to_text_columns.rb' + - 'scripts/qa/testcases-check' + - 'spec/channels/awareness_channel_spec.rb' + - 'spec/components/pajamas/banner_component_spec.rb' - 'spec/config/settings_spec.rb' - 'spec/controllers/admin/application_settings_controller_spec.rb' - 'spec/controllers/application_controller_spec.rb' - 'spec/controllers/groups/labels_controller_spec.rb' - 'spec/controllers/groups/releases_controller_spec.rb' - - 'spec/controllers/groups/settings/ci_cd_controller_spec.rb' - 'spec/controllers/import/manifest_controller_spec.rb' - 'spec/controllers/projects/blame_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' @@ -122,6 +123,7 @@ Layout/SpaceInsideBlockBraces: - 'spec/frontend/fixtures/clusters.rb' - 'spec/frontend/fixtures/deploy_keys.rb' - 'spec/frontend/fixtures/groups.rb' + - 'spec/frontend/fixtures/integrations.rb' - 'spec/frontend/fixtures/issues.rb' - 'spec/frontend/fixtures/jobs.rb' - 'spec/frontend/fixtures/labels.rb' @@ -131,6 +133,7 @@ Layout/SpaceInsideBlockBraces: - 'spec/frontend/fixtures/pipeline_schedules.rb' - 'spec/frontend/fixtures/pipelines.rb' - 'spec/frontend/fixtures/projects.rb' + - 'spec/frontend/fixtures/prometheus_integration.rb' - 'spec/frontend/fixtures/raw.rb' - 'spec/frontend/fixtures/snippet.rb' - 'spec/frontend/fixtures/todos.rb' @@ -144,30 +147,41 @@ Layout/SpaceInsideBlockBraces: - 'spec/helpers/wiki_page_version_helper_spec.rb' - 'spec/initializers/carrierwave_patch_spec.rb' - 'spec/initializers/trusted_proxies_spec.rb' + - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' + - 'spec/lib/gitlab/memory/reports/jemalloc_stats_spec.rb' - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/migrations/20210812013042_remove_duplicate_project_authorizations_spec.rb' - 'spec/migrations/20210910194952_update_report_type_for_existing_approval_project_rules_spec.rb' + - 'spec/migrations/20220505174658_update_index_on_alerts_to_exclude_null_fingerprints_spec.rb' - 'spec/migrations/confirm_support_bot_user_spec.rb' - 'spec/migrations/reset_job_token_scope_enabled_again_spec.rb' - 'spec/migrations/reset_job_token_scope_enabled_spec.rb' - 'spec/migrations/reset_severity_levels_to_new_default_spec.rb' - - 'spec/migrations/schedule_copy_ci_builds_columns_to_security_scans2_spec.rb' + - 'spec/models/merge_request/approval_removal_settings_spec.rb' - 'spec/policies/clusters/agent_policy_spec.rb' - 'spec/policies/group_member_policy_spec.rb' - 'spec/policies/issue_policy_spec.rb' - 'spec/policies/project_policy_spec.rb' - 'spec/policies/terraform/state_policy_spec.rb' - 'spec/policies/terraform/state_version_policy_spec.rb' + - 'spec/policies/timelog_policy_spec.rb' - 'spec/presenters/packages/composer/packages_presenter_spec.rb' - 'spec/presenters/packages/conan/package_presenter_spec.rb' - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb' + - 'spec/presenters/packages/pypi/simple_package_versions_presenter_spec.rb' - 'spec/presenters/project_presenter_spec.rb' - 'spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb' + - 'spec/scripts/changed-feature-flags_spec.rb' - 'spec/serializers/cluster_entity_spec.rb' + - 'spec/serializers/deploy_keys/basic_deploy_key_entity_spec.rb' + - 'spec/serializers/deploy_keys/deploy_key_entity_spec.rb' - 'spec/serializers/import/provider_repo_serializer_spec.rb' + - 'spec/services/ci/runners/bulk_delete_runners_service_spec.rb' + - 'spec/services/work_items/widgets/assignees_service/update_service_spec.rb' + - 'spec/services/work_items/widgets/start_and_due_date_service/update_service_spec.rb' - 'spec/support/helpers/cycle_analytics_helpers.rb' + - 'spec/support/helpers/graphql_helpers.rb' - 'spec/support/redis/redis_shared_examples.rb' - - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' - 'spec/support/shared_contexts/graphql/requests/packages_shared_context.rb' - 'spec/support/shared_contexts/markdown_golden_master_shared_examples.rb' - 'spec/support/shared_contexts/requests/api/conan_packages_shared_context.rb' @@ -176,6 +190,7 @@ Layout/SpaceInsideBlockBraces: - 'spec/support/shared_examples/features/board_sidebar_labels_examples.rb' - 'spec/support/shared_examples/features/snippets_shared_examples.rb' - 'spec/support/shared_examples/features/wiki/user_views_asciidoc_page_with_includes_shared_examples.rb' + - 'spec/support/shared_examples/helpers/wiki_helpers_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/sql/set_operator_shared_examples.rb' - 'spec/support/shared_examples/models/cluster_application_core_shared_examples.rb' @@ -185,7 +200,6 @@ Layout/SpaceInsideBlockBraces: - 'spec/support/shared_examples/models/label_note_shared_examples.rb' - 'spec/support/shared_examples/models/packages/debian/distribution_shared_examples.rb' - 'spec/support/shared_examples/models/project_latest_successful_build_for_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/graphql/group_and_project_boards_query_shared_examples.rb' - 'spec/support/shared_examples/requests/api/issues/merge_requests_count_shared_examples.rb' - 'spec/support/shared_examples/requests/api/labels_api_shared_examples.rb' - 'spec/support/shared_examples/requests/api/repository_storage_moves_shared_examples.rb' @@ -198,12 +212,14 @@ Layout/SpaceInsideBlockBraces: - 'spec/tasks/gitlab/snippets_rake_spec.rb' - 'spec/uploaders/packages/debian/distribution_release_file_uploader_spec.rb' - 'spec/validators/addressable_url_validator_spec.rb' + - 'spec/views/devise/sessions/new.html.haml_spec.rb' - 'spec/views/help/instance_configuration.html.haml_spec.rb' - 'spec/views/layouts/_header_search.html.haml_spec.rb' - 'spec/views/layouts/_published_experiments.html.haml_spec.rb' - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' - 'spec/workers/bulk_imports/export_request_worker_spec.rb' - 'spec/workers/clusters/cleanup/project_namespace_worker_spec.rb' + - 'spec/workers/packages/cleanup/execute_policy_worker_spec.rb' - 'spec/workers/packages/helm/extraction_worker_spec.rb' - 'spec/workers/pages_worker_spec.rb' - 'spec/workers/purge_dependency_proxy_cache_worker_spec.rb' diff --git a/.rubocop_todo/rails/rake_environment.yml b/.rubocop_todo/rails/rake_environment.yml deleted file mode 100644 index d248db022ce..00000000000 --- a/.rubocop_todo/rails/rake_environment.yml +++ /dev/null @@ -1,25 +0,0 @@ ---- -# Cop supports --auto-correct. -Rails/RakeEnvironment: - # Offense count: 31 - # Temporarily disabled due to too many offenses - Enabled: false - Exclude: - - 'ee/lib/tasks/gitlab/elastic/test.rake' - - 'lib/tasks/config_lint.rake' - - 'lib/tasks/dev.rake' - - 'lib/tasks/gettext.rake' - - 'lib/tasks/gitlab/assets.rake' - - 'lib/tasks/gitlab/db.rake' - - 'lib/tasks/gitlab/docs/compile_deprecations.rake' - - 'lib/tasks/gitlab/docs/redirect.rake' - - 'lib/tasks/gitlab/helpers.rake' - - 'lib/tasks/gitlab/sidekiq.rake' - - 'lib/tasks/gitlab/tw/codeowners.rake' - - 'lib/tasks/gitlab/update_templates.rake' - - 'lib/tasks/lint.rake' - - 'lib/tasks/migrate/setup_postgresql.rake' - - 'lib/tasks/setup.rake' - - 'lib/tasks/test.rake' - - 'lib/tasks/yarn.rake' - - 'qa/qa/fixtures/auto_devops_rack/Rakefile' |