add visibility_level44460-api-group-visibility-level-incorrectly-evaluated

1 files changed, 8 insertions, 2 deletions

diff --git a/lib/api/groups.rb b/lib/api/groups.rb
index 4a4df1b8b9e..34d27a5a297 100644
--- a/lib/api/groups.rb
+++ b/lib/api/groups.rb
@@ -109,8 +109,11 @@ module API
         else
           authorize! :create_group
         end
+        
+        opts = declared_params(include_missing: false)
+        opts[:visibility_level] = Gitlab::VisibilityLevel.level_value opts[:visibility]
 
-        group = ::Groups::CreateService.new(current_user, declared_params(include_missing: false)).execute
+        group = ::Groups::CreateService.new(current_user, opts).execute
 
         if group.persisted?
           present group, with: Entities::GroupDetail, current_user: current_user
@@ -135,8 +138,11 @@ module API
       put ':id' do
         group = find_group!(params[:id])
         authorize! :admin_group, group
+        
+        opts = declared_params(include_missing: false)
+        opts[:visibility_level] = Gitlab::VisibilityLevel.level_value opts[:visibility]
 
-        if ::Groups::UpdateService.new(group, current_user, declared_params(include_missing: false)).execute
+        if ::Groups::UpdateService.new(group, current_user, opts).execute
           present group, with: Entities::GroupDetail, current_user: current_user
         else
           render_validation_error!(group)