Add latest changes from gitlab-org/gitlab@master

1 files changed, 21 insertions, 0 deletions

diff --git a/spec/lib/gitlab/ci/config/entry/needs_spec.rb b/spec/lib/gitlab/ci/config/entry/needs_spec.rb
index d1a8a74ac06..61bb3e912ba 100644
--- a/spec/lib/gitlab/ci/config/entry/needs_spec.rb
+++ b/spec/lib/gitlab/ci/config/entry/needs_spec.rb
@@ -52,6 +52,27 @@ RSpec.describe ::Gitlab::Ci::Config::Entry::Needs, feature_category: :pipeline_c
       end
     end
 
+    context 'when config has disallowed keys' do
+      let(:config) { ['some_value'] }
+
+      before do
+        needs.metadata[:allowed_needs] = %i[cross_dependency]
+        needs.compose!
+      end
+
+      describe '#valid?' do
+        it 'returns invalid' do
+          expect(needs.valid?).to be_falsey
+        end
+      end
+
+      describe '#errors' do
+        it 'returns invalid types error' do
+          expect(needs.errors).to include('needs config uses invalid types: job')
+        end
+      end
+    end
+
     context 'when wrong needs type is used' do
       let(:config) { [{ job: 'job_name', artifacts: true, some: :key }] }