diff options
| author | Scott Hampton <shampton@gitlab.com> | 2019-02-20 22:20:09 +0300 |
|---|---|---|
| committer | Scott Hampton <shampton@gitlab.com> | 2019-02-20 22:20:09 +0300 |
| commit | 52c910eeca47f140246d003fbb6b4748d1be8bb8 (patch) | |
| tree | 55f917eef8d7d6c45d5030b505f4e3997f60405a | |
| parent | 54a5d513e5f068c53fad3b2dac04998f5e9afd88 (diff) | |
Remove deprecated ci status helper function
After changing all places that used the function, we can now remove it.
| -rw-r--r-- | app/helpers/ci_status_helper.rb | 6 | ||||
| -rw-r--r-- | app/views/ci/status/_icon.html.haml | 2 | ||||
| -rw-r--r-- | spec/views/ci/status/_icon.html.haml_spec.rb | 1 |
3 files changed, 2 insertions, 7 deletions
diff --git a/app/helpers/ci_status_helper.rb b/app/helpers/ci_status_helper.rb index 923a06a0512..dfeeecf1228 100644 --- a/app/helpers/ci_status_helper.rb +++ b/app/helpers/ci_status_helper.rb @@ -123,12 +123,6 @@ module CiStatusHelper icon_size: 24) end - def render_pipeline_status(pipeline, tooltip_placement: 'left') - project = pipeline.project - path = project_pipeline_path(project, pipeline) - render_status_with_link('pipeline', pipeline.status, path, tooltip_placement: tooltip_placement) - end - def render_status_with_link(type, status, path = nil, tooltip_placement: 'left', cssclass: '', container: 'body', icon_size: 16) klass = "ci-status-link ci-status-icon-#{status.dasherize} #{cssclass}" title = "#{type.titleize}: #{ci_label_for_status(status)}" diff --git a/app/views/ci/status/_icon.html.haml b/app/views/ci/status/_icon.html.haml index bfdf9c2ec9f..29ce9cd1afd 100644 --- a/app/views/ci/status/_icon.html.haml +++ b/app/views/ci/status/_icon.html.haml @@ -9,4 +9,4 @@ = sprite_icon(status.icon, size: size) - else %span{ class: css_classes, title: title, data: { html: title.present? } } - = sprite_icon(status.icon, size: size)
\ No newline at end of file + = sprite_icon(status.icon, size: size) diff --git a/spec/views/ci/status/_icon.html.haml_spec.rb b/spec/views/ci/status/_icon.html.haml_spec.rb index 43806446164..626159fc512 100644 --- a/spec/views/ci/status/_icon.html.haml_spec.rb +++ b/spec/views/ci/status/_icon.html.haml_spec.rb @@ -1,3 +1,4 @@ +# frozen_string_literal: true require 'spec_helper' describe 'ci/status/_icon' do |