diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2019-10-22 15:06:20 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2019-10-22 15:06:20 +0300 |
| commit | b1bcdba89bc241e2cede910f26cf3f5fff8d7901 (patch) | |
| tree | 41b45ec9ff1ba56c93b29b00435495e7e5abf02b | |
| parent | 30dc5b50569db30fef06cc7ab66e7341161b3c70 (diff) | |
Add latest changes from gitlab-org/gitlab@master
322 files changed, 2162 insertions, 381 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 9411180abff..279c6ede932 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,325 +2,6 @@ documentation](doc/development/changelog.md) for instructions on adding your own entry. -## 12.4.0 - -### Security (14 changes) - -- HTML-escape search term in empty message. !18319 -- Fix private feature Elasticsearch leak. -- Prevent bypassing email verification using Salesforce. -- Fix new project path being disclosed through unsubscribe link of issue/merge requests. -- Do not show resource label events referencing not accessible labels. -- Check permissions before showing head pipeline blocking merge requests. -- Cancel all running CI jobs triggered by the user who is just blocked. -- Do not disclose project milestones on group milestones page when project milestones access is disabled in project settings. -- Display only participants that user has permission to see on milestone page. -- Fix Gitaly SearchBlobs flag RPC injection. -- Add a policy check for system notes that may not be visible due to cross references to private items. -- Limit search for IID to a type to avoid leaking records with the same IID that the user does not have access to. -- Prevent GitLab accounts takeover if SAML is configured. -- Only render fixed number of mermaid blocks. - -### Fixed (103 changes, 12 of them are from the community) - -- When user toggles task list item, keep details open until user closes the details manually. !16153 -- Fix formatting welcome screen external users. !16667 -- Fix signup link in admin area not being disabled. !16726 (Illya Klymov) -- Fix routing bugs in security dashboards. !16738 -- Fix Jira integration favicon image with relative URL. !16802 -- Add timeout mechanism for CI config validation. !16807 -- Fix for count in todo badge when user has over 1,000 todos. Will now correctly display todo count after user marks some todos as done. !16844 (Jesse Hall @jessehall3) -- Naming a project "shared" will no longer automatically open the "Shared Projects" tab. !16847 (Jesse Hall @jessehall3) -- Adds the ability to delete single tags from the docker registry. Fix the issue that caused all related tags and image to be deleted at the same time. !16886 -- Changed confidential quick action to only be available on non confidential issues. !16902 (Marc Schwede) -- Stop sidebar icons from jumping when expanded & collapsed. !16971 -- Set name and updated_at properly in GitHub ReleaseImporter. !17020 -- Remove thin white line at top of diff view code blocks. !17026 -- Show correct CI indicator when build succeeded with warnings. !17034 -- Create a persistent ref per pipeline for keeping pipelines run from force-push and merged results. !17043 -- Move SMAU usage counters to the UsageData count field. !17074 -- Allow maintainers to toggle write permission for public deploy keys. !17210 -- Fix GraphQL for read-only instances. !17225 -- Fix visibility level error when updating group from API. !17227 (Mathieu Parent) -- Fix stylelint errors in epics.scss. !17243 -- Fix new discussion replies sometimes showing up twice. !17255 -- Adjust unnapliable suggestions in expanded lines. !17286 -- Show all groups user belongs to in Notification settings. !17303 -- Alphabetically sorts selected sidebar labels. !17309 -- Show issue weight when weight is 0. !17329 (briankabiro) -- Generate LFS token authorization for user LFS requests. !17332 -- Backfill releases table updated_at column and add not null constraints to created_at and updated_at. !17400 -- Log Sidekiq exceptions properly in JSON format. !17412 -- Redo fix for related issues border radius. !17480 -- Show the original branch name and link of merge request in pipeline emails. !17513 -- Fixes issues with the security reports migration. !17519 -- Users can view the blame or history of a file with newlines in its filename. !17543 (Jesse Hall @jessehall3) -- Display reCAPTCHA modal when making issue public. !17553 -- Fix css selector for details in issue description. !17557 -- Prevents a group path change when a project inside the group has container registry images. !17583 -- Show 20 labels in dropdown instead of 5. !17596 -- Nullify platform Kubernetes namespace if blank. !17657 -- Fix Issue: WebIDE asks for confirmation to leave the page when committing and creating a new MR. !17671 -- Catch unhandled exceptions in health checks. !17694 -- Suppress error messages shown when navigating to a new page. !17706 -- Specify sort order explicitly for Group and Project audit events. !17739 -- Merge Request: Close JIRA issues when issues are disabled. !17743 -- Disable gitlab-workhorse static error page on health endpoints. !17770 -- Fix notes race condition when linking to specific note. !17777 -- Fix relative positioning when moving items down and there is no space. !17781 -- Fix project imports for pipelines for merge requests. !17799 -- Increase the limit of includes in CI file to 100. !17807 -- Geo: Fix race condition for container synchronization. !17823 -- Geo: Invalidate cache after refreshing foreign tables. !17885 -- Abort Merge When Pipeline Succeeds when Fast Forward merge is impossible. !17886 -- Fix viewing merge reqeust from a fork that's being deleted. !17894 -- Fix empty security dashboard for public projects. !17915 -- Fix inline rendering of videos for uploads with uppercase file extensions. !17924 -- Hide redundant labels in issue boards. !17937 -- Time window filter in monitor dashboard gets reset. !17972 -- Use cache_method_asymmetrically with Repository#has_visible_content?. !17975 -- Allow users to compare Git revisions on a read-only instance. !18038 -- Enable Google API retries for uploads. !18040 -- Fix bug with new wiki not being indexed. !18051 -- Stops the expand button in reports from expanding. !18064 -- Make sure project insights stick on its own. !18082 -- Embed metrics time window scroll no longer affects other embeds. !18109 -- Fix broken notes avatar rendering in Chrome 77. !18110 -- Ignore incoming emails with X-Autoreply header. !18118 -- Enable grid, frame and stripes styling on AsciiDoc tables. !18165 (Guillaume Grossetie) -- Add backend support for selecting custom templates by ID. !18178 -- Fix notifications for private group mentions in Notes, Issues, and Merge Requests. !18183 -- Do not strip forwarded message body when creating an issue from Service Desk email. !18196 -- Fix protected branch detection used by notification service. !18221 -- Fix error where helper was incorrectly returning `true`. !18231 -- Adjust placeholder to solve misleading regex. !18235 -- Fix Flaky spec/finders/members_finder_spec.rb:85. !18257 (Jacopo Beschi @jacopo-beschi) -- Fix 500 error on clicking to LetsEncrypt Terms of Service. !18263 -- Fix error tracking table layout on small screens. !18325 -- GitHub import: Handle nil published_at dates. !18355 -- Do not allow deactivated users to use slash commands. !18365 -- Fix creating epics with dates from api. !18393 -- JIRA Service: Improve username/email validation. !18397 -- Stopped CRD apply retrying from allowing silent failures. !18421 -- Fix erroneous "No activities found" message. !18434 -- Support ES searches for project snippets. !18459 -- Fix styling of set status emoji picker. !18509 -- Fix showing diff when it has legacy diff notes. !18510 -- JIRA Integration API URL works having a trailing slash. !18526 -- Fixes embedded metrics chart tooltip spacing. !18543 -- Bump GITLAB_ELASTICSEARCH_INDEXER_VERSION=v1.4.0. !18558 -- Fix pod logs failure when pod contains more than 1 container. !18574 -- Prevent the slash command parser from removing leading whitespace from content that is unrelated to slash commands. !18589 (Jared Deckard) -- Fix inability to set snippet visibility via API. !18612 -- Fix Web IDE tree not updating modified status. !18647 -- Fix button link foreground color. !18669 -- Resolve missing design system notes icons. !18693 -- Remove duplicate primary button in dashboard snippets. !32048 (George Tsiolis) -- Allow to view productivity analytics page without a license. !33876 -- Fix container registry delete tag modal title and button. !34032 -- Fixes variables overflowing in sm screens. -- Update top nav bar to fit all content in at all screen sizes. -- Fix permissions for group milestones. -- Removes Collapsible Sections from Job Log. -- Fixes job overflow in stages dropdown. -- Fix moved help URL for monitoring performance. -- Fix issue with wiki TOC links being treated as external links. (Oren Kanner) -- Show error message when setting an invalid group ID for the performance bar. - -### Deprecated (1 change) - -- Removing cleanup:repo, cleanup:dirs. !18087 - -### Changed (51 changes, 3 of them are from the community) - -- Links on Releases page to commits and tags. !16128 -- Add status to deployments and state to environments in API responses. !16242 -- Use search scope label in empty results message. !16324 -- Add step 2 of the experimental signup flow. !16583 -- Add property to enable metrics dashboards to be rearranged. !16605 -- Allow intra-project MR dependencies. !16799 -- Use scope param instead of hide_dismissed. !16834 -- Add empty state in file search. !16851 -- Warn before applying issue templates. !16865 -- MR Test Summary now shows errors as failures. !17039 -- Add support for the association of multiple milestones to the Releases page. !17091 -- Display if an issue was moved in issue list. !17102 -- Improve UI for admin/projects and group/settings/projects pages. !17247 -- Update registry tag delete popup message. !17257 -- Show the "Set up CI/CD" prompt in empty repositories when applicable. !17274 (Ben McCormick) -- Knative version bump 0.6 -> 0.7. !17367 (Chris Baumbauer) -- Fix usability problems with the file template picker. !17522 -- Make commit status created for any pipelines. !17524 (Aufar Gilbran) -- Add warnings to performance bar when page shows signs of poor performance. !17612 -- Banners should only be dismissable by clicking x button. !17642 -- Changes response body of liveness check to be more accurate. !17655 -- Enable Request Access functionality by default for new projects and groups. !17662 -- Add more attributes to issues GraphQL endpoint. !17802 -- Improve admin/system_info page ui. !17829 -- Adds management project for a cluster. !17866 -- Upgrade gitlab-workhorse to 8.12.0. !17892 -- Geo: Fix instruction from rake geo:gitlab:check. !17895 -- Upgrade to Gitaly v1.66.0. !17900 -- Do not start mirroring via API when paused. !17930 -- Use MR links in PipelinePresenter#ref_text for branch pipelines. !17947 -- Avoid knative and prometheus uninstall race condition. !18020 -- Deprecate usage of state column for issues and merge requests. !18099 -- Add missing page title to projects/container-registry. !18114 -- Port over EE pipeline functionality to CE. !18136 -- Aggregate push events when there are too many. !18239 -- Cleanup background migrations for any approval rules. !18256 -- Container registry tag(s) delete button pluralization. !18260 -- Create clusters with VPC-Native enabled. !18284 -- Update cluster link text. !18322 -- Upgrade to Gitaly v1.67.0. !18326 -- Improve UI of documentation under /help. !18331 -- Cross-link unreplicated Geo types to issues. !18443 -- Make designs read-only if the issue has been moved, or if its discussion has been locked. !18551 -- Do not show new issue button on archived projects. !18590 -- Increase group avatar size to 40px. !18654 -- Sort vulnerabilities by severity then confidence for dashboard and pipeline views. !18675 -- Add timeouts for each RPC call. !31766 -- Add more specific message to clarify the role of empty images in container registry. !32919 -- Embed Jaeger in Gitlab UI. -- Use text instead of icon for recent searches dropdown. -- Export liveness and readiness probes. - -### Performance (25 changes, 1 of them is from the community) - -- Limit diverging commit counts requests. !16737 -- Use GetBlobs RPC for uri type. !16824 -- Reduce Gitaly calls when viewing a commit. !17095 -- Limit snippets search count. !17585 -- Narrow snippet search scope in GitLab.com. !17625 -- Handle wiki and graphql attachments in gitlab-workhorse. !17690 -- Reduce lock contention of deployment creation by allocating IID outside of the pipeline transaction. !17696 -- Update PumaWorkerKiller defaults. !17758 -- Add trigram index on snippet content. !17806 -- Fix Gitaly N+1 queries in related merge requests API. !17850 -- Don't execute webhooks/services when above limit. !17874 -- Only schedule updating push-mirrors once per push. !17902 -- Show only personal snippets on explore page. !18092 -- Priority bump authorized_projects sidekiq queue. !18125 -- Avoid dumping files on disk when direct_upload is enabled. !18135 -- Check if mapping is empty before caching in File Collections. !18290 (briankabiro) -- Avoid unnecessary locks on internal_ids. !18328 -- Fix N+1 queries in Jira Development Panel API endpoint. !18329 -- Optimize SQL requests for BlameController and CommitsController. !18342 -- Remove N+1 for fetching commits signatures. !18389 -- Reduce idle in transaction time when updating a merge request. !18493 -- Use cascading deletes for deleting logs upon deleting a webhook. !18642 -- Replace index on ci_triggers. !18652 -- Hide license breakdown in /admin if user count is high. !18825 -- Cache branch and tag names as Redis sets. !30476 - -### Added (78 changes, 12 of them are from the community) - -- Adds sorting of packages at the project level. !15448 -- Add projects.only option to Insights. !15930 -- Add kubernetes section to group runner settings. !16338 -- Enable Cloud Run on GKE cluster creation. !16566 -- Add file matching rule to flexible CI rules. !16574 -- Enable preview of private artifacts. !16675 (Tuomo Ala-Vannesluoma) -- Upgrade Gitaly to v1.64. !16788 -- Render xml artifact files in GitLab. !16790 -- Add GitHub & Gitea importers project filtering. !16823 -- Add project filtering to Bitbucket Cloud import. !16828 -- Provides internationalization support to chart legends. !16832 -- Expose name property in imports API. !16848 -- Add allowFilter and allowAnySHA1InWant for partial clones. !16850 -- [ObjectStorage] Allow migrating back to local storage. !16868 -- Require admins to enter admin-mode by re-authenticating before performing administrative operations. !16981 (Roger Rüttimann & Diego Louzán) -- Deactivate a user (with self-service reactivation). !17037 -- Add database tables to store AWS roles and cluster providers. !17057 -- Collect docker registry related metrics. !17063 -- Allow releases to be targeted by URL anchor links on the Releases page. !17150 -- Add project_pages_metadata DB table. !17197 -- Add index on ci_builds for successful Pages deploys. !17204 -- Creation of Evidence collection of new releases. !17217 -- API: Add missing group parameters. !17220 (Mathieu Parent) -- Allow to exclude ancestor groups on group labels API. !17221 (Mathieu Parent) -- Added 'copy link' in epic comment dropdown. !17224 -- Add columns for per project/group max pages/artifacts sizes. !17231 -- Create table for grafana api token for metrics embeds. !17234 -- Add proper label REST API for update, delete and promote. !17239 (Mathieu Parent) -- Allow cross-project pipeline triggering with CI_JOB_TOKEN in core. !17251 -- Add user_id and created_at columns to design_management_versions table. !17316 -- Add pull_mirror_branch_prefix column on projects table. !17368 -- Expose web_url for epics on API. !17380 -- Improve time window filtering on metrics dashboard. !17554 -- Group level Container Registry browser. !17615 -- Add API for manually creating and updating deployments. !17620 -- Introduce diffs_batch JSON endpoint for paginated diffs. !17651 -- Web IDE button should fork and open forked project when selected from read-only project. !17672 -- Allow users to be searched with a @ prefix. !17742 -- Add individual inherited member lookup API. !17744 -- Preserve custom .gitlab-ci.yml config path when forking. !17817 (Mathieu Parent) -- Introduce CI_PROJECT_TITLE as predefined environment variable. !17849 (Nejc Habjan) -- Feature enabling embedded audio elements in markdown. !17860 (Jesse Hall @jessehall3) -- Add 'New release' to the project custom notifications. !17877 -- Added timestamps (created_at and updated_at) to API pipelines response. !17911 -- Added timestamp (updated_at) to API deployments response. !17913 -- Add pipeline preparing status icons. !17923 -- Creates Vue and Vuex app to render exposed artifacts. !17934 -- Add web_exporter to expose Prometheus metrics. !17943 -- Schedule background migration to populate pages metadata. !17993 -- Add "Edit Release" page. !18033 -- Unpin ingress image version, upgrade chart to 1.22.1. !18047 -- Adds sorting of packages at the group level. !18062 -- Introduce a lightweight diffs_metadata endpoint. !18104 -- Limit the number of comments on an issue, MR, or commit. !18111 -- Introduce new Ansi2json parser to convert job logs to JSON. !18133 -- Use new Ansi2json job log converter via feature flag. !18134 -- Snowplow custom events for Monitor: Health Product Categories. !18157 -- Support Create/Read/Destroy operations in Feature Flag API. !18198 -- Add two new predefined stages to pipelines. !18205 -- Add endpoint to proxy requests to grafana's proxy endpoint. !18210 -- Add ability to query todos using GraphQL. !18218 -- Include in the callout message a list of jobs that caused missing dependencies failure. !18219 -- Adds login input with copy box and supporting copy to empty container registry view. !18244 (nate geslin) -- Add max_artifacts_size fields under project and group settings. !18286 -- Provide Merge requests and Issue links through the Release API. !18311 -- Adds separate parsers for mentions of users, groups, projects in markdown content. !18318 -- Add matching branch info to branch column. !18352 -- Users can preview audio files in a repository. !18354 (Jesse Hall @jessehall3) -- Add edit button to release blocks on Releases page. !18411 -- Add "Custom HTTP Git clone URL root" setting. !18422 -- Add support for epic update through GraphQL API. !18440 -- Expose subscribed attribute for epic on API. !18475 -- Geo: Enable replicating uploads, LFS objects, and artifacts in Object Storage. !18482 -- Show related merge requests in pipeline view. !18697 -- Allow users to configure protected paths from Admin panel. !31246 -- persist the refs when open the link of refs in a new tab of browser. !31998 (minghuan lei) -- Add first_parent option to list commits api. !32410 (jhenkens) -- Allow users to add and remove zoom rooms on an issue using quick action commands. - -### Other (23 changes, 5 of them are from the community) - -- Sync issuables state_id with null values. !16480 -- Experimental separate sign up flow. !16482 -- Upgrade Rouge to v3.11.0. !17011 -- Better job naming for Docker.gitlab-ci.yml. !17218 (luca.orlandi@gmail.com) -- Update GitLab Runner Helm Chart to 0.9.0. !17326 -- Change welcome message and make translatable. !17391 -- Remove map-get($grid-breakpoints, xs) for max-width. !17420 (Takuya Noguchi) -- Document Git LFS and max file size interaction. !17609 -- Refactor email notification code. !17741 (briankabiro) -- Ignore id column of ci_build_trace_sections table. !17805 -- Extend graphql query endpoint for merge requests to return more attributes to support sidebar implementation. !17813 -- Project list: Align star icons. !17833 -- Moves the license compliance reports to the Backend. !17905 -- Fixes wrong link on Protected paths admin settings. !17945 -- Update Pages to v1.11.0. !18010 -- Refactor checksum code in uploads. !18065 (briankabiro) -- Make instance configuration user friendly. !18363 (Takuya Noguchi) -- Update Workhorse to v8.14.0. !18391 -- Attribute each Sidekiq worker to a feature category. !18462 -- Update GitLab Shell to v10.2.0. !18735 -- Use correct icons for issue actions. -- Increase color contrast of select option path. -- Remove Postgresql specific setup tasks and move to schema.rb. - - ## 12.3.4 ### Fixed (2 changes) @@ -1 +1 @@ -12.5.0-pre +12.3.0-pre diff --git a/app/assets/javascripts/vue_shared/components/split_button.vue b/app/assets/javascripts/vue_shared/components/split_button.vue new file mode 100644 index 00000000000..f7dc00a345c --- /dev/null +++ b/app/assets/javascripts/vue_shared/components/split_button.vue @@ -0,0 +1,76 @@ +<script> +import _ from 'underscore'; + +import { GlDropdown, GlDropdownDivider, GlDropdownItem } from '@gitlab/ui'; + +const isValidItem = item => + _.isString(item.eventName) && _.isString(item.title) && _.isString(item.description); + +export default { + components: { + GlDropdown, + GlDropdownDivider, + GlDropdownItem, + }, + + props: { + actionItems: { + type: Array, + required: true, + validator(value) { + return value.length > 1 && value.every(isValidItem); + }, + }, + menuClass: { + type: String, + required: false, + default: '', + }, + }, + + data() { + return { + selectedItem: this.actionItems[0], + }; + }, + + computed: { + dropdownToggleText() { + return this.selectedItem.title; + }, + }, + + methods: { + triggerEvent() { + this.$emit(this.selectedItem.eventName); + }, + }, +}; +</script> + +<template> + <gl-dropdown + :menu-class="`dropdown-menu-selectable ${menuClass}`" + split + :text="dropdownToggleText" + v-bind="$attrs" + @click="triggerEvent" + > + <template v-for="(item, itemIndex) in actionItems"> + <gl-dropdown-item + :key="item.eventName" + :active="selectedItem === item" + active-class="is-active" + @click="selectedItem = item" + > + <strong>{{ item.title }}</strong> + <div>{{ item.description }}</div> + </gl-dropdown-item> + + <gl-dropdown-divider + v-if="itemIndex < actionItems.length - 1" + :key="`${item.eventName}-divider`" + /> + </template> + </gl-dropdown> +</template> diff --git a/app/assets/stylesheets/framework/dropdowns.scss b/app/assets/stylesheets/framework/dropdowns.scss index ce74aa6ed02..d53a4c1286c 100644 --- a/app/assets/stylesheets/framework/dropdowns.scss +++ b/app/assets/stylesheets/framework/dropdowns.scss @@ -506,7 +506,8 @@ .dropdown-menu-selectable { li { a, - button { + button, + .dropdown-item { padding: 8px 40px; position: relative; diff --git a/app/models/merge_request.rb b/app/models/merge_request.rb index b1c7e778743..cd8ede3905a 100644 --- a/app/models/merge_request.rb +++ b/app/models/merge_request.rb @@ -1081,7 +1081,7 @@ class MergeRequest < ApplicationRecord return true unless project.only_allow_merge_if_pipeline_succeeds? return false unless actual_head_pipeline - actual_head_pipeline.success? || actual_head_pipeline.skipped? + actual_head_pipeline.success? end def environments_for(current_user) diff --git a/app/models/project_services/chat_message/pipeline_message.rb b/app/models/project_services/chat_message/pipeline_message.rb index a3793d9937b..46fe894cfc3 100644 --- a/app/models/project_services/chat_message/pipeline_message.rb +++ b/app/models/project_services/chat_message/pipeline_message.rb @@ -75,11 +75,11 @@ module ChatMessage def activity { - title: s_("ChatMessage|Pipeline %{pipeline_link} of %{ref_type} %{branch_link} by %{user_combined_name} %{humanized_status}") % + title: s_("ChatMessage|Pipeline %{pipeline_link} of %{ref_type} %{ref_link} by %{user_combined_name} %{humanized_status}") % { pipeline_link: pipeline_link, ref_type: ref_type, - branch_link: branch_link, + ref_link: ref_link, user_combined_name: user_combined_name, humanized_status: humanized_status }, @@ -123,7 +123,7 @@ module ChatMessage fields = [ { title: ref_type == "tag" ? s_("ChatMessage|Tag") : s_("ChatMessage|Branch"), - value: Slack::Notifier::LinkFormatter.format(ref_name_link), + value: Slack::Notifier::LinkFormatter.format(ref_link), short: true }, { @@ -141,12 +141,12 @@ module ChatMessage end def message - s_("ChatMessage|%{project_link}: Pipeline %{pipeline_link} of %{ref_type} %{branch_link} by %{user_combined_name} %{humanized_status} in %{duration}") % + s_("ChatMessage|%{project_link}: Pipeline %{pipeline_link} of %{ref_type} %{ref_link} by %{user_combined_name} %{humanized_status} in %{duration}") % { project_link: project_link, pipeline_link: pipeline_link, ref_type: ref_type, - branch_link: branch_link, + ref_link: ref_link, user_combined_name: user_combined_name, humanized_status: humanized_status, duration: pretty_duration(duration) @@ -193,12 +193,16 @@ module ChatMessage end end - def branch_url - "#{project_url}/commits/#{ref}" + def ref_url + if ref_type == 'tag' + "#{project_url}/-/tags/#{ref}" + else + "#{project_url}/commits/#{ref}" + end end - def branch_link - "[#{ref}](#{branch_url})" + def ref_link + "[#{ref}](#{ref_url})" end def project_url @@ -266,14 +270,6 @@ module ChatMessage "[#{commit.title}](#{commit_url})" end - def commits_page_url - "#{project_url}/commits/#{ref}" - end - - def ref_name_link - "[#{ref}](#{commits_page_url})" - end - def author_url return unless user && committer diff --git a/app/models/project_services/chat_message/push_message.rb b/app/models/project_services/chat_message/push_message.rb index 8163fca33a2..07622f570c2 100644 --- a/app/models/project_services/chat_message/push_message.rb +++ b/app/models/project_services/chat_message/push_message.rb @@ -82,16 +82,20 @@ module ChatMessage Gitlab::Git.blank_ref?(after) end - def branch_url - "#{project_url}/commits/#{ref}" + def ref_url + if ref_type == 'tag' + "#{project_url}/-/tags/#{ref}" + else + "#{project_url}/commits/#{ref}" + end end def compare_url "#{project_url}/compare/#{before}...#{after}" end - def branch_link - "[#{ref}](#{branch_url})" + def ref_link + "[#{ref}](#{ref_url})" end def project_link @@ -104,11 +108,11 @@ module ChatMessage def compose_action_details if new_branch? - ['pushed new', branch_link, "to #{project_link}"] + ['pushed new', ref_link, "to #{project_link}"] elsif removed_branch? ['removed', ref, "from #{project_link}"] else - ['pushed to', branch_link, "of #{project_link} (#{compare_link})"] + ['pushed to', ref_link, "of #{project_link} (#{compare_link})"] end end diff --git a/changelogs/unreleased/10893-hide-redundant-labels-in-issue-boards.yml b/changelogs/unreleased/10893-hide-redundant-labels-in-issue-boards.yml new file mode 100644 index 00000000000..4e5547030de --- /dev/null +++ b/changelogs/unreleased/10893-hide-redundant-labels-in-issue-boards.yml @@ -0,0 +1,5 @@ +--- +title: Hide redundant labels in issue boards +merge_request: 17937 +author: +type: fixed diff --git a/changelogs/unreleased/10904-insights-include-projects.yml b/changelogs/unreleased/10904-insights-include-projects.yml new file mode 100644 index 00000000000..224ae9b786f --- /dev/null +++ b/changelogs/unreleased/10904-insights-include-projects.yml @@ -0,0 +1,5 @@ +--- +title: Add projects.only option to Insights +merge_request: 15930 +author: +type: added diff --git a/changelogs/unreleased/10946-fix-the-following-style-lint-errors-and-warnings-for-ee-app-assets-.yml b/changelogs/unreleased/10946-fix-the-following-style-lint-errors-and-warnings-for-ee-app-assets-.yml new file mode 100644 index 00000000000..4c167ad7ea5 --- /dev/null +++ b/changelogs/unreleased/10946-fix-the-following-style-lint-errors-and-warnings-for-ee-app-assets-.yml @@ -0,0 +1,5 @@ +--- +title: Fix stylelint errors in epics.scss +merge_request: 17243 +author: +type: fixed diff --git a/changelogs/unreleased/11412-fix-security-dashboard-history-bug.yml b/changelogs/unreleased/11412-fix-security-dashboard-history-bug.yml new file mode 100644 index 00000000000..3d7a862b2b8 --- /dev/null +++ b/changelogs/unreleased/11412-fix-security-dashboard-history-bug.yml @@ -0,0 +1,5 @@ +--- +title: Fix routing bugs in security dashboards +merge_request: 16738 +author: +type: fixed diff --git a/changelogs/unreleased/12564-email-regex.yml b/changelogs/unreleased/12564-email-regex.yml new file mode 100644 index 00000000000..68f489d31ef --- /dev/null +++ b/changelogs/unreleased/12564-email-regex.yml @@ -0,0 +1,5 @@ +--- +title: Adjust placeholder to solve misleading regex +merge_request: 18235 +author: +type: fixed diff --git a/changelogs/unreleased/12739-incomplete-group-audit-logs-in-group-view.yml b/changelogs/unreleased/12739-incomplete-group-audit-logs-in-group-view.yml new file mode 100644 index 00000000000..206badd5ab2 --- /dev/null +++ b/changelogs/unreleased/12739-incomplete-group-audit-logs-in-group-view.yml @@ -0,0 +1,5 @@ +--- +title: Specify sort order explicitly for Group and Project audit events +merge_request: 17739 +author: +type: fixed diff --git a/changelogs/unreleased/12764-refactor-checksum-code.yml b/changelogs/unreleased/12764-refactor-checksum-code.yml new file mode 100644 index 00000000000..b29d7bad5be --- /dev/null +++ b/changelogs/unreleased/12764-refactor-checksum-code.yml @@ -0,0 +1,5 @@ +--- +title: Refactor checksum code in uploads +merge_request: 18065 +author: briankabiro +type: other diff --git a/changelogs/unreleased/12819-remove-feature-flag.yml b/changelogs/unreleased/12819-remove-feature-flag.yml new file mode 100644 index 00000000000..0096a0d00ac --- /dev/null +++ b/changelogs/unreleased/12819-remove-feature-flag.yml @@ -0,0 +1,5 @@ +--- +title: Fix pod logs failure when pod contains more than 1 container +merge_request: 18574 +author: +type: fixed diff --git a/changelogs/unreleased/13321-show-issue-weight-when-zero.yml b/changelogs/unreleased/13321-show-issue-weight-when-zero.yml new file mode 100644 index 00000000000..422245548d6 --- /dev/null +++ b/changelogs/unreleased/13321-show-issue-weight-when-zero.yml @@ -0,0 +1,5 @@ +--- +title: Show issue weight when weight is 0 +merge_request: 17329 +author: briankabiro +type: fixed diff --git a/changelogs/unreleased/13360-fix-epics-api.yml b/changelogs/unreleased/13360-fix-epics-api.yml new file mode 100644 index 00000000000..ab89f2a8b5c --- /dev/null +++ b/changelogs/unreleased/13360-fix-epics-api.yml @@ -0,0 +1,5 @@ +--- +title: Fix creating epics with dates from api +merge_request: 18393 +author: +type: fixed diff --git a/changelogs/unreleased/13422-empty-security-dashboard-on-public-project-with-found-vulnerabiliti.yml b/changelogs/unreleased/13422-empty-security-dashboard-on-public-project-with-found-vulnerabiliti.yml new file mode 100644 index 00000000000..6f5a0054a58 --- /dev/null +++ b/changelogs/unreleased/13422-empty-security-dashboard-on-public-project-with-found-vulnerabiliti.yml @@ -0,0 +1,5 @@ +--- +title: Fix empty security dashboard for public projects +merge_request: 17915 +author: +type: fixed diff --git a/changelogs/unreleased/13426-add-user-and-timestamps-to-design-management-version.yml b/changelogs/unreleased/13426-add-user-and-timestamps-to-design-management-version.yml new file mode 100644 index 00000000000..2f56de32b2d --- /dev/null +++ b/changelogs/unreleased/13426-add-user-and-timestamps-to-design-management-version.yml @@ -0,0 +1,5 @@ +--- +title: Add user_id and created_at columns to design_management_versions table +merge_request: 17316 +author: +type: added diff --git a/changelogs/unreleased/13426-disable-design-mutation-abilities-when-issue-moved-or-locked.yml b/changelogs/unreleased/13426-disable-design-mutation-abilities-when-issue-moved-or-locked.yml new file mode 100644 index 00000000000..21c2dbff7e9 --- /dev/null +++ b/changelogs/unreleased/13426-disable-design-mutation-abilities-when-issue-moved-or-locked.yml @@ -0,0 +1,5 @@ +--- +title: Make designs read-only if the issue has been moved, or if its discussion has been locked +merge_request: 18551 +author: +type: changed diff --git a/changelogs/unreleased/13536-add-sort-to-group-packages.yml b/changelogs/unreleased/13536-add-sort-to-group-packages.yml new file mode 100644 index 00000000000..cf0e835510c --- /dev/null +++ b/changelogs/unreleased/13536-add-sort-to-group-packages.yml @@ -0,0 +1,5 @@ +--- +title: Adds sorting of packages at the group level +merge_request: 18062 +author: +type: added diff --git a/changelogs/unreleased/14064-commit-status-on-any-pipelines.yml b/changelogs/unreleased/14064-commit-status-on-any-pipelines.yml new file mode 100644 index 00000000000..db55148cf65 --- /dev/null +++ b/changelogs/unreleased/14064-commit-status-on-any-pipelines.yml @@ -0,0 +1,5 @@ +--- +title: Make commit status created for any pipelines +merge_request: 17524 +author: Aufar Gilbran +type: changed diff --git a/changelogs/unreleased/14794-rake-gitlab-geo-check-does-not-give-the-actual-state.yml b/changelogs/unreleased/14794-rake-gitlab-geo-check-does-not-give-the-actual-state.yml new file mode 100644 index 00000000000..4a4ee2f8c97 --- /dev/null +++ b/changelogs/unreleased/14794-rake-gitlab-geo-check-does-not-give-the-actual-state.yml @@ -0,0 +1,5 @@ +--- +title: 'Geo: Invalidate cache after refreshing foreign tables' +merge_request: 17885 +author: +type: fixed diff --git a/changelogs/unreleased/14945-fix-jira-api-url-parsing.yml b/changelogs/unreleased/14945-fix-jira-api-url-parsing.yml new file mode 100644 index 00000000000..c7323080e95 --- /dev/null +++ b/changelogs/unreleased/14945-fix-jira-api-url-parsing.yml @@ -0,0 +1,5 @@ +--- +title: 'JIRA Integration API URL works having a trailing slash' +merge_request: 18526 +author: +type: fixed diff --git a/changelogs/unreleased/15018-build-results-fe.yml b/changelogs/unreleased/15018-build-results-fe.yml new file mode 100644 index 00000000000..6d619910937 --- /dev/null +++ b/changelogs/unreleased/15018-build-results-fe.yml @@ -0,0 +1,5 @@ +--- +title: Creates Vue and Vuex app to render exposed artifacts +merge_request: 17934 +author: +type: added diff --git a/changelogs/unreleased/16188-warn-before-applying-issue-templates.yml b/changelogs/unreleased/16188-warn-before-applying-issue-templates.yml new file mode 100644 index 00000000000..c6cc6cb0992 --- /dev/null +++ b/changelogs/unreleased/16188-warn-before-applying-issue-templates.yml @@ -0,0 +1,5 @@ +--- +title: Warn before applying issue templates +merge_request: 16865 +author: +type: changed diff --git a/changelogs/unreleased/16388-abort-mwps-on-impossible-ff-merge.yml b/changelogs/unreleased/16388-abort-mwps-on-impossible-ff-merge.yml new file mode 100644 index 00000000000..4823c75bf2d --- /dev/null +++ b/changelogs/unreleased/16388-abort-mwps-on-impossible-ff-merge.yml @@ -0,0 +1,5 @@ +--- +title: Abort Merge When Pipeline Succeeds when Fast Forward merge is impossible +merge_request: 17886 +author: +type: fixed diff --git a/changelogs/unreleased/16482-split-sign-in-and-sign-up.yml b/changelogs/unreleased/16482-split-sign-in-and-sign-up.yml new file mode 100644 index 00000000000..bb3c01385d8 --- /dev/null +++ b/changelogs/unreleased/16482-split-sign-in-and-sign-up.yml @@ -0,0 +1,5 @@ +--- +title: Experimental separate sign up flow +merge_request: 16482 +author: +type: other diff --git a/changelogs/unreleased/16654-audio-in-markdown.yml b/changelogs/unreleased/16654-audio-in-markdown.yml new file mode 100644 index 00000000000..8983e06da2c --- /dev/null +++ b/changelogs/unreleased/16654-audio-in-markdown.yml @@ -0,0 +1,5 @@ +--- +title: Feature enabling embedded audio elements in markdown. +merge_request: 17860 +author: Jesse Hall @jessehall3 +type: added diff --git a/changelogs/unreleased/16790-render-xml-artifacts.yml b/changelogs/unreleased/16790-render-xml-artifacts.yml new file mode 100644 index 00000000000..d9cfcc04a68 --- /dev/null +++ b/changelogs/unreleased/16790-render-xml-artifacts.yml @@ -0,0 +1,5 @@ +--- +title: Render xml artifact files in GitLab +merge_request: 16790 +author: +type: added diff --git a/changelogs/unreleased/17596-show-all-matching-labels-when-using-label-quick-action.yml b/changelogs/unreleased/17596-show-all-matching-labels-when-using-label-quick-action.yml new file mode 100644 index 00000000000..7618e89b7c9 --- /dev/null +++ b/changelogs/unreleased/17596-show-all-matching-labels-when-using-label-quick-action.yml @@ -0,0 +1,5 @@ +--- +title: Show 20 labels in dropdown instead of 5 +merge_request: 17596 +author: +type: fixed diff --git a/changelogs/unreleased/17970-preserve-leading-whitespace.yml b/changelogs/unreleased/17970-preserve-leading-whitespace.yml new file mode 100644 index 00000000000..84085b80547 --- /dev/null +++ b/changelogs/unreleased/17970-preserve-leading-whitespace.yml @@ -0,0 +1,5 @@ +--- +title: Prevent the slash command parser from removing leading whitespace from content that is unrelated to slash commands +merge_request: 18589 +author: Jared Deckard +type: fixed diff --git a/changelogs/unreleased/18126-change-tag-url-for-tag-push-events-in-chat-msg-integration.yaml b/changelogs/unreleased/18126-change-tag-url-for-tag-push-events-in-chat-msg-integration.yaml new file mode 100644 index 00000000000..c576b57f7cb --- /dev/null +++ b/changelogs/unreleased/18126-change-tag-url-for-tag-push-events-in-chat-msg-integration.yaml @@ -0,0 +1,5 @@ +--- +title: "Show tag link whenever it's a tag in chat message integration for push events and pipeline events" +merge_request: 18126 +author: Mats Estensen +type: fixed diff --git a/changelogs/unreleased/18217-request-access-to-project-should-be-on-by-default.yml b/changelogs/unreleased/18217-request-access-to-project-should-be-on-by-default.yml new file mode 100644 index 00000000000..3fb1b874e77 --- /dev/null +++ b/changelogs/unreleased/18217-request-access-to-project-should-be-on-by-default.yml @@ -0,0 +1,5 @@ +--- +title: Enable Request Access functionality by default for new projects and groups +merge_request: 17662 +author: +type: changed diff --git a/changelogs/unreleased/19152-improve-jira-username-validation.yml b/changelogs/unreleased/19152-improve-jira-username-validation.yml new file mode 100644 index 00000000000..8f007497d32 --- /dev/null +++ b/changelogs/unreleased/19152-improve-jira-username-validation.yml @@ -0,0 +1,5 @@ +--- +title: 'JIRA Service: Improve username/email validation' +merge_request: 18397 +author: +type: fixed diff --git a/changelogs/unreleased/19822-audio-preview-in-repo.yml b/changelogs/unreleased/19822-audio-preview-in-repo.yml new file mode 100644 index 00000000000..9b165479f09 --- /dev/null +++ b/changelogs/unreleased/19822-audio-preview-in-repo.yml @@ -0,0 +1,5 @@ +--- +title: Users can preview audio files in a repository. +merge_request: 18354 +author: Jesse Hall @jessehall3 +type: added diff --git a/changelogs/unreleased/20-add-signup-step-2.yml b/changelogs/unreleased/20-add-signup-step-2.yml new file mode 100644 index 00000000000..cfaa57cea97 --- /dev/null +++ b/changelogs/unreleased/20-add-signup-step-2.yml @@ -0,0 +1,5 @@ +--- +title: Add step 2 of the experimental signup flow +merge_request: 16583 +author: +type: changed diff --git a/changelogs/unreleased/20718-extend-issue-attributes-returned-by-graphql.yml b/changelogs/unreleased/20718-extend-issue-attributes-returned-by-graphql.yml new file mode 100644 index 00000000000..1142772f434 --- /dev/null +++ b/changelogs/unreleased/20718-extend-issue-attributes-returned-by-graphql.yml @@ -0,0 +1,5 @@ +--- +title: Add more attributes to issues GraphQL endpoint +merge_request: 17802 +author: +type: changed diff --git a/changelogs/unreleased/20829-extend-mr-attributes-returned-by-graphql.yml b/changelogs/unreleased/20829-extend-mr-attributes-returned-by-graphql.yml new file mode 100644 index 00000000000..86e34bcdab1 --- /dev/null +++ b/changelogs/unreleased/20829-extend-mr-attributes-returned-by-graphql.yml @@ -0,0 +1,5 @@ +--- +title: Extend graphql query endpoint for merge requests to return more attributes to support sidebar implementation +merge_request: 17813 +author: +type: other diff --git a/changelogs/unreleased/21405-fix-registry-tag-delete.yml b/changelogs/unreleased/21405-fix-registry-tag-delete.yml new file mode 100644 index 00000000000..48890ec62fc --- /dev/null +++ b/changelogs/unreleased/21405-fix-registry-tag-delete.yml @@ -0,0 +1,5 @@ +--- +title: 'Adds the ability to delete single tags from the docker registry. Fix the issue that caused all related tags and image to be deleted at the same time.' +merge_request: 16886 +author: +type: fixed diff --git a/changelogs/unreleased/21800-parse-mentioned-users-group-projects-from-markdown.yml b/changelogs/unreleased/21800-parse-mentioned-users-group-projects-from-markdown.yml new file mode 100644 index 00000000000..463d8a0ab98 --- /dev/null +++ b/changelogs/unreleased/21800-parse-mentioned-users-group-projects-from-markdown.yml @@ -0,0 +1,5 @@ +--- +title: Adds separate parsers for mentions of users, groups, projects in markdown content +merge_request: 18318 +author: +type: added diff --git a/changelogs/unreleased/22388-limit-the-number-of-comments-on-a-noteable.yml b/changelogs/unreleased/22388-limit-the-number-of-comments-on-a-noteable.yml new file mode 100644 index 00000000000..f047d3ddac1 --- /dev/null +++ b/changelogs/unreleased/22388-limit-the-number-of-comments-on-a-noteable.yml @@ -0,0 +1,5 @@ +--- +title: Limit the number of comments on an issue, MR, or commit +merge_request: 18111 +author: +type: added diff --git a/changelogs/unreleased/22879-close-jira-issues-with-issues-disabled.yml b/changelogs/unreleased/22879-close-jira-issues-with-issues-disabled.yml new file mode 100644 index 00000000000..c8f32d2226e --- /dev/null +++ b/changelogs/unreleased/22879-close-jira-issues-with-issues-disabled.yml @@ -0,0 +1,5 @@ +--- +title: 'Merge Request: Close JIRA issues when issues are disabled' +merge_request: 17743 +author: +type: fixed diff --git a/changelogs/unreleased/22904-fix-overflow.yml b/changelogs/unreleased/22904-fix-overflow.yml new file mode 100644 index 00000000000..06669d5b548 --- /dev/null +++ b/changelogs/unreleased/22904-fix-overflow.yml @@ -0,0 +1,5 @@ +--- +title: Fixes job overflow in stages dropdown +merge_request: +author: +type: fixed diff --git a/changelogs/unreleased/22959-remove-map-get-grid-breakpoints-xs-for-max-width.yml b/changelogs/unreleased/22959-remove-map-get-grid-breakpoints-xs-for-max-width.yml new file mode 100644 index 00000000000..12ef1fb23f2 --- /dev/null +++ b/changelogs/unreleased/22959-remove-map-get-grid-breakpoints-xs-for-max-width.yml @@ -0,0 +1,5 @@ +--- +title: Remove map-get($grid-breakpoints, xs) for max-width +merge_request: 17420 +author: Takuya Noguchi +type: other diff --git a/changelogs/unreleased/23079-write-permission-global-deploy-keys.yml b/changelogs/unreleased/23079-write-permission-global-deploy-keys.yml new file mode 100644 index 00000000000..04f9dfc9043 --- /dev/null +++ b/changelogs/unreleased/23079-write-permission-global-deploy-keys.yml @@ -0,0 +1,5 @@ +--- +title: Allow maintainers to toggle write permission for public deploy keys +merge_request: 17210 +author: +type: fixed diff --git a/changelogs/unreleased/23315-group-level-container-registry-browser.yml b/changelogs/unreleased/23315-group-level-container-registry-browser.yml new file mode 100644 index 00000000000..4340c565a88 --- /dev/null +++ b/changelogs/unreleased/23315-group-level-container-registry-browser.yml @@ -0,0 +1,5 @@ +--- +title: Group level Container Registry browser +merge_request: 17615 +author: +type: added diff --git a/changelogs/unreleased/23400-fix-duplicate-replies.yml b/changelogs/unreleased/23400-fix-duplicate-replies.yml new file mode 100644 index 00000000000..26b24c66085 --- /dev/null +++ b/changelogs/unreleased/23400-fix-duplicate-replies.yml @@ -0,0 +1,5 @@ +--- +title: Fix new discussion replies sometimes showing up twice +merge_request: 17255 +author: +type: fixed diff --git a/changelogs/unreleased/2358-elasticsearch-project-snippets.yml b/changelogs/unreleased/2358-elasticsearch-project-snippets.yml new file mode 100644 index 00000000000..28324c1827d --- /dev/null +++ b/changelogs/unreleased/2358-elasticsearch-project-snippets.yml @@ -0,0 +1,5 @@ +--- +title: Support ES searches for project snippets +merge_request: 18459 +author: +type: fixed diff --git a/changelogs/unreleased/24818-fix-jira-favicon-link.yml b/changelogs/unreleased/24818-fix-jira-favicon-link.yml new file mode 100644 index 00000000000..c6857d1f83c --- /dev/null +++ b/changelogs/unreleased/24818-fix-jira-favicon-link.yml @@ -0,0 +1,5 @@ +--- +title: Fix Jira integration favicon image with relative URL +merge_request: 16802 +author: +type: fixed diff --git a/changelogs/unreleased/26001-notification-release-be.yml b/changelogs/unreleased/26001-notification-release-be.yml new file mode 100644 index 00000000000..f3e81a60dc9 --- /dev/null +++ b/changelogs/unreleased/26001-notification-release-be.yml @@ -0,0 +1,5 @@ +--- +title: Add 'New release' to the project custom notifications +merge_request: 17877 +author: +type: added diff --git a/changelogs/unreleased/26019-evidence-collection.yml b/changelogs/unreleased/26019-evidence-collection.yml new file mode 100644 index 00000000000..439a4b55900 --- /dev/null +++ b/changelogs/unreleased/26019-evidence-collection.yml @@ -0,0 +1,5 @@ +--- +title: Creation of Evidence collection of new releases. +merge_request: 17217 +author: +type: added diff --git a/changelogs/unreleased/26210-toc-links.yml b/changelogs/unreleased/26210-toc-links.yml new file mode 100644 index 00000000000..c37798c5b39 --- /dev/null +++ b/changelogs/unreleased/26210-toc-links.yml @@ -0,0 +1,5 @@ +--- +title: Fix issue with wiki TOC links being treated as external links +merge_request: +author: Oren Kanner +type: fixed diff --git a/changelogs/unreleased/27502-enable-cloud-run-on-gke.yml b/changelogs/unreleased/27502-enable-cloud-run-on-gke.yml new file mode 100644 index 00000000000..77b365f17db --- /dev/null +++ b/changelogs/unreleased/27502-enable-cloud-run-on-gke.yml @@ -0,0 +1,5 @@ +--- +title: Enable Cloud Run on GKE cluster creation +merge_request: 16566 +author: +type: added diff --git a/changelogs/unreleased/27715-fix-unrenderable-notes.yml b/changelogs/unreleased/27715-fix-unrenderable-notes.yml new file mode 100644 index 00000000000..329f9cbb30c --- /dev/null +++ b/changelogs/unreleased/27715-fix-unrenderable-notes.yml @@ -0,0 +1,5 @@ +--- +title: Fix showing diff when it has legacy diff notes +merge_request: 18510 +author: +type: fixed diff --git a/changelogs/unreleased/27835-move-and-resize-panels-in-dashboard-save-to-branch.yml b/changelogs/unreleased/27835-move-and-resize-panels-in-dashboard-save-to-branch.yml new file mode 100644 index 00000000000..b7d7f37bccc --- /dev/null +++ b/changelogs/unreleased/27835-move-and-resize-panels-in-dashboard-save-to-branch.yml @@ -0,0 +1,5 @@ +--- +title: Add property to enable metrics dashboards to be rearranged +merge_request: 16605 +author: +type: changed diff --git a/changelogs/unreleased/28211-check-if-mapping-is-empty-before-caching.yml b/changelogs/unreleased/28211-check-if-mapping-is-empty-before-caching.yml new file mode 100644 index 00000000000..efdd47bb061 --- /dev/null +++ b/changelogs/unreleased/28211-check-if-mapping-is-empty-before-caching.yml @@ -0,0 +1,5 @@ +--- +title: Check if mapping is empty before caching in File Collections +merge_request: 18290 +author: briankabiro +type: performance diff --git a/changelogs/unreleased/28243-check-for-docker-images-before-renaming-group.yml b/changelogs/unreleased/28243-check-for-docker-images-before-renaming-group.yml new file mode 100644 index 00000000000..8717d59b1bc --- /dev/null +++ b/changelogs/unreleased/28243-check-for-docker-images-before-renaming-group.yml @@ -0,0 +1,6 @@ +--- +title: Prevents a group path change when a project inside the group has container + registry images +merge_request: 17583 +author: +type: fixed diff --git a/changelogs/unreleased/28311-extremely-low-contrast-in-dropdown-for-group-file-templates.yml b/changelogs/unreleased/28311-extremely-low-contrast-in-dropdown-for-group-file-templates.yml new file mode 100644 index 00000000000..9f690e02a47 --- /dev/null +++ b/changelogs/unreleased/28311-extremely-low-contrast-in-dropdown-for-group-file-templates.yml @@ -0,0 +1,5 @@ +--- +title: Increase color contrast of select option path +merge_request: +author: +type: other diff --git a/changelogs/unreleased/28492-upgrade-ingress-to-latest.yml b/changelogs/unreleased/28492-upgrade-ingress-to-latest.yml new file mode 100644 index 00000000000..2e4d8baf9f6 --- /dev/null +++ b/changelogs/unreleased/28492-upgrade-ingress-to-latest.yml @@ -0,0 +1,5 @@ +--- +title: Unpin ingress image version, upgrade chart to 1.22.1 +merge_request: 18047 +author: +type: added diff --git a/changelogs/unreleased/28781-migrate-pages-metadata-in-background.yml b/changelogs/unreleased/28781-migrate-pages-metadata-in-background.yml new file mode 100644 index 00000000000..171fd8ff554 --- /dev/null +++ b/changelogs/unreleased/28781-migrate-pages-metadata-in-background.yml @@ -0,0 +1,5 @@ +--- +title: Schedule background migration to populate pages metadata +merge_request: 17993 +author: +type: added diff --git a/changelogs/unreleased/28781-migrate-pages-metadata-on-demand.yml b/changelogs/unreleased/28781-migrate-pages-metadata-on-demand.yml new file mode 100644 index 00000000000..ad478c8895d --- /dev/null +++ b/changelogs/unreleased/28781-migrate-pages-metadata-on-demand.yml @@ -0,0 +1,5 @@ +--- +title: Add index on ci_builds for successful Pages deploys +merge_request: 17204 +author: +type: added diff --git a/changelogs/unreleased/28781-pages-namespaces-virtual-domain.yml b/changelogs/unreleased/28781-pages-namespaces-virtual-domain.yml new file mode 100644 index 00000000000..6725d070440 --- /dev/null +++ b/changelogs/unreleased/28781-pages-namespaces-virtual-domain.yml @@ -0,0 +1,5 @@ +--- +title: Add project_pages_metadata DB table +merge_request: 17197 +author: +type: added diff --git a/changelogs/unreleased/29020-merge-requests-issues-links.yml b/changelogs/unreleased/29020-merge-requests-issues-links.yml new file mode 100644 index 00000000000..ec0b6990cac --- /dev/null +++ b/changelogs/unreleased/29020-merge-requests-issues-links.yml @@ -0,0 +1,5 @@ +--- +title: Provide Merge requests and Issue links through the Release API +merge_request: 18311 +author: +type: added diff --git a/changelogs/unreleased/29020-update-release-blocks-for-multiple-milestone-support.yml b/changelogs/unreleased/29020-update-release-blocks-for-multiple-milestone-support.yml new file mode 100644 index 00000000000..9520302068e --- /dev/null +++ b/changelogs/unreleased/29020-update-release-blocks-for-multiple-milestone-support.yml @@ -0,0 +1,5 @@ +--- +title: Add support for the association of multiple milestones to the Releases page +merge_request: 17091 +author: +type: changed diff --git a/changelogs/unreleased/29215-500-error-when-deleting-group-web-hook-activerecord-statementinvali.yml b/changelogs/unreleased/29215-500-error-when-deleting-group-web-hook-activerecord-statementinvali.yml new file mode 100644 index 00000000000..f1b82620418 --- /dev/null +++ b/changelogs/unreleased/29215-500-error-when-deleting-group-web-hook-activerecord-statementinvali.yml @@ -0,0 +1,5 @@ +--- +title: Use cascading deletes for deleting logs upon deleting a webhook +merge_request: 18642 +author: +type: performance diff --git a/changelogs/unreleased/29284-video-preview-not-working.yml b/changelogs/unreleased/29284-video-preview-not-working.yml new file mode 100644 index 00000000000..1d36b3e0dff --- /dev/null +++ b/changelogs/unreleased/29284-video-preview-not-working.yml @@ -0,0 +1,5 @@ +--- +title: Fix inline rendering of videos for uploads with uppercase file extensions +merge_request: 17924 +author: +type: fixed diff --git a/changelogs/unreleased/29477-notification-settings-display-all-groups.yml b/changelogs/unreleased/29477-notification-settings-display-all-groups.yml new file mode 100644 index 00000000000..a4cb6fe1643 --- /dev/null +++ b/changelogs/unreleased/29477-notification-settings-display-all-groups.yml @@ -0,0 +1,5 @@ +--- +title: Show all groups user belongs to in Notification settings +merge_request: 17303 +author: +type: fixed diff --git a/changelogs/unreleased/29513-continue-improvements-for-time-window-filtering-on-metrics-dashboar.yml b/changelogs/unreleased/29513-continue-improvements-for-time-window-filtering-on-metrics-dashboar.yml new file mode 100644 index 00000000000..668e25f4749 --- /dev/null +++ b/changelogs/unreleased/29513-continue-improvements-for-time-window-filtering-on-metrics-dashboar.yml @@ -0,0 +1,5 @@ +--- +title: Improve time window filtering on metrics dashboard +merge_request: 17554 +author: +type: added diff --git a/changelogs/unreleased/29835-webide-fork.yml b/changelogs/unreleased/29835-webide-fork.yml new file mode 100644 index 00000000000..1849b414a2d --- /dev/null +++ b/changelogs/unreleased/29835-webide-fork.yml @@ -0,0 +1,6 @@ +--- +title: Web IDE button should fork and open forked project when selected from read-only + project +merge_request: 17672 +author: +type: added diff --git a/changelogs/unreleased/29881-fix-ide-delete-and-readd.yml b/changelogs/unreleased/29881-fix-ide-delete-and-readd.yml new file mode 100644 index 00000000000..91445ca791b --- /dev/null +++ b/changelogs/unreleased/29881-fix-ide-delete-and-readd.yml @@ -0,0 +1,5 @@ +--- +title: Fix Web IDE tree not updating modified status +merge_request: 18647 +author: +type: fixed diff --git a/changelogs/unreleased/30112-private-internal-sub-group-email-notifications-not-sent-when-mentio.yml b/changelogs/unreleased/30112-private-internal-sub-group-email-notifications-not-sent-when-mentio.yml new file mode 100644 index 00000000000..fd20fc274e8 --- /dev/null +++ b/changelogs/unreleased/30112-private-internal-sub-group-email-notifications-not-sent-when-mentio.yml @@ -0,0 +1,5 @@ +--- +title: Fix notifications for private group mentions in Notes, Issues, and Merge Requests +merge_request: 18183 +author: +type: fixed diff --git a/changelogs/unreleased/30186-mirror-pull-api-no-unpause.yml b/changelogs/unreleased/30186-mirror-pull-api-no-unpause.yml new file mode 100644 index 00000000000..dee4128051e --- /dev/null +++ b/changelogs/unreleased/30186-mirror-pull-api-no-unpause.yml @@ -0,0 +1,5 @@ +--- +title: Do not start mirroring via API when paused +merge_request: 17930 +author: +type: changed diff --git a/changelogs/unreleased/30217-refactor-email-notification-code.yml b/changelogs/unreleased/30217-refactor-email-notification-code.yml new file mode 100644 index 00000000000..c55096301cb --- /dev/null +++ b/changelogs/unreleased/30217-refactor-email-notification-code.yml @@ -0,0 +1,5 @@ +--- +title: Refactor email notification code +merge_request: 17741 +author: briankabiro +type: other diff --git a/changelogs/unreleased/30392-variables.yml b/changelogs/unreleased/30392-variables.yml new file mode 100644 index 00000000000..2a35ffd3215 --- /dev/null +++ b/changelogs/unreleased/30392-variables.yml @@ -0,0 +1,5 @@ +--- +title: Fixes variables overflowing in sm screens +merge_request: +author: +type: fixed diff --git a/changelogs/unreleased/30497-race-condition-in-discussions-json-request-could-lead-to-notes-show.yml b/changelogs/unreleased/30497-race-condition-in-discussions-json-request-could-lead-to-notes-show.yml new file mode 100644 index 00000000000..32e21a6d003 --- /dev/null +++ b/changelogs/unreleased/30497-race-condition-in-discussions-json-request-could-lead-to-notes-show.yml @@ -0,0 +1,5 @@ +--- +title: Fix notes race condition when linking to specific note +merge_request: 17777 +author: +type: fixed diff --git a/changelogs/unreleased/30525-iframe_jaeger.yml b/changelogs/unreleased/30525-iframe_jaeger.yml new file mode 100644 index 00000000000..19fdccf6333 --- /dev/null +++ b/changelogs/unreleased/30525-iframe_jaeger.yml @@ -0,0 +1,5 @@ +--- +title: Embed Jaeger in Gitlab UI +merge_request: +author: +type: changed diff --git a/changelogs/unreleased/30619-make-recent-searches-more-visible.yml b/changelogs/unreleased/30619-make-recent-searches-more-visible.yml new file mode 100644 index 00000000000..c57806fcdd9 --- /dev/null +++ b/changelogs/unreleased/30619-make-recent-searches-more-visible.yml @@ -0,0 +1,5 @@ +--- +title: Use text instead of icon for recent searches dropdown +merge_request: +author: +type: changed diff --git a/changelogs/unreleased/30807-fix-usability-problem.yml b/changelogs/unreleased/30807-fix-usability-problem.yml new file mode 100644 index 00000000000..691a6a8ff1d --- /dev/null +++ b/changelogs/unreleased/30807-fix-usability-problem.yml @@ -0,0 +1,5 @@ +--- +title: Fix usability problems with the file template picker +merge_request: 17522 +author: +type: changed diff --git a/changelogs/unreleased/30839-asciidoc-table-styles.yml b/changelogs/unreleased/30839-asciidoc-table-styles.yml new file mode 100644 index 00000000000..11960f3620d --- /dev/null +++ b/changelogs/unreleased/30839-asciidoc-table-styles.yml @@ -0,0 +1,5 @@ +--- +title: Enable grid, frame and stripes styling on AsciiDoc tables +merge_request: 18165 +author: Guillaume Grossetie +type: fixed diff --git a/changelogs/unreleased/30877-optimize-explore-snippets.yml b/changelogs/unreleased/30877-optimize-explore-snippets.yml new file mode 100644 index 00000000000..7ca52876609 --- /dev/null +++ b/changelogs/unreleased/30877-optimize-explore-snippets.yml @@ -0,0 +1,5 @@ +--- +title: Show only personal snippets on explore page +merge_request: 18092 +author: +type: performance diff --git a/changelogs/unreleased/30881-webide-mr-confirmation.yml b/changelogs/unreleased/30881-webide-mr-confirmation.yml new file mode 100644 index 00000000000..075e091adc4 --- /dev/null +++ b/changelogs/unreleased/30881-webide-mr-confirmation.yml @@ -0,0 +1,6 @@ +--- +title: 'Fix Issue: WebIDE asks for confirmation to leave the page when committing + and creating a new MR' +merge_request: 17671 +author: +type: fixed diff --git a/changelogs/unreleased/31007-limit-activity-events.yml b/changelogs/unreleased/31007-limit-activity-events.yml new file mode 100644 index 00000000000..d5ad588af33 --- /dev/null +++ b/changelogs/unreleased/31007-limit-activity-events.yml @@ -0,0 +1,5 @@ +--- +title: Aggregate push events when there are too many +merge_request: 18239 +author: +type: changed diff --git a/changelogs/unreleased/31009-limit-project-hooks-services.yml b/changelogs/unreleased/31009-limit-project-hooks-services.yml new file mode 100644 index 00000000000..dc1e0461567 --- /dev/null +++ b/changelogs/unreleased/31009-limit-project-hooks-services.yml @@ -0,0 +1,5 @@ +--- +title: Don't execute webhooks/services when above limit +merge_request: 17874 +author: +type: performance diff --git a/changelogs/unreleased/31030-when-viewing-comments-occasionally-the-users-profile-picture-will-b.yml b/changelogs/unreleased/31030-when-viewing-comments-occasionally-the-users-profile-picture-will-b.yml new file mode 100644 index 00000000000..5ff7f31d86b --- /dev/null +++ b/changelogs/unreleased/31030-when-viewing-comments-occasionally-the-users-profile-picture-will-b.yml @@ -0,0 +1,5 @@ +--- +title: Fix broken notes avatar rendering in Chrome 77 +merge_request: 18110 +author: +type: fixed diff --git a/changelogs/unreleased/31118-do-not-use-blob-for-file-path.yml b/changelogs/unreleased/31118-do-not-use-blob-for-file-path.yml new file mode 100644 index 00000000000..454ad15ee46 --- /dev/null +++ b/changelogs/unreleased/31118-do-not-use-blob-for-file-path.yml @@ -0,0 +1,5 @@ +--- +title: Reduce Gitaly calls when viewing a commit +merge_request: 17095 +author: +type: performance diff --git a/changelogs/unreleased/31290-mr-diffs-batch-load.yml b/changelogs/unreleased/31290-mr-diffs-batch-load.yml new file mode 100644 index 00000000000..933493e80d7 --- /dev/null +++ b/changelogs/unreleased/31290-mr-diffs-batch-load.yml @@ -0,0 +1,5 @@ +--- +title: Introduce diffs_batch JSON endpoint for paginated diffs +merge_request: 17651 +author: +type: added diff --git a/changelogs/unreleased/31329-hidden-nav-content.yml b/changelogs/unreleased/31329-hidden-nav-content.yml new file mode 100644 index 00000000000..2c85c8df2e3 --- /dev/null +++ b/changelogs/unreleased/31329-hidden-nav-content.yml @@ -0,0 +1,5 @@ +--- +title: Update top nav bar to fit all content in at all screen sizes +merge_request: +author: +type: fixed diff --git a/changelogs/unreleased/31393-when-adding-labels-in-a-merge-request-adds-them-out-of-order-until-.yml b/changelogs/unreleased/31393-when-adding-labels-in-a-merge-request-adds-them-out-of-order-until-.yml new file mode 100644 index 00000000000..2b47255a06f --- /dev/null +++ b/changelogs/unreleased/31393-when-adding-labels-in-a-merge-request-adds-them-out-of-order-until-.yml @@ -0,0 +1,5 @@ +--- +title: Alphabetically sorts selected sidebar labels. +merge_request: 17309 +author: +type: fixed diff --git a/changelogs/unreleased/31427-flaky-spec-finders-members_finder_spec-rb-85.yml b/changelogs/unreleased/31427-flaky-spec-finders-members_finder_spec-rb-85.yml new file mode 100644 index 00000000000..13d4735d2d0 --- /dev/null +++ b/changelogs/unreleased/31427-flaky-spec-finders-members_finder_spec-rb-85.yml @@ -0,0 +1,5 @@ +--- +title: Fix Flaky spec/finders/members_finder_spec.rb:85 +merge_request: 18257 +author: Jacopo Beschi @jacopo-beschi +type: fixed diff --git a/changelogs/unreleased/31441-make-it-easy-for-includes-to-add-jobs-at-beginning-end-of-pipeline.yml b/changelogs/unreleased/31441-make-it-easy-for-includes-to-add-jobs-at-beginning-end-of-pipeline.yml new file mode 100644 index 00000000000..e909c56983b --- /dev/null +++ b/changelogs/unreleased/31441-make-it-easy-for-includes-to-add-jobs-at-beginning-end-of-pipeline.yml @@ -0,0 +1,5 @@ +--- +title: Add two new predefined stages to pipelines +merge_request: 18205 +author: +type: added diff --git a/changelogs/unreleased/31492-banners-should-only-be-dismissable-by-clicking-x.yml b/changelogs/unreleased/31492-banners-should-only-be-dismissable-by-clicking-x.yml new file mode 100644 index 00000000000..322f006e8af --- /dev/null +++ b/changelogs/unreleased/31492-banners-should-only-be-dismissable-by-clicking-x.yml @@ -0,0 +1,5 @@ +--- +title: Banners should only be dismissable by clicking x button +merge_request: 17642 +author: +type: changed diff --git a/changelogs/unreleased/31547-update-registry-tag-delete-popup-message.yml b/changelogs/unreleased/31547-update-registry-tag-delete-popup-message.yml new file mode 100644 index 00000000000..fe1afaca080 --- /dev/null +++ b/changelogs/unreleased/31547-update-registry-tag-delete-popup-message.yml @@ -0,0 +1,5 @@ +--- +title: Update registry tag delete popup message +merge_request: 17257 +author: +type: changed diff --git a/changelogs/unreleased/31573-cross-project-pipeline-triggering-does-not-work-in-core.yml b/changelogs/unreleased/31573-cross-project-pipeline-triggering-does-not-work-in-core.yml new file mode 100644 index 00000000000..1638746ea72 --- /dev/null +++ b/changelogs/unreleased/31573-cross-project-pipeline-triggering-does-not-work-in-core.yml @@ -0,0 +1,5 @@ +--- +title: Allow cross-project pipeline triggering with CI_JOB_TOKEN in core +merge_request: 17251 +author: +type: added diff --git a/changelogs/unreleased/31573-cross-project-piplelines.yml b/changelogs/unreleased/31573-cross-project-piplelines.yml new file mode 100644 index 00000000000..37db74b035b --- /dev/null +++ b/changelogs/unreleased/31573-cross-project-piplelines.yml @@ -0,0 +1,5 @@ +--- +title: Port over EE pipeline functionality to CE +merge_request: 18136 +author: +type: changed diff --git a/changelogs/unreleased/31590-tag-delete-instrumentation.yml b/changelogs/unreleased/31590-tag-delete-instrumentation.yml new file mode 100644 index 00000000000..d071808987f --- /dev/null +++ b/changelogs/unreleased/31590-tag-delete-instrumentation.yml @@ -0,0 +1,5 @@ +--- +title: Collect docker registry related metrics +merge_request: 17063 +author: +type: added diff --git a/changelogs/unreleased/31678-update-cluster-link-text.yml b/changelogs/unreleased/31678-update-cluster-link-text.yml new file mode 100644 index 00000000000..fc759749380 --- /dev/null +++ b/changelogs/unreleased/31678-update-cluster-link-text.yml @@ -0,0 +1,5 @@ +--- +title: Update cluster link text +merge_request: 18322 +author: +type: changed diff --git a/changelogs/unreleased/31728-nullify-cluster-namespace-if-blank.yml b/changelogs/unreleased/31728-nullify-cluster-namespace-if-blank.yml new file mode 100644 index 00000000000..362d0c88eea --- /dev/null +++ b/changelogs/unreleased/31728-nullify-cluster-namespace-if-blank.yml @@ -0,0 +1,5 @@ +--- +title: Nullify platform Kubernetes namespace if blank +merge_request: 17657 +author: +type: fixed diff --git a/changelogs/unreleased/31837-sidebar-icons-jump.yml b/changelogs/unreleased/31837-sidebar-icons-jump.yml new file mode 100644 index 00000000000..2cf359d5398 --- /dev/null +++ b/changelogs/unreleased/31837-sidebar-icons-jump.yml @@ -0,0 +1,5 @@ +--- +title: Stop sidebar icons from jumping when expanded & collapsed +merge_request: 16971 +author: +type: fixed diff --git a/changelogs/unreleased/31914-graphql-todos-query-pd.yml b/changelogs/unreleased/31914-graphql-todos-query-pd.yml new file mode 100644 index 00000000000..e39bcda1ff6 --- /dev/null +++ b/changelogs/unreleased/31914-graphql-todos-query-pd.yml @@ -0,0 +1,5 @@ +--- +title: Add ability to query todos using GraphQL +merge_request: 18218 +author: +type: added diff --git a/changelogs/unreleased/31923-Snowplow-custom-events-Monitor.yml b/changelogs/unreleased/31923-Snowplow-custom-events-Monitor.yml new file mode 100644 index 00000000000..161fb59ca6e --- /dev/null +++ b/changelogs/unreleased/31923-Snowplow-custom-events-Monitor.yml @@ -0,0 +1,5 @@ +--- +title: 'Snowplow custom events for Monitor: Health Product Categories' +merge_request: 18157 +author: +type: added diff --git a/changelogs/unreleased/32030-move-licence-complience-to-the-backend-FE.yml b/changelogs/unreleased/32030-move-licence-complience-to-the-backend-FE.yml new file mode 100644 index 00000000000..a37732960a4 --- /dev/null +++ b/changelogs/unreleased/32030-move-licence-complience-to-the-backend-FE.yml @@ -0,0 +1,5 @@ +--- +title: Moves the license compliance reports to the Backend +merge_request: 17905 +author: +type: other diff --git a/changelogs/unreleased/32036-add-some-spacing-offset-to-the-star-icon-to-project-row-in-case-the.yml b/changelogs/unreleased/32036-add-some-spacing-offset-to-the-star-icon-to-project-row-in-case-the.yml new file mode 100644 index 00000000000..6ec9504b1a9 --- /dev/null +++ b/changelogs/unreleased/32036-add-some-spacing-offset-to-the-star-icon-to-project-row-in-case-the.yml @@ -0,0 +1,5 @@ +--- +title: 'Project list: Align star icons' +merge_request: 17833 +author: +type: other diff --git a/changelogs/unreleased/32133-remove-feature-flag-for-zoom.yml b/changelogs/unreleased/32133-remove-feature-flag-for-zoom.yml new file mode 100644 index 00000000000..74e4d15c67f --- /dev/null +++ b/changelogs/unreleased/32133-remove-feature-flag-for-zoom.yml @@ -0,0 +1,5 @@ +--- +title: Allow users to add and remove zoom rooms on an issue using quick action commands +merge_request: +author: +type: added diff --git a/changelogs/unreleased/32146-remove-fe-code.yml b/changelogs/unreleased/32146-remove-fe-code.yml new file mode 100644 index 00000000000..f7dd251de44 --- /dev/null +++ b/changelogs/unreleased/32146-remove-fe-code.yml @@ -0,0 +1,5 @@ +--- +title: Removes Collapsible Sections from Job Log +merge_request: +author: +type: fixed diff --git a/changelogs/unreleased/32192-remove-gap-at-the-top-of-expandable-code-diff-blocks.yml b/changelogs/unreleased/32192-remove-gap-at-the-top-of-expandable-code-diff-blocks.yml new file mode 100644 index 00000000000..737390b2522 --- /dev/null +++ b/changelogs/unreleased/32192-remove-gap-at-the-top-of-expandable-code-diff-blocks.yml @@ -0,0 +1,5 @@ +--- +title: Remove thin white line at top of diff view code blocks +merge_request: 17026 +author: +type: fixed diff --git a/changelogs/unreleased/32279-fix_graphql_for_secondary_node.yml b/changelogs/unreleased/32279-fix_graphql_for_secondary_node.yml new file mode 100644 index 00000000000..746ed2e2333 --- /dev/null +++ b/changelogs/unreleased/32279-fix_graphql_for_secondary_node.yml @@ -0,0 +1,5 @@ +--- +title: Fix GraphQL for read-only instances +merge_request: 17225 +author: +type: fixed diff --git a/changelogs/unreleased/32380-update-issue-list-icons.yml b/changelogs/unreleased/32380-update-issue-list-icons.yml new file mode 100644 index 00000000000..42ad9b1eb99 --- /dev/null +++ b/changelogs/unreleased/32380-update-issue-list-icons.yml @@ -0,0 +1,5 @@ +--- +title: Use correct icons for issue actions +merge_request: +author: +type: other diff --git a/changelogs/unreleased/32396-collapsible-markdown-formatted-weirdly.yml b/changelogs/unreleased/32396-collapsible-markdown-formatted-weirdly.yml new file mode 100644 index 00000000000..49ee7ea6c0a --- /dev/null +++ b/changelogs/unreleased/32396-collapsible-markdown-formatted-weirdly.yml @@ -0,0 +1,5 @@ +--- +title: Fix css selector for details in issue description +merge_request: 17557 +author: +type: fixed diff --git a/changelogs/unreleased/32397-geo-instructions-to-update-fdw-schema-aren-t-entirely-correct.yml b/changelogs/unreleased/32397-geo-instructions-to-update-fdw-schema-aren-t-entirely-correct.yml new file mode 100644 index 00000000000..1ee73c2b959 --- /dev/null +++ b/changelogs/unreleased/32397-geo-instructions-to-update-fdw-schema-aren-t-entirely-correct.yml @@ -0,0 +1,5 @@ +--- +title: 'Geo: Fix instruction from rake geo:gitlab:check' +merge_request: 17895 +author: +type: changed diff --git a/changelogs/unreleased/32457-change-welcome-to-gitlab-message.yml b/changelogs/unreleased/32457-change-welcome-to-gitlab-message.yml new file mode 100644 index 00000000000..2d1c29d90ce --- /dev/null +++ b/changelogs/unreleased/32457-change-welcome-to-gitlab-message.yml @@ -0,0 +1,5 @@ +--- +title: Change welcome message and make translatable +merge_request: 17391 +author: +type: other diff --git a/changelogs/unreleased/32595-blame-or-history-newline-in-filename.yml b/changelogs/unreleased/32595-blame-or-history-newline-in-filename.yml new file mode 100644 index 00000000000..b67b823704f --- /dev/null +++ b/changelogs/unreleased/32595-blame-or-history-newline-in-filename.yml @@ -0,0 +1,5 @@ +--- +title: Users can view the blame or history of a file with newlines in its filename. +merge_request: 17543 +author: Jesse Hall @jessehall3 +type: fixed diff --git a/changelogs/unreleased/32839-fix-relative-position-edge-case.yml b/changelogs/unreleased/32839-fix-relative-position-edge-case.yml new file mode 100644 index 00000000000..fd975f27cdc --- /dev/null +++ b/changelogs/unreleased/32839-fix-relative-position-edge-case.yml @@ -0,0 +1,5 @@ +--- +title: Fix relative positioning when moving items down and there is no space +merge_request: 17781 +author: +type: fixed diff --git a/changelogs/unreleased/32899-handle-race-condition-for-container-registry-sync.yml b/changelogs/unreleased/32899-handle-race-condition-for-container-registry-sync.yml new file mode 100644 index 00000000000..4182f49b730 --- /dev/null +++ b/changelogs/unreleased/32899-handle-race-condition-for-container-registry-sync.yml @@ -0,0 +1,5 @@ +--- +title: 'Geo: Fix race condition for container synchronization' +merge_request: 17823 +author: +type: fixed diff --git a/changelogs/unreleased/32919-inform-the-user-that-removing-the-last-tag-of-an-image-it-will-remo.yml b/changelogs/unreleased/32919-inform-the-user-that-removing-the-last-tag-of-an-image-it-will-remo.yml new file mode 100644 index 00000000000..76da5fcebc8 --- /dev/null +++ b/changelogs/unreleased/32919-inform-the-user-that-removing-the-last-tag-of-an-image-it-will-remo.yml @@ -0,0 +1,6 @@ +--- +title: Add more specific message to clarify the role of empty images in container + registry +merge_request: 32919 +author: +type: changed diff --git a/changelogs/unreleased/32930-matching-branch-code-owner-approval.yml b/changelogs/unreleased/32930-matching-branch-code-owner-approval.yml new file mode 100644 index 00000000000..b2e1d6d5958 --- /dev/null +++ b/changelogs/unreleased/32930-matching-branch-code-owner-approval.yml @@ -0,0 +1,5 @@ +--- +title: Add matching branch info to branch column +merge_request: 18352 +author: +type: added diff --git a/changelogs/unreleased/33158-time-window-filter-dropdown-doesn-t-retain-previously-selected-wind.yml b/changelogs/unreleased/33158-time-window-filter-dropdown-doesn-t-retain-previously-selected-wind.yml new file mode 100644 index 00000000000..16951ac7051 --- /dev/null +++ b/changelogs/unreleased/33158-time-window-filter-dropdown-doesn-t-retain-previously-selected-wind.yml @@ -0,0 +1,5 @@ +--- +title: Time window filter in monitor dashboard gets reset +merge_request: 17972 +author: +type: fixed diff --git a/changelogs/unreleased/33230-undefined-method-terms_of_service_url.yml b/changelogs/unreleased/33230-undefined-method-terms_of_service_url.yml new file mode 100644 index 00000000000..547612ccf39 --- /dev/null +++ b/changelogs/unreleased/33230-undefined-method-terms_of_service_url.yml @@ -0,0 +1,5 @@ +--- +title: Fix 500 error on clicking to LetsEncrypt Terms of Service +merge_request: 18263 +author: +type: fixed diff --git a/changelogs/unreleased/33322-missing-page-title-on-projects-container-registry.yml b/changelogs/unreleased/33322-missing-page-title-on-projects-container-registry.yml new file mode 100644 index 00000000000..94c46c9d057 --- /dev/null +++ b/changelogs/unreleased/33322-missing-page-title-on-projects-container-registry.yml @@ -0,0 +1,5 @@ +--- +title: Add missing page title to projects/container-registry +merge_request: 18114 +author: +type: changed diff --git a/changelogs/unreleased/33337-fix-insights-only-projects-for-project.yml b/changelogs/unreleased/33337-fix-insights-only-projects-for-project.yml new file mode 100644 index 00000000000..7dea4519d10 --- /dev/null +++ b/changelogs/unreleased/33337-fix-insights-only-projects-for-project.yml @@ -0,0 +1,5 @@ +--- +title: Make sure project insights stick on its own +merge_request: 18082 +author: +type: fixed diff --git a/changelogs/unreleased/33405-container-registry-improve-delete-modal-button.yml b/changelogs/unreleased/33405-container-registry-improve-delete-modal-button.yml new file mode 100644 index 00000000000..23ebd3b038e --- /dev/null +++ b/changelogs/unreleased/33405-container-registry-improve-delete-modal-button.yml @@ -0,0 +1,5 @@ +--- +title: Container registry tag(s) delete button pluralization +merge_request: 18260 +author: +type: changed diff --git a/changelogs/unreleased/33582-fix-protected-branch-wildcard.yml b/changelogs/unreleased/33582-fix-protected-branch-wildcard.yml new file mode 100644 index 00000000000..091a88f80a5 --- /dev/null +++ b/changelogs/unreleased/33582-fix-protected-branch-wildcard.yml @@ -0,0 +1,5 @@ +--- +title: Fix protected branch detection used by notification service +merge_request: 18221 +author: +type: fixed diff --git a/changelogs/unreleased/33668-fix-search-term-xss.yml b/changelogs/unreleased/33668-fix-search-term-xss.yml new file mode 100644 index 00000000000..ed54542bd9c --- /dev/null +++ b/changelogs/unreleased/33668-fix-search-term-xss.yml @@ -0,0 +1,5 @@ +--- +title: HTML-escape search term in empty message +merge_request: 18319 +author: +type: security diff --git a/changelogs/unreleased/33750-follow-up-from-resolve-deactivate-a-user-with-self-service-reactiva.yml b/changelogs/unreleased/33750-follow-up-from-resolve-deactivate-a-user-with-self-service-reactiva.yml new file mode 100644 index 00000000000..7fca33c0cd2 --- /dev/null +++ b/changelogs/unreleased/33750-follow-up-from-resolve-deactivate-a-user-with-self-service-reactiva.yml @@ -0,0 +1,5 @@ +--- +title: Do not allow deactivated users to use slash commands +merge_request: 18365 +author: +type: fixed diff --git a/changelogs/unreleased/33876-ensure-proper-access-level-check-on-pa.yml b/changelogs/unreleased/33876-ensure-proper-access-level-check-on-pa.yml new file mode 100644 index 00000000000..686382c7caf --- /dev/null +++ b/changelogs/unreleased/33876-ensure-proper-access-level-check-on-pa.yml @@ -0,0 +1,5 @@ +--- +title: Allow to view productivity analytics page without a license +merge_request: 33876 +author: +type: fixed diff --git a/changelogs/unreleased/34032-container-registry-bug-on-modal-delete-button-and-title-text.yml b/changelogs/unreleased/34032-container-registry-bug-on-modal-delete-button-and-title-text.yml new file mode 100644 index 00000000000..a4d3e62a48a --- /dev/null +++ b/changelogs/unreleased/34032-container-registry-bug-on-modal-delete-button-and-title-text.yml @@ -0,0 +1,5 @@ +--- +title: Fix container registry delete tag modal title and button +merge_request: 34032 +author: +type: fixed diff --git a/changelogs/unreleased/34120-design-system-notes-icon-does-not-appear.yml b/changelogs/unreleased/34120-design-system-notes-icon-does-not-appear.yml new file mode 100644 index 00000000000..8533067a408 --- /dev/null +++ b/changelogs/unreleased/34120-design-system-notes-icon-does-not-appear.yml @@ -0,0 +1,5 @@ +--- +title: Resolve missing design system notes icons +merge_request: 18693 +author: +type: fixed diff --git a/changelogs/unreleased/45797-welcome-screen.yml b/changelogs/unreleased/45797-welcome-screen.yml new file mode 100644 index 00000000000..4f0868c484f --- /dev/null +++ b/changelogs/unreleased/45797-welcome-screen.yml @@ -0,0 +1,5 @@ +--- +title: Fix formatting welcome screen external users +merge_request: 16667 +author: +type: fixed diff --git a/changelogs/unreleased/46686-add-aws-cluster-data-model.yml b/changelogs/unreleased/46686-add-aws-cluster-data-model.yml new file mode 100644 index 00000000000..130c4c0c855 --- /dev/null +++ b/changelogs/unreleased/46686-add-aws-cluster-data-model.yml @@ -0,0 +1,5 @@ +--- +title: Add database tables to store AWS roles and cluster providers +merge_request: 17057 +author: +type: added diff --git a/changelogs/unreleased/53041-groups-named-shared.yml b/changelogs/unreleased/53041-groups-named-shared.yml new file mode 100644 index 00000000000..165b6727fe9 --- /dev/null +++ b/changelogs/unreleased/53041-groups-named-shared.yml @@ -0,0 +1,5 @@ +--- +title: Naming a project "shared" will no longer automatically open the "Shared Projects" tab. +merge_request: 16847 +author: Jesse Hall @jessehall3 +type: fixed diff --git a/changelogs/unreleased/5582-add-missing-actions-and-data-to-environments-and-deployments-apis.yml b/changelogs/unreleased/5582-add-missing-actions-and-data-to-environments-and-deployments-apis.yml new file mode 100644 index 00000000000..7c90834385f --- /dev/null +++ b/changelogs/unreleased/5582-add-missing-actions-and-data-to-environments-and-deployments-apis.yml @@ -0,0 +1,5 @@ +--- +title: Add status to deployments and state to environments in API responses +merge_request: 16242 +author: +type: changed diff --git a/changelogs/unreleased/59036-object-to-local-storage.yml b/changelogs/unreleased/59036-object-to-local-storage.yml new file mode 100644 index 00000000000..213361b7b7e --- /dev/null +++ b/changelogs/unreleased/59036-object-to-local-storage.yml @@ -0,0 +1,5 @@ +--- +title: "[ObjectStorage] Allow migrating back to local storage" +merge_request: 16868 +author: +type: added diff --git a/changelogs/unreleased/61061-links-to-sha-commits-in-release-notes.yml b/changelogs/unreleased/61061-links-to-sha-commits-in-release-notes.yml new file mode 100644 index 00000000000..554d30c9dc5 --- /dev/null +++ b/changelogs/unreleased/61061-links-to-sha-commits-in-release-notes.yml @@ -0,0 +1,5 @@ +--- +title: Links on Releases page to commits and tags +merge_request: 16128 +author: +type: changed diff --git a/changelogs/unreleased/61078-empty-state-file-finder.yml b/changelogs/unreleased/61078-empty-state-file-finder.yml new file mode 100644 index 00000000000..694ac4a3b7c --- /dev/null +++ b/changelogs/unreleased/61078-empty-state-file-finder.yml @@ -0,0 +1,5 @@ +--- +title: Add empty state in file search +merge_request: 16851 +author: +type: changed diff --git a/changelogs/unreleased/61933-toggling-a-task-inside-a-collapsible-section-collapses-all-sections.yml b/changelogs/unreleased/61933-toggling-a-task-inside-a-collapsible-section-collapses-all-sections.yml new file mode 100644 index 00000000000..2239bffcd5e --- /dev/null +++ b/changelogs/unreleased/61933-toggling-a-task-inside-a-collapsible-section-collapses-all-sections.yml @@ -0,0 +1,6 @@ +--- +title: When user toggles task list item, keep details open until user closes the details + manually +merge_request: 16153 +author: +type: fixed diff --git a/changelogs/unreleased/63768-group-settings-kubernetes-runner-section.yml b/changelogs/unreleased/63768-group-settings-kubernetes-runner-section.yml new file mode 100644 index 00000000000..ed374922632 --- /dev/null +++ b/changelogs/unreleased/63768-group-settings-kubernetes-runner-section.yml @@ -0,0 +1,5 @@ +--- +title: Add kubernetes section to group runner settings +merge_request: 16338 +author: +type: added diff --git a/changelogs/unreleased/63921-deactivate-a-user-with-self-service-reactivation.yml b/changelogs/unreleased/63921-deactivate-a-user-with-self-service-reactivation.yml new file mode 100644 index 00000000000..5f4d9e41e04 --- /dev/null +++ b/changelogs/unreleased/63921-deactivate-a-user-with-self-service-reactivation.yml @@ -0,0 +1,5 @@ +--- +title: Deactivate a user (with self-service reactivation) +merge_request: 17037 +author: +type: added diff --git a/changelogs/unreleased/64251-branch-name-set-cache.yml b/changelogs/unreleased/64251-branch-name-set-cache.yml new file mode 100644 index 00000000000..6ce4bdf5e43 --- /dev/null +++ b/changelogs/unreleased/64251-branch-name-set-cache.yml @@ -0,0 +1,5 @@ +--- +title: Cache branch and tag names as Redis sets +merge_request: 30476 +author: +type: performance diff --git a/changelogs/unreleased/64837-persist-refs-over-browser-tabs.yml b/changelogs/unreleased/64837-persist-refs-over-browser-tabs.yml new file mode 100644 index 00000000000..68042383ed6 --- /dev/null +++ b/changelogs/unreleased/64837-persist-refs-over-browser-tabs.yml @@ -0,0 +1,5 @@ +--- +title: persist the refs when open the link of refs in a new tab of browser +merge_request: 31998 +author: minghuan lei +type: added diff --git a/changelogs/unreleased/66123-over-a-thousand-todos-displays-count-of-one.yml b/changelogs/unreleased/66123-over-a-thousand-todos-displays-count-of-one.yml new file mode 100644 index 00000000000..3feb8539378 --- /dev/null +++ b/changelogs/unreleased/66123-over-a-thousand-todos-displays-count-of-one.yml @@ -0,0 +1,6 @@ +--- +title: Fix for count in todo badge when user has over 1,000 todos. Will now correctly + display todo count after user marks some todos as done. +merge_request: 16844 +author: Jesse Hall @jessehall3 +type: fixed diff --git a/changelogs/unreleased/66330-confidential-quick-action-is-available-for-confidential-issues.yml b/changelogs/unreleased/66330-confidential-quick-action-is-available-for-confidential-issues.yml new file mode 100644 index 00000000000..4ed18adb7e2 --- /dev/null +++ b/changelogs/unreleased/66330-confidential-quick-action-is-available-for-confidential-issues.yml @@ -0,0 +1,5 @@ +--- +title: Changed confidential quick action to only be available on non confidential issues +merge_request: 16902 +author: Marc Schwede +type: fixed diff --git a/changelogs/unreleased/9102-update-hide-dismissed-param.yml b/changelogs/unreleased/9102-update-hide-dismissed-param.yml new file mode 100644 index 00000000000..0bc2146b0c1 --- /dev/null +++ b/changelogs/unreleased/9102-update-hide-dismissed-param.yml @@ -0,0 +1,5 @@ +--- +title: Use scope param instead of hide_dismissed +merge_request: 16834 +author: +type: changed diff --git a/changelogs/unreleased/9801-epic-copy-link.yml b/changelogs/unreleased/9801-epic-copy-link.yml new file mode 100644 index 00000000000..c3d24010a59 --- /dev/null +++ b/changelogs/unreleased/9801-epic-copy-link.yml @@ -0,0 +1,5 @@ +--- +title: Added 'copy link' in epic comment dropdown. +merge_request: 17224 +author: +type: added diff --git a/changelogs/unreleased/9841-geo-unable-to-compare-branches-on-secondary.yml b/changelogs/unreleased/9841-geo-unable-to-compare-branches-on-secondary.yml new file mode 100644 index 00000000000..037e63c4813 --- /dev/null +++ b/changelogs/unreleased/9841-geo-unable-to-compare-branches-on-secondary.yml @@ -0,0 +1,5 @@ +--- +title: Allow users to compare Git revisions on a read-only instance +merge_request: 18038 +author: +type: fixed diff --git a/changelogs/unreleased/ab-iid-unnecessary-locks.yml b/changelogs/unreleased/ab-iid-unnecessary-locks.yml new file mode 100644 index 00000000000..cbdef4ffa87 --- /dev/null +++ b/changelogs/unreleased/ab-iid-unnecessary-locks.yml @@ -0,0 +1,5 @@ +--- +title: Avoid unnecessary locks on internal_ids +merge_request: 18328 +author: +type: performance diff --git a/changelogs/unreleased/ab-replace-index.yml b/changelogs/unreleased/ab-replace-index.yml new file mode 100644 index 00000000000..3e8586d2ad1 --- /dev/null +++ b/changelogs/unreleased/ab-replace-index.yml @@ -0,0 +1,5 @@ +--- +title: Replace index on ci_triggers +merge_request: 18652 +author: +type: performance diff --git a/changelogs/unreleased/ac-fix-only-os-uplods.yml b/changelogs/unreleased/ac-fix-only-os-uplods.yml new file mode 100644 index 00000000000..d63ddc059b6 --- /dev/null +++ b/changelogs/unreleased/ac-fix-only-os-uplods.yml @@ -0,0 +1,5 @@ +--- +title: Avoid dumping files on disk when direct_upload is enabled +merge_request: 18135 +author: +type: performance diff --git a/changelogs/unreleased/ac-pull-mirror-branch-prefix.yml b/changelogs/unreleased/ac-pull-mirror-branch-prefix.yml new file mode 100644 index 00000000000..b39308ea38a --- /dev/null +++ b/changelogs/unreleased/ac-pull-mirror-branch-prefix.yml @@ -0,0 +1,5 @@ +--- +title: Add pull_mirror_branch_prefix column on projects table +merge_request: 17368 +author: +type: added diff --git a/changelogs/unreleased/ac-workhorse-8-11-0.yml b/changelogs/unreleased/ac-workhorse-8-11-0.yml new file mode 100644 index 00000000000..1f86416449e --- /dev/null +++ b/changelogs/unreleased/ac-workhorse-8-11-0.yml @@ -0,0 +1,5 @@ +--- +title: Handle wiki and graphql attachments in gitlab-workhorse +merge_request: 17690 +author: +type: performance diff --git a/changelogs/unreleased/add-ansi2json-log-parser.yml b/changelogs/unreleased/add-ansi2json-log-parser.yml new file mode 100644 index 00000000000..1aec5d36fbe --- /dev/null +++ b/changelogs/unreleased/add-ansi2json-log-parser.yml @@ -0,0 +1,5 @@ +--- +title: Introduce new Ansi2json parser to convert job logs to JSON +merge_request: 18133 +author: +type: added diff --git a/changelogs/unreleased/add-ci-project-title-variable.yml b/changelogs/unreleased/add-ci-project-title-variable.yml new file mode 100644 index 00000000000..68f650a8f58 --- /dev/null +++ b/changelogs/unreleased/add-ci-project-title-variable.yml @@ -0,0 +1,5 @@ +--- +title: Introduce CI_PROJECT_TITLE as predefined environment variable +merge_request: 17849 +author: Nejc Habjan +type: added diff --git a/changelogs/unreleased/add-first-parent-to-find-commits.yml b/changelogs/unreleased/add-first-parent-to-find-commits.yml new file mode 100644 index 00000000000..076eed90f68 --- /dev/null +++ b/changelogs/unreleased/add-first-parent-to-find-commits.yml @@ -0,0 +1,5 @@ +--- +title: Add first_parent option to list commits api +merge_request: 32410 +author: jhenkens +type: added diff --git a/changelogs/unreleased/add-health-checks-exporter.yml b/changelogs/unreleased/add-health-checks-exporter.yml new file mode 100644 index 00000000000..7ffce51b82c --- /dev/null +++ b/changelogs/unreleased/add-health-checks-exporter.yml @@ -0,0 +1,5 @@ +--- +title: Export liveness and readiness probes +merge_request: +author: +type: changed diff --git a/changelogs/unreleased/add-sorting-to-packages-list.yml b/changelogs/unreleased/add-sorting-to-packages-list.yml new file mode 100644 index 00000000000..8eab37326a1 --- /dev/null +++ b/changelogs/unreleased/add-sorting-to-packages-list.yml @@ -0,0 +1,5 @@ +--- +title: Adds sorting of packages at the project level +merge_request: 15448 +author: +type: added diff --git a/changelogs/unreleased/add-timestamps-to-api-deployments-response.yml b/changelogs/unreleased/add-timestamps-to-api-deployments-response.yml new file mode 100644 index 00000000000..f136efc088d --- /dev/null +++ b/changelogs/unreleased/add-timestamps-to-api-deployments-response.yml @@ -0,0 +1,5 @@ +--- +title: Added timestamp (updated_at) to API deployments response +merge_request: 17913 +author: +type: added diff --git a/changelogs/unreleased/add-timestamps-to-api-pipelines-response.yml b/changelogs/unreleased/add-timestamps-to-api-pipelines-response.yml new file mode 100644 index 00000000000..54975d3229d --- /dev/null +++ b/changelogs/unreleased/add-timestamps-to-api-pipelines-response.yml @@ -0,0 +1,5 @@ +--- +title: Added timestamps (created_at and updated_at) to API pipelines response +merge_request: 17911 +author: +type: added diff --git a/changelogs/unreleased/ak-health-check-custom-error.yml b/changelogs/unreleased/ak-health-check-custom-error.yml new file mode 100644 index 00000000000..dd9ef8f9c7a --- /dev/null +++ b/changelogs/unreleased/ak-health-check-custom-error.yml @@ -0,0 +1,5 @@ +--- +title: Disable gitlab-workhorse static error page on health endpoints +merge_request: 17770 +author: +type: fixed diff --git a/changelogs/unreleased/ak-unhandled-exception-in-health-checks.yml b/changelogs/unreleased/ak-unhandled-exception-in-health-checks.yml new file mode 100644 index 00000000000..a738cbb0369 --- /dev/null +++ b/changelogs/unreleased/ak-unhandled-exception-in-health-checks.yml @@ -0,0 +1,5 @@ +--- +title: Catch unhandled exceptions in health checks +merge_request: 17694 +author: +type: fixed diff --git a/changelogs/unreleased/ak-upgrade-workhorse.yml b/changelogs/unreleased/ak-upgrade-workhorse.yml new file mode 100644 index 00000000000..f92e8f876a6 --- /dev/null +++ b/changelogs/unreleased/ak-upgrade-workhorse.yml @@ -0,0 +1,5 @@ +--- +title: Upgrade gitlab-workhorse to 8.12.0 +merge_request: 17892 +author: +type: changed diff --git a/changelogs/unreleased/allow-api-lookup-of-inherited-member-by-id.yml b/changelogs/unreleased/allow-api-lookup-of-inherited-member-by-id.yml new file mode 100644 index 00000000000..f266d197c6c --- /dev/null +++ b/changelogs/unreleased/allow-api-lookup-of-inherited-member-by-id.yml @@ -0,0 +1,5 @@ +--- +title: Add individual inherited member lookup API +merge_request: 17744 +author: +type: added diff --git a/changelogs/unreleased/allow-username-search-to-work-with-at-sign.yml b/changelogs/unreleased/allow-username-search-to-work-with-at-sign.yml new file mode 100644 index 00000000000..fa6d679f7a2 --- /dev/null +++ b/changelogs/unreleased/allow-username-search-to-work-with-at-sign.yml @@ -0,0 +1,5 @@ +--- +title: Allow users to be searched with a @ prefix +merge_request: 17742 +author: +type: added diff --git a/changelogs/unreleased/an-priority-bump-authorized_projects.yml b/changelogs/unreleased/an-priority-bump-authorized_projects.yml new file mode 100644 index 00000000000..a52143698cd --- /dev/null +++ b/changelogs/unreleased/an-priority-bump-authorized_projects.yml @@ -0,0 +1,5 @@ +--- +title: Priority bump authorized_projects sidekiq queue +merge_request: 18125 +author: +type: performance diff --git a/changelogs/unreleased/an-sidekiq-job-feature-attribution.yml b/changelogs/unreleased/an-sidekiq-job-feature-attribution.yml new file mode 100644 index 00000000000..6f5832dfef2 --- /dev/null +++ b/changelogs/unreleased/an-sidekiq-job-feature-attribution.yml @@ -0,0 +1,5 @@ +--- +title: Attribute each Sidekiq worker to a feature category +merge_request: 18462 +author: +type: other diff --git a/changelogs/unreleased/ancestor_groups.yml b/changelogs/unreleased/ancestor_groups.yml new file mode 100644 index 00000000000..1b5d6573b86 --- /dev/null +++ b/changelogs/unreleased/ancestor_groups.yml @@ -0,0 +1,5 @@ +--- +title: 'Allow to exclude ancestor groups on group labels API' +merge_request: 17221 +author: Mathieu Parent +type: added diff --git a/changelogs/unreleased/backfill-releases-updated-at.yml b/changelogs/unreleased/backfill-releases-updated-at.yml new file mode 100644 index 00000000000..dfaaf8cd41e --- /dev/null +++ b/changelogs/unreleased/backfill-releases-updated-at.yml @@ -0,0 +1,5 @@ +--- +title: Backfill releases table updated_at column and add not null constraints to created_at and updated_at +merge_request: 17400 +author: +type: fixed diff --git a/changelogs/unreleased/bjk-32646_puma_killer.yml b/changelogs/unreleased/bjk-32646_puma_killer.yml new file mode 100644 index 00000000000..11318966a01 --- /dev/null +++ b/changelogs/unreleased/bjk-32646_puma_killer.yml @@ -0,0 +1,5 @@ +--- +title: Update PumaWorkerKiller defaults +merge_request: 17758 +author: +type: performance diff --git a/changelogs/unreleased/bump-elasticsearch-indexer-to-v1-4-0.yml b/changelogs/unreleased/bump-elasticsearch-indexer-to-v1-4-0.yml new file mode 100644 index 00000000000..561514a2dc4 --- /dev/null +++ b/changelogs/unreleased/bump-elasticsearch-indexer-to-v1-4-0.yml @@ -0,0 +1,5 @@ +--- +title: Bump GITLAB_ELASTICSEARCH_INDEXER_VERSION=v1.4.0 +merge_request: 18558 +author: +type: fixed diff --git a/changelogs/unreleased/bvl-fix-view-mr-deleted-repo.yml b/changelogs/unreleased/bvl-fix-view-mr-deleted-repo.yml new file mode 100644 index 00000000000..ffd7135eec1 --- /dev/null +++ b/changelogs/unreleased/bvl-fix-view-mr-deleted-repo.yml @@ -0,0 +1,5 @@ +--- +title: Fix viewing merge reqeust from a fork that's being deleted +merge_request: 17894 +author: +type: fixed diff --git a/changelogs/unreleased/bvl-only-one-pushmirror-per-push.yml b/changelogs/unreleased/bvl-only-one-pushmirror-per-push.yml new file mode 100644 index 00000000000..29090739d8b --- /dev/null +++ b/changelogs/unreleased/bvl-only-one-pushmirror-per-push.yml @@ -0,0 +1,5 @@ +--- +title: Only schedule updating push-mirrors once per push +merge_request: 17902 +author: +type: performance diff --git a/changelogs/unreleased/cache-issues-with-has_visible_content.yml b/changelogs/unreleased/cache-issues-with-has_visible_content.yml new file mode 100644 index 00000000000..0007b3086e8 --- /dev/null +++ b/changelogs/unreleased/cache-issues-with-has_visible_content.yml @@ -0,0 +1,5 @@ +--- +title: Use cache_method_asymmetrically with Repository#has_visible_content? +merge_request: 17975 +author: +type: fixed diff --git a/changelogs/unreleased/cluster_management_projects.yml b/changelogs/unreleased/cluster_management_projects.yml new file mode 100644 index 00000000000..9958537f25f --- /dev/null +++ b/changelogs/unreleased/cluster_management_projects.yml @@ -0,0 +1,5 @@ +--- +title: Adds management project for a cluster +merge_request: 17866 +author: +type: changed diff --git a/changelogs/unreleased/dedicated-pipeline-ref.yml b/changelogs/unreleased/dedicated-pipeline-ref.yml new file mode 100644 index 00000000000..6484bab1da4 --- /dev/null +++ b/changelogs/unreleased/dedicated-pipeline-ref.yml @@ -0,0 +1,6 @@ +--- +title: Create a persistent ref per pipeline for keeping pipelines run from force-push + and merged results +merge_request: 17043 +author: +type: fixed diff --git a/changelogs/unreleased/deployment-iid-transaction-improvement.yml b/changelogs/unreleased/deployment-iid-transaction-improvement.yml new file mode 100644 index 00000000000..aefc3349c35 --- /dev/null +++ b/changelogs/unreleased/deployment-iid-transaction-improvement.yml @@ -0,0 +1,6 @@ +--- +title: Reduce lock contention of deployment creation by allocating IID outside + of the pipeline transaction +merge_request: 17696 +author: +type: performance diff --git a/changelogs/unreleased/deployments-api.yml b/changelogs/unreleased/deployments-api.yml new file mode 100644 index 00000000000..dce1763bdf1 --- /dev/null +++ b/changelogs/unreleased/deployments-api.yml @@ -0,0 +1,5 @@ +--- +title: Add API for manually creating and updating deployments +merge_request: 17620 +author: +type: added diff --git a/changelogs/unreleased/dz-fix-group-settings-projects-page.yml b/changelogs/unreleased/dz-fix-group-settings-projects-page.yml new file mode 100644 index 00000000000..9d5b93f9a50 --- /dev/null +++ b/changelogs/unreleased/dz-fix-group-settings-projects-page.yml @@ -0,0 +1,5 @@ +--- +title: Improve UI for admin/projects and group/settings/projects pages +merge_request: 17247 +author: +type: changed diff --git a/changelogs/unreleased/dz-improve-groups-list-ui.yml b/changelogs/unreleased/dz-improve-groups-list-ui.yml new file mode 100644 index 00000000000..36460eb911a --- /dev/null +++ b/changelogs/unreleased/dz-improve-groups-list-ui.yml @@ -0,0 +1,5 @@ +--- +title: Increase group avatar size to 40px +merge_request: 18654 +author: +type: changed diff --git a/changelogs/unreleased/dz-improve-help-layout.yml b/changelogs/unreleased/dz-improve-help-layout.yml new file mode 100644 index 00000000000..2e4d885e2c2 --- /dev/null +++ b/changelogs/unreleased/dz-improve-help-layout.yml @@ -0,0 +1,5 @@ +--- +title: Improve UI of documentation under /help +merge_request: 18331 +author: +type: changed diff --git a/changelogs/unreleased/dz-redesign-admin-system-info.yml b/changelogs/unreleased/dz-redesign-admin-system-info.yml new file mode 100644 index 00000000000..f86f6c6d603 --- /dev/null +++ b/changelogs/unreleased/dz-redesign-admin-system-info.yml @@ -0,0 +1,5 @@ +--- +title: Improve admin/system_info page ui +merge_request: 17829 +author: +type: changed diff --git a/changelogs/unreleased/eb-fix-ci-status-indicator-for-warnings.yml b/changelogs/unreleased/eb-fix-ci-status-indicator-for-warnings.yml new file mode 100644 index 00000000000..efc3238a267 --- /dev/null +++ b/changelogs/unreleased/eb-fix-ci-status-indicator-for-warnings.yml @@ -0,0 +1,5 @@ +--- +title: Show correct CI indicator when build succeeded with warnings. +merge_request: 17034 +author: +type: fixed diff --git a/changelogs/unreleased/eb-missing-dependencies-custom-callout-message.yml b/changelogs/unreleased/eb-missing-dependencies-custom-callout-message.yml new file mode 100644 index 00000000000..eda37da11b4 --- /dev/null +++ b/changelogs/unreleased/eb-missing-dependencies-custom-callout-message.yml @@ -0,0 +1,6 @@ +--- +title: Include in the callout message a list of jobs that caused missing dependencies + failure. +merge_request: 18219 +author: +type: added diff --git a/changelogs/unreleased/eb-project-group-max-artifacts-size-fields.yml b/changelogs/unreleased/eb-project-group-max-artifacts-size-fields.yml new file mode 100644 index 00000000000..8e911ffead5 --- /dev/null +++ b/changelogs/unreleased/eb-project-group-max-artifacts-size-fields.yml @@ -0,0 +1,5 @@ +--- +title: Add max_artifacts_size fields under project and group settings. +merge_request: 18286 +author: +type: added diff --git a/changelogs/unreleased/eb-support-test-report-error-key.yml b/changelogs/unreleased/eb-support-test-report-error-key.yml new file mode 100644 index 00000000000..304e9814529 --- /dev/null +++ b/changelogs/unreleased/eb-support-test-report-error-key.yml @@ -0,0 +1,5 @@ +--- +title: MR Test Summary now shows errors as failures. +merge_request: 17039 +author: +type: changed diff --git a/changelogs/unreleased/ee-16726-signup-not-disabled.yml b/changelogs/unreleased/ee-16726-signup-not-disabled.yml new file mode 100644 index 00000000000..eb0482f7046 --- /dev/null +++ b/changelogs/unreleased/ee-16726-signup-not-disabled.yml @@ -0,0 +1,5 @@ +--- +title: Fix signup link in admin area not being disabled +merge_request: 16726 +author: Illya Klymov +type: fixed diff --git a/changelogs/unreleased/enable-group-events.yml b/changelogs/unreleased/enable-group-events.yml new file mode 100644 index 00000000000..8a7af8ab170 --- /dev/null +++ b/changelogs/unreleased/enable-group-events.yml @@ -0,0 +1,5 @@ +--- +title: Show epic events on group activity page. +merge_request: 18869 +author: +type: added diff --git a/changelogs/unreleased/expose-name-property-in-import-api.yml b/changelogs/unreleased/expose-name-property-in-import-api.yml new file mode 100644 index 00000000000..9a0fb581321 --- /dev/null +++ b/changelogs/unreleased/expose-name-property-in-import-api.yml @@ -0,0 +1,5 @@ +--- +title: Expose name property in imports API +merge_request: 16848 +author: +type: added diff --git a/changelogs/unreleased/feat-user-mode-in-session-for-admins.yml b/changelogs/unreleased/feat-user-mode-in-session-for-admins.yml new file mode 100644 index 00000000000..ea8760d5224 --- /dev/null +++ b/changelogs/unreleased/feat-user-mode-in-session-for-admins.yml @@ -0,0 +1,6 @@ +--- +title: Require admins to enter admin-mode by re-authenticating before performing + administrative operations +merge_request: 16981 +author: Roger Rüttimann & Diego Louzán +type: added diff --git a/changelogs/unreleased/feature-add-copyable-login-with-copy-to-empty-container-registry-view.yml b/changelogs/unreleased/feature-add-copyable-login-with-copy-to-empty-container-registry-view.yml new file mode 100644 index 00000000000..6d7a773120b --- /dev/null +++ b/changelogs/unreleased/feature-add-copyable-login-with-copy-to-empty-container-registry-view.yml @@ -0,0 +1,5 @@ +--- +title: Adds login input with copy box and supporting copy to empty container registry view +merge_request: 18244 +author: nate geslin +type: added diff --git a/changelogs/unreleased/feature-default-cluster-to-vpc-enabled.yml b/changelogs/unreleased/feature-default-cluster-to-vpc-enabled.yml new file mode 100644 index 00000000000..feb000554a8 --- /dev/null +++ b/changelogs/unreleased/feature-default-cluster-to-vpc-enabled.yml @@ -0,0 +1,5 @@ +--- +title: Create clusters with VPC-Native enabled +merge_request: 18284 +author: +type: changed diff --git a/changelogs/unreleased/feature-ignore-prometheus-metrics-not-present.yml b/changelogs/unreleased/feature-ignore-prometheus-metrics-not-present.yml new file mode 100644 index 00000000000..ab480548387 --- /dev/null +++ b/changelogs/unreleased/feature-ignore-prometheus-metrics-not-present.yml @@ -0,0 +1,5 @@ +--- +title: Avoid knative and prometheus uninstall race condition +merge_request: 18020 +author: +type: changed diff --git a/changelogs/unreleased/fix-cache-expiration-new-wiki-page.yml b/changelogs/unreleased/fix-cache-expiration-new-wiki-page.yml new file mode 100644 index 00000000000..7bc0205ff1a --- /dev/null +++ b/changelogs/unreleased/fix-cache-expiration-new-wiki-page.yml @@ -0,0 +1,5 @@ +--- +title: Fix bug with new wiki not being indexed +merge_request: 18051 +author: +type: fixed diff --git a/changelogs/unreleased/fix-moved-help-doc-administration-monitoring-performance.yml b/changelogs/unreleased/fix-moved-help-doc-administration-monitoring-performance.yml new file mode 100644 index 00000000000..2fe34855ee8 --- /dev/null +++ b/changelogs/unreleased/fix-moved-help-doc-administration-monitoring-performance.yml @@ -0,0 +1,5 @@ +--- +title: Fix moved help URL for monitoring performance +merge_request: +author: +type: fixed diff --git a/changelogs/unreleased/fix-n-plus-one-in-jira-github-api.yml b/changelogs/unreleased/fix-n-plus-one-in-jira-github-api.yml new file mode 100644 index 00000000000..f8cc5985b0f --- /dev/null +++ b/changelogs/unreleased/fix-n-plus-one-in-jira-github-api.yml @@ -0,0 +1,5 @@ +--- +title: Fix N+1 queries in Jira Development Panel API endpoint +merge_request: 18329 +author: +type: performance diff --git a/changelogs/unreleased/fix-service-desk-forward.yml b/changelogs/unreleased/fix-service-desk-forward.yml new file mode 100644 index 00000000000..e675eaf9b39 --- /dev/null +++ b/changelogs/unreleased/fix-service-desk-forward.yml @@ -0,0 +1,6 @@ +--- +title: Do not strip forwarded message body when creating an issue from Service Desk + email. +merge_request: 18196 +author: +type: fixed diff --git a/changelogs/unreleased/fix-set-status-emoji-button.yml b/changelogs/unreleased/fix-set-status-emoji-button.yml new file mode 100644 index 00000000000..e7a8c119c91 --- /dev/null +++ b/changelogs/unreleased/fix-set-status-emoji-button.yml @@ -0,0 +1,5 @@ +--- +title: Fix styling of set status emoji picker +merge_request: 18509 +author: +type: fixed diff --git a/changelogs/unreleased/fj-26123-narrow-snippet-search-scope-in-com.yml b/changelogs/unreleased/fj-26123-narrow-snippet-search-scope-in-com.yml new file mode 100644 index 00000000000..a5f670257e1 --- /dev/null +++ b/changelogs/unreleased/fj-26123-narrow-snippet-search-scope-in-com.yml @@ -0,0 +1,5 @@ +--- +title: Narrow snippet search scope in GitLab.com +merge_request: 17625 +author: +type: performance diff --git a/changelogs/unreleased/fj-28429-generate-lfs-token-authorization.yml b/changelogs/unreleased/fj-28429-generate-lfs-token-authorization.yml new file mode 100644 index 00000000000..2b5ddb4ab7c --- /dev/null +++ b/changelogs/unreleased/fj-28429-generate-lfs-token-authorization.yml @@ -0,0 +1,5 @@ +--- +title: Generate LFS token authorization for user LFS requests +merge_request: 17332 +author: +type: fixed diff --git a/changelogs/unreleased/fj-32643-limit-snippets-search-count.yml b/changelogs/unreleased/fj-32643-limit-snippets-search-count.yml new file mode 100644 index 00000000000..8b5382f0a70 --- /dev/null +++ b/changelogs/unreleased/fj-32643-limit-snippets-search-count.yml @@ -0,0 +1,5 @@ +--- +title: Limit snippets search count +merge_request: 17585 +author: +type: performance diff --git a/changelogs/unreleased/fj-32885-add-trigram-index-snippet-content.yml b/changelogs/unreleased/fj-32885-add-trigram-index-snippet-content.yml new file mode 100644 index 00000000000..695098d41ff --- /dev/null +++ b/changelogs/unreleased/fj-32885-add-trigram-index-snippet-content.yml @@ -0,0 +1,5 @@ +--- +title: Add trigram index on snippet content +merge_request: 17806 +author: +type: performance diff --git a/changelogs/unreleased/fj-fix-smau-usage-counters.yml b/changelogs/unreleased/fj-fix-smau-usage-counters.yml new file mode 100644 index 00000000000..3bc4bb348ee --- /dev/null +++ b/changelogs/unreleased/fj-fix-smau-usage-counters.yml @@ -0,0 +1,5 @@ +--- +title: Move SMAU usage counters to the UsageData count field +merge_request: 17074 +author: +type: fixed diff --git a/changelogs/unreleased/fork_gitlab_ci.yml b/changelogs/unreleased/fork_gitlab_ci.yml new file mode 100644 index 00000000000..4b64fe735dd --- /dev/null +++ b/changelogs/unreleased/fork_gitlab_ci.yml @@ -0,0 +1,5 @@ +--- +title: Preserve custom .gitlab-ci.yml config path when forking. +merge_request: 17817 +author: Mathieu Parent +type: added diff --git a/changelogs/unreleased/geo-mk-add-custom-http-clone-url-root.yml b/changelogs/unreleased/geo-mk-add-custom-http-clone-url-root.yml new file mode 100644 index 00000000000..5bd7cc1761d --- /dev/null +++ b/changelogs/unreleased/geo-mk-add-custom-http-clone-url-root.yml @@ -0,0 +1,5 @@ +--- +title: Add "Custom HTTP Git clone URL root" setting +merge_request: 18422 +author: +type: added diff --git a/changelogs/unreleased/georgekoltsov-add-github-importer-filtering.yml b/changelogs/unreleased/georgekoltsov-add-github-importer-filtering.yml new file mode 100644 index 00000000000..9c7a8caea66 --- /dev/null +++ b/changelogs/unreleased/georgekoltsov-add-github-importer-filtering.yml @@ -0,0 +1,5 @@ +--- +title: Add GitHub & Gitea importers project filtering +merge_request: 16823 +author: +type: added diff --git a/changelogs/unreleased/georgekoltsov-bitbucket-cloud-import-filtering.yml b/changelogs/unreleased/georgekoltsov-bitbucket-cloud-import-filtering.yml new file mode 100644 index 00000000000..8fdbdb20d28 --- /dev/null +++ b/changelogs/unreleased/georgekoltsov-bitbucket-cloud-import-filtering.yml @@ -0,0 +1,5 @@ +--- +title: Add project filtering to Bitbucket Cloud import +merge_request: 16828 +author: +type: added diff --git a/changelogs/unreleased/gitaly-1-64.yml b/changelogs/unreleased/gitaly-1-64.yml new file mode 100644 index 00000000000..53ae64c9830 --- /dev/null +++ b/changelogs/unreleased/gitaly-1-64.yml @@ -0,0 +1,5 @@ +--- +title: Upgrade Gitaly to v1.64 +merge_request: 16788 +author: +type: added diff --git a/changelogs/unreleased/gitaly-version-v1.66.0.yml b/changelogs/unreleased/gitaly-version-v1.66.0.yml new file mode 100644 index 00000000000..41a0e1ab87a --- /dev/null +++ b/changelogs/unreleased/gitaly-version-v1.66.0.yml @@ -0,0 +1,5 @@ +--- +title: Upgrade to Gitaly v1.66.0 +merge_request: 17900 +author: +type: changed diff --git a/changelogs/unreleased/gitaly-version-v1.67.0.yml b/changelogs/unreleased/gitaly-version-v1.67.0.yml new file mode 100644 index 00000000000..03846e4d4d8 --- /dev/null +++ b/changelogs/unreleased/gitaly-version-v1.67.0.yml @@ -0,0 +1,5 @@ +--- +title: Upgrade to Gitaly v1.67.0 +merge_request: 18326 +author: +type: changed diff --git a/changelogs/unreleased/github-release-importer-fixup.yml b/changelogs/unreleased/github-release-importer-fixup.yml new file mode 100644 index 00000000000..3c688426ad2 --- /dev/null +++ b/changelogs/unreleased/github-release-importer-fixup.yml @@ -0,0 +1,5 @@ +--- +title: Set name and updated_at properly in GitHub ReleaseImporter +merge_request: 17020 +author: +type: fixed diff --git a/changelogs/unreleased/graphql-epic-mutate.yml b/changelogs/unreleased/graphql-epic-mutate.yml new file mode 100644 index 00000000000..322c069aa46 --- /dev/null +++ b/changelogs/unreleased/graphql-epic-mutate.yml @@ -0,0 +1,5 @@ +--- +title: Add support for epic update through GraphQL API. +merge_request: 18440 +author: +type: added diff --git a/changelogs/unreleased/group_default_visibility.yml b/changelogs/unreleased/group_default_visibility.yml new file mode 100644 index 00000000000..3816223c066 --- /dev/null +++ b/changelogs/unreleased/group_default_visibility.yml @@ -0,0 +1,5 @@ +--- +title: Fix visibility level error when updating group from API +merge_request: 17227 +author: Mathieu Parent +type: fixed diff --git a/changelogs/unreleased/groups_api.yml b/changelogs/unreleased/groups_api.yml new file mode 100644 index 00000000000..09e85c45811 --- /dev/null +++ b/changelogs/unreleased/groups_api.yml @@ -0,0 +1,5 @@ +--- +title: 'API: Add missing group parameters' +merge_request: 17220 +author: Mathieu Parent +type: added diff --git a/changelogs/unreleased/id-blame-controller-performance.yml b/changelogs/unreleased/id-blame-controller-performance.yml new file mode 100644 index 00000000000..2f7477adfde --- /dev/null +++ b/changelogs/unreleased/id-blame-controller-performance.yml @@ -0,0 +1,5 @@ +--- +title: Optimize SQL requests for BlameController and CommitsController +merge_request: 18342 +author: +type: performance diff --git a/changelogs/unreleased/id-cleanup-anny-approver-migrations.yml b/changelogs/unreleased/id-cleanup-anny-approver-migrations.yml new file mode 100644 index 00000000000..979250d4762 --- /dev/null +++ b/changelogs/unreleased/id-cleanup-anny-approver-migrations.yml @@ -0,0 +1,5 @@ +--- +title: Cleanup background migrations for any approval rules +merge_request: 18256 +author: +type: changed diff --git a/changelogs/unreleased/id-fix-nplus1-for-signatures.yml b/changelogs/unreleased/id-fix-nplus1-for-signatures.yml new file mode 100644 index 00000000000..e060c771227 --- /dev/null +++ b/changelogs/unreleased/id-fix-nplus1-for-signatures.yml @@ -0,0 +1,5 @@ +--- +title: Remove N+1 for fetching commits signatures +merge_request: 18389 +author: +type: performance diff --git a/changelogs/unreleased/id-merge-request-dependencies.yml b/changelogs/unreleased/id-merge-request-dependencies.yml new file mode 100644 index 00000000000..7532979a9f6 --- /dev/null +++ b/changelogs/unreleased/id-merge-request-dependencies.yml @@ -0,0 +1,5 @@ +--- +title: Allow intra-project MR dependencies +merge_request: 16799 +author: +type: changed diff --git a/changelogs/unreleased/ignore-autreply.yml b/changelogs/unreleased/ignore-autreply.yml new file mode 100644 index 00000000000..69f9885a16f --- /dev/null +++ b/changelogs/unreleased/ignore-autreply.yml @@ -0,0 +1,5 @@ +--- +title: Ignore incoming emails with X-Autoreply header. +merge_request: 18118 +author: +type: fixed diff --git a/changelogs/unreleased/ignore-id-column-ci_build_trace_sections.yml b/changelogs/unreleased/ignore-id-column-ci_build_trace_sections.yml new file mode 100644 index 00000000000..4208273be19 --- /dev/null +++ b/changelogs/unreleased/ignore-id-column-ci_build_trace_sections.yml @@ -0,0 +1,5 @@ +--- +title: Ignore id column of ci_build_trace_sections table +merge_request: 17805 +author: +type: change diff --git a/changelogs/unreleased/improve-search-empty-message.yml b/changelogs/unreleased/improve-search-empty-message.yml new file mode 100644 index 00000000000..cc9692c4fd6 --- /dev/null +++ b/changelogs/unreleased/improve-search-empty-message.yml @@ -0,0 +1,5 @@ +--- +title: Use search scope label in empty results message +merge_request: 16324 +author: +type: changed diff --git a/changelogs/unreleased/increase-limit-for-recursively-include.yml b/changelogs/unreleased/increase-limit-for-recursively-include.yml new file mode 100644 index 00000000000..5fed53e8f24 --- /dev/null +++ b/changelogs/unreleased/increase-limit-for-recursively-include.yml @@ -0,0 +1,5 @@ +--- +title: Increase the limit of includes in CI file to 100 +merge_request: 17807 +author: +type: fixed diff --git a/changelogs/unreleased/internationalization-time-series-wrapper.yml b/changelogs/unreleased/internationalization-time-series-wrapper.yml new file mode 100644 index 00000000000..b49a2875c1c --- /dev/null +++ b/changelogs/unreleased/internationalization-time-series-wrapper.yml @@ -0,0 +1,5 @@ +--- +title: Provides internationalization support to chart legends +merge_request: 16832 +author: +type: added diff --git a/changelogs/unreleased/introduce-feature-flag-api.yml b/changelogs/unreleased/introduce-feature-flag-api.yml new file mode 100644 index 00000000000..fa6c3be302f --- /dev/null +++ b/changelogs/unreleased/introduce-feature-flag-api.yml @@ -0,0 +1,5 @@ +--- +title: Support Create/Read/Destroy operations in Feature Flag API +merge_request: 18198 +author: +type: added diff --git a/changelogs/unreleased/issue_11240.yml b/changelogs/unreleased/issue_11240.yml new file mode 100644 index 00000000000..751440d1e8c --- /dev/null +++ b/changelogs/unreleased/issue_11240.yml @@ -0,0 +1,5 @@ +--- +title: Expose subscribed attribute for epic on API +merge_request: 18475 +author: +type: added diff --git a/changelogs/unreleased/issue_11241.yml b/changelogs/unreleased/issue_11241.yml new file mode 100644 index 00000000000..ff9364b4b5b --- /dev/null +++ b/changelogs/unreleased/issue_11241.yml @@ -0,0 +1,5 @@ +--- +title: Expose web_url for epics on API +merge_request: 17380 +author: +type: added diff --git a/changelogs/unreleased/issue_26823_sync_state_id.yml b/changelogs/unreleased/issue_26823_sync_state_id.yml new file mode 100644 index 00000000000..fd3993d3b65 --- /dev/null +++ b/changelogs/unreleased/issue_26823_sync_state_id.yml @@ -0,0 +1,5 @@ +--- +title: Sync issuables state_id with null values +merge_request: 16480 +author: +type: other diff --git a/changelogs/unreleased/issue_28457.yml b/changelogs/unreleased/issue_28457.yml new file mode 100644 index 00000000000..51e19660ffc --- /dev/null +++ b/changelogs/unreleased/issue_28457.yml @@ -0,0 +1,5 @@ +--- +title: Deprecate usage of state column for issues and merge requests +merge_request: 18099 +author: +type: changed diff --git a/changelogs/unreleased/issue_32364.yml b/changelogs/unreleased/issue_32364.yml new file mode 100644 index 00000000000..c68115ed707 --- /dev/null +++ b/changelogs/unreleased/issue_32364.yml @@ -0,0 +1,5 @@ +--- +title: Fix permissions for group milestones +merge_request: +author: +type: fixed diff --git a/changelogs/unreleased/jc-add-config-options-for-partial-clone.yml b/changelogs/unreleased/jc-add-config-options-for-partial-clone.yml new file mode 100644 index 00000000000..72a6339aa78 --- /dev/null +++ b/changelogs/unreleased/jc-add-config-options-for-partial-clone.yml @@ -0,0 +1,5 @@ +--- +title: Add allowFilter and allowAnySHA1InWant for partial clones +merge_request: 16850 +author: +type: added diff --git a/changelogs/unreleased/jc-optimize-uri-type.yml b/changelogs/unreleased/jc-optimize-uri-type.yml new file mode 100644 index 00000000000..41625abe072 --- /dev/null +++ b/changelogs/unreleased/jc-optimize-uri-type.yml @@ -0,0 +1,5 @@ +--- +title: Use GetBlobs RPC for uri type +merge_request: 16824 +author: +type: performance diff --git a/changelogs/unreleased/jc-remove-cleanup-rake-tasks.yml b/changelogs/unreleased/jc-remove-cleanup-rake-tasks.yml new file mode 100644 index 00000000000..fd2d0e323e8 --- /dev/null +++ b/changelogs/unreleased/jc-remove-cleanup-rake-tasks.yml @@ -0,0 +1,5 @@ +--- +title: Removing cleanup:repo, cleanup:dirs +merge_request: 18087 +author: +type: deprecated diff --git a/changelogs/unreleased/job_file_matching.yml b/changelogs/unreleased/job_file_matching.yml new file mode 100644 index 00000000000..e74878471bd --- /dev/null +++ b/changelogs/unreleased/job_file_matching.yml @@ -0,0 +1,5 @@ +--- +title: Add file matching rule to flexible CI rules +merge_request: 16574 +author: +type: added diff --git a/changelogs/unreleased/jramsay-clarify-git-lfs-push-rule-behavior.yml b/changelogs/unreleased/jramsay-clarify-git-lfs-push-rule-behavior.yml new file mode 100644 index 00000000000..ca85114e5ac --- /dev/null +++ b/changelogs/unreleased/jramsay-clarify-git-lfs-push-rule-behavior.yml @@ -0,0 +1,5 @@ +--- +title: Document Git LFS and max file size interaction +merge_request: 17609 +author: +type: other diff --git a/changelogs/unreleased/knative-0-7.yml b/changelogs/unreleased/knative-0-7.yml new file mode 100644 index 00000000000..71c661bf306 --- /dev/null +++ b/changelogs/unreleased/knative-0-7.yml @@ -0,0 +1,5 @@ +--- +title: Knative version bump 0.6 -> 0.7 +merge_request: 17367 +author: Chris Baumbauer +type: changed diff --git a/changelogs/unreleased/labels_rest.yml b/changelogs/unreleased/labels_rest.yml new file mode 100644 index 00000000000..e2b37ee2a11 --- /dev/null +++ b/changelogs/unreleased/labels_rest.yml @@ -0,0 +1,5 @@ +--- +title: Add proper label REST API for update, delete and promote +merge_request: 17239 +author: Mathieu Parent +type: added diff --git a/changelogs/unreleased/mc-bug-omips-not-blocking-on-skipped-pipelines.yml b/changelogs/unreleased/mc-bug-omips-not-blocking-on-skipped-pipelines.yml new file mode 100644 index 00000000000..560b4de81a0 --- /dev/null +++ b/changelogs/unreleased/mc-bug-omips-not-blocking-on-skipped-pipelines.yml @@ -0,0 +1,5 @@ +--- +title: Block MR with OMIPS on skipped pipelines. +merge_request: 18838 +author: +type: fixed diff --git a/changelogs/unreleased/mc-feature-show-setup-cicd-empty-repo.yml b/changelogs/unreleased/mc-feature-show-setup-cicd-empty-repo.yml new file mode 100644 index 00000000000..3165159fdab --- /dev/null +++ b/changelogs/unreleased/mc-feature-show-setup-cicd-empty-repo.yml @@ -0,0 +1,5 @@ +--- +title: Show the "Set up CI/CD" prompt in empty repositories when applicable. +merge_request: 17274 +author: Ben McCormick +type: changed diff --git a/changelogs/unreleased/mc-fixes-wrong-link-on-protected-paths-admin-ui.yml b/changelogs/unreleased/mc-fixes-wrong-link-on-protected-paths-admin-ui.yml new file mode 100644 index 00000000000..61e54f2f5e0 --- /dev/null +++ b/changelogs/unreleased/mc-fixes-wrong-link-on-protected-paths-admin-ui.yml @@ -0,0 +1,5 @@ +--- +title: Fixes wrong link on Protected paths admin settings +merge_request: 17945 +author: +type: other diff --git a/changelogs/unreleased/mc-moves-protected-path-throttle-to-gitlab-rails.yml b/changelogs/unreleased/mc-moves-protected-path-throttle-to-gitlab-rails.yml new file mode 100644 index 00000000000..47c6c926b42 --- /dev/null +++ b/changelogs/unreleased/mc-moves-protected-path-throttle-to-gitlab-rails.yml @@ -0,0 +1,5 @@ +--- +title: Allow users to configure protected paths from Admin panel +merge_request: 31246 +author: +type: added diff --git a/changelogs/unreleased/mfluharty-add-mr-links-to-pipeline-view.yml b/changelogs/unreleased/mfluharty-add-mr-links-to-pipeline-view.yml new file mode 100644 index 00000000000..e3bb00bc5bd --- /dev/null +++ b/changelogs/unreleased/mfluharty-add-mr-links-to-pipeline-view.yml @@ -0,0 +1,5 @@ +--- +title: Show related merge requests in pipeline view +merge_request: 18697 +author: +type: added diff --git a/changelogs/unreleased/mk-remove-flag-geo_object_storage_replication.yml b/changelogs/unreleased/mk-remove-flag-geo_object_storage_replication.yml new file mode 100644 index 00000000000..8e2c6d4b093 --- /dev/null +++ b/changelogs/unreleased/mk-remove-flag-geo_object_storage_replication.yml @@ -0,0 +1,5 @@ +--- +title: 'Geo: Enable replicating uploads, LFS objects, and artifacts in Object Storage' +merge_request: 18482 +author: +type: added diff --git a/changelogs/unreleased/mr-links-4-pipes.yml b/changelogs/unreleased/mr-links-4-pipes.yml new file mode 100644 index 00000000000..8eed38963ea --- /dev/null +++ b/changelogs/unreleased/mr-links-4-pipes.yml @@ -0,0 +1,5 @@ +--- +title: Use MR links in PipelinePresenter#ref_text for branch pipelines +merge_request: 17947 +author: +type: changed diff --git a/changelogs/unreleased/nfriend-add-edit-button-to-release-blocks.yml b/changelogs/unreleased/nfriend-add-edit-button-to-release-blocks.yml new file mode 100644 index 00000000000..ac0439f9f63 --- /dev/null +++ b/changelogs/unreleased/nfriend-add-edit-button-to-release-blocks.yml @@ -0,0 +1,5 @@ +--- +title: Add edit button to release blocks on Releases page +merge_request: 18411 +author: +type: added diff --git a/changelogs/unreleased/nfriend-add-edit-release-page.yml b/changelogs/unreleased/nfriend-add-edit-release-page.yml new file mode 100644 index 00000000000..5369ab6b19c --- /dev/null +++ b/changelogs/unreleased/nfriend-add-edit-release-page.yml @@ -0,0 +1,5 @@ +--- +title: Add "Edit Release" page +merge_request: 18033 +author: +type: added diff --git a/changelogs/unreleased/nfriend-allow-release-page-anchor-scrolling.yml b/changelogs/unreleased/nfriend-allow-release-page-anchor-scrolling.yml new file mode 100644 index 00000000000..7b30852eba4 --- /dev/null +++ b/changelogs/unreleased/nfriend-allow-release-page-anchor-scrolling.yml @@ -0,0 +1,5 @@ +--- +title: Allow releases to be targeted by URL anchor links on the Releases page +merge_request: 17150 +author: +type: added diff --git a/changelogs/unreleased/nfriend-fix-lin.yml b/changelogs/unreleased/nfriend-fix-lin.yml new file mode 100644 index 00000000000..0b16eb9c1f4 --- /dev/null +++ b/changelogs/unreleased/nfriend-fix-lin.yml @@ -0,0 +1,5 @@ +--- +title: Fix button link foreground color +merge_request: 18669 +author: +type: fixed diff --git a/changelogs/unreleased/nfriend-suppress-ajax-errors-again.yml b/changelogs/unreleased/nfriend-suppress-ajax-errors-again.yml new file mode 100644 index 00000000000..04909152aa8 --- /dev/null +++ b/changelogs/unreleased/nfriend-suppress-ajax-errors-again.yml @@ -0,0 +1,5 @@ +--- +title: Suppress error messages shown when navigating to a new page +merge_request: 17706 +author: +type: fixed diff --git a/changelogs/unreleased/not_silent_retry_failure.yml b/changelogs/unreleased/not_silent_retry_failure.yml new file mode 100644 index 00000000000..bccd046db7b --- /dev/null +++ b/changelogs/unreleased/not_silent_retry_failure.yml @@ -0,0 +1,5 @@ +--- +title: Stopped CRD apply retrying from allowing silent failures +merge_request: 18421 +author: +type: fixed diff --git a/changelogs/unreleased/osw-diffs-metadata-endpoint.yml b/changelogs/unreleased/osw-diffs-metadata-endpoint.yml new file mode 100644 index 00000000000..c8da00249f1 --- /dev/null +++ b/changelogs/unreleased/osw-diffs-metadata-endpoint.yml @@ -0,0 +1,5 @@ +--- +title: Introduce a lightweight diffs_metadata endpoint +merge_request: 18104 +author: +type: added diff --git a/changelogs/unreleased/osw-unnappliable-suggestion-on-expanded-lines.yml b/changelogs/unreleased/osw-unnappliable-suggestion-on-expanded-lines.yml new file mode 100644 index 00000000000..726ac455466 --- /dev/null +++ b/changelogs/unreleased/osw-unnappliable-suggestion-on-expanded-lines.yml @@ -0,0 +1,5 @@ +--- +title: Adjust unnapliable suggestions in expanded lines +merge_request: 17286 +author: +type: fixed diff --git a/changelogs/unreleased/pages-1-11-0.yml b/changelogs/unreleased/pages-1-11-0.yml new file mode 100644 index 00000000000..da798340ee2 --- /dev/null +++ b/changelogs/unreleased/pages-1-11-0.yml @@ -0,0 +1,5 @@ +--- +title: Update Pages to v1.11.0 +merge_request: 18010 +author: +type: other diff --git a/changelogs/unreleased/pages-per-project-size-limit-db.yml b/changelogs/unreleased/pages-per-project-size-limit-db.yml new file mode 100644 index 00000000000..97a24b356e6 --- /dev/null +++ b/changelogs/unreleased/pages-per-project-size-limit-db.yml @@ -0,0 +1,5 @@ +--- +title: Add columns for per project/group max pages/artifacts sizes +merge_request: 17231 +author: +type: added diff --git a/changelogs/unreleased/patch-29.yml b/changelogs/unreleased/patch-29.yml new file mode 100644 index 00000000000..e5e1d639a69 --- /dev/null +++ b/changelogs/unreleased/patch-29.yml @@ -0,0 +1,5 @@ +--- +title: Better job naming for Docker.gitlab-ci.yml +merge_request: 17218 +author: luca.orlandi@gmail.com +type: other diff --git a/changelogs/unreleased/performance-bar-warnings.yml b/changelogs/unreleased/performance-bar-warnings.yml new file mode 100644 index 00000000000..d1d02ce9b94 --- /dev/null +++ b/changelogs/unreleased/performance-bar-warnings.yml @@ -0,0 +1,5 @@ +--- +title: Add warnings to performance bar when page shows signs of poor performance +merge_request: 17612 +author: +type: changed diff --git a/changelogs/unreleased/preview_private_artifacts.yml b/changelogs/unreleased/preview_private_artifacts.yml new file mode 100644 index 00000000000..9f5caad624c --- /dev/null +++ b/changelogs/unreleased/preview_private_artifacts.yml @@ -0,0 +1,5 @@ +--- +title: Enable preview of private artifacts +merge_request: 16675 +author: Tuomo Ala-Vannesluoma +type: added diff --git a/changelogs/unreleased/psi-indy-embed-zooms.yml b/changelogs/unreleased/psi-indy-embed-zooms.yml new file mode 100644 index 00000000000..a05977664f3 --- /dev/null +++ b/changelogs/unreleased/psi-indy-embed-zooms.yml @@ -0,0 +1,5 @@ +--- +title: Embed metrics time window scroll no longer affects other embeds +merge_request: 18109 +author: +type: fixed diff --git a/changelogs/unreleased/psi-responsive-error-tracking.yml b/changelogs/unreleased/psi-responsive-error-tracking.yml new file mode 100644 index 00000000000..36be17d7bf0 --- /dev/null +++ b/changelogs/unreleased/psi-responsive-error-tracking.yml @@ -0,0 +1,5 @@ +--- +title: Fix error tracking table layout on small screens +merge_request: 18325 +author: +type: fixed diff --git a/changelogs/unreleased/rd-fix-show-trial-errors-helper.yml b/changelogs/unreleased/rd-fix-show-trial-errors-helper.yml new file mode 100644 index 00000000000..ddcc5f34676 --- /dev/null +++ b/changelogs/unreleased/rd-fix-show-trial-errors-helper.yml @@ -0,0 +1,5 @@ +--- +title: Fix error where helper was incorrectly returning `true` +merge_request: 18231 +author: +type: fixed diff --git a/changelogs/unreleased/remove-duplicate-primary-button-in-dashboard-snippets.yml b/changelogs/unreleased/remove-duplicate-primary-button-in-dashboard-snippets.yml new file mode 100644 index 00000000000..6b08e8fbc0f --- /dev/null +++ b/changelogs/unreleased/remove-duplicate-primary-button-in-dashboard-snippets.yml @@ -0,0 +1,5 @@ +--- +title: Remove duplicate primary button in dashboard snippets +merge_request: 32048 +author: George Tsiolis +type: fixed diff --git a/changelogs/unreleased/return-error-message-when-performance-bar-group-is-not-found.yml b/changelogs/unreleased/return-error-message-when-performance-bar-group-is-not-found.yml new file mode 100644 index 00000000000..1d00597ba7d --- /dev/null +++ b/changelogs/unreleased/return-error-message-when-performance-bar-group-is-not-found.yml @@ -0,0 +1,5 @@ +--- +title: Show error message when setting an invalid group ID for the performance bar +merge_request: +author: +type: fixed diff --git a/changelogs/unreleased/sec-rep-mr-fixes.yml b/changelogs/unreleased/sec-rep-mr-fixes.yml new file mode 100644 index 00000000000..30e4a367552 --- /dev/null +++ b/changelogs/unreleased/sec-rep-mr-fixes.yml @@ -0,0 +1,5 @@ +--- +title: Fixes issues with the security reports migration +merge_request: 17519 +author: +type: fixed diff --git a/changelogs/unreleased/security-12630-private-system-note-disclosed-in-graphql.yml b/changelogs/unreleased/security-12630-private-system-note-disclosed-in-graphql.yml new file mode 100644 index 00000000000..03658c931a3 --- /dev/null +++ b/changelogs/unreleased/security-12630-private-system-note-disclosed-in-graphql.yml @@ -0,0 +1,6 @@ +--- +title: Add a policy check for system notes that may not be visible due to cross references + to private items +merge_request: +author: +type: security diff --git a/changelogs/unreleased/security-12717-fix-confidential-issue-assignee-visible-to-guests.yml b/changelogs/unreleased/security-12717-fix-confidential-issue-assignee-visible-to-guests.yml new file mode 100644 index 00000000000..574f9f8283c --- /dev/null +++ b/changelogs/unreleased/security-12717-fix-confidential-issue-assignee-visible-to-guests.yml @@ -0,0 +1,5 @@ +--- +title: Display only participants that user has permission to see on milestone page +merge_request: +author: +type: security diff --git a/changelogs/unreleased/security-12718-project-milestones-disclosed-via-groups.yml b/changelogs/unreleased/security-12718-project-milestones-disclosed-via-groups.yml new file mode 100644 index 00000000000..7625655cadd --- /dev/null +++ b/changelogs/unreleased/security-12718-project-milestones-disclosed-via-groups.yml @@ -0,0 +1,6 @@ +--- +title: Do not disclose project milestones on group milestones page when project milestones + access is disabled in project settings +merge_request: +author: +type: security diff --git a/changelogs/unreleased/security-13338-fix-head-pipeline-leak.yml b/changelogs/unreleased/security-13338-fix-head-pipeline-leak.yml new file mode 100644 index 00000000000..1091a302aba --- /dev/null +++ b/changelogs/unreleased/security-13338-fix-head-pipeline-leak.yml @@ -0,0 +1,5 @@ +--- +title: Check permissions before showing head pipeline blocking merge requests +merge_request: +author: +type: security diff --git a/changelogs/unreleased/security-29491.yml b/changelogs/unreleased/security-29491.yml new file mode 100644 index 00000000000..ec4ada47c62 --- /dev/null +++ b/changelogs/unreleased/security-29491.yml @@ -0,0 +1,5 @@ +--- +title: Fix private feature Elasticsearch leak +merge_request: +author: +type: security diff --git a/changelogs/unreleased/security-64938-dont-disclose-path.yml b/changelogs/unreleased/security-64938-dont-disclose-path.yml new file mode 100644 index 00000000000..0c858401233 --- /dev/null +++ b/changelogs/unreleased/security-64938-dont-disclose-path.yml @@ -0,0 +1,6 @@ +--- +title: Fix new project path being disclosed through unsubscribe link of issue/merge + requests +merge_request: +author: +type: security diff --git a/changelogs/unreleased/security-bypass-email-verification-using-salesforce.yml b/changelogs/unreleased/security-bypass-email-verification-using-salesforce.yml new file mode 100644 index 00000000000..20b841b68f8 --- /dev/null +++ b/changelogs/unreleased/security-bypass-email-verification-using-salesforce.yml @@ -0,0 +1,5 @@ +--- +title: Prevent bypassing email verification using Salesforce +merge_request: +author: +type: security diff --git a/changelogs/unreleased/security-cross-reference-fix.yml b/changelogs/unreleased/security-cross-reference-fix.yml new file mode 100644 index 00000000000..15d6509fd63 --- /dev/null +++ b/changelogs/unreleased/security-cross-reference-fix.yml @@ -0,0 +1,5 @@ +--- +title: Do not show resource label events referencing not accessible labels. +merge_request: +author: +type: security diff --git a/changelogs/unreleased/security-fp-stop-jobs-when-blocking-user.yml b/changelogs/unreleased/security-fp-stop-jobs-when-blocking-user.yml new file mode 100644 index 00000000000..1bc4345d5b6 --- /dev/null +++ b/changelogs/unreleased/security-fp-stop-jobs-when-blocking-user.yml @@ -0,0 +1,5 @@ +--- +title: Cancel all running CI jobs triggered by the user who is just blocked +merge_request: +author: +type: security diff --git a/changelogs/unreleased/security-gitaly-1-65-1.yml b/changelogs/unreleased/security-gitaly-1-65-1.yml new file mode 100644 index 00000000000..e532a8aba9f --- /dev/null +++ b/changelogs/unreleased/security-gitaly-1-65-1.yml @@ -0,0 +1,5 @@ +--- +title: Fix Gitaly SearchBlobs flag RPC injection +merge_request: +author: +type: security diff --git a/changelogs/unreleased/security-mermaid-block.yml b/changelogs/unreleased/security-mermaid-block.yml new file mode 100644 index 00000000000..993e8cfec08 --- /dev/null +++ b/changelogs/unreleased/security-mermaid-block.yml @@ -0,0 +1,5 @@ +--- +title: Only render fixed number of mermaid blocks +merge_request: +author: +type: security diff --git a/changelogs/unreleased/security-sarcila-verify-saml-request-origin.yml b/changelogs/unreleased/security-sarcila-verify-saml-request-origin.yml new file mode 100644 index 00000000000..9022bc8a26f --- /dev/null +++ b/changelogs/unreleased/security-sarcila-verify-saml-request-origin.yml @@ -0,0 +1,5 @@ +--- +title: Prevent GitLab accounts takeover if SAML is configured +merge_request: +author: +type: security diff --git a/changelogs/unreleased/security-search-by-iid-leaks-data.yml b/changelogs/unreleased/security-search-by-iid-leaks-data.yml new file mode 100644 index 00000000000..cf68fe504de --- /dev/null +++ b/changelogs/unreleased/security-search-by-iid-leaks-data.yml @@ -0,0 +1,6 @@ +--- +title: Limit search for IID to a type to avoid leaking records with the same IID that + the user does not have access to +merge_request: +author: +type: security diff --git a/changelogs/unreleased/sh-bump-rouge-3-11-0.yml b/changelogs/unreleased/sh-bump-rouge-3-11-0.yml new file mode 100644 index 00000000000..6ef44fcbafc --- /dev/null +++ b/changelogs/unreleased/sh-bump-rouge-3-11-0.yml @@ -0,0 +1,5 @@ +--- +title: Upgrade Rouge to v3.11.0 +merge_request: 17011 +author: +type: other diff --git a/changelogs/unreleased/sh-disable-pager-on-small-counts.yml b/changelogs/unreleased/sh-disable-pager-on-small-counts.yml new file mode 100644 index 00000000000..1d86d9aaf94 --- /dev/null +++ b/changelogs/unreleased/sh-disable-pager-on-small-counts.yml @@ -0,0 +1,5 @@ +--- +title: Fix erroneous "No activities found" message +merge_request: 18434 +author: +type: fixed diff --git a/changelogs/unreleased/sh-enable-google-api-retries.yml b/changelogs/unreleased/sh-enable-google-api-retries.yml new file mode 100644 index 00000000000..5c6b10faa91 --- /dev/null +++ b/changelogs/unreleased/sh-enable-google-api-retries.yml @@ -0,0 +1,5 @@ +--- +title: Enable Google API retries for uploads +merge_request: 18040 +author: +type: fixed diff --git a/changelogs/unreleased/sh-fix-gitaly-nplus-one-issues-related-mrs.yml b/changelogs/unreleased/sh-fix-gitaly-nplus-one-issues-related-mrs.yml new file mode 100644 index 00000000000..4cc0e8f0746 --- /dev/null +++ b/changelogs/unreleased/sh-fix-gitaly-nplus-one-issues-related-mrs.yml @@ -0,0 +1,5 @@ +--- +title: Fix Gitaly N+1 queries in related merge requests API +merge_request: 17850 +author: +type: performance diff --git a/changelogs/unreleased/sh-fix-project-export-for-pipelines-for-mrs.yml b/changelogs/unreleased/sh-fix-project-export-for-pipelines-for-mrs.yml new file mode 100644 index 00000000000..1236255e3fd --- /dev/null +++ b/changelogs/unreleased/sh-fix-project-export-for-pipelines-for-mrs.yml @@ -0,0 +1,5 @@ +--- +title: Fix project imports for pipelines for merge requests +merge_request: 17799 +author: +type: fixed diff --git a/changelogs/unreleased/sh-fix-snippet-visibility-api.yml b/changelogs/unreleased/sh-fix-snippet-visibility-api.yml new file mode 100644 index 00000000000..837da277179 --- /dev/null +++ b/changelogs/unreleased/sh-fix-snippet-visibility-api.yml @@ -0,0 +1,5 @@ +--- +title: Fix inability to set snippet visibility via API +merge_request: 18612 +author: +type: fixed diff --git a/changelogs/unreleased/sh-github-import-handle-nil-dates.yml b/changelogs/unreleased/sh-github-import-handle-nil-dates.yml new file mode 100644 index 00000000000..d9b350a5197 --- /dev/null +++ b/changelogs/unreleased/sh-github-import-handle-nil-dates.yml @@ -0,0 +1,5 @@ +--- +title: 'GitHub import: Handle nil published_at dates' +merge_request: 18355 +author: +type: fixed diff --git a/changelogs/unreleased/sh-handle-exceptions-sidekiq.yml b/changelogs/unreleased/sh-handle-exceptions-sidekiq.yml new file mode 100644 index 00000000000..e2569d5beb5 --- /dev/null +++ b/changelogs/unreleased/sh-handle-exceptions-sidekiq.yml @@ -0,0 +1,5 @@ +--- +title: Log Sidekiq exceptions properly in JSON format +merge_request: 17412 +author: +type: fixed diff --git a/changelogs/unreleased/sh-hide-license-breakdown.yml b/changelogs/unreleased/sh-hide-license-breakdown.yml new file mode 100644 index 00000000000..f6b8efdc773 --- /dev/null +++ b/changelogs/unreleased/sh-hide-license-breakdown.yml @@ -0,0 +1,5 @@ +--- +title: Hide license breakdown in /admin if user count is high +merge_request: 18825 +author: +type: performance diff --git a/changelogs/unreleased/sh-limit-diverging-commit-counts.yml b/changelogs/unreleased/sh-limit-diverging-commit-counts.yml new file mode 100644 index 00000000000..8f0acf879cf --- /dev/null +++ b/changelogs/unreleased/sh-limit-diverging-commit-counts.yml @@ -0,0 +1,5 @@ +--- +title: Limit diverging commit counts requests +merge_request: 16737 +author: +type: performance diff --git a/changelogs/unreleased/sh-move-mr-diff-after-commit.yml b/changelogs/unreleased/sh-move-mr-diff-after-commit.yml new file mode 100644 index 00000000000..7eb1edcfe4f --- /dev/null +++ b/changelogs/unreleased/sh-move-mr-diff-after-commit.yml @@ -0,0 +1,5 @@ +--- +title: Reduce idle in transaction time when updating a merge request +merge_request: 18493 +author: +type: performance diff --git a/changelogs/unreleased/sh-use-template-project-id-backend.yml b/changelogs/unreleased/sh-use-template-project-id-backend.yml new file mode 100644 index 00000000000..00be1dcbd42 --- /dev/null +++ b/changelogs/unreleased/sh-use-template-project-id-backend.yml @@ -0,0 +1,5 @@ +--- +title: Add backend support for selecting custom templates by ID +merge_request: 18178 +author: +type: fixed diff --git a/changelogs/unreleased/show-correct-link-in-mr-pipelines.yml b/changelogs/unreleased/show-correct-link-in-mr-pipelines.yml new file mode 100644 index 00000000000..8a4b557f716 --- /dev/null +++ b/changelogs/unreleased/show-correct-link-in-mr-pipelines.yml @@ -0,0 +1,5 @@ +--- +title: Show the original branch name and link of merge request in pipeline emails +merge_request: 17513 +author: +type: fixed diff --git a/changelogs/unreleased/sort-severity-then-confidence.yml b/changelogs/unreleased/sort-severity-then-confidence.yml new file mode 100644 index 00000000000..3c7ab63d60b --- /dev/null +++ b/changelogs/unreleased/sort-severity-then-confidence.yml @@ -0,0 +1,5 @@ +--- +title: Sort vulnerabilities by severity then confidence for dashboard and pipeline views +merge_request: 18675 +author: +type: changed diff --git a/changelogs/unreleased/stop-liveness-check-returning-incorrect-data.yml b/changelogs/unreleased/stop-liveness-check-returning-incorrect-data.yml new file mode 100644 index 00000000000..0238ac469f8 --- /dev/null +++ b/changelogs/unreleased/stop-liveness-check-returning-incorrect-data.yml @@ -0,0 +1,5 @@ +--- +title: Changes response body of liveness check to be more accurate +merge_request: 17655 +author: +type: changed diff --git a/changelogs/unreleased/stop-showing-new-issue-button-when-project-is-archived.yml b/changelogs/unreleased/stop-showing-new-issue-button-when-project-is-archived.yml new file mode 100644 index 00000000000..f786df41528 --- /dev/null +++ b/changelogs/unreleased/stop-showing-new-issue-button-when-project-is-archived.yml @@ -0,0 +1,5 @@ +--- +title: Do not show new issue button on archived projects +merge_request: 18590 +author: +type: changed diff --git a/changelogs/unreleased/stop-the-expand-button-expanding.yml b/changelogs/unreleased/stop-the-expand-button-expanding.yml new file mode 100644 index 00000000000..f722e17707a --- /dev/null +++ b/changelogs/unreleased/stop-the-expand-button-expanding.yml @@ -0,0 +1,5 @@ +--- +title: Stops the expand button in reports from expanding +merge_request: 18064 +author: +type: fixed diff --git a/changelogs/unreleased/sy-grafana-auth-be.yml b/changelogs/unreleased/sy-grafana-auth-be.yml new file mode 100644 index 00000000000..3fbd53f9e98 --- /dev/null +++ b/changelogs/unreleased/sy-grafana-auth-be.yml @@ -0,0 +1,5 @@ +--- +title: Create table for grafana api token for metrics embeds +merge_request: 17234 +author: +type: added diff --git a/changelogs/unreleased/sy-grafana-proxy.yml b/changelogs/unreleased/sy-grafana-proxy.yml new file mode 100644 index 00000000000..2c2a3959bff --- /dev/null +++ b/changelogs/unreleased/sy-grafana-proxy.yml @@ -0,0 +1,5 @@ +--- +title: Add endpoint to proxy requests to grafana's proxy endpoint +merge_request: 18210 +author: +type: added diff --git a/changelogs/unreleased/tc-link-geo-unrepl-docs.yml b/changelogs/unreleased/tc-link-geo-unrepl-docs.yml new file mode 100644 index 00000000000..c4cd42fa7e8 --- /dev/null +++ b/changelogs/unreleased/tc-link-geo-unrepl-docs.yml @@ -0,0 +1,5 @@ +--- +title: Cross-link unreplicated Geo types to issues +merge_request: 18443 +author: +type: changed diff --git a/changelogs/unreleased/timeout-ci-includes-expansion.yml b/changelogs/unreleased/timeout-ci-includes-expansion.yml new file mode 100644 index 00000000000..07551655e2d --- /dev/null +++ b/changelogs/unreleased/timeout-ci-includes-expansion.yml @@ -0,0 +1,5 @@ +--- +title: Add timeout mechanism for CI config validation +merge_request: 16807 +author: +type: fixed diff --git a/changelogs/unreleased/tr-fix-embed-tooltip.yml b/changelogs/unreleased/tr-fix-embed-tooltip.yml new file mode 100644 index 00000000000..0bd09d29c93 --- /dev/null +++ b/changelogs/unreleased/tr-fix-embed-tooltip.yml @@ -0,0 +1,5 @@ +--- +title: Fixes embedded metrics chart tooltip spacing +merge_request: 18543 +author: +type: fixed diff --git a/changelogs/unreleased/update-gitlab-runner-helm-chart-to-0-9-0.yml b/changelogs/unreleased/update-gitlab-runner-helm-chart-to-0-9-0.yml new file mode 100644 index 00000000000..b7709b10402 --- /dev/null +++ b/changelogs/unreleased/update-gitlab-runner-helm-chart-to-0-9-0.yml @@ -0,0 +1,5 @@ +--- +title: Update GitLab Runner Helm Chart to 0.9.0 +merge_request: 17326 +author: +type: other diff --git a/changelogs/unreleased/update-gitlab-shell-10-2.yml b/changelogs/unreleased/update-gitlab-shell-10-2.yml new file mode 100644 index 00000000000..cc13c18d633 --- /dev/null +++ b/changelogs/unreleased/update-gitlab-shell-10-2.yml @@ -0,0 +1,5 @@ +--- +title: Update GitLab Shell to v10.2.0 +merge_request: 18735 +author: +type: other diff --git a/changelogs/unreleased/update-preparing-stage-icon.yml b/changelogs/unreleased/update-preparing-stage-icon.yml new file mode 100644 index 00000000000..6fc5bc4cd7c --- /dev/null +++ b/changelogs/unreleased/update-preparing-stage-icon.yml @@ -0,0 +1,5 @@ +--- +title: Add pipeline preparing status icons +merge_request: 17923 +author: +type: added diff --git a/changelogs/unreleased/update-schema-rb.yml b/changelogs/unreleased/update-schema-rb.yml new file mode 100644 index 00000000000..7e0756dc489 --- /dev/null +++ b/changelogs/unreleased/update-schema-rb.yml @@ -0,0 +1,5 @@ +--- +title: Remove Postgresql specific setup tasks and move to schema.rb +merge_request: +author: +type: other diff --git a/changelogs/unreleased/use-ansi2json-for-job-logs.yml b/changelogs/unreleased/use-ansi2json-for-job-logs.yml new file mode 100644 index 00000000000..1fce00e821c --- /dev/null +++ b/changelogs/unreleased/use-ansi2json-for-job-logs.yml @@ -0,0 +1,5 @@ +--- +title: Use new Ansi2json job log converter via feature flag +merge_request: 18134 +author: +type: added diff --git a/changelogs/unreleased/user-friendly-instance-configuration.yml b/changelogs/unreleased/user-friendly-instance-configuration.yml new file mode 100644 index 00000000000..07a0250dff9 --- /dev/null +++ b/changelogs/unreleased/user-friendly-instance-configuration.yml @@ -0,0 +1,5 @@ +--- +title: Make instance configuration user friendly +merge_request: 18363 +author: Takuya Noguchi +type: other diff --git a/changelogs/unreleased/web-metrics-exporter-ee.yml b/changelogs/unreleased/web-metrics-exporter-ee.yml new file mode 100644 index 00000000000..89d6efba654 --- /dev/null +++ b/changelogs/unreleased/web-metrics-exporter-ee.yml @@ -0,0 +1,5 @@ +--- +title: Add web_exporter to expose Prometheus metrics +merge_request: 17943 +author: +type: added diff --git a/changelogs/unreleased/winh-confidential-issue-recaptcha.yml b/changelogs/unreleased/winh-confidential-issue-recaptcha.yml new file mode 100644 index 00000000000..3256c8f5507 --- /dev/null +++ b/changelogs/unreleased/winh-confidential-issue-recaptcha.yml @@ -0,0 +1,5 @@ +--- +title: Display reCAPTCHA modal when making issue public +merge_request: 17553 +author: +type: fixed diff --git a/changelogs/unreleased/winh-issue-list-moved.yml b/changelogs/unreleased/winh-issue-list-moved.yml new file mode 100644 index 00000000000..c8113e39b97 --- /dev/null +++ b/changelogs/unreleased/winh-issue-list-moved.yml @@ -0,0 +1,5 @@ +--- +title: Display if an issue was moved in issue list +merge_request: 17102 +author: +type: changed diff --git a/changelogs/unreleased/winh-related-issues-border.yml b/changelogs/unreleased/winh-related-issues-border.yml new file mode 100644 index 00000000000..8b6b62b440d --- /dev/null +++ b/changelogs/unreleased/winh-related-issues-border.yml @@ -0,0 +1,5 @@ +--- +title: Redo fix for related issues border radius +merge_request: 17480 +author: +type: fixed diff --git a/changelogs/unreleased/workhorse-8-14.yml b/changelogs/unreleased/workhorse-8-14.yml new file mode 100644 index 00000000000..5df25876201 --- /dev/null +++ b/changelogs/unreleased/workhorse-8-14.yml @@ -0,0 +1,5 @@ +--- +title: Update Workhorse to v8.14.0 +merge_request: 18391 +author: +type: other diff --git a/changelogs/unreleased/zj-timeouts-gitaly-rpcs.yml b/changelogs/unreleased/zj-timeouts-gitaly-rpcs.yml new file mode 100644 index 00000000000..f028df84b6e --- /dev/null +++ b/changelogs/unreleased/zj-timeouts-gitaly-rpcs.yml @@ -0,0 +1,5 @@ +--- +title: Add timeouts for each RPC call +merge_request: 31766 +author: +type: changed diff --git a/db/post_migrate/20191017045817_schedule_fix_gitlab_com_pages_access_level.rb b/db/post_migrate/20191017045817_schedule_fix_gitlab_com_pages_access_level.rb new file mode 100644 index 00000000000..4a1eda130f9 --- /dev/null +++ b/db/post_migrate/20191017045817_schedule_fix_gitlab_com_pages_access_level.rb @@ -0,0 +1,38 @@ +# frozen_string_literal: true + +# See http://doc.gitlab.com/ce/development/migration_style_guide.html +# for more information on how to write migrations for GitLab. + +# TODO: remove this migration after execution on gitlab.com https://gitlab.com/gitlab-org/gitlab/issues/34018 +class ScheduleFixGitlabComPagesAccessLevel < ActiveRecord::Migration[5.2] + include Gitlab::Database::MigrationHelpers + + DOWNTIME = false + + MIGRATION = 'FixGitlabComPagesAccessLevel' + BATCH_SIZE = 20_000 + BATCH_TIME = 2.minutes + + # Project + class Project < ActiveRecord::Base + include EachBatch + + self.table_name = 'projects' + self.inheritance_column = :_type_disabled + end + + disable_ddl_transaction! + + def up + return unless ::Gitlab.com? + + queue_background_migration_jobs_by_range_at_intervals( + Project, + MIGRATION, + BATCH_TIME, + batch_size: BATCH_SIZE) + end + + def down + end +end diff --git a/db/schema.rb b/db/schema.rb index 290c669e467..7c5a54bd1d2 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema.define(version: 2019_10_16_220135) do +ActiveRecord::Schema.define(version: 2019_10_17_045817) do # These are extensions that must be enabled in order to support this database enable_extension "pg_trgm" diff --git a/doc/administration/repository_storage_paths.md b/doc/administration/repository_storage_paths.md index 7d3e36e9796..86998280b93 100644 --- a/doc/administration/repository_storage_paths.md +++ b/doc/administration/repository_storage_paths.md @@ -2,8 +2,8 @@ > [Introduced][ce-4578] in GitLab 8.10. -GitLab allows you to define multiple repository storage paths to distribute the -storage load between several mount points. +GitLab allows you to define multiple repository storage paths (sometimes called +storage shards) to distribute the storage load between several mount points. > **Notes:** > diff --git a/doc/administration/repository_storage_types.md b/doc/administration/repository_storage_types.md index 227d6928baf..f6f0222270f 100644 --- a/doc/administration/repository_storage_types.md +++ b/doc/administration/repository_storage_types.md @@ -5,8 +5,8 @@ Two different storage layouts can be used to store the repositories on disk and their characteristics. -GitLab can be configured to use one or multiple repository shard locations -that can be: +GitLab can be configured to use one or multiple repository storage paths/shard +locations that can be: - Mounted to the local disk - Exposed as an NFS shared volume @@ -34,8 +34,8 @@ easy for Administrators to find where the repository is stored. On the other hand this has some drawbacks: Storage location will concentrate huge amount of top-level namespaces. The -impact can be reduced by the introduction of [multiple storage -paths][storage-paths]. +impact can be reduced by the introduction of +[multiple storage paths](repository_storage_paths.md). Because backups are a snapshot of the same URL mapping, if you try to recover a very old backup, you need to verify whether any project has taken the place of @@ -197,5 +197,4 @@ They are also S3 compatible since **10.0** (GitLab Premium), and available in Gi [ce-2821]: https://gitlab.com/gitlab-com/infrastructure/issues/2821 [ce-28283]: https://gitlab.com/gitlab-org/gitlab-foss/issues/28283 [rake/migrate-to-hashed]: raketasks/storage.md#migrate-existing-projects-to-hashed-storage -[storage-paths]: repository_storage_types.md [gitaly]: gitaly/index.md diff --git a/lib/gitlab/background_migration/fix_gitlab_com_pages_access_level.rb b/lib/gitlab/background_migration/fix_gitlab_com_pages_access_level.rb new file mode 100644 index 00000000000..2da92c99928 --- /dev/null +++ b/lib/gitlab/background_migration/fix_gitlab_com_pages_access_level.rb @@ -0,0 +1,116 @@ +# frozen_string_literal: true + +module Gitlab + module BackgroundMigration + # Fixes https://gitlab.com/gitlab-org/gitlab/issues/32961 + class FixGitlabComPagesAccessLevel + # Copy routable here to avoid relying on application logic + module Routable + def build_full_path + if parent && path + parent.build_full_path + '/' + path + else + path + end + end + end + + # Namespace + class Namespace < ActiveRecord::Base + self.table_name = 'namespaces' + self.inheritance_column = :_type_disabled + + include Routable + + belongs_to :parent, class_name: "Namespace" + end + + # ProjectPagesMetadatum + class ProjectPagesMetadatum < ActiveRecord::Base + self.primary_key = :project_id + + belongs_to :project, inverse_of: :pages_metadatum + + scope :deployed, -> { where(deployed: true) } + end + + # Project + class Project < ActiveRecord::Base + self.table_name = 'projects' + self.inheritance_column = :_type_disabled + + include Routable + + belongs_to :namespace + alias_method :parent, :namespace + alias_attribute :parent_id, :namespace_id + + has_one :project_feature, inverse_of: :project + + has_one :pages_metadatum, class_name: 'ProjectPagesMetadatum', inverse_of: :project + + scope :with_pages_deployed, -> do + joins(:pages_metadatum).merge(ProjectPagesMetadatum.deployed) + end + + PRIVATE = 0 + INTERNAL = 10 + PUBLIC = 20 + + delegate :public_pages?, to: :project_feature + + def public_pages_path + File.join(pages_path, 'public') + end + + def pages_path + File.join(Settings.pages.path, build_full_path) + end + + def public? + visibility_level == PUBLIC + end + end + + # ProjectFeature + class ProjectFeature < ActiveRecord::Base + self.table_name = 'project_features' + + belongs_to :project + + DISABLED = 0 + PRIVATE = 10 + ENABLED = 20 + PUBLIC = 30 + end + + def perform(start_id, stop_id) + logger = Gitlab::BackgroundMigration::Logger.build + + Project.where(id: start_id..stop_id).with_pages_deployed.includes(:project_feature).find_each do |project| + config_path = File.join(project.pages_path, 'config.json') + ac_is_enabled_in_config = JSON.parse(File.read(config_path))["access_control"] + + next if ac_is_enabled_in_config # we already made site private and don't want to surprise the user + + next if project.project_feature.pages_access_level == ProjectFeature::DISABLED + + new_access_level = project.public? ? ProjectFeature::ENABLED : ProjectFeature::PUBLIC + + next if project.project_feature.pages_access_level == new_access_level + + logger.info( + message: "Changing pages access control level", + project_id: project.id, + access_level_before: project.project_feature.pages_access_level, + access_level_after: new_access_level + ) + + project.project_feature.update_column(:pages_access_level, new_access_level) + rescue => e + Gitlab::Sentry.track_exception(e, extra: { project_id: project.id }) + end + end + end + end +end diff --git a/lib/gitlab/sidekiq_middleware/metrics.rb b/lib/gitlab/sidekiq_middleware/metrics.rb index 8af353d8674..86762a2d02b 100644 --- a/lib/gitlab/sidekiq_middleware/metrics.rb +++ b/lib/gitlab/sidekiq_middleware/metrics.rb @@ -9,6 +9,8 @@ module Gitlab def initialize @metrics = init_metrics + + @metrics[:sidekiq_concurrency].set({}, Sidekiq.options[:concurrency].to_i) end def call(_worker, job, queue) @@ -45,7 +47,8 @@ module Gitlab sidekiq_jobs_completion_seconds: ::Gitlab::Metrics.histogram(:sidekiq_jobs_completion_seconds, 'Seconds to complete sidekiq job', {}, SIDEKIQ_LATENCY_BUCKETS), sidekiq_jobs_failed_total: ::Gitlab::Metrics.counter(:sidekiq_jobs_failed_total, 'Sidekiq jobs failed'), sidekiq_jobs_retried_total: ::Gitlab::Metrics.counter(:sidekiq_jobs_retried_total, 'Sidekiq jobs retried'), - sidekiq_running_jobs: ::Gitlab::Metrics.gauge(:sidekiq_running_jobs, 'Number of Sidekiq jobs running', {}, :livesum) + sidekiq_running_jobs: ::Gitlab::Metrics.gauge(:sidekiq_running_jobs, 'Number of Sidekiq jobs running', {}, :all), + sidekiq_concurrency: ::Gitlab::Metrics.gauge(:sidekiq_concurrency, 'Maximum number of Sidekiq jobs', {}, :all) } end diff --git a/lib/prometheus/pid_provider.rb b/lib/prometheus/pid_provider.rb index e0f7e7e0a9e..228639357ac 100644 --- a/lib/prometheus/pid_provider.rb +++ b/lib/prometheus/pid_provider.rb @@ -6,7 +6,7 @@ module Prometheus def worker_id if Sidekiq.server? - 'sidekiq' + sidekiq_worker_id elsif defined?(Unicorn::Worker) unicorn_worker_id elsif defined?(::Puma) @@ -18,6 +18,14 @@ module Prometheus private + def sidekiq_worker_id + if worker = ENV['SIDEKIQ_WORKER_ID'] + "sidekiq_#{worker}" + else + 'sidekiq' + end + end + def unicorn_worker_id if matches = process_name.match(/unicorn.*worker\[([0-9]+)\]/) "unicorn_#{matches[1]}" diff --git a/locale/gitlab.pot b/locale/gitlab.pot index d97a149805b..b5a2c8a0b8c 100644 --- a/locale/gitlab.pot +++ b/locale/gitlab.pot @@ -925,6 +925,9 @@ msgstr "" msgid "Add an SSH key" msgstr "" +msgid "Add an existing issue to the epic." +msgstr "" + msgid "Add an issue" msgstr "" @@ -2964,7 +2967,7 @@ msgstr "" msgid "Chat" msgstr "" -msgid "ChatMessage|%{project_link}: Pipeline %{pipeline_link} of %{ref_type} %{branch_link} by %{user_combined_name} %{humanized_status} in %{duration}" +msgid "ChatMessage|%{project_link}: Pipeline %{pipeline_link} of %{ref_type} %{ref_link} by %{user_combined_name} %{humanized_status} in %{duration}" msgstr "" msgid "ChatMessage|Branch" @@ -2985,7 +2988,7 @@ msgstr "" msgid "ChatMessage|Pipeline #%{pipeline_id} %{humanized_status} in %{duration}" msgstr "" -msgid "ChatMessage|Pipeline %{pipeline_link} of %{ref_type} %{branch_link} by %{user_combined_name} %{humanized_status}" +msgid "ChatMessage|Pipeline %{pipeline_link} of %{ref_type} %{ref_link} by %{user_combined_name} %{humanized_status}" msgstr "" msgid "ChatMessage|Tag" @@ -4672,12 +4675,18 @@ msgstr "" msgid "Create a new issue" msgstr "" +msgid "Create a new issue and add it to the epic." +msgstr "" + msgid "Create a new repository" msgstr "" msgid "Create a personal access token on your account to pull or push via %{protocol}." msgstr "" +msgid "Create an issue" +msgstr "" + msgid "Create an issue. Issues are created for each alert triggered." msgstr "" diff --git a/spec/features/merge_request/user_merges_only_if_pipeline_succeeds_spec.rb b/spec/features/merge_request/user_merges_only_if_pipeline_succeeds_spec.rb index 4afbf30ece4..419f741d0ea 100644 --- a/spec/features/merge_request/user_merges_only_if_pipeline_succeeds_spec.rb +++ b/spec/features/merge_request/user_merges_only_if_pipeline_succeeds_spec.rb @@ -89,12 +89,12 @@ describe 'Merge request > User merges only if pipeline succeeds', :js do context 'when CI skipped' do let(:status) { :skipped } - it 'allows MR to be merged' do + it 'does not allow MR to be merged' do visit project_merge_request_path(project, merge_request) wait_for_requests - expect(page).to have_button 'Merge' + expect(page).not_to have_button 'Merge' end end end diff --git a/spec/frontend/vue_shared/components/__snapshots__/split_button_spec.js.snap b/spec/frontend/vue_shared/components/__snapshots__/split_button_spec.js.snap new file mode 100644 index 00000000000..95296de5a5d --- /dev/null +++ b/spec/frontend/vue_shared/components/__snapshots__/split_button_spec.js.snap @@ -0,0 +1,37 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`SplitButton renders actionItems 1`] = ` +<gldropdown-stub + menu-class="dropdown-menu-selectable " + split="true" + text="professor" +> + <gldropdownitem-stub + active="true" + active-class="is-active" + > + <strong> + professor + </strong> + + <div> + very symphonic + </div> + </gldropdownitem-stub> + + <gldropdowndivider-stub /> + <gldropdownitem-stub + active-class="is-active" + > + <strong> + captain + </strong> + + <div> + warp drive + </div> + </gldropdownitem-stub> + + <!----> +</gldropdown-stub> +`; diff --git a/spec/frontend/vue_shared/components/split_button_spec.js b/spec/frontend/vue_shared/components/split_button_spec.js new file mode 100644 index 00000000000..520abb02cf7 --- /dev/null +++ b/spec/frontend/vue_shared/components/split_button_spec.js @@ -0,0 +1,104 @@ +import { GlDropdown, GlDropdownItem } from '@gitlab/ui'; +import { shallowMount } from '@vue/test-utils'; + +import SplitButton from '~/vue_shared/components/split_button.vue'; + +const mockActionItems = [ + { + eventName: 'concert', + title: 'professor', + description: 'very symphonic', + }, + { + eventName: 'apocalypse', + title: 'captain', + description: 'warp drive', + }, +]; + +describe('SplitButton', () => { + let wrapper; + + const createComponent = propsData => { + wrapper = shallowMount(SplitButton, { + propsData, + sync: false, + }); + }; + + const findDropdown = () => wrapper.find(GlDropdown); + const findDropdownItem = (index = 0) => + findDropdown() + .findAll(GlDropdownItem) + .at(index); + const selectItem = index => { + findDropdownItem(index).vm.$emit('click'); + + return wrapper.vm.$nextTick(); + }; + const clickToggleButton = () => { + findDropdown().vm.$emit('click'); + + return wrapper.vm.$nextTick(); + }; + + it('fails for empty actionItems', () => { + const actionItems = []; + expect(() => createComponent({ actionItems })).toThrow(); + }); + + it('fails for single actionItems', () => { + const actionItems = [mockActionItems[0]]; + expect(() => createComponent({ actionItems })).toThrow(); + }); + + it('renders actionItems', () => { + createComponent({ actionItems: mockActionItems }); + + expect(wrapper.element).toMatchSnapshot(); + }); + + describe('toggle button text', () => { + beforeEach(() => { + createComponent({ actionItems: mockActionItems }); + }); + + it('defaults to first actionItems title', () => { + expect(findDropdown().props().text).toBe(mockActionItems[0].title); + }); + + it('changes to selected actionItems title', () => + selectItem(1).then(() => { + expect(findDropdown().props().text).toBe(mockActionItems[1].title); + })); + }); + + describe('emitted event', () => { + let eventHandler; + + beforeEach(() => { + createComponent({ actionItems: mockActionItems }); + }); + + const addEventHandler = ({ eventName }) => { + eventHandler = jest.fn(); + wrapper.vm.$once(eventName, () => eventHandler()); + }; + + it('defaults to first actionItems event', () => { + addEventHandler(mockActionItems[0]); + + return clickToggleButton().then(() => { + expect(eventHandler).toHaveBeenCalled(); + }); + }); + + it('changes to selected actionItems event', () => + selectItem(1) + .then(() => addEventHandler(mockActionItems[1])) + .then(clickToggleButton) + .then(() => { + expect(eventHandler).toHaveBeenCalled(); + })); + }); +}); diff --git a/spec/lib/gitlab/sidekiq_middleware/metrics_spec.rb b/spec/lib/gitlab/sidekiq_middleware/metrics_spec.rb index 806112fcb16..ec4c8560f22 100644 --- a/spec/lib/gitlab/sidekiq_middleware/metrics_spec.rb +++ b/spec/lib/gitlab/sidekiq_middleware/metrics_spec.rb @@ -3,25 +3,37 @@ require 'spec_helper' describe Gitlab::SidekiqMiddleware::Metrics do - describe '#call' do - let(:middleware) { described_class.new } - let(:worker) { double(:worker) } - - let(:completion_seconds_metric) { double('completion seconds metric') } - let(:user_execution_seconds_metric) { double('user execution seconds metric') } - let(:failed_total_metric) { double('failed total metric') } - let(:retried_total_metric) { double('retried total metric') } - let(:running_jobs_metric) { double('running jobs metric') } + let(:middleware) { described_class.new } + + let(:concurrency_metric) { double('concurrency metric') } + let(:completion_seconds_metric) { double('completion seconds metric') } + let(:user_execution_seconds_metric) { double('user execution seconds metric') } + let(:failed_total_metric) { double('failed total metric') } + let(:retried_total_metric) { double('retried total metric') } + let(:running_jobs_metric) { double('running jobs metric') } + + before do + allow(Gitlab::Metrics).to receive(:histogram).with(:sidekiq_jobs_completion_seconds, anything, anything, anything).and_return(completion_seconds_metric) + allow(Gitlab::Metrics).to receive(:histogram).with(:sidekiq_jobs_cpu_seconds, anything, anything, anything).and_return(user_execution_seconds_metric) + allow(Gitlab::Metrics).to receive(:counter).with(:sidekiq_jobs_failed_total, anything).and_return(failed_total_metric) + allow(Gitlab::Metrics).to receive(:counter).with(:sidekiq_jobs_retried_total, anything).and_return(retried_total_metric) + allow(Gitlab::Metrics).to receive(:gauge).with(:sidekiq_running_jobs, anything, {}, :all).and_return(running_jobs_metric) + allow(Gitlab::Metrics).to receive(:gauge).with(:sidekiq_concurrency, anything, {}, :all).and_return(concurrency_metric) + + allow(running_jobs_metric).to receive(:increment) + allow(concurrency_metric).to receive(:set) + end - before do - allow(Gitlab::Metrics).to receive(:histogram).with(:sidekiq_jobs_completion_seconds, anything, anything, anything).and_return(completion_seconds_metric) - allow(Gitlab::Metrics).to receive(:histogram).with(:sidekiq_jobs_cpu_seconds, anything, anything, anything).and_return(user_execution_seconds_metric) - allow(Gitlab::Metrics).to receive(:counter).with(:sidekiq_jobs_failed_total, anything).and_return(failed_total_metric) - allow(Gitlab::Metrics).to receive(:counter).with(:sidekiq_jobs_retried_total, anything).and_return(retried_total_metric) - allow(Gitlab::Metrics).to receive(:gauge).with(:sidekiq_running_jobs, anything, {}, :livesum).and_return(running_jobs_metric) + describe '#initialize' do + it 'sets general metrics' do + expect(concurrency_metric).to receive(:set).with({}, Sidekiq.options[:concurrency].to_i) - allow(running_jobs_metric).to receive(:increment) + middleware end + end + + describe '#call' do + let(:worker) { double(:worker) } it 'yields block' do allow(completion_seconds_metric).to receive(:observe) @@ -30,7 +42,7 @@ describe Gitlab::SidekiqMiddleware::Metrics do expect { |b| middleware.call(worker, {}, :test, &b) }.to yield_control.once end - it 'sets metrics' do + it 'sets queue specific metrics' do labels = { queue: :test } allow(middleware).to receive(:get_thread_cputime).and_return(1, 3) diff --git a/spec/lib/prometheus/pid_provider_spec.rb b/spec/lib/prometheus/pid_provider_spec.rb index ba843b27254..6fdc11b14c4 100644 --- a/spec/lib/prometheus/pid_provider_spec.rb +++ b/spec/lib/prometheus/pid_provider_spec.rb @@ -18,7 +18,17 @@ describe Prometheus::PidProvider do expect(Sidekiq).to receive(:server?).and_return(true) end - it { is_expected.to eq 'sidekiq' } + context 'in a clustered setup' do + before do + stub_env('SIDEKIQ_WORKER_ID', '123') + end + + it { is_expected.to eq 'sidekiq_123' } + end + + context 'in a single process setup' do + it { is_expected.to eq 'sidekiq' } + end end context 'when running in Unicorn mode' do diff --git a/spec/migrations/schedule_fix_gitlab_com_pages_access_level_spec.rb b/spec/migrations/schedule_fix_gitlab_com_pages_access_level_spec.rb new file mode 100644 index 00000000000..db312242bea --- /dev/null +++ b/spec/migrations/schedule_fix_gitlab_com_pages_access_level_spec.rb @@ -0,0 +1,143 @@ +require 'spec_helper' +require Rails.root.join('db', 'post_migrate', '20191017045817_schedule_fix_gitlab_com_pages_access_level.rb') + +describe ScheduleFixGitlabComPagesAccessLevel, :migration, :sidekiq, schema: 2019_10_16_072826 do + using RSpec::Parameterized::TableSyntax + + let(:migration_name) { 'FixGitlabComPagesAccessLevel' } + + ProjectClass = ::Gitlab::BackgroundMigration::FixGitlabComPagesAccessLevel::Project + FeatureClass = ::Gitlab::BackgroundMigration::FixGitlabComPagesAccessLevel::ProjectFeature + + let(:namespaces_table) { table(:namespaces) } + let(:projects_table) { table(:projects) } + let(:features_table) { table(:project_features) } + let(:pages_metadata_table) { table(:project_pages_metadata) } + + let(:subgroup) do + root_group = namespaces_table.create(path: "group", name: "group") + namespaces_table.create!(path: "subgroup", name: "group", parent_id: root_group.id) + end + + before do + allow(::Gitlab).to receive(:com?).and_return true + end + + describe 'scheduling migration' do + let!(:first_project) { create_project(ProjectClass::PRIVATE, FeatureClass::PRIVATE, false, false, 'first' ) } + let!(:last_project) { create_project(ProjectClass::PRIVATE, FeatureClass::PRIVATE, false, false, 'second' ) } + + subject do + Sidekiq::Testing.fake! do + migrate! + end + end + + it 'schedules background migrations' do + Timecop.freeze do + subject + + expect(migration_name).to be_scheduled_delayed_migration(2.minutes, first_project.id, last_project.id) + expect(BackgroundMigrationWorker.jobs.size).to eq(1) + end + end + + context 'not on gitlab.com' do + before do + allow(::Gitlab).to receive(:com?).and_return false + end + + it 'does not schedule background migrations' do + Timecop.freeze do + subject + + expect(BackgroundMigrationWorker.jobs.size).to eq(0) + end + end + end + end + + where(:visibility_level, :pages_access_level, + :pages_deployed, :ac_is_enabled_in_config, + :result_pages_access_level) do + # Does not change anything if pages are not deployed + ProjectClass::PRIVATE | FeatureClass::DISABLED | false | false | FeatureClass::DISABLED + ProjectClass::PRIVATE | FeatureClass::PRIVATE | false | false | FeatureClass::PRIVATE + ProjectClass::PRIVATE | FeatureClass::ENABLED | false | false | FeatureClass::ENABLED + ProjectClass::PRIVATE | FeatureClass::PUBLIC | false | false | FeatureClass::PUBLIC + ProjectClass::INTERNAL | FeatureClass::DISABLED | false | false | FeatureClass::DISABLED + ProjectClass::INTERNAL | FeatureClass::PRIVATE | false | false | FeatureClass::PRIVATE + ProjectClass::INTERNAL | FeatureClass::ENABLED | false | false | FeatureClass::ENABLED + ProjectClass::INTERNAL | FeatureClass::PUBLIC | false | false | FeatureClass::PUBLIC + ProjectClass::PUBLIC | FeatureClass::DISABLED | false | false | FeatureClass::DISABLED + ProjectClass::PUBLIC | FeatureClass::PRIVATE | false | false | FeatureClass::PRIVATE + ProjectClass::PUBLIC | FeatureClass::ENABLED | false | false | FeatureClass::ENABLED + ProjectClass::PUBLIC | FeatureClass::PUBLIC | false | false | FeatureClass::PUBLIC + + # Does not change anything if pages are already private in config.json + # many of these cases are invalid and will not occur in production + ProjectClass::PRIVATE | FeatureClass::DISABLED | true | true | FeatureClass::DISABLED + ProjectClass::PRIVATE | FeatureClass::PRIVATE | true | true | FeatureClass::PRIVATE + ProjectClass::PRIVATE | FeatureClass::ENABLED | true | true | FeatureClass::ENABLED + ProjectClass::PRIVATE | FeatureClass::PUBLIC | true | true | FeatureClass::PUBLIC + ProjectClass::INTERNAL | FeatureClass::DISABLED | true | true | FeatureClass::DISABLED + ProjectClass::INTERNAL | FeatureClass::PRIVATE | true | true | FeatureClass::PRIVATE + ProjectClass::INTERNAL | FeatureClass::ENABLED | true | true | FeatureClass::ENABLED + ProjectClass::INTERNAL | FeatureClass::PUBLIC | true | true | FeatureClass::PUBLIC + ProjectClass::PUBLIC | FeatureClass::DISABLED | true | true | FeatureClass::DISABLED + ProjectClass::PUBLIC | FeatureClass::PRIVATE | true | true | FeatureClass::PRIVATE + ProjectClass::PUBLIC | FeatureClass::ENABLED | true | true | FeatureClass::ENABLED + ProjectClass::PUBLIC | FeatureClass::PUBLIC | true | true | FeatureClass::PUBLIC + + # when pages are deployed and ac is disabled in config + ProjectClass::PRIVATE | FeatureClass::DISABLED | true | false | FeatureClass::DISABLED + ProjectClass::PRIVATE | FeatureClass::PRIVATE | true | false | FeatureClass::PUBLIC # need to update + ProjectClass::PRIVATE | FeatureClass::ENABLED | true | false | FeatureClass::PUBLIC # invalid state, need to update + ProjectClass::PRIVATE | FeatureClass::PUBLIC | true | false | FeatureClass::PUBLIC + ProjectClass::INTERNAL | FeatureClass::DISABLED | true | false | FeatureClass::DISABLED + ProjectClass::INTERNAL | FeatureClass::PRIVATE | true | false | FeatureClass::PUBLIC # need to update + ProjectClass::INTERNAL | FeatureClass::ENABLED | true | false | FeatureClass::PUBLIC # invalid state, need to update + ProjectClass::INTERNAL | FeatureClass::PUBLIC | true | false | FeatureClass::PUBLIC + ProjectClass::PUBLIC | FeatureClass::DISABLED | true | false | FeatureClass::DISABLED + ProjectClass::PUBLIC | FeatureClass::PRIVATE | true | false | FeatureClass::ENABLED # need to update + ProjectClass::PUBLIC | FeatureClass::ENABLED | true | false | FeatureClass::ENABLED + ProjectClass::PUBLIC | FeatureClass::PUBLIC | true | false | FeatureClass::ENABLED # invalid state, need to update + end + + with_them do + it 'fixes settings' do + perform_enqueued_jobs do + project = create_project(visibility_level, pages_access_level, pages_deployed, ac_is_enabled_in_config) + + expect(features_table.find_by(project_id: project.id).pages_access_level).to eq(pages_access_level) + + migrate! + + expect(features_table.find_by(project_id: project.id).pages_access_level).to eq(result_pages_access_level) + end + end + end + + def create_project(visibility_level, pages_access_level, pages_deployed, ac_is_enabled_in_config, path = 'project') + project = projects_table.create!(path: path, visibility_level: visibility_level, + namespace_id: subgroup.id) + + pages_metadata_table.create!(project_id: project.id, deployed: pages_deployed) + + if pages_deployed + FileUtils.mkdir_p(ProjectClass.find(project.id).public_pages_path) + + # write config.json + allow(project).to receive(:public_pages?).and_return(!ac_is_enabled_in_config) + allow(project).to receive(:pages_domains).and_return([]) + allow(project).to receive(:project_id).and_return(project.id) + allow(project).to receive(:pages_path).and_return(ProjectClass.find(project.id).pages_path) + Projects::UpdatePagesConfigurationService.new(project).execute + end + + project.update!(visibility_level: visibility_level) + features_table.create!(project_id: project.id, pages_access_level: pages_access_level) + + project + end +end diff --git a/spec/models/merge_request_spec.rb b/spec/models/merge_request_spec.rb index e2a0acf85f6..5a421cad0f8 100644 --- a/spec/models/merge_request_spec.rb +++ b/spec/models/merge_request_spec.rb @@ -2267,7 +2267,7 @@ describe MergeRequest do allow(subject).to receive(:head_pipeline) { pipeline } end - it { expect(subject.mergeable_ci_state?).to be_truthy } + it { expect(subject.mergeable_ci_state?).to be_falsey } end context 'when no pipeline is associated' do diff --git a/spec/models/project_services/chat_message/pipeline_message_spec.rb b/spec/models/project_services/chat_message/pipeline_message_spec.rb index cf7c7bf7e61..366ef01924e 100644 --- a/spec/models/project_services/chat_message/pipeline_message_spec.rb +++ b/spec/models/project_services/chat_message/pipeline_message_spec.rb @@ -159,6 +159,45 @@ describe ChatMessage::PipelineMessage do ) end end + + context 'when ref type is tag' do + before do + args[:object_attributes][:tag] = true + args[:object_attributes][:ref] = 'new_tag' + end + + it "returns the pipeline summary in the activity's title" do + expect(subject.activity[:title]).to eq( + "Pipeline [#123](http://example.gitlab.com/pipelines/123)" \ + " of tag [new_tag](http://example.gitlab.com/-/tags/new_tag)" \ + " by The Hacker (hacker) passed" + ) + end + + it "returns the pipeline summary as the attachment's text property" do + expect(subject.attachments.first[:text]).to eq( + "<http://example.gitlab.com|project_name>:" \ + " Pipeline <http://example.gitlab.com/pipelines/123|#123>" \ + " of tag <http://example.gitlab.com/-/tags/new_tag|new_tag>" \ + " by The Hacker (hacker) passed in 02:00:10" + ) + end + + context 'when rendering markdown' do + before do + args[:markdown] = true + end + + it 'returns the pipeline summary as the attachments in markdown format' do + expect(subject.attachments).to eq( + "[project_name](http://example.gitlab.com):" \ + " Pipeline [#123](http://example.gitlab.com/pipelines/123)" \ + " of tag [new_tag](http://example.gitlab.com/-/tags/new_tag)" \ + " by The Hacker (hacker) passed in 02:00:10" + ) + end + end + end end context 'when the fancy_pipeline_slack_notifications feature flag is enabled' do diff --git a/spec/models/project_services/chat_message/push_message_spec.rb b/spec/models/project_services/chat_message/push_message_spec.rb index 2bde0b93fda..fe0b2fe3440 100644 --- a/spec/models/project_services/chat_message/push_message_spec.rb +++ b/spec/models/project_services/chat_message/push_message_spec.rb @@ -96,7 +96,7 @@ describe ChatMessage::PushMessage do context 'without markdown' do it 'returns a message regarding pushes' do expect(subject.pretext).to eq('test.user pushed new tag ' \ - '<http://url.com/commits/new_tag|new_tag> to ' \ + '<http://url.com/-/tags/new_tag|new_tag> to ' \ '<http://url.com|project_name>') expect(subject.attachments).to be_empty end @@ -109,10 +109,10 @@ describe ChatMessage::PushMessage do it 'returns a message regarding pushes' do expect(subject.pretext).to eq( - 'test.user pushed new tag [new_tag](http://url.com/commits/new_tag) to [project_name](http://url.com)') + 'test.user pushed new tag [new_tag](http://url.com/-/tags/new_tag) to [project_name](http://url.com)') expect(subject.attachments).to be_empty expect(subject.activity).to eq( - title: 'test.user pushed new tag [new_tag](http://url.com/commits/new_tag)', + title: 'test.user pushed new tag [new_tag](http://url.com/-/tags/new_tag)', subtitle: 'in [project_name](http://url.com)', text: '[Compare changes](http://url.com/compare/0000000000000000000000000000000000000000...after)', image: 'http://someavatar.com' |