diff options
| author | Eric Eastwood <contact@ericeastwood.com> | 2017-12-05 10:35:37 +0300 |
|---|---|---|
| committer | Eric Eastwood <contact@ericeastwood.com> | 2017-12-08 13:30:13 +0300 |
| commit | b87c53c72d7cb3226200b025ee7d7ca8fccece42 (patch) | |
| tree | a20581b9deace7b0aa5e3147c6f9ee67d0b7dc01 /app/assets/javascripts/image_diff | |
| parent | 7fabc892f251740dbd9a4755baede662e6854870 (diff) | |
Fix comment on image discussion icon alignment
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/39608
Use SVG icons to avoid having to position things
See https://gitlab.com/gitlab-org/gitlab-ce/issues/39608#note_50088917
Diffstat (limited to 'app/assets/javascripts/image_diff')
| -rw-r--r-- | app/assets/javascripts/image_diff/helpers/badge_helper.js | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/app/assets/javascripts/image_diff/helpers/badge_helper.js b/app/assets/javascripts/image_diff/helpers/badge_helper.js index 6a6a668308d..eddaeda9578 100644 --- a/app/assets/javascripts/image_diff/helpers/badge_helper.js +++ b/app/assets/javascripts/image_diff/helpers/badge_helper.js @@ -19,12 +19,9 @@ export function addImageBadge(containerEl, { coordinate, badgeText, noteId }) { } export function addImageCommentBadge(containerEl, { coordinate, noteId }) { - const buttonEl = createImageBadge(noteId, coordinate, ['image-comment-badge', 'inverted']); - const iconEl = document.createElement('i'); - iconEl.className = 'fa fa-comment-o'; - iconEl.setAttribute('aria-label', 'comment'); + const buttonEl = createImageBadge(noteId, coordinate, ['image-comment-badge']); + buttonEl.innerHTML = gl.utils.spriteIcon('image-comment-dark'); - buttonEl.appendChild(iconEl); containerEl.appendChild(buttonEl); } |