diff options
author | Douwe Maan <douwe@selenight.nl> | 2017-03-31 06:06:09 +0300 |
---|---|---|
committer | Luke "Jared" Bennett <lbennett@gitlab.com> | 2017-04-05 19:44:14 +0300 |
commit | 21e10888c3fc0fe545c0443cf0e23f593df847a4 (patch) | |
tree | c6c89c2ea2c75ffae4529ab4dceb937ce2f6299a /app/helpers/notes_helper.rb | |
parent | fe26b8af94e8e12a66249e28e34196a4f8b987c4 (diff) |
Address review comments
Diffstat (limited to 'app/helpers/notes_helper.rb')
-rw-r--r-- | app/helpers/notes_helper.rb | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/app/helpers/notes_helper.rb b/app/helpers/notes_helper.rb index 8ec72d5f43a..443e0143647 100644 --- a/app/helpers/notes_helper.rb +++ b/app/helpers/notes_helper.rb @@ -57,23 +57,6 @@ module NotesHelper data: data, title: 'Add a reply' end - def preload_max_access_for_authors(notes, project) - user_ids = notes.map(&:author_id) - project.team.max_member_access_for_user_ids(user_ids) - end - - def preload_noteable_for_regular_notes(notes) - ActiveRecord::Associations::Preloader.new.preload(notes.reject(&:for_commit?), :noteable) - end - - def prepare_notes_for_rendering(notes) - preload_noteable_for_regular_notes(notes) - preload_max_access_for_authors(notes, @project) - Banzai::NoteRenderer.render(notes, @project, current_user) - - notes - end - def note_max_access_for_user(note) note.project.team.human_max_access(note.author_id) end |