diff options
| author | Robert Speicher <rspeicher@gmail.com> | 2018-12-14 20:47:49 +0300 |
|---|---|---|
| committer | Robert Speicher <rspeicher@gmail.com> | 2018-12-14 22:56:03 +0300 |
| commit | 04a3e48c2a0e31e31f8ba0e9036597428ee3a373 (patch) | |
| tree | 641d1554ce6199fe3059ea3f4200e39cec9a95e9 /app/helpers/version_check_helper.rb | |
| parent | eafc8e2f481751b973260287c844b70bd408dcb2 (diff) | |
Use class methods for VersionCheck
All of these methods are stateless, there was no point to have them as
instance methods.
Mostly this allows us to remove an `allow_any_instance_of` usage.
Diffstat (limited to 'app/helpers/version_check_helper.rb')
| -rw-r--r-- | app/helpers/version_check_helper.rb | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/app/helpers/version_check_helper.rb b/app/helpers/version_check_helper.rb index ab77b149072..5e519cf5c19 100644 --- a/app/helpers/version_check_helper.rb +++ b/app/helpers/version_check_helper.rb @@ -6,8 +6,7 @@ module VersionCheckHelper return unless Gitlab::CurrentSettings.version_check_enabled return if User.single_user&.requires_usage_stats_consent? - image_url = VersionCheck.new.url - image_tag image_url, class: 'js-version-status-badge' + image_tag VersionCheck.url, class: 'js-version-status-badge' end def link_to_version |