Rename the hidden option to whitelisted

1 files changed, 7 insertions, 6 deletions

diff --git a/app/models/concerns/cache_markdown_field.rb b/app/models/concerns/cache_markdown_field.rb
index 4212224b66a..15d8d58b9b5 100644
--- a/app/models/concerns/cache_markdown_field.rb
+++ b/app/models/concerns/cache_markdown_field.rb
@@ -7,7 +7,7 @@
 #     cache_markdown_field :foo
 #     cache_markdown_field :bar
 #     cache_markdown_field :baz, pipeline: :single_line
-#     cache_markdown_field :baz, hidden: false
+#     cache_markdown_field :baz, whitelisted: true
 #
 # Corresponding foo_html, bar_html and baz_html fields should exist.
 module CacheMarkdownField
@@ -41,9 +41,9 @@ module CacheMarkdownField
       markdown_fields.map { |field| html_field(field) }
     end
 
-    def hidden_html_fields
+    def html_fields_whitelisted
       markdown_fields.each_with_object([]) do |field, fields|
-        if @data[field].fetch(:hidden, true)
+        if @data[field].fetch(:whitelisted, false)
           fields << html_field(field)
         end
       end
@@ -159,13 +159,14 @@ module CacheMarkdownField
     def attributes
       attrs = attributes_before_markdown_cache
       html_fields = cached_markdown_fields.html_fields
-      hidden_html_fields = cached_markdown_fields.hidden_html_fields
+      whitelisted = cached_markdown_fields.html_fields_whitelisted
+      exclude_fields = html_fields - whitelisted
 
-      hidden_html_fields.each do |field|
+      exclude_fields.each do |field|
         attrs.delete(field)
       end
 
-      if (html_fields - hidden_html_fields).empty?
+      if whitelisted.empty?
         attrs.delete('cached_markdown_version')
       end