diff options
| author | Andrew Newdigate <andrew@gitlab.com> | 2019-02-08 15:19:53 +0300 |
|---|---|---|
| committer | Andrew Newdigate <andrew@gitlab.com> | 2019-03-06 18:51:56 +0300 |
| commit | 3288e1a874ec0184f9f27f932748e51c57babf17 (patch) | |
| tree | 9f8667f5349ecfc59f3c8a6e9641cb1e32fa3d5b /app/models/label_note.rb | |
| parent | 7bbdb2a29fbc7b8c9f879c42de7063adaa8313c7 (diff) | |
Adds the Rubocop ReturnNil cop
This style change enforces `return if ...` instead of
`return nil if ...` to save maintainers a few minor review points
Diffstat (limited to 'app/models/label_note.rb')
| -rw-r--r-- | app/models/label_note.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/models/label_note.rb b/app/models/label_note.rb index 680952cf421..d6814f4a948 100644 --- a/app/models/label_note.rb +++ b/app/models/label_note.rb @@ -81,7 +81,7 @@ class LabelNote < Note deleted = label_refs.count - existing_refs.count deleted_str = deleted == 0 ? nil : "#{deleted} deleted" - return nil unless refs_str || deleted_str + return unless refs_str || deleted_str label_list_str = [refs_str, deleted_str].compact.join(' + ') suffix = 'label'.pluralize(deleted > 0 ? deleted : existing_refs.count) |