diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-09-01 16:20:26 +0300 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-09-01 16:20:26 +0300 |
| commit | 67b4448e37350a39fa2f7e43aa6b74fc65b3eb6c (patch) | |
| tree | f421ad9e576c74a85f992c4c4f3aff7c1b62cc7e /app/models/project_services | |
| parent | 72d39e3d8c1ca8ee7e49d6bccd4306fb347c63f6 (diff) | |
| parent | 20111b045d7df27223808b1e8eaa4861d4906863 (diff) | |
Merge branch 'remove-unnecessary-freeze-in-app-models' into 'master'
Avoid calling freeze on already frozen strings in app/models
See merge request gitlab-org/gitlab-ce!32499
Diffstat (limited to 'app/models/project_services')
| -rw-r--r-- | app/models/project_services/buildkite_service.rb | 2 | ||||
| -rw-r--r-- | app/models/project_services/pivotaltracker_service.rb | 2 | ||||
| -rw-r--r-- | app/models/project_services/pushover_service.rb | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/app/models/project_services/buildkite_service.rb b/app/models/project_services/buildkite_service.rb index 43edfde851c..d058904dd9e 100644 --- a/app/models/project_services/buildkite_service.rb +++ b/app/models/project_services/buildkite_service.rb @@ -5,7 +5,7 @@ require "addressable/uri" class BuildkiteService < CiService include ReactiveService - ENDPOINT = "https://buildkite.com".freeze + ENDPOINT = "https://buildkite.com" prop_accessor :project_url, :token boolean_accessor :enable_ssl_verification diff --git a/app/models/project_services/pivotaltracker_service.rb b/app/models/project_services/pivotaltracker_service.rb index c15993bdc06..d3fff100964 100644 --- a/app/models/project_services/pivotaltracker_service.rb +++ b/app/models/project_services/pivotaltracker_service.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true class PivotaltrackerService < Service - API_ENDPOINT = 'https://www.pivotaltracker.com/services/v5/source_commits'.freeze + API_ENDPOINT = 'https://www.pivotaltracker.com/services/v5/source_commits' prop_accessor :token, :restrict_to_branch validates :token, presence: true, if: :activated? diff --git a/app/models/project_services/pushover_service.rb b/app/models/project_services/pushover_service.rb index 0d35bab7f80..7324890551c 100644 --- a/app/models/project_services/pushover_service.rb +++ b/app/models/project_services/pushover_service.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true class PushoverService < Service - BASE_URI = 'https://api.pushover.net/1'.freeze + BASE_URI = 'https://api.pushover.net/1' prop_accessor :api_key, :user_key, :device, :priority, :sound validates :api_key, :user_key, :priority, presence: true, if: :activated? |