Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhil Hughes <me@iamphill.com>2017-06-19 17:56:22 +0300
committerPhil Hughes <me@iamphill.com>2017-06-28 12:17:12 +0300
commit9aa832285c10f627a67b5f49870d694b27fc37c2 (patch)
tree07dbac4c94c779857f986704ce6cf4f56d69d32d /app/services/boards
parent5214e507b043c8e71d2826252491cdac97d27416 (diff)
Fixed issue boards closed list not listing all issues
This was a regression caused by the backlog list being re-added Closes #33850
Diffstat (limited to 'app/services/boards')
-rw-r--r--app/services/boards/issues/list_service.rb12
1 files changed, 10 insertions, 2 deletions
diff --git a/app/services/boards/issues/list_service.rb b/app/services/boards/issues/list_service.rb
index 418fa9afd6e..a1d67cbc244 100644
--- a/app/services/boards/issues/list_service.rb
+++ b/app/services/boards/issues/list_service.rb
@@ -3,7 +3,7 @@ module Boards
class ListService < BaseService
def execute
issues = IssuesFinder.new(current_user, filter_params).execute
- issues = without_board_labels(issues) unless movable_list?
+ issues = without_board_labels(issues) unless movable_list? || closed_list?
issues = with_list_label(issues) if movable_list?
issues.order_by_position_and_priority
end
@@ -21,7 +21,15 @@ module Boards
end
def movable_list?
- @movable_list ||= list.present? && list.movable?
+ return @movable_list if defined?(@movable_list)
+
+ @movable_list = list.present? && list.movable?
+ end
+
+ def closed_list?
+ return @closed_list if defined?(@closed_list)
+
+ @closed_list = list.present? && list.closed?
end
def filter_params