diff options
author | Nick Thomas <nick@gitlab.com> | 2019-03-27 19:18:28 +0300 |
---|---|---|
committer | Nick Thomas <nick@gitlab.com> | 2019-03-28 19:18:23 +0300 |
commit | f086dbf66ee54e684fed4be17bce1e3537779d24 (patch) | |
tree | 2b095a22cba62bdc5c933d6b488572bca883e929 /app/services/merge_requests | |
parent | 013f7cd24c4359d5d704b719d85b6df7ca1fdd55 (diff) |
Add a thin encapsulation around .pluck(:id)
Diffstat (limited to 'app/services/merge_requests')
-rw-r--r-- | app/services/merge_requests/delete_non_latest_diffs_service.rb | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/app/services/merge_requests/delete_non_latest_diffs_service.rb b/app/services/merge_requests/delete_non_latest_diffs_service.rb index d5929446122..bdb7ec8a7c2 100644 --- a/app/services/merge_requests/delete_non_latest_diffs_service.rb +++ b/app/services/merge_requests/delete_non_latest_diffs_service.rb @@ -8,15 +8,13 @@ module MergeRequests @merge_request = merge_request end - # rubocop: disable CodeReuse/ActiveRecord def execute diffs = @merge_request.non_latest_diffs.with_files diffs.each_batch(of: BATCH_SIZE) do |relation, index| - ids = relation.pluck(:id).map { |id| [id] } + ids = relation.pluck_primary_key.map { |id| [id] } DeleteDiffFilesWorker.bulk_perform_in(index * 5.minutes, ids) end end - # rubocop: enable CodeReuse/ActiveRecord end end |