diff options
| author | Shinya Maeda <shinya@gitlab.com> | 2018-12-25 12:48:26 +0300 |
|---|---|---|
| committer | Shinya Maeda <shinya@gitlab.com> | 2018-12-31 08:35:57 +0300 |
| commit | 8f1e96c89bd3ffe6ae47c275df2d1e919d42c39a (patch) | |
| tree | 783bdd82084985736a8a07ab13d0e9f335f2fcd0 /app/services/tags | |
| parent | dc8a8c7d998e2c1f78fcf60f8dc45b572f62abe8 (diff) | |
Add spec for Release API
Add spec for all release API - GET, POST, PUT, DELETE.
Also, fixes some minior bugs.
Diffstat (limited to 'app/services/tags')
| -rw-r--r-- | app/services/tags/destroy_service.rb | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/app/services/tags/destroy_service.rb b/app/services/tags/destroy_service.rb index 6bfef09ac54..cab507946b4 100644 --- a/app/services/tags/destroy_service.rb +++ b/app/services/tags/destroy_service.rb @@ -2,7 +2,6 @@ module Tags class DestroyService < BaseService - # rubocop: disable CodeReuse/ActiveRecord def execute(tag_name) repository = project.repository tag = repository.find_tag(tag_name) @@ -12,8 +11,12 @@ module Tags end if repository.rm_tag(current_user, tag_name) - release = project.releases.find_by(tag: tag_name) - release&.destroy + ## + # When a tag in a repository is destroyed, + # release assets will be destroyed too. + Releases::DestroyService + .new(project, current_user, tag: tag_name) + .execute push_data = build_push_data(tag) EventCreateService.new.push(project, current_user, push_data) @@ -27,7 +30,6 @@ module Tags rescue Gitlab::Git::PreReceiveError => ex error(ex.message) end - # rubocop: enable CodeReuse/ActiveRecord def error(message, return_code = 400) super(message).merge(return_code: return_code) |