Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKamil Trzciński <ayufan@ayufan.eu>2019-04-08 16:33:36 +0300
committerKamil Trzciński <ayufan@ayufan.eu>2019-04-15 14:05:14 +0300
commit650f40865e5d8136cb366fbde689c4100aafb0c5 (patch)
treef740d9f235693ad8e2a3693d6ec30dee26d2a74a /app/services/users/migrate_to_ghost_user_service.rb
parent7457c1e1229cd1e90e608e8b247e2fbb217f05b6 (diff)
Forbid the use of `#reload` and prefer `#reset`
The `#reload` makes to load all objects into memory, and the main purpose of `#reload` is to drop the association cache. The `#reset` seems to solve exactly that case.
Diffstat (limited to 'app/services/users/migrate_to_ghost_user_service.rb')
-rw-r--r--app/services/users/migrate_to_ghost_user_service.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/app/services/users/migrate_to_ghost_user_service.rb b/app/services/users/migrate_to_ghost_user_service.rb
index 04fd6e37501..a66b6627e40 100644
--- a/app/services/users/migrate_to_ghost_user_service.rb
+++ b/app/services/users/migrate_to_ghost_user_service.rb
@@ -33,7 +33,7 @@ module Users
end
end
- user.reload
+ user.reset
end
private