diff options
author | Douwe Maan <douwe@selenight.nl> | 2016-03-22 02:09:20 +0300 |
---|---|---|
committer | Douwe Maan <douwe@selenight.nl> | 2016-03-22 02:09:20 +0300 |
commit | 31266c5be4748f57a7d56bbcc6f06d570cbf5356 (patch) | |
tree | 1ee744a7303335cf1a270d92ec6b9e955a52cace /app/services | |
parent | ae7b2ef62cdf61c990f914d776a6fdfc2bc49fa2 (diff) |
Address feedback
Diffstat (limited to 'app/services')
-rw-r--r-- | app/services/groups/create_service.rb | 2 | ||||
-rw-r--r-- | app/services/groups/update_service.rb | 4 |
2 files changed, 1 insertions, 5 deletions
diff --git a/app/services/groups/create_service.rb b/app/services/groups/create_service.rb index 46c2a53e1f6..2bccd584dde 100644 --- a/app/services/groups/create_service.rb +++ b/app/services/groups/create_service.rb @@ -12,7 +12,7 @@ module Groups return @group end - @group.name = @group.path.dup unless @group.name + @group.name ||= @group.path.dup @group.save @group.add_owner(current_user) @group diff --git a/app/services/groups/update_service.rb b/app/services/groups/update_service.rb index b70e2e4aaa9..99ad12b1003 100644 --- a/app/services/groups/update_service.rb +++ b/app/services/groups/update_service.rb @@ -1,7 +1,3 @@ -# Checks visibility level permission check before updating a group -# Do not allow to put Group visibility level smaller than its projects -# Do not allow unauthorized permission levels - module Groups class UpdateService < Groups::BaseService def execute |