diff options
author | Rubén Dávila <ruben@gitlab.com> | 2019-04-02 18:55:34 +0300 |
---|---|---|
committer | Rubén Dávila <ruben@gitlab.com> | 2019-04-03 07:20:43 +0300 |
commit | e8da6255d93beed1ffa3f55587c12a85561f40b0 (patch) | |
tree | 35c3358d0ec8297124e7426789b4295e481865ff /app/services | |
parent | ccdf7a93905bb7fd5eb4be5772160a9fad8e19a4 (diff) |
Backport some changes from EE
MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9815
Diffstat (limited to 'app/services')
-rw-r--r-- | app/services/groups/base_service.rb | 6 | ||||
-rw-r--r-- | app/services/groups/create_service.rb | 2 | ||||
-rw-r--r-- | app/services/groups/update_service.rb | 1 |
3 files changed, 9 insertions, 0 deletions
diff --git a/app/services/groups/base_service.rb b/app/services/groups/base_service.rb index 8c8acce5ca5..019cd047ae9 100644 --- a/app/services/groups/base_service.rb +++ b/app/services/groups/base_service.rb @@ -7,5 +7,11 @@ module Groups def initialize(group, user, params = {}) @group, @current_user, @params = group, user, params.dup end + + private + + def remove_unallowed_params + # overridden in EE + end end end diff --git a/app/services/groups/create_service.rb b/app/services/groups/create_service.rb index 99ead467f74..74aad3b1c94 100644 --- a/app/services/groups/create_service.rb +++ b/app/services/groups/create_service.rb @@ -8,6 +8,8 @@ module Groups end def execute + remove_unallowed_params + @group = Group.new(params) after_build_hook(@group, params) diff --git a/app/services/groups/update_service.rb b/app/services/groups/update_service.rb index 787445180f0..73e1e00dc33 100644 --- a/app/services/groups/update_service.rb +++ b/app/services/groups/update_service.rb @@ -6,6 +6,7 @@ module Groups def execute reject_parent_id! + remove_unallowed_params return false unless valid_visibility_level_change?(group, params[:visibility_level]) |