diff options
| author | mfluharty <mfluharty@gitlab.com> | 2019-05-07 22:37:29 +0300 |
|---|---|---|
| committer | mfluharty <mfluharty@gitlab.com> | 2019-06-04 16:09:01 +0300 |
| commit | 598fa4cdd8e698d4ed19ad6101989aa286c9131c (patch) | |
| tree | 8cb38abd21ba624dde4057b4227f2e1284821ccc /app/views/ci | |
| parent | d16c11ab36d91fc51a01406fa77ee2bf307ad8f5 (diff) | |
Default masked to false for new variables
Set the default value to false
Adjust tests to expect false as the default
Update documentation to make new default clear
Diffstat (limited to 'app/views/ci')
| -rw-r--r-- | app/views/ci/variables/_content.html.haml | 2 | ||||
| -rw-r--r-- | app/views/ci/variables/_variable_row.html.haml | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/app/views/ci/variables/_content.html.haml b/app/views/ci/variables/_content.html.haml index d07cbe4589c..0b5c1a806b2 100644 --- a/app/views/ci/variables/_content.html.haml +++ b/app/views/ci/variables/_content.html.haml @@ -1,3 +1,3 @@ -= _('Environment variables are applied to environments via the runner. They can be protected by only exposing them to protected branches or tags. Additionally, they will be masked by default so they are hidden in job logs, though they must match certain regexp requirements to do so. You can use environment variables for passwords, secret keys, or whatever you want.') += _('Environment variables are applied to environments via the runner. They can be protected by only exposing them to protected branches or tags. Additionally, they can be masked so they are hidden in job logs, though they must match certain regexp requirements to do so. You can use environment variables for passwords, secret keys, or whatever you want.') = _('You may also add variables that are made available to the running application by prepending the variable key with <code>K8S_SECRET_</code>.').html_safe = link_to _('More information'), help_page_path('ci/variables/README', anchor: 'variables') diff --git a/app/views/ci/variables/_variable_row.html.haml b/app/views/ci/variables/_variable_row.html.haml index ca2521e9bc6..ed4bd5ae19e 100644 --- a/app/views/ci/variables/_variable_row.html.haml +++ b/app/views/ci/variables/_variable_row.html.haml @@ -8,7 +8,7 @@ - value = variable&.value - is_protected_default = ci_variable_protected_by_default? - is_protected = ci_variable_protected?(variable, only_key_value) -- is_masked_default = true +- is_masked_default = false - is_masked = ci_variable_masked?(variable, only_key_value) - id_input_name = "#{form_field}[variables_attributes][][id]" |