Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTimothy Andrew <mail@timothyandrew.net>2016-08-18 09:58:36 +0300
committerTimothy Andrew <mail@timothyandrew.net>2016-08-18 19:42:02 +0300
commitdbedf3a61b5fe233b87b217596dea5572fc741b3 (patch)
tree2e94353c983f50cee38116e1a98df368e108cb18 /app/views/u2f
parenta41cf621f5e4719f81efad603f0bc91f8fbe5f40 (diff)
Address review comments from @smcgivern.
1. Remove an unnecessary (since we're fetching all the records anyway) `pluck` while fetching U2F registration records. 2. Align "Your device was successfully set up!" section with the "U2F Devices" table below.
Diffstat (limited to 'app/views/u2f')
-rw-r--r--app/views/u2f/_register.html.haml17
1 files changed, 9 insertions, 8 deletions
diff --git a/app/views/u2f/_register.html.haml b/app/views/u2f/_register.html.haml
index 7a4b7d7a77a..8f7b42eb351 100644
--- a/app/views/u2f/_register.html.haml
+++ b/app/views/u2f/_register.html.haml
@@ -28,14 +28,15 @@
%script#js-register-u2f-registered{ type: "text/template" }
%div.row.append-bottom-10
- %p Your device was successfully set up! Give it a name and register it with the GitLab server.
- = form_tag(create_u2f_profile_two_factor_auth_path, method: :post) do
- .row.append-bottom-10
- .col-md-3
- = text_field_tag 'u2f_registration[name]', nil, class: 'form-control', placeholder: "Pick a name"
- .col-md-3
- = hidden_field_tag 'u2f_registration[device_response]', nil, class: 'form-control', required: true, id: "js-device-response"
- = submit_tag "Register U2F Device", class: "btn btn-success"
+ .col-md-12
+ %p Your device was successfully set up! Give it a name and register it with the GitLab server.
+ = form_tag(create_u2f_profile_two_factor_auth_path, method: :post) do
+ .row.append-bottom-10
+ .col-md-3
+ = text_field_tag 'u2f_registration[name]', nil, class: 'form-control', placeholder: "Pick a name"
+ .col-md-3
+ = hidden_field_tag 'u2f_registration[device_response]', nil, class: 'form-control', required: true, id: "js-device-response"
+ = submit_tag "Register U2F Device", class: "btn btn-success"
:javascript
var u2fRegister = new U2FRegister($("#js-register-u2f"), gon.u2f);