diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2023-04-14 00:17:21 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2023-04-14 00:17:21 +0300 |
commit | b2e3da6a38f143a8c782dae4baceae3ed764733d (patch) | |
tree | 243bb5191b3c961a9b2951c3e99768fda02d251c /app | |
parent | 53d77359a0e6bf78bfc8ef8c72995eebe1f9e63b (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'app')
5 files changed, 19 insertions, 11 deletions
diff --git a/app/assets/javascripts/notes/components/note_awards_list.vue b/app/assets/javascripts/notes/components/note_awards_list.vue index 21841680cab..9c04a72375b 100644 --- a/app/assets/javascripts/notes/components/note_awards_list.vue +++ b/app/assets/javascripts/notes/components/note_awards_list.vue @@ -35,9 +35,6 @@ export default { isAuthoredByMe() { return this.noteAuthorId === this.getUserData.id; }, - addButtonClass() { - return this.isAuthoredByMe ? 'js-user-authored' : ''; - }, }, methods: { ...mapActions(['toggleAwardRequest']), @@ -64,7 +61,6 @@ export default { :awards="awards" :can-award-emoji="canAwardEmoji" :current-user-id="getUserData.id" - :add-button-class="addButtonClass" @award="handleAward($event)" /> </div> diff --git a/app/assets/javascripts/repository/components/blob_content_viewer.vue b/app/assets/javascripts/repository/components/blob_content_viewer.vue index 60df042529a..4ce714f7c21 100644 --- a/app/assets/javascripts/repository/components/blob_content_viewer.vue +++ b/app/assets/javascripts/repository/components/blob_content_viewer.vue @@ -144,7 +144,7 @@ export default { }, computed: { shouldRenderGenie() { - return this.glFeatures.explainCode && this.glFeatures.explainCodeSnippet; + return this.glFeatures.explainCode && this.glFeatures.explainCodeSnippet && this.isLoggedIn; }, isLoggedIn() { return isLoggedIn(); diff --git a/app/assets/javascripts/super_sidebar/components/pinned_section.vue b/app/assets/javascripts/super_sidebar/components/pinned_section.vue index 193de143c2b..164ea04ab8e 100644 --- a/app/assets/javascripts/super_sidebar/components/pinned_section.vue +++ b/app/assets/javascripts/super_sidebar/components/pinned_section.vue @@ -2,6 +2,8 @@ import { GlCollapse, GlIcon } from '@gitlab/ui'; import Draggable from 'vuedraggable'; import { s__ } from '~/locale'; +import { setCookie, getCookie } from '~/lib/utils/common_utils'; +import { SIDEBAR_PINS_EXPANDED_COOKIE, SIDEBAR_COOKIE_EXPIRATION } from '../constants'; import NavItem from './nav_item.vue'; export default { @@ -25,7 +27,7 @@ export default { }, data() { return { - expanded: true, + expanded: getCookie(SIDEBAR_PINS_EXPANDED_COOKIE) !== 'false', draggableItems: this.items, }; }, @@ -38,6 +40,11 @@ export default { }, }, watch: { + expanded(newExpanded) { + setCookie(SIDEBAR_PINS_EXPANDED_COOKIE, newExpanded, { + expires: SIDEBAR_COOKIE_EXPIRATION, + }); + }, items(newItems) { this.draggableItems = newItems; }, diff --git a/app/assets/javascripts/super_sidebar/constants.js b/app/assets/javascripts/super_sidebar/constants.js index 4e25b9cff45..3dbd12b4ff7 100644 --- a/app/assets/javascripts/super_sidebar/constants.js +++ b/app/assets/javascripts/super_sidebar/constants.js @@ -30,3 +30,6 @@ export const HELP_MENU_TRACKING_DEFAULTS = { 'data-track-property': 'nav_help_menu', 'data-track-action': 'click_link', }; + +export const SIDEBAR_PINS_EXPANDED_COOKIE = 'sidebar_pinned_section_expanded'; +export const SIDEBAR_COOKIE_EXPIRATION = 365 * 10; diff --git a/app/assets/javascripts/vue_shared/components/awards_list.vue b/app/assets/javascripts/vue_shared/components/awards_list.vue index cb38b3e13bb..8f1f7ba0ad8 100644 --- a/app/assets/javascripts/vue_shared/components/awards_list.vue +++ b/app/assets/javascripts/vue_shared/components/awards_list.vue @@ -35,11 +35,6 @@ export default { required: false, default: NO_USER_ID, }, - addButtonClass: { - type: String, - required: false, - default: '', - }, defaultAwards: { type: Array, required: false, @@ -50,6 +45,11 @@ export default { required: false, default: 'selected', }, + boundary: { + type: String, + required: false, + default: '', + }, }, data() { return { @@ -201,6 +201,8 @@ export default { v-gl-tooltip.viewport :title="__('Add reaction')" :toggle-class="['add-reaction-button btn-icon gl-relative!', { 'is-active': isMenuOpen }]" + :right="false" + :boundary="boundary" data-testid="emoji-picker" @click="handleAward" @shown="setIsMenuOpen(true)" |