diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2023-04-11 18:08:32 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2023-04-11 18:08:32 +0300 |
commit | f1ce71c88c407709987dd4a7b40bdb7596b6baa2 (patch) | |
tree | 0d20ea80baaf8c11524584f586c2cc763af07cb2 /config | |
parent | 28e90894e1e6f17320f5b1d2fff6fe736bf65dff (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'config')
-rw-r--r-- | config/feature_flags/development/include_groups_from_group_shares_in_project_creation_locations.yml | 8 | ||||
-rw-r--r-- | config/vue3migration/compiler.js | 15 |
2 files changed, 23 insertions, 0 deletions
diff --git a/config/feature_flags/development/include_groups_from_group_shares_in_project_creation_locations.yml b/config/feature_flags/development/include_groups_from_group_shares_in_project_creation_locations.yml new file mode 100644 index 00000000000..7a2770f4b27 --- /dev/null +++ b/config/feature_flags/development/include_groups_from_group_shares_in_project_creation_locations.yml @@ -0,0 +1,8 @@ +--- +name: include_groups_from_group_shares_in_project_creation_locations +introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/116089 +rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/403019 +milestone: '15.11' +type: development +group: group::tenant scale +default_enabled: false diff --git a/config/vue3migration/compiler.js b/config/vue3migration/compiler.js index bb92e1e2356..a2c82584227 100644 --- a/config/vue3migration/compiler.js +++ b/config/vue3migration/compiler.js @@ -1,5 +1,7 @@ const { parse, compile: compilerDomCompile } = require('@vue/compiler-dom'); +const COMMENT_NODE_TYPE = 3; + const getPropIndex = (node, prop) => node.props?.findIndex((p) => p.name === prop) ?? -1; function modifyKeysInsideTemplateTag(templateNode) { @@ -26,6 +28,19 @@ module.exports = { parse, compile(template, options) { const rootNode = parse(template, options); + + // We do not want to switch to whitespace: collapse mode which is Vue.js 3 default + // It will be too devastating to codebase + + // However, without `whitespace: condense` Vue will treat spaces between comments + // and nodes itself as text nodes, resulting in multi-root component + // For multi-root component passing classes / attributes fallthrough will not work + + // See https://github.com/vuejs/core/issues/7909 for details + + // To fix that we simply drop all component comments only on top-level + rootNode.children = rootNode.children.filter((n) => n.type !== COMMENT_NODE_TYPE); + const pendingNodes = [rootNode]; while (pendingNodes.length) { const currentNode = pendingNodes.pop(); |