diff options
author | Lin Jen-Shin <godfat@godfat.org> | 2019-09-06 09:22:02 +0300 |
---|---|---|
committer | Lin Jen-Shin <godfat@godfat.org> | 2019-09-06 09:22:02 +0300 |
commit | 351d72cbed57c5b117e6b2239dffabcedbc45046 (patch) | |
tree | 0c1d87332450741f710e159485a0f1e8899767ee /danger/duplicate_yarn_dependencies/Dangerfile | |
parent | 13227500f29d8a74c77cba23b7dfdb4169222821 (diff) | |
parent | 70e1a17604a45419b079ab9da5ef69e010b103c6 (diff) |
Merge branch '66596-allow-danger-to-be-run-locally' into 'master'
Break up Danger rules into local or CI only
See merge request gitlab-org/gitlab-ce!32196
Diffstat (limited to 'danger/duplicate_yarn_dependencies/Dangerfile')
-rw-r--r-- | danger/duplicate_yarn_dependencies/Dangerfile | 24 |
1 files changed, 13 insertions, 11 deletions
diff --git a/danger/duplicate_yarn_dependencies/Dangerfile b/danger/duplicate_yarn_dependencies/Dangerfile index 25f81ec86a4..492b888d00e 100644 --- a/danger/duplicate_yarn_dependencies/Dangerfile +++ b/danger/duplicate_yarn_dependencies/Dangerfile @@ -1,6 +1,6 @@ # frozen_string_literal: true -return unless helper.all_changed_files.include? 'yarn.lock' +return unless helper.all_changed_files.include?('yarn.lock') duplicate = `node_modules/.bin/yarn-deduplicate --list --strategy fewer yarn.lock` .split(/$/) @@ -11,17 +11,19 @@ return if duplicate.empty? warn 'This merge request has introduced duplicated yarn dependencies.' -markdown(<<~MARKDOWN) - ## Duplicate yarn dependencies +if GitlabDanger.new(helper.gitlab_helper).ci? + markdown(<<~MARKDOWN) + ## Duplicate yarn dependencies - The following dependencies should be de-duplicated: + The following dependencies should be de-duplicated: - * #{duplicate.map { |path| "`#{path}`" }.join("\n* ")} + * #{duplicate.map { |path| "`#{path}`" }.join("\n* ")} - Please run the following command and commit the changes to `yarn.lock`: + Please run the following command and commit the changes to `yarn.lock`: - ``` - node_modules/.bin/yarn-deduplicate --strategy fewer yarn.lock \\ - && yarn install - ``` -MARKDOWN + ``` + node_modules/.bin/yarn-deduplicate --strategy fewer yarn.lock \\ + && yarn install + ``` + MARKDOWN +end |