diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-09-22 15:09:39 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-09-22 15:09:39 +0300 |
| commit | 26879909dd0571b392f105373a700a314201cd53 (patch) | |
| tree | 800cb6476926e919ce7cabdcadd58a1cdb3178e1 /danger | |
| parent | 1086ac5177a6762ac14bccc6ce5584781bd44d1c (diff) | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'danger')
| -rw-r--r-- | danger/telemetry/Dangerfile | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/danger/telemetry/Dangerfile b/danger/telemetry/Dangerfile index 6cfc1a005c3..e335f6e0f73 100644 --- a/danger/telemetry/Dangerfile +++ b/danger/telemetry/Dangerfile @@ -2,7 +2,7 @@ TELEMETRY_CHANGED_FILES_MESSAGE = <<~MSG For the following files, a review from the [Data team and Telemetry team](https://gitlab.com/groups/gitlab-org/growth/telemetry/engineers/-/group_members?with_inherited_permissions=exclude) is recommended -Please check the ~telemetry [guide](https://docs.gitlab.com/ee/development/telemetry/usage_ping.html) and reach out to @gitlab-org/growth/telemetry/engineers group for a review. +Please check the ~telemetry [guide](https://docs.gitlab.com/ee/development/telemetry/usage_ping.html) and reach out to %<telemetry_engineers_group>s group for a review. %<changed_files>s @@ -13,6 +13,8 @@ UPDATE_METRICS_DEFINITIONS_MESSAGE = <<~MSG MSG +TELEMETRY_ENGINEERS_GROUP = '@gitlab-org/growth/telemetry/engineers' + tracking_files = [ 'lib/gitlab/tracking.rb', 'spec/lib/gitlab/tracking_spec.rb', @@ -28,7 +30,14 @@ snowplow_events_changed_files = git.modified_files & tracking_files changed_files = (usage_data_changed_files + snowplow_events_changed_files) if changed_files.any? - warn format(TELEMETRY_CHANGED_FILES_MESSAGE, changed_files: helper.markdown_list(changed_files)) + + mention = if helper.draft_mr? + "`#{TELEMETRY_ENGINEERS_GROUP}`" + else + TELEMETRY_ENGINEERS_GROUP + end + + warn format(TELEMETRY_CHANGED_FILES_MESSAGE, changed_files: helper.markdown_list(changed_files), telemetry_engineers_group: mention) warn format(UPDATE_METRICS_DEFINITIONS_MESSAGE) unless helper.changed_files(/usage_ping\.md/).any? telemetry_labels = ['telemetry'] |