diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-05-06 21:09:38 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-05-06 21:09:38 +0300 |
| commit | 73886079f3f877ffb8f8938d700643a5e99bc849 (patch) | |
| tree | ff8f3c64df680962c1da38156e8c1e63a015b0fb /danger | |
| parent | a7beadc83470bd9ce23757a019795f49f95a6fff (diff) | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'danger')
| -rw-r--r-- | danger/telemetry/Dangerfile | 16 |
1 files changed, 14 insertions, 2 deletions
diff --git a/danger/telemetry/Dangerfile b/danger/telemetry/Dangerfile index dd3c8a6a322..c18a15fcb03 100644 --- a/danger/telemetry/Dangerfile +++ b/danger/telemetry/Dangerfile @@ -9,12 +9,24 @@ USAGE_DATA_FILES_MESSAGE = <<~MSG For the following files, a review from the [Data team and Telemetry team](https://gitlab.com/groups/gitlab-org/growth/telemetry/engineers/-/group_members?with_inherited_permissions=exclude) is recommended: MSG +tracking_files = [ + 'lib/gitlab/tracking.rb', + 'spec/lib/gitlab/tracking_spec.rb', + 'app/helpers/tracking_helper.rb', + 'spec/helpers/tracking_helper_spec.rb', + 'app/assets/javascripts/tracking.js', + 'spec/frontend/tracking_spec.js' + ] + usage_data_changed_files = git.modified_files.grep(%r{usage_data}) +snowplow_events_changed_files = git.modified_files & tracking_files + +changed_files = (usage_data_changed_files + snowplow_events_changed_files) -if usage_data_changed_files.any? +if changed_files.any? warn format(TELEMETRY_CHANGED_FILES_MESSAGE) - markdown(USAGE_DATA_FILES_MESSAGE + helper.markdown_list(usage_data_changed_files)) + markdown(USAGE_DATA_FILES_MESSAGE + helper.markdown_list(changed_files)) telemetry_labels = ['telemetry'] telemetry_labels << 'telemetry::review pending' unless helper.mr_has_labels?('telemetry::reviewed') |