diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-04-06 15:09:21 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-04-06 15:09:21 +0300 |
| commit | ebed39e3cedad74e1a1ee4e8d33adfb8bbdc7040 (patch) | |
| tree | ae91160251c527eb063413ff9e530b6da96eb74d /danger | |
| parent | 61ee5c363522f2639d1c515a74b9b02b7672c7c2 (diff) | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'danger')
| -rw-r--r-- | danger/product_intelligence/Dangerfile | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/danger/product_intelligence/Dangerfile b/danger/product_intelligence/Dangerfile index d2ce2b31e64..d2bed7629ff 100644 --- a/danger/product_intelligence/Dangerfile +++ b/danger/product_intelligence/Dangerfile @@ -3,15 +3,13 @@ CHANGED_FILES_MESSAGE = <<~MSG For the following files, a review from the [Data team and Product Intelligence team](https://gitlab.com/groups/gitlab-org/growth/product-intelligence/engineers/-/group_members?with_inherited_permissions=exclude) is recommended -Please check the ~"product intelligence" [guide](https://docs.gitlab.com/ee/development/usage_ping.html) and reach out to %<engineers_group>s group for a review. +Please check the ~"product intelligence" [guide](https://docs.gitlab.com/ee/development/usage_ping.html). %<changed_files>s MSG -ENGINEERS_GROUP = '@gitlab-org/growth/product-intelligence/engineers' - UPDATE_DICTIONARY_MESSAGE = <<~MSG When adding, changing, or updating metrics, please update the [Metrics Dictionary](https://docs.gitlab.com/ee/development/usage_ping/dictionary.html) @@ -84,8 +82,7 @@ matching_changed_files = usage_data_changed_files + if matching_changed_files.any? - mention = "`#{ENGINEERS_GROUP}`" - warn format(CHANGED_FILES_MESSAGE, changed_files: helper.markdown_list(matching_changed_files), engineers_group: mention) + warn format(CHANGED_FILES_MESSAGE, changed_files: helper.markdown_list(matching_changed_files)) fail format(UPDATE_DICTIONARY_MESSAGE) if required_dictionary_update_changed_files.any? && dictionary_changed_file.empty? |