diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-08-12 15:11:05 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-08-12 15:11:05 +0300 |
| commit | 2fe5ea34a5f63661a050404d3b5fbe3056a39765 (patch) | |
| tree | 630d5b896d2933d38a206abf4e2baf7e1b773027 /doc/development/code_review.md | |
| parent | dcb517514405d6f550cc077686889dbb34c37c75 (diff) | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc/development/code_review.md')
| -rw-r--r-- | doc/development/code_review.md | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 4d2007f548f..f542b11e864 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -578,11 +578,12 @@ context is fresh in memory, and improves contributors' experience significantly. To ensure swift feedback to ready-to-review code, we maintain a `Review-response` Service-level Objective (SLO). The SLO is defined as: -> - review-response SLO = (time when first review response is provided) - (time MR is assigned to reviewer) < 2 business days +> Review-response SLO = (time when first review is provided) - (time MR is assigned to reviewer) < 2 business days If you don't think you can review a merge request in the `Review-response` SLO -time frame, let the author know as soon as possible and try to help them find -another reviewer or maintainer who is able to, so that they can be unblocked +time frame, let the author know as soon as possible in the comments +(no later than 36 hours after first receiving the review request) +and try to help them find another reviewer or maintainer who is able to, so that they can be unblocked and get on with their work quickly. Remove yourself as a reviewer. If you think you are at capacity and are unable to accept any more reviews until |