diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-07-19 21:08:23 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-07-19 21:08:23 +0300 |
| commit | 3f0db3db2ad99a74c3969bf2e930814004ccf1ec (patch) | |
| tree | c8b4123b3b4b422b14211430b85556e64eb68a26 /doc/development/code_review.md | |
| parent | 4a721269429a178957e8ce7c6d0a75d3307c9830 (diff) | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc/development/code_review.md')
| -rw-r--r-- | doc/development/code_review.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index a24a4ecc266..929e75e7774 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -384,7 +384,7 @@ Before taking the decision to merge: - Set the milestone. - Consider warnings and errors from danger bot, code quality, and other reports. Unless a strong case can be made for the violation, these should be resolved - before merging. A comment must to be posted if the MR is merged with any failed job. + before merging. A comment must be posted if the MR is merged with any failed job. - If the MR contains both Quality and non-Quality-related changes, the MR should be merged by the relevant maintainer for user-facing changes (backend, frontend, or database) after the Quality related changes are approved by a Software Engineer in Test. If a merge request is fundamentally ready, but needs only trivial fixes (such as |