Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarcel Amirault <mamirault@gitlab.com>2019-07-19 05:20:32 +0300
committerEvan Read <eread@gitlab.com>2019-07-19 05:20:32 +0300
commit7da80b2d36adc30964423042e956ef880a2650f9 (patch)
tree81c5e21931e2d2134fbedb8c0a859aeac6d14c5b /doc/development/code_review.md
parentacdb1f79688adae87933b34c3140e286ebab055c (diff)
Update numbered lists for docs standards
Ensure that all numbered lists use only 1. and no other numbers. Also ensure that numbered lists use proper spacing.
Diffstat (limited to 'doc/development/code_review.md')
-rw-r--r--doc/development/code_review.md3
1 files changed, 1 insertions, 2 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md
index e9c8b193309..a9a46c62d38 100644
--- a/doc/development/code_review.md
+++ b/doc/development/code_review.md
@@ -341,8 +341,7 @@ Enterprise Edition instance. This has some implications:
- [Background migrations](background_migrations.md) run in Sidekiq, and
should only be done for migrations that would take an extreme amount of
time at GitLab.com scale.
-1. **Sidekiq workers**
- [cannot change in a backwards-incompatible way](sidekiq_style_guide.md#removing-or-renaming-queues):
+1. **Sidekiq workers** [cannot change in a backwards-incompatible way](sidekiq_style_guide.md#removing-or-renaming-queues):
1. Sidekiq queues are not drained before a deploy happens, so there will be
workers in the queue from the previous version of GitLab.
1. If you need to change a method signature, try to do so across two releases,