diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-12-12 15:08:36 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-12-12 15:08:36 +0300 |
commit | 77ba8f96b5da12090a50c31be7f8503aad21cb33 (patch) | |
tree | 6d2502de91f8bf0ba469db44a1fbc4bd847ced2c /doc/development/sidekiq/compatibility_across_updates.md | |
parent | 8973e49a6060d87845807a1ea6760c48f1e476a8 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc/development/sidekiq/compatibility_across_updates.md')
-rw-r--r-- | doc/development/sidekiq/compatibility_across_updates.md | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/doc/development/sidekiq/compatibility_across_updates.md b/doc/development/sidekiq/compatibility_across_updates.md index c9759a1c95f..b417a099228 100644 --- a/doc/development/sidekiq/compatibility_across_updates.md +++ b/doc/development/sidekiq/compatibility_across_updates.md @@ -158,7 +158,10 @@ To remove a worker class, follow these steps over two minor releases: By implementing this no-op, you can avoid unnecessary cycles once any deprecated jobs that are still enqueued eventually get processed. -1. In a separate merge request, because it's a migration, consider using the `sidekiq_remove_jobs` helper migration method in a **post-deployment migration**: +### In a subsequent, separate minor release + +1. Delete the worker class file and follow the guidance in our [Sidekiq queues documentation](../sidekiq/index.md#sidekiq-queues) around running Rake tasks to regenerate/update related files. +1. Add a migration (not a post-deployment migration) that uses `sidekiq_remove_jobs`: ```ruby class RemoveMyDeprecatedWorkersJobInstances < Gitlab::Database::Migration[2.0] @@ -177,10 +180,6 @@ To remove a worker class, follow these steps over two minor releases: end ``` -#### In a subsequent, separate minor release - -1. Delete the worker class file and follow the guidance in our [Sidekiq queues documentation](../sidekiq/index.md#sidekiq-queues) around running Rake tasks to regenerate/update related files. - ## Renaming queues For the same reasons that removing workers is dangerous, care should be taken |