diff options
| author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-10-20 00:10:55 +0300 |
|---|---|---|
| committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-10-20 00:10:55 +0300 |
| commit | f7f930eadb300b1b1c69752381289c3a8e37c7c3 (patch) | |
| tree | 1ac57ce64cc5709a72e3d7c6fdda5e1165c83180 /doc/development | |
| parent | b45b4fa37b88501538b4139ef9f2f2777414d630 (diff) | |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc/development')
| -rw-r--r-- | doc/development/code_review.md | 4 | ||||
| -rw-r--r-- | doc/development/documentation/topic_types/troubleshooting.md | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 5b745f06d22..00922995562 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -56,8 +56,8 @@ We make the following assumption with regards to automatically being considered - Team members working in a specific stage/group (for example, create: source code) are considered domain experts for that area of the app they work on. - Team members working on a specific feature (for example, search) are considered domain experts for that feature. -We default to assigning reviews to team members with domain expertise. -When a suitable [domain expert](#domain-experts) isn't available, you can choose any team member to review the MR, or follow the [Reviewer roulette](#reviewer-roulette) recommendation. +We default to assigning reviews to team members with domain expertise for code reviews. For UX reviews we default to the recommended designer from the Reviewer roulette. +When a suitable [domain expert](#domain-experts) isn't available, you can choose any team member to review the MR, or follow the [Reviewer roulette](#reviewer-roulette) recommendation (see above for UX reviews). To find a domain expert: diff --git a/doc/development/documentation/topic_types/troubleshooting.md b/doc/development/documentation/topic_types/troubleshooting.md index e2136de2e06..3a6329e0adc 100644 --- a/doc/development/documentation/topic_types/troubleshooting.md +++ b/doc/development/documentation/topic_types/troubleshooting.md @@ -9,7 +9,7 @@ info: To determine the technical writer assigned to the Stage/Group associated w Troubleshooting topics should be the last topics on a page. If a page has more than five troubleshooting topics, put the content on a separate page that has troubleshooting information exclusively. Name the page `Troubleshooting <feature>` -and in the left nav, use the word `Troubleshoot` only. +and in the left nav, use the word `Troubleshooting` only. Troubleshooting can be one of three types. |