diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-05-18 15:08:08 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-05-18 15:08:08 +0300 |
commit | 48650fe1bfc1e3d20ec3a5702ef4d64e9fe69912 (patch) | |
tree | 0f73ad6e03989c301b79490ddb30125c233e4eff /doc | |
parent | 1b9a2ce27825c02cc14b594ed5ea061fccf1d957 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'doc')
-rw-r--r-- | doc/administration/packages/container_registry.md | 21 | ||||
-rw-r--r-- | doc/ci/docker/using_kaniko.md | 1 | ||||
-rw-r--r-- | doc/ci/yaml/README.md | 6 | ||||
-rw-r--r-- | doc/development/code_review.md | 17 | ||||
-rw-r--r-- | doc/raketasks/x509_signatures.md | 6 | ||||
-rw-r--r-- | doc/user/group/epics/manage_epics.md | 8 |
6 files changed, 40 insertions, 19 deletions
diff --git a/doc/administration/packages/container_registry.md b/doc/administration/packages/container_registry.md index 8c78cd66b3f..14ae0c3e8c6 100644 --- a/doc/administration/packages/container_registry.md +++ b/doc/administration/packages/container_registry.md @@ -18,21 +18,22 @@ You can read more about the Docker Registry at **Omnibus GitLab installations** -If you are using the Omnibus GitLab built-in [Let's Encrypt integration](https://docs.gitlab.com/omnibus/settings/ssl.html#lets-encrypt-integration), as of GitLab 12.5, the Container Registry will be automatically enabled on port 5050 of the default domain. +If you installed GitLab by using the Omnibus installation package, the Container Registry +may or may not be available by default. -If you are not using GitLab 12.5 or later, or do not use GitLab's built-in Let's Encrypt -integration, the GitLab Container Registry must be enabled and -[configured to use an external domain](#container-registry-domain-configuration). +The Container Registry is automatically enabled and available on your GitLab domain, port 5050 if: -To enable the GitLab Container Registry on your *existing* GitLab domain, refer to the section on -[configuring Container Registry to use an existing domain](#configure-container-registry-under-an-existing-gitlab-domain). +- You're using the built-in [Let's Encrypt integration](https://docs.gitlab.com/omnibus/settings/ssl.html#lets-encrypt-integration), and +- You're using GitLab 12.5 or later. -To use a *separate* domain with your Container Registry, refer to the section on -[configuring Container Registry under its own domain](#configure-container-registry-under-its-own-domain). +Otherwise, the Container Registry is not enabled. To enable it: + +- You can configure it for your [GitLab domain](#configure-container-registry-under-an-existing-gitlab-domain), or +- You can configure it for [a different domain](#configure-container-registry-under-its-own-domain). NOTE: **Note:** -The container registry works under HTTPS by default. Using HTTP is possible -but not recommended and out of the scope of this document. +The Container Registry works under HTTPS by default. You can use HTTP +but it's not recommended and is out of the scope of this document. Read the [insecure Registry documentation](https://docs.docker.com/registry/insecure/) if you want to implement this. diff --git a/doc/ci/docker/using_kaniko.md b/doc/ci/docker/using_kaniko.md index 99d01590895..587f1f91f72 100644 --- a/doc/ci/docker/using_kaniko.md +++ b/doc/ci/docker/using_kaniko.md @@ -82,6 +82,7 @@ store: ```yaml before_script: + - mkdir -p /kaniko/.docker - echo "{\"auths\":{\"$CI_REGISTRY\":{\"username\":\"$CI_REGISTRY_USER\",\"password\":\"$CI_REGISTRY_PASSWORD\"}}}" > /kaniko/.docker/config.json - | echo "-----BEGIN CERTIFICATE----- diff --git a/doc/ci/yaml/README.md b/doc/ci/yaml/README.md index 64ee2940eee..3a8e08291e1 100644 --- a/doc/ci/yaml/README.md +++ b/doc/ci/yaml/README.md @@ -3617,7 +3617,7 @@ Read more about the various [YAML features](https://learnxinyminutes.com/docs/ya YAML has a handy feature called 'anchors', which lets you easily duplicate content across your document. Anchors can be used to duplicate/inherit -properties, and is a perfect example to be used with [hidden keys](#hide-jobs) +properties, and is a perfect example to be used with [hidden jobs](#hide-jobs) to provide templates for your jobs. The following example uses anchors and map merging. It will create two jobs, @@ -3731,7 +3731,7 @@ test:mysql: - ruby ``` -You can see that the hidden keys are conveniently used as templates. +You can see that the hidden jobs are conveniently used as templates. NOTE: **Note:** You can't use YAML anchors across multiple files when leveraging the [`include`](#include) @@ -3829,7 +3829,7 @@ GitLab CI/CD. In the following example, `.hidden_job` will be ignored: ``` Use this feature to ignore jobs, or use the -[special YAML features](#special-yaml-features) and transform the hidden keys +[special YAML features](#special-yaml-features) and transform the hidden jobs into templates. ## Skip Pipeline diff --git a/doc/development/code_review.md b/doc/development/code_review.md index e49ad23d822..a5ad7dc0f46 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -327,6 +327,23 @@ Before taking the decision to merge: before merging. A comment must to be posted if the MR is merged with any failed job. - If the MR contains both Quality and non-Quality-related changes, the MR should be merged by the relevant maintainer for user-facing changes (backend, frontend, or database) after the Quality related changes are approved by a Software Engineer in Test. +If a merge request is fundamentally ready, but needs only trivial fixes (such as +typos), consider demonstrating a [bias for +action](https://about.gitlab.com/handbook/values/#bias-for-action) by making +those changes directly without going back to the author. You can do this by +using the [suggest changes](../user/discussions/index.md#suggest-changes) feature to apply +your own suggestions to the merge request. Note that: + +- If the changes are not straightforward, please prefer assigning the merge request back + to the author. +- **Before applying suggestions**, edit the merge request to make sure + [squash and + merge](../user/project/merge_requests/squash_and_merge.md#squash-and-merge) + is enabled, otherwise, the pipeline's Danger job will fail. + - If a merge request does not have squash and merge enabled, and it + has more than one commit, then see the note below about rewriting + commit history. + When ready to merge: - Consider using the [Squash and diff --git a/doc/raketasks/x509_signatures.md b/doc/raketasks/x509_signatures.md index e52584680f4..f7c47794690 100644 --- a/doc/raketasks/x509_signatures.md +++ b/doc/raketasks/x509_signatures.md @@ -1,5 +1,7 @@ # X.509 signatures **(CORE ONLY)** +> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/122159) in GitLab 12.10. + When [signing commits with X.509](../user/project/repository/x509_signed_commits/index.md), the trust anchor might change and the signatures stored within the database must be updated. @@ -10,13 +12,13 @@ certificate store. To update all X.509 signatures, run: -**Omnibus Installation** +**Omnibus Installations:** ```shell sudo gitlab-rake gitlab:x509:update_signatures ``` -**Source Installation** +**Source Installations:** ```shell sudo -u git -H bundle exec rake gitlab:x509:update_signatures RAILS_ENV=production diff --git a/doc/user/group/epics/manage_epics.md b/doc/user/group/epics/manage_epics.md index b94def57c76..50eb0c64f4b 100644 --- a/doc/user/group/epics/manage_epics.md +++ b/doc/user/group/epics/manage_epics.md @@ -217,9 +217,9 @@ To reorder child epics assigned to an epic: 1. Go to the **Epics and Issues** tab. 1. Drag and drop epics into the desired order. -### Move issues between epics +### Move issues between epics **(ULTIMATE)** -> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/33039) in GitLab 13.0. +> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/33039) in [GitLab Ultimate](https://about.gitlab.com/pricing/) 13.0. New issues are added to the top of their list in the **Epics and Issues** tab. You can move issues from one epic to another. Issues and child epics cannot be intermingled. @@ -270,14 +270,14 @@ To add a child epic to an epic: ### Move child epics between epics -> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/33039) in GitLab 13.0. +> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/33039) in [GitLab Ultimate](https://about.gitlab.com/pricing/) 13.0. New child epics are added to the top of their list in the **Epics and Issues** tab. You can move child epics from one epic to another. When you add an epic that's already linked to a parent epic, the link to its current parent is removed. Issues and child epics cannot be intermingled. -To move child epics **(ULTIMATE)** to another epic: +To move child epics to another epic: 1. Go to the **Epics and Issues** tab. 1. Drag and drop epics into the desired parent epic. |