diff options
author | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2018-04-10 13:56:52 +0300 |
---|---|---|
committer | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2018-04-11 11:52:08 +0300 |
commit | 160ffb6870c39d467bd5efa4170007be18ccd7d2 (patch) | |
tree | 08dd4687a1d3bc95e5d8e6691914e054fcf82071 /lib/gitlab/ci/status | |
parent | 7e3bb679a92156304972e2db1ae49c9b0e4cd188 (diff) |
Fix empty state for build that doesn ot have a trace
It also adds a fallback that covers other edge cases that might surface
later.
Diffstat (limited to 'lib/gitlab/ci/status')
-rw-r--r-- | lib/gitlab/ci/status/build/common.rb | 7 | ||||
-rw-r--r-- | lib/gitlab/ci/status/build/empty.rb | 21 | ||||
-rw-r--r-- | lib/gitlab/ci/status/build/factory.rb | 3 |
3 files changed, 30 insertions, 1 deletions
diff --git a/lib/gitlab/ci/status/build/common.rb b/lib/gitlab/ci/status/build/common.rb index c0c7c7f5b5d..639e88ebf1f 100644 --- a/lib/gitlab/ci/status/build/common.rb +++ b/lib/gitlab/ci/status/build/common.rb @@ -3,6 +3,13 @@ module Gitlab module Status module Build module Common + def illustration + { + image: 'illustrations/skipped-job_empty.svg', + size: 'svg-430' + } + end + def has_details? can?(user, :read_build, subject) end diff --git a/lib/gitlab/ci/status/build/empty.rb b/lib/gitlab/ci/status/build/empty.rb new file mode 100644 index 00000000000..3e598877602 --- /dev/null +++ b/lib/gitlab/ci/status/build/empty.rb @@ -0,0 +1,21 @@ +module Gitlab + module Ci + module Status + module Build + class Empty < Status::Extended + def illustration + { + image: 'illustrations/skipped-job_empty.svg', + size: 'svg-430', + title: _('This job does not have a trace.') + } + end + + def self.matches?(build, user) + !build.has_trace? + end + end + end + end + end +end diff --git a/lib/gitlab/ci/status/build/factory.rb b/lib/gitlab/ci/status/build/factory.rb index 2b26ebb45a1..0b42d5edfc1 100644 --- a/lib/gitlab/ci/status/build/factory.rb +++ b/lib/gitlab/ci/status/build/factory.rb @@ -17,7 +17,8 @@ module Gitlab Status::Build::Play, Status::Build::Stop], [Status::Build::Action], - [Status::Build::Retried]] + [Status::Build::Retried], + [Status::Build::Empty]] end def self.common_helpers |