diff options
| author | Ben Kochie <superq@gmail.com> | 2017-07-12 15:48:46 +0300 |
|---|---|---|
| committer | Ben Kochie <superq@gmail.com> | 2017-07-12 15:48:46 +0300 |
| commit | 86cbef4df42efae51732e01070dfad456dc5c1b5 (patch) | |
| tree | ffad16b36de52e8a0a5abae3f1353369f40c9c5f /lib/gitlab/health_checks | |
| parent | e9363229b749db194a999dc76787ba92fd127dbc (diff) | |
Add unit to latency metrics.
Add `seconds` unit to latency metrics based on uptream naming
convention[0].
[0]: https://prometheus.io/docs/practices/naming/#metric-names
Diffstat (limited to 'lib/gitlab/health_checks')
| -rw-r--r-- | lib/gitlab/health_checks/fs_shards_check.rb | 6 | ||||
| -rw-r--r-- | lib/gitlab/health_checks/simple_abstract_check.rb | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/lib/gitlab/health_checks/fs_shards_check.rb b/lib/gitlab/health_checks/fs_shards_check.rb index 70da4080cae..bebde857b16 100644 --- a/lib/gitlab/health_checks/fs_shards_check.rb +++ b/lib/gitlab/health_checks/fs_shards_check.rb @@ -35,9 +35,9 @@ module Gitlab repository_storages.flat_map do |storage_name| tmp_file_path = tmp_file_path(storage_name) [ - operation_metrics(:filesystem_accessible, :filesystem_access_latency, -> { storage_stat_test(storage_name) }, shard: storage_name), - operation_metrics(:filesystem_writable, :filesystem_write_latency, -> { storage_write_test(tmp_file_path) }, shard: storage_name), - operation_metrics(:filesystem_readable, :filesystem_read_latency, -> { storage_read_test(tmp_file_path) }, shard: storage_name) + operation_metrics(:filesystem_accessible, :filesystem_access_latency_seconds, -> { storage_stat_test(storage_name) }, shard: storage_name), + operation_metrics(:filesystem_writable, :filesystem_write_latency_seconds, -> { storage_write_test(tmp_file_path) }, shard: storage_name), + operation_metrics(:filesystem_readable, :filesystem_read_latency_seconds, -> { storage_read_test(tmp_file_path) }, shard: storage_name) ].flatten end end diff --git a/lib/gitlab/health_checks/simple_abstract_check.rb b/lib/gitlab/health_checks/simple_abstract_check.rb index fbe1645c1b1..3dcb28a193c 100644 --- a/lib/gitlab/health_checks/simple_abstract_check.rb +++ b/lib/gitlab/health_checks/simple_abstract_check.rb @@ -20,7 +20,7 @@ module Gitlab [ metric("#{metric_prefix}_timeout", result.is_a?(Timeout::Error) ? 1 : 0), metric("#{metric_prefix}_success", is_successful?(result) ? 1 : 0), - metric("#{metric_prefix}_latency", elapsed) + metric("#{metric_prefix}_latency_seconds", elapsed) ] end end |