diff options
author | Bob Van Landuyt <bob@vanlanduyt.co> | 2018-05-07 18:56:18 +0300 |
---|---|---|
committer | Bob Van Landuyt <bob@vanlanduyt.co> | 2018-06-15 15:58:46 +0300 |
commit | 3b5ce6945dee059717855962271245bbb29f24e1 (patch) | |
tree | c499b124287fa38686556fa62d03d0825aaaf284 /lib/gitlab/i18n | |
parent | ca065e493e7a62f22cb330659e75f8567fa6131f (diff) |
Validate PO-variable usage in message ids
That way we can detect incorrect usage before the strings are added to
Crowdin for translation
Diffstat (limited to 'lib/gitlab/i18n')
-rw-r--r-- | lib/gitlab/i18n/po_linter.rb | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/gitlab/i18n/po_linter.rb b/lib/gitlab/i18n/po_linter.rb index ab79d4188dc..ba08ef59776 100644 --- a/lib/gitlab/i18n/po_linter.rb +++ b/lib/gitlab/i18n/po_linter.rb @@ -109,10 +109,14 @@ module Gitlab def validate_variables(errors, entry) if entry.has_singular_translation? + validate_variables_in_message(errors, entry.msgid, entry.msgid) + validate_variables_in_message(errors, entry.msgid, entry.singular_translation) end if entry.has_plural? + validate_variables_in_message(errors, entry.plural_id, entry.plural_id) + entry.plural_translations.each do |translation| validate_variables_in_message(errors, entry.plural_id, translation) end |