diff options
| author | Kamil Trzciński <ayufan@ayufan.eu> | 2019-04-08 16:33:36 +0300 |
|---|---|---|
| committer | Kamil Trzciński <ayufan@ayufan.eu> | 2019-04-15 14:05:14 +0300 |
| commit | 650f40865e5d8136cb366fbde689c4100aafb0c5 (patch) | |
| tree | f740d9f235693ad8e2a3693d6ec30dee26d2a74a /lib/gitlab/optimistic_locking.rb | |
| parent | 7457c1e1229cd1e90e608e8b247e2fbb217f05b6 (diff) | |
Forbid the use of `#reload` and prefer `#reset`
The `#reload` makes to load all objects into memory,
and the main purpose of `#reload` is to drop the association cache.
The `#reset` seems to solve exactly that case.
Diffstat (limited to 'lib/gitlab/optimistic_locking.rb')
| -rw-r--r-- | lib/gitlab/optimistic_locking.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/gitlab/optimistic_locking.rb b/lib/gitlab/optimistic_locking.rb index ce4ba9f752b..868b2ae641a 100644 --- a/lib/gitlab/optimistic_locking.rb +++ b/lib/gitlab/optimistic_locking.rb @@ -12,7 +12,7 @@ module Gitlab retries -= 1 raise unless retries >= 0 - subject.reload + subject.reset retry end |