diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-06-03 15:10:18 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-06-03 15:10:18 +0300 |
commit | f5987db869d7025fb8f403edc5106c5f2a3e448f (patch) | |
tree | 804c2c04e607f8d5010be1541fac4e325b9d116a /lib | |
parent | e5f183140340a76754af3beabff0fcd74212a102 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'lib')
-rw-r--r-- | lib/api/entities/release.rb | 7 | ||||
-rw-r--r-- | lib/api/releases.rb | 9 | ||||
-rw-r--r-- | lib/gitlab/ci/jwt.rb | 1 | ||||
-rw-r--r-- | lib/gitlab/data_builder/wiki_page.rb | 3 | ||||
-rw-r--r-- | lib/gitlab/prometheus/adapter.rb | 3 | ||||
-rw-r--r-- | lib/gitlab/usage_data_counters/known_events/common.yml | 1 |
6 files changed, 11 insertions, 13 deletions
diff --git a/lib/api/entities/release.rb b/lib/api/entities/release.rb index 94124352298..056b54674f1 100644 --- a/lib/api/entities/release.rb +++ b/lib/api/entities/release.rb @@ -8,7 +8,7 @@ module API expose :name expose :tag, as: :tag_name, if: ->(_, _) { can_download_code? } expose :description - expose :description_html, unless: ->(_, _) { remove_description_html? } do |entity| + expose :description_html, if: -> (_, options) { options[:include_html_description] } do |entity| MarkupHelper.markdown_field(entity, :description, current_user: options[:current_user]) end expose :created_at @@ -45,11 +45,6 @@ module API def can_read_milestone? Ability.allowed?(options[:current_user], :read_milestone, object.project) end - - def remove_description_html? - ::Feature.enabled?(:remove_description_html_in_release_api, object.project, default_enabled: :yaml) && - ::Feature.disabled?(:remove_description_html_in_release_api_override, object.project) - end end end end diff --git a/lib/api/releases.rb b/lib/api/releases.rb index c65a23e334f..7cd8b442706 100644 --- a/lib/api/releases.rb +++ b/lib/api/releases.rb @@ -29,6 +29,8 @@ module API desc: 'Return releases ordered by `released_at` or `created_at`.' optional :sort, type: String, values: %w[asc desc], default: 'desc', desc: 'Return releases sorted in `asc` or `desc` order.' + optional :include_html_description, type: Boolean, + desc: 'If `true`, a response includes HTML rendered markdown of the release description.' end get ':id/releases' do releases = ::ReleasesFinder.new(user_project, current_user, declared_params.slice(:order_by, :sort)).execute @@ -43,7 +45,8 @@ module API # context is unnecessary here. cache_context: -> (_) { "user:{#{current_user&.id}}" }, expires_in: 5.minutes, - current_user: current_user + current_user: current_user, + include_html_description: params[:include_html_description] end desc 'Get a single project release' do @@ -53,11 +56,13 @@ module API end params do requires :tag_name, type: String, desc: 'The name of the tag', as: :tag + optional :include_html_description, type: Boolean, + desc: 'If `true`, a response includes HTML rendered markdown of the release description.' end get ':id/releases/:tag_name', requirements: RELEASE_ENDPOINT_REQUIREMENTS do authorize_download_code! - present release, with: Entities::Release, current_user: current_user + present release, with: Entities::Release, current_user: current_user, include_html_description: params[:include_html_description] end desc 'Create a new release' do diff --git a/lib/gitlab/ci/jwt.rb b/lib/gitlab/ci/jwt.rb index 0b94debb24e..3fb86b8b3e8 100644 --- a/lib/gitlab/ci/jwt.rb +++ b/lib/gitlab/ci/jwt.rb @@ -54,6 +54,7 @@ module Gitlab user_login: user&.username, user_email: user&.email, pipeline_id: build.pipeline.id.to_s, + pipeline_source: build.pipeline.source.to_s, job_id: build.id.to_s, ref: source_ref, ref_type: ref_type, diff --git a/lib/gitlab/data_builder/wiki_page.rb b/lib/gitlab/data_builder/wiki_page.rb index 8aee25e9fe6..87679654a17 100644 --- a/lib/gitlab/data_builder/wiki_page.rb +++ b/lib/gitlab/data_builder/wiki_page.rb @@ -18,7 +18,8 @@ module Gitlab wiki: wiki.hook_attrs, object_attributes: wiki_page.hook_attrs.merge( url: Gitlab::UrlBuilder.build(wiki_page), - action: action + action: action, + diff_url: Gitlab::UrlBuilder.build(wiki_page, action: :diff, version_id: wiki_page.version.id) ) } end diff --git a/lib/gitlab/prometheus/adapter.rb b/lib/gitlab/prometheus/adapter.rb index 45438d9bf7c..a977040ef6f 100644 --- a/lib/gitlab/prometheus/adapter.rb +++ b/lib/gitlab/prometheus/adapter.rb @@ -19,9 +19,6 @@ module Gitlab end def cluster_prometheus_adapter - application = cluster&.application_prometheus - return application if application&.available? - integration = cluster&.integration_prometheus integration if integration&.available? end diff --git a/lib/gitlab/usage_data_counters/known_events/common.yml b/lib/gitlab/usage_data_counters/known_events/common.yml index 101c65981ee..f2e45a52434 100644 --- a/lib/gitlab/usage_data_counters/known_events/common.yml +++ b/lib/gitlab/usage_data_counters/known_events/common.yml @@ -344,7 +344,6 @@ category: terraform redis_slot: terraform aggregation: weekly - feature_flag: usage_data_p_terraform_state_api_unique_users # Pipeline Authoring - name: o_pipeline_authoring_unique_users_committing_ciconfigfile category: pipeline_authoring |