diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2022-12-01 15:09:35 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2022-12-01 15:09:35 +0300 |
commit | 4ee706fcd1ffcb2926fd9258e9f296c260a3d06c (patch) | |
tree | 47ef82efe01cd18bc0da6eb0922273aed9e060ea /rubocop | |
parent | 5a9468a4e504d06fd8f5a558f953f4af6355f702 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'rubocop')
-rw-r--r-- | rubocop/cop/rspec/timecop_freeze.rb | 41 | ||||
-rw-r--r-- | rubocop/cop/rspec/timecop_travel.rb | 41 |
2 files changed, 0 insertions, 82 deletions
diff --git a/rubocop/cop/rspec/timecop_freeze.rb b/rubocop/cop/rspec/timecop_freeze.rb deleted file mode 100644 index b13f5050040..00000000000 --- a/rubocop/cop/rspec/timecop_freeze.rb +++ /dev/null @@ -1,41 +0,0 @@ -# frozen_string_literal: true - -require 'rubocop-rspec' - -module RuboCop - module Cop - module RSpec - # This cop checks for `Timecop.freeze` usage in specs. - # - # @example - # - # # bad - # Timecop.freeze(Time.current) { example.run } - # - # # good - # freeze_time(Time.current) { example.run } - # - class TimecopFreeze < RuboCop::Cop::Base - extend RuboCop::Cop::AutoCorrector - - include MatchRange - MESSAGE = 'Do not use `Timecop.freeze`, use `freeze_time` instead. ' \ - 'See https://gitlab.com/gitlab-org/gitlab/-/issues/214432 for more info.' - - def_node_matcher :timecop_freeze?, <<~PATTERN - (send (const nil? :Timecop) :freeze ?_) - PATTERN - - def on_send(node) - return unless timecop_freeze?(node) - - add_offense(node, message: MESSAGE) do |corrector| - each_match_range(node.source_range, /^(Timecop\.freeze)/) do |match_range| - corrector.replace(match_range, 'freeze_time') - end - end - end - end - end - end -end diff --git a/rubocop/cop/rspec/timecop_travel.rb b/rubocop/cop/rspec/timecop_travel.rb deleted file mode 100644 index 03f978be349..00000000000 --- a/rubocop/cop/rspec/timecop_travel.rb +++ /dev/null @@ -1,41 +0,0 @@ -# frozen_string_literal: true - -require 'rubocop-rspec' - -module RuboCop - module Cop - module RSpec - # This cop checks for `Timecop.travel` usage in specs. - # - # @example - # - # # bad - # Timecop.travel(1.day.ago) { create(:issue) } - # - # # good - # travel_to(1.day.ago) { create(:issue) } - # - class TimecopTravel < RuboCop::Cop::Base - extend RuboCop::Cop::AutoCorrector - - include MatchRange - MESSAGE = 'Do not use `Timecop.travel`, use `travel_to` instead. ' \ - 'See https://gitlab.com/gitlab-org/gitlab/-/issues/214432 for more info.' - - def_node_matcher :timecop_travel?, <<~PATTERN - (send (const nil? :Timecop) :travel _) - PATTERN - - def on_send(node) - return unless timecop_travel?(node) - - add_offense(node, message: MESSAGE) do |corrector| - each_match_range(node.source_range, /^(Timecop\.travel)/) do |match_range| - corrector.replace(match_range, 'travel_to') - end - end - end - end - end - end -end |