diff options
| author | Mario de la Ossa <mariodelaossa@gmail.com> | 2019-02-19 23:51:11 +0300 |
|---|---|---|
| committer | Mario de la Ossa <mariodelaossa@gmail.com> | 2019-02-28 20:25:57 +0300 |
| commit | 39afba065970bc5482589039e9e93c04f0c9285f (patch) | |
| tree | f2583f60faabbee632728a6aa13aeed080a71e0b /spec/controllers | |
| parent | b570f53d17f5bc0e72fef9a122b7fe5645db0ea9 (diff) | |
Always use CTE for IssuableFinder counts
Since the CTE is faster than a subquery and the only reason we're using
a subquery is that the CTE can't handle sorting by certain attributes,
let's use the CTE always (when the feature flag is enabled) when
counting, since we can ignore ordering if we just want a count of
results.
Diffstat (limited to 'spec/controllers')
| -rw-r--r-- | spec/controllers/groups_controller_spec.rb | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/spec/controllers/groups_controller_spec.rb b/spec/controllers/groups_controller_spec.rb index 7d87b33e503..21e5122c06b 100644 --- a/spec/controllers/groups_controller_spec.rb +++ b/spec/controllers/groups_controller_spec.rb @@ -227,9 +227,7 @@ describe GroupsController do context 'searching' do before do - # Remove in https://gitlab.com/gitlab-org/gitlab-ce/issues/54643 - stub_feature_flags(use_cte_for_group_issues_search: false) - stub_feature_flags(use_subquery_for_group_issues_search: true) + stub_feature_flags(attempt_group_search_optimizations: true) end it 'works with popularity sort' do |