diff options
| author | Timothy Andrew <mail@timothyandrew.net> | 2016-06-16 05:54:13 +0300 |
|---|---|---|
| committer | Timothy Andrew <mail@timothyandrew.net> | 2016-06-16 05:54:13 +0300 |
| commit | 7ee0898a9ec4a03c9a55841b1cbea67add460c50 (patch) | |
| tree | 02715669032caed346c063a1e56db826f167fca2 /spec/features/profiles | |
| parent | faa0e3f7580bc38d4d12916b4589c64d6c2678a7 (diff) | |
Implement @DouweM's feedback.
- Extract a duplicated `redirect_to`
- Fix a typo: "token", not "certificate"
- Have the "Expires at" datepicker be attached to a text field, not inline
- Have both private tokens and personal access tokens verified in a
single "authenticate_from_private_token" method, both in the
application and API. Move relevant logic to
`User#find_by_personal_access_token`
- Remove unnecessary constants relating to API auth. We don't need a
separate constant for personal access tokens since the param is the
same as for private tokens.
Diffstat (limited to 'spec/features/profiles')
| -rw-r--r-- | spec/features/profiles/personal_access_tokens_spec.rb | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/spec/features/profiles/personal_access_tokens_spec.rb b/spec/features/profiles/personal_access_tokens_spec.rb index d824e1d288d..a85930c7543 100644 --- a/spec/features/profiles/personal_access_tokens_spec.rb +++ b/spec/features/profiles/personal_access_tokens_spec.rb @@ -41,6 +41,7 @@ describe 'Profile > Personal Access Tokens', feature: true, js: true do fill_in "Name", with: FFaker::Product.brand # Set date to 1st of next month + find_field("Expires at").trigger('focus') find("a[title='Next']").click click_on "1" |