Add latest changes from gitlab-org/gitlab@master

8 files changed, 116 insertions, 34 deletions

diff --git a/spec/frontend/__helpers__/matchers/to_match_interpolated_text.js b/spec/frontend/__helpers__/matchers/to_match_interpolated_text.js
index 4ce814a01b4..41e69bffd88 100644
--- a/spec/frontend/__helpers__/matchers/to_match_interpolated_text.js
+++ b/spec/frontend/__helpers__/matchers/to_match_interpolated_text.js
@@ -1,4 +1,5 @@
-export const toMatchInterpolatedText = (received, match) => {
+// Custom matchers are object methods and should be traditional functions to be able to access `utils` on `this`
+export function toMatchInterpolatedText(received, match) {
   let clearReceived;
   let clearMatch;
 
@@ -15,16 +16,14 @@ export const toMatchInterpolatedText = (received, match) => {
   const pass = clearReceived === clearMatch;
   const message = pass
     ? () => `
-        \n\n
-        Expected: ${this.utils.printExpected(clearReceived)}
-        To not equal: ${this.utils.printReceived(clearMatch)}
+        Expected to not be: ${this.utils.printExpected(clearMatch)}
+        Received:           ${this.utils.printReceived(clearReceived)}
         `
     : () =>
         `
-      \n\n
-      Expected: ${this.utils.printExpected(clearReceived)}
-      To equal: ${this.utils.printReceived(clearMatch)}
+      Expected to be: ${this.utils.printExpected(clearMatch)}
+      Received:       ${this.utils.printReceived(clearReceived)}
       `;
 
   return { actual: received, message, pass };
-};
+}
diff --git a/spec/frontend/blob/components/__snapshots__/blob_header_spec.js.snap b/spec/frontend/blob/components/__snapshots__/blob_header_spec.js.snap
index 22bec77276b..b3d93906445 100644
--- a/spec/frontend/blob/components/__snapshots__/blob_header_spec.js.snap
+++ b/spec/frontend/blob/components/__snapshots__/blob_header_spec.js.snap
@@ -13,6 +13,7 @@ exports[`Blob Header Default Actions rendering matches the snapshot 1`] = `
      
     <blob-filepath-stub
       blob="[object Object]"
+      showpath="true"
     />
   </div>
    
diff --git a/spec/frontend/environments/environment_pin_spec.js b/spec/frontend/environments/environment_pin_spec.js
index a9a58071e12..669c974ea4f 100644
--- a/spec/frontend/environments/environment_pin_spec.js
+++ b/spec/frontend/environments/environment_pin_spec.js
@@ -1,5 +1,9 @@
+import Vue from 'vue';
+import VueApollo from 'vue-apollo';
 import { GlDropdownItem } from '@gitlab/ui';
 import { shallowMount } from '@vue/test-utils';
+import cancelAutoStopMutation from '~/environments/graphql/mutations/cancel_auto_stop.mutation.graphql';
+import createMockApollo from 'helpers/mock_apollo_helper';
 import PinComponent from '~/environments/components/environment_pin.vue';
 import eventHub from '~/environments/event_hub';
 
@@ -18,28 +22,66 @@ describe('Pin Component', () => {
 
   const autoStopUrl = '/root/auto-stop-env-test/-/environments/38/cancel_auto_stop';
 
-  beforeEach(() => {
-    factory({
-      propsData: {
-        autoStopUrl,
-      },
+  describe('without graphql', () => {
+    beforeEach(() => {
+      factory({
+        propsData: {
+          autoStopUrl,
+        },
+      });
     });
-  });
 
-  afterEach(() => {
-    wrapper.destroy();
-  });
+    afterEach(() => {
+      wrapper.destroy();
+    });
 
-  it('should render the component with descriptive text', () => {
-    expect(wrapper.text()).toBe('Prevent auto-stopping');
+    it('should render the component with descriptive text', () => {
+      expect(wrapper.text()).toBe('Prevent auto-stopping');
+    });
+
+    it('should emit onPinClick when clicked', () => {
+      const eventHubSpy = jest.spyOn(eventHub, '$emit');
+      const item = wrapper.find(GlDropdownItem);
+
+      item.vm.$emit('click');
+
+      expect(eventHubSpy).toHaveBeenCalledWith('cancelAutoStop', autoStopUrl);
+    });
   });
 
-  it('should emit onPinClick when clicked', () => {
-    const eventHubSpy = jest.spyOn(eventHub, '$emit');
-    const item = wrapper.find(GlDropdownItem);
+  describe('with graphql', () => {
+    Vue.use(VueApollo);
+    let mockApollo;
 
-    item.vm.$emit('click');
+    beforeEach(() => {
+      mockApollo = createMockApollo();
+      factory({
+        propsData: {
+          autoStopUrl,
+          graphql: true,
+        },
+        apolloProvider: mockApollo,
+      });
+    });
 
-    expect(eventHubSpy).toHaveBeenCalledWith('cancelAutoStop', autoStopUrl);
+    afterEach(() => {
+      wrapper.destroy();
+    });
+
+    it('should render the component with descriptive text', () => {
+      expect(wrapper.text()).toBe('Prevent auto-stopping');
+    });
+
+    it('should emit onPinClick when clicked', () => {
+      jest.spyOn(mockApollo.defaultClient, 'mutate');
+      const item = wrapper.find(GlDropdownItem);
+
+      item.vm.$emit('click');
+
+      expect(mockApollo.defaultClient.mutate).toHaveBeenCalledWith({
+        mutation: cancelAutoStopMutation,
+        variables: { autoStopUrl },
+      });
+    });
   });
 });
diff --git a/spec/frontend/environments/graphql/resolvers_spec.js b/spec/frontend/environments/graphql/resolvers_spec.js
index 6b53dc24f0f..21d7e09bad5 100644
--- a/spec/frontend/environments/graphql/resolvers_spec.js
+++ b/spec/frontend/environments/graphql/resolvers_spec.js
@@ -173,9 +173,7 @@ describe('~/frontend/environments/graphql/resolvers', () => {
     it('should post to the auto stop path', async () => {
       mock.onPost(ENDPOINT).reply(200);
 
-      await mockResolvers.Mutation.cancelAutoStop(null, {
-        environment: { autoStopPath: ENDPOINT },
-      });
+      await mockResolvers.Mutation.cancelAutoStop(null, { autoStopUrl: ENDPOINT });
 
       expect(mock.history.post).toContainEqual(
         expect.objectContaining({ url: ENDPOINT, method: 'post' }),
diff --git a/spec/frontend/environments/new_environment_item_spec.js b/spec/frontend/environments/new_environment_item_spec.js
index de36b701a16..0d5d216ba02 100644
--- a/spec/frontend/environments/new_environment_item_spec.js
+++ b/spec/frontend/environments/new_environment_item_spec.js
@@ -191,9 +191,9 @@ describe('~/environments/components/new_environment_item.vue', () => {
       });
 
       it('shows the option to pin the environment if there is an autostop date', () => {
-        const rollback = wrapper.findByRole('menuitem', { name: __('Prevent auto-stopping') });
+        const pin = wrapper.findByRole('menuitem', { name: __('Prevent auto-stopping') });
 
-        expect(rollback.exists()).toBe(true);
+        expect(pin.exists()).toBe(true);
       });
 
       it('shows when the environment auto stops', () => {
@@ -211,9 +211,9 @@ describe('~/environments/components/new_environment_item.vue', () => {
       it('does not show the option to pin the environment if there is no autostop date', () => {
         wrapper = createWrapper({ apolloProvider: createApolloProvider() });
 
-        const rollback = wrapper.findByRole('menuitem', { name: __('Prevent auto-stopping') });
+        const pin = wrapper.findByRole('menuitem', { name: __('Prevent auto-stopping') });
 
-        expect(rollback.exists()).toBe(false);
+        expect(pin.exists()).toBe(false);
       });
 
       it('does not show when the environment auto stops', () => {
@@ -246,9 +246,9 @@ describe('~/environments/components/new_environment_item.vue', () => {
       it('does not show the option to pin the environment if there is no autostop date', () => {
         wrapper = createWrapper({ apolloProvider: createApolloProvider() });
 
-        const rollback = wrapper.findByRole('menuitem', { name: __('Prevent auto-stopping') });
+        const pin = wrapper.findByRole('menuitem', { name: __('Prevent auto-stopping') });
 
-        expect(rollback.exists()).toBe(false);
+        expect(pin.exists()).toBe(false);
       });
 
       it('does not show when the environment auto stops', () => {
diff --git a/spec/frontend/repository/components/blob_content_viewer_spec.js b/spec/frontend/repository/components/blob_content_viewer_spec.js
index 70808a3c7b1..eb9b443c694 100644
--- a/spec/frontend/repository/components/blob_content_viewer_spec.js
+++ b/spec/frontend/repository/components/blob_content_viewer_spec.js
@@ -236,7 +236,7 @@ describe('Blob content viewer component', () => {
 
         await waitForPromises();
 
-        expect(loadViewer).toHaveBeenCalledWith(viewer);
+        expect(loadViewer).toHaveBeenCalledWith(viewer, false);
         expect(wrapper.findComponent(loadViewerReturnValue).exists()).toBe(true);
       },
     );
diff --git a/spec/frontend/repository/components/blob_viewers/lfs_viewer_spec.js b/spec/frontend/repository/components/blob_viewers/lfs_viewer_spec.js
new file mode 100644
index 00000000000..59cca23ebfc
--- /dev/null
+++ b/spec/frontend/repository/components/blob_viewers/lfs_viewer_spec.js
@@ -0,0 +1,41 @@
+import { GlLink, GlSprintf } from '@gitlab/ui';
+import { shallowMount } from '@vue/test-utils';
+import LfsViewer from '~/repository/components/blob_viewers/lfs_viewer.vue';
+
+describe('LFS Viewer', () => {
+  let wrapper;
+
+  const DEFAULT_PROPS = {
+    fileName: 'file_name.js',
+    filePath: '/some/file/path',
+  };
+
+  const createComponent = () => {
+    wrapper = shallowMount(LfsViewer, {
+      propsData: { ...DEFAULT_PROPS },
+      stubs: { GlSprintf },
+    });
+  };
+
+  const findLink = () => wrapper.findComponent(GlLink);
+
+  beforeEach(() => createComponent());
+
+  afterEach(() => wrapper.destroy());
+
+  it('renders the correct text', () => {
+    expect(wrapper.text()).toBe(
+      'This content could not be displayed because it is stored in LFS. You can download it instead.',
+    );
+  });
+
+  it('renders download link', () => {
+    const { filePath, fileName } = DEFAULT_PROPS;
+
+    expect(findLink().attributes()).toMatchObject({
+      target: '_blank',
+      href: filePath,
+      download: fileName,
+    });
+  });
+});
diff --git a/spec/frontend/repository/mock_data.js b/spec/frontend/repository/mock_data.js
index b8ab5cfcef1..2df89965fbe 100644
--- a/spec/frontend/repository/mock_data.js
+++ b/spec/frontend/repository/mock_data.js
@@ -17,6 +17,7 @@ export const simpleViewerMock = {
   canCurrentUserPushToBranch: true,
   archived: false,
   storedExternally: false,
+  externalStorageUrl: '',
   externalStorage: 'lfs',
   rawPath: 'some_file.js',
   replacePath: 'some_file.js/replace',