Add latest changes from gitlab-org/gitlab@master

36 files changed, 56 insertions, 56 deletions

diff --git a/spec/frontend/analytics/usage_trends/utils_spec.js b/spec/frontend/analytics/usage_trends/utils_spec.js
index 656f310dda7..9982e96735e 100644
--- a/spec/frontend/analytics/usage_trends/utils_spec.js
+++ b/spec/frontend/analytics/usage_trends/utils_spec.js
@@ -16,17 +16,17 @@ describe('getAverageByMonth', () => {
     expect(getAverageByMonth(mockCountsData2)).toStrictEqual(countsMonthlyChartData2);
   });
 
-  it('it transforms a data point to the first of the month', () => {
+  it('transforms a data point to the first of the month', () => {
     const item = mockCountsData1[0];
     const firstOfTheMonth = item.recordedAt.replace(/-[0-9]{2}$/, '-01');
     expect(getAverageByMonth([item])).toStrictEqual([[firstOfTheMonth, item.count]]);
   });
 
-  it('it uses sane defaults', () => {
+  it('uses sane defaults', () => {
     expect(getAverageByMonth()).toStrictEqual([]);
   });
 
-  it('it errors when passing null', () => {
+  it('errors when passing null', () => {
     expect(() => {
       getAverageByMonth(null);
     }).toThrow();
diff --git a/spec/frontend/batch_comments/components/preview_dropdown_spec.js b/spec/frontend/batch_comments/components/preview_dropdown_spec.js
index 079b64225e4..283632cb560 100644
--- a/spec/frontend/batch_comments/components/preview_dropdown_spec.js
+++ b/spec/frontend/batch_comments/components/preview_dropdown_spec.js
@@ -53,7 +53,7 @@ describe('Batch comments preview dropdown', () => {
   });
 
   describe('clicking draft', () => {
-    it('it toggles active file when viewDiffsFileByFile is true', async () => {
+    it('toggles active file when viewDiffsFileByFile is true', async () => {
       factory({
         viewDiffsFileByFile: true,
         sortedDrafts: [{ id: 1, file_hash: 'hash' }],
diff --git a/spec/frontend/batch_comments/components/preview_item_spec.js b/spec/frontend/batch_comments/components/preview_item_spec.js
index cb71edd1238..91e6b84a216 100644
--- a/spec/frontend/batch_comments/components/preview_item_spec.js
+++ b/spec/frontend/batch_comments/components/preview_item_spec.js
@@ -118,7 +118,7 @@ describe('Batch comments draft preview item component', () => {
       );
     });
 
-    it('it renders thread resolved text', () => {
+    it('renders thread resolved text', () => {
       expect(vm.$el.querySelector('.draft-note-resolution').textContent).toContain(
         'Thread will be resolved',
       );
diff --git a/spec/frontend/batch_comments/components/review_bar_spec.js b/spec/frontend/batch_comments/components/review_bar_spec.js
index f50db6ab210..0a4c9ff62e4 100644
--- a/spec/frontend/batch_comments/components/review_bar_spec.js
+++ b/spec/frontend/batch_comments/components/review_bar_spec.js
@@ -24,7 +24,7 @@ describe('Batch comments review bar component', () => {
     wrapper.destroy();
   });
 
-  it('it adds review-bar-visible class to body when review bar is mounted', async () => {
+  it('adds review-bar-visible class to body when review bar is mounted', async () => {
     expect(document.body.classList.contains(REVIEW_BAR_VISIBLE_CLASS_NAME)).toBe(false);
 
     createComponent();
@@ -32,7 +32,7 @@ describe('Batch comments review bar component', () => {
     expect(document.body.classList.contains(REVIEW_BAR_VISIBLE_CLASS_NAME)).toBe(true);
   });
 
-  it('it removes review-bar-visible class to body when review bar is destroyed', async () => {
+  it('removes review-bar-visible class to body when review bar is destroyed', async () => {
     createComponent();
 
     wrapper.destroy();
diff --git a/spec/frontend/batch_comments/components/submit_dropdown_spec.js b/spec/frontend/batch_comments/components/submit_dropdown_spec.js
index b28e6d68e40..462ef7e7280 100644
--- a/spec/frontend/batch_comments/components/submit_dropdown_spec.js
+++ b/spec/frontend/batch_comments/components/submit_dropdown_spec.js
@@ -92,7 +92,7 @@ describe('Batch comments submit dropdown', () => {
     canApprove | exists   | existsText
     ${true}    | ${true}  | ${'shows'}
     ${false}   | ${false} | ${'hides'}
-  `('it $existsText approve checkbox if can_approve is $canApprove', ({ canApprove, exists }) => {
+  `('$existsText approve checkbox if can_approve is $canApprove', ({ canApprove, exists }) => {
     factory({ canApprove });
 
     expect(wrapper.findByTestId('approve_merge_request').exists()).toBe(exists);
diff --git a/spec/frontend/boards/components/board_new_issue_spec.js b/spec/frontend/boards/components/board_new_issue_spec.js
index 8b0100d069a..f097f42476a 100644
--- a/spec/frontend/boards/components/board_new_issue_spec.js
+++ b/spec/frontend/boards/components/board_new_issue_spec.js
@@ -90,7 +90,7 @@ describe('Issue boards new issue form', () => {
       });
     });
 
-    it('it uses the first issue ID as moveAfterId', async () => {
+    it('uses the first issue ID as moveAfterId', async () => {
       findBoardNewItem().vm.$emit('form-submit', { title: 'Foo' });
 
       await nextTick();
diff --git a/spec/frontend/clusters_list/components/clusters_main_view_spec.js b/spec/frontend/clusters_list/components/clusters_main_view_spec.js
index 218463b9adf..6f23ed47d2a 100644
--- a/spec/frontend/clusters_list/components/clusters_main_view_spec.js
+++ b/spec/frontend/clusters_list/components/clusters_main_view_spec.js
@@ -142,7 +142,7 @@ describe('ClustersMainViewComponent', () => {
         createWrapper({ certificateBasedClustersEnabled: false });
       });
 
-      it('it displays only the Agent tab', () => {
+      it('displays only the Agent tab', () => {
         expect(findAllTabs()).toHaveLength(1);
         const agentTab = findGlTabAtIndex(0);
 
diff --git a/spec/frontend/code_navigation/utils/index_spec.js b/spec/frontend/code_navigation/utils/index_spec.js
index b8448709f0b..700c912029c 100644
--- a/spec/frontend/code_navigation/utils/index_spec.js
+++ b/spec/frontend/code_navigation/utils/index_spec.js
@@ -17,7 +17,7 @@ describe('getCurrentHoverElement', () => {
     value
     ${'test'}
     ${undefined}
-  `('it returns cached current key', ({ value }) => {
+  `('returns cached current key', ({ value }) => {
     if (value) {
       cachedData.set('current', value);
     }
@@ -52,7 +52,7 @@ describe('addInteractionClass', () => {
     ${1} | ${0} | ${0}
     ${1} | ${0} | ${0}
   `(
-    'it sets code navigation attributes for line $line and character $char',
+    'sets code navigation attributes for line $line and character $char',
     ({ line, char, index }) => {
       addInteractionClass({ path: 'index.js', d: { start_line: line, start_char: char } });
 
diff --git a/spec/frontend/cycle_analytics/value_stream_metrics_spec.js b/spec/frontend/cycle_analytics/value_stream_metrics_spec.js
index 23e41f35b00..9c8cd6a3dbc 100644
--- a/spec/frontend/cycle_analytics/value_stream_metrics_spec.js
+++ b/spec/frontend/cycle_analytics/value_stream_metrics_spec.js
@@ -176,7 +176,7 @@ describe('ValueStreamMetrics', () => {
       await waitForPromises();
     });
 
-    it('it should render an error message', () => {
+    it('should render an error message', () => {
       expect(createFlash).toHaveBeenCalledWith({
         message: `There was an error while fetching value stream analytics ${fakeReqName} data.`,
       });
diff --git a/spec/frontend/deprecated_jquery_dropdown_spec.js b/spec/frontend/deprecated_jquery_dropdown_spec.js
index b18d53b317d..4a070395eaf 100644
--- a/spec/frontend/deprecated_jquery_dropdown_spec.js
+++ b/spec/frontend/deprecated_jquery_dropdown_spec.js
@@ -314,7 +314,7 @@ describe('deprecatedJQueryDropdown', () => {
     });
 
     describe('with a trackSuggestionsClickedLabel', () => {
-      it('it includes data-track attributes', () => {
+      it('includes data-track attributes', () => {
         const dropdown = dropdownWithOptions({
           trackSuggestionClickedLabel: 'some_value_for_label',
         });
@@ -333,7 +333,7 @@ describe('deprecatedJQueryDropdown', () => {
         expect(link).toHaveAttr('data-track-property', 'suggestion-category');
       });
 
-      it('it defaults property to no_category when category not provided', () => {
+      it('defaults property to no_category when category not provided', () => {
         const dropdown = dropdownWithOptions({
           trackSuggestionClickedLabel: 'some_value_for_label',
         });
diff --git a/spec/frontend/diffs/components/app_spec.js b/spec/frontend/diffs/components/app_spec.js
index 2b1bf19471a..b88206c3b9a 100644
--- a/spec/frontend/diffs/components/app_spec.js
+++ b/spec/frontend/diffs/components/app_spec.js
@@ -682,7 +682,7 @@ describe('diffs/components/app', () => {
         ${'123'}          | ${2}
         ${'312'}          | ${1}
       `(
-        'it calls navigateToDiffFileIndex with $index when $link is clicked',
+        'calls navigateToDiffFileIndex with $index when $link is clicked',
         async ({ currentDiffFileId, targetFile }) => {
           createComponent({ fileByFileUserPreference: true }, ({ state }) => {
             state.diffs.diffFiles.push({ file_hash: '123' }, { file_hash: '312' });
diff --git a/spec/frontend/diffs/components/tree_list_spec.js b/spec/frontend/diffs/components/tree_list_spec.js
index 2e37425519d..ca7de8fd751 100644
--- a/spec/frontend/diffs/components/tree_list_spec.js
+++ b/spec/frontend/diffs/components/tree_list_spec.js
@@ -106,7 +106,7 @@ describe('Diffs tree list component', () => {
         ${'index.js'}   | ${1}
         ${'app/*.js'}   | ${1}
         ${'*.js, *.rb'} | ${2}
-      `('it returns $itemSize item for $extension', async ({ extension, itemSize }) => {
+      `('returns $itemSize item for $extension', async ({ extension, itemSize }) => {
         wrapper.find('[data-testid="diff-tree-search"]').setValue(extension);
 
         await nextTick();
diff --git a/spec/frontend/editor/components/source_editor_toolbar_spec.js b/spec/frontend/editor/components/source_editor_toolbar_spec.js
index 6e99eadbd97..bead39ca744 100644
--- a/spec/frontend/editor/components/source_editor_toolbar_spec.js
+++ b/spec/frontend/editor/components/source_editor_toolbar_spec.js
@@ -68,7 +68,7 @@ describe('Source Editor Toolbar', () => {
   });
 
   describe('buttons update', () => {
-    it('it properly updates buttons on Apollo cache update', async () => {
+    it('properly updates buttons on Apollo cache update', async () => {
       const item = buildButton('first', {
         group: EDITOR_TOOLBAR_RIGHT_GROUP,
       });
diff --git a/spec/frontend/editor/source_editor_instance_spec.js b/spec/frontend/editor/source_editor_instance_spec.js
index 3ac77da5729..20ba23d56ff 100644
--- a/spec/frontend/editor/source_editor_instance_spec.js
+++ b/spec/frontend/editor/source_editor_instance_spec.js
@@ -382,7 +382,7 @@ describe('Source Editor Instance', () => {
         },
       );
 
-      it('it does not remove entry from the global registry to keep for potential future re-use', () => {
+      it('does not remove entry from the global registry to keep for potential future re-use', () => {
         const extensionStore = new Map();
         seInstance = new SourceEditorInstance({}, extensionStore);
         const extensions = seInstance.use(fullExtensionsArray);
diff --git a/spec/frontend/emoji/components/utils_spec.js b/spec/frontend/emoji/components/utils_spec.js
index 56f514ee9a8..a17ddb3bb9a 100644
--- a/spec/frontend/emoji/components/utils_spec.js
+++ b/spec/frontend/emoji/components/utils_spec.js
@@ -4,13 +4,13 @@ import { getFrequentlyUsedEmojis, addToFrequentlyUsed } from '~/emoji/components
 jest.mock('~/lib/utils/cookies');
 
 describe('getFrequentlyUsedEmojis', () => {
-  it('it returns null when no saved emojis set', () => {
+  it('returns null when no saved emojis set', () => {
     jest.spyOn(Cookies, 'get').mockReturnValue(null);
 
     expect(getFrequentlyUsedEmojis()).toBe(null);
   });
 
-  it('it returns frequently used emojis object', () => {
+  it('returns frequently used emojis object', () => {
     jest.spyOn(Cookies, 'get').mockReturnValue('thumbsup,thumbsdown');
 
     expect(getFrequentlyUsedEmojis()).toEqual({
diff --git a/spec/frontend/environments/environment_table_spec.js b/spec/frontend/environments/environment_table_spec.js
index 49a643aaac8..a86cfdd56ba 100644
--- a/spec/frontend/environments/environment_table_spec.js
+++ b/spec/frontend/environments/environment_table_spec.js
@@ -363,7 +363,7 @@ describe('Environment table', () => {
   });
 
   describe('sortedEnvironments', () => {
-    it('it should sort children as well', () => {
+    it('should sort children as well', () => {
       const mockItems = [
         {
           name: 'production',
diff --git a/spec/frontend/environments/new_environment_spec.js b/spec/frontend/environments/new_environment_spec.js
index 5a1c1c7714c..2405cb82eac 100644
--- a/spec/frontend/environments/new_environment_spec.js
+++ b/spec/frontend/environments/new_environment_spec.js
@@ -65,7 +65,7 @@ describe('~/environments/components/new.vue', () => {
     input         | value
     ${() => name} | ${'test'}
     ${() => url}  | ${'https://example.org'}
-  `('it changes the value of the input to $value', async ({ input, value }) => {
+  `('changes the value of the input to $value', async ({ input, value }) => {
     await input().setValue(value);
 
     expect(input().element.value).toBe(value);
diff --git a/spec/frontend/error_tracking/components/error_tracking_list_spec.js b/spec/frontend/error_tracking/components/error_tracking_list_spec.js
index b7dffbbec04..805ada54509 100644
--- a/spec/frontend/error_tracking/components/error_tracking_list_spec.js
+++ b/spec/frontend/error_tracking/components/error_tracking_list_spec.js
@@ -164,19 +164,19 @@ describe('ErrorTrackingList', () => {
         expect(findSortDropdown().exists()).toBe(true);
       });
 
-      it('it searches by query', () => {
+      it('searches by query', () => {
         findSearchBox().vm.$emit('input', 'search');
         findSearchBox().trigger('keyup.enter');
         expect(actions.searchByQuery.mock.calls[0][1]).toBe('search');
       });
 
-      it('it sorts by fields', () => {
+      it('sorts by fields', () => {
         const findSortItem = () => findSortDropdown().find('.dropdown-item');
         findSortItem().trigger('click');
         expect(actions.sortByField).toHaveBeenCalled();
       });
 
-      it('it filters by status', () => {
+      it('filters by status', () => {
         const findStatusFilter = () => findStatusFilterDropdown().find('.dropdown-item');
         findStatusFilter().trigger('click');
         expect(actions.filterByStatus).toHaveBeenCalled();
diff --git a/spec/frontend/filtered_search/droplab/drop_down_spec.js b/spec/frontend/filtered_search/droplab/drop_down_spec.js
index f49dbfcf79c..6fbb4394944 100644
--- a/spec/frontend/filtered_search/droplab/drop_down_spec.js
+++ b/spec/frontend/filtered_search/droplab/drop_down_spec.js
@@ -557,11 +557,11 @@ describe('DropLab DropDown', () => {
       DropDown.prototype.show.call(testContext.dropdown);
     });
 
-    it('it should set .list display to block', () => {
+    it('should set .list display to block', () => {
       expect(testContext.list.style.display).toBe('block');
     });
 
-    it('it should set .hidden to false', () => {
+    it('should set .hidden to false', () => {
       expect(testContext.dropdown.hidden).toBe(false);
     });
 
@@ -591,11 +591,11 @@ describe('DropLab DropDown', () => {
       DropDown.prototype.hide.call(testContext.dropdown);
     });
 
-    it('it should set .list display to none', () => {
+    it('should set .list display to none', () => {
       expect(testContext.list.style.display).toBe('none');
     });
 
-    it('it should set .hidden to true', () => {
+    it('should set .hidden to true', () => {
       expect(testContext.dropdown.hidden).toBe(true);
     });
   });
@@ -648,11 +648,11 @@ describe('DropLab DropDown', () => {
       DropDown.prototype.destroy.call(testContext.dropdown);
     });
 
-    it('it should call .hide', () => {
+    it('should call .hide', () => {
       expect(testContext.dropdown.hide).toHaveBeenCalled();
     });
 
-    it('it should call .removeEventListener', () => {
+    it('should call .removeEventListener', () => {
       expect(testContext.list.removeEventListener).toHaveBeenCalledWith(
         'click',
         testContext.eventWrapper.clickEvent,
diff --git a/spec/frontend/groups/components/group_item_spec.js b/spec/frontend/groups/components/group_item_spec.js
index fcf305d60e6..3aa66644c19 100644
--- a/spec/frontend/groups/components/group_item_spec.js
+++ b/spec/frontend/groups/components/group_item_spec.js
@@ -274,7 +274,7 @@ describe('GroupItemComponent', () => {
         ${'itemscope'} | ${'itemscope'}
         ${'itemtype'}  | ${'https://schema.org/Organization'}
         ${'itemprop'}  | ${'subOrganization'}
-      `('it does set correct $attr', ({ attr, value } = {}) => {
+      `('does set correct $attr', ({ attr, value } = {}) => {
         expect(wrapper.attributes(attr)).toBe(value);
       });
 
@@ -283,7 +283,7 @@ describe('GroupItemComponent', () => {
         ${'img'}                               | ${'logo'}
         ${'[data-testid="group-name"]'}        | ${'name'}
         ${'[data-testid="group-description"]'} | ${'description'}
-      `('it does set correct $selector', ({ selector, propValue } = {}) => {
+      `('does set correct $selector', ({ selector, propValue } = {}) => {
         expect(wrapper.find(selector).attributes('itemprop')).toBe(propValue);
       });
     });
diff --git a/spec/frontend/issues/create_merge_request_dropdown_spec.js b/spec/frontend/issues/create_merge_request_dropdown_spec.js
index cb7173c56a8..cc2ee84348a 100644
--- a/spec/frontend/issues/create_merge_request_dropdown_spec.js
+++ b/spec/frontend/issues/create_merge_request_dropdown_spec.js
@@ -106,7 +106,7 @@ describe('CreateMergeRequestDropdown', () => {
       loading  | hasClass
       ${true}  | ${false}
       ${false} | ${true}
-    `('it toggle loading spinner when loading is $loading', ({ loading, hasClass }) => {
+    `('toggle loading spinner when loading is $loading', ({ loading, hasClass }) => {
       dropdown.setLoading(loading);
 
       expect(document.querySelector('.js-spinner').classList.contains('gl-display-none')).toEqual(
diff --git a/spec/frontend/lib/utils/is_navigating_away_spec.js b/spec/frontend/lib/utils/is_navigating_away_spec.js
index e1230fe96bf..b8a01a1706c 100644
--- a/spec/frontend/lib/utils/is_navigating_away_spec.js
+++ b/spec/frontend/lib/utils/is_navigating_away_spec.js
@@ -6,7 +6,7 @@ describe('isNavigatingAway', () => {
     setNavigatingForTestsOnly(false);
   });
 
-  it.each([false, true])('it returns the navigation flag with value %s', (flag) => {
+  it.each([false, true])('returns the navigation flag with value %s', (flag) => {
     setNavigatingForTestsOnly(flag);
     expect(isNavigatingAway()).toEqual(flag);
   });
diff --git a/spec/frontend/lib/utils/navigation_utility_spec.js b/spec/frontend/lib/utils/navigation_utility_spec.js
index 6d3a871eb33..4dbd50223d5 100644
--- a/spec/frontend/lib/utils/navigation_utility_spec.js
+++ b/spec/frontend/lib/utils/navigation_utility_spec.js
@@ -63,7 +63,7 @@ describe('initPrefetchLinks', () => {
     expect(newLink.addEventListener).toHaveBeenCalled();
   });
 
-  it('it is not fired when less then 100ms over link', () => {
+  it('is not fired when less then 100ms over link', () => {
     const mouseOverEvent = new Event('mouseover');
     const mouseOutEvent = new Event('mouseout');
 
diff --git a/spec/frontend/merge_request_tabs_spec.js b/spec/frontend/merge_request_tabs_spec.js
index 2001bb5f95e..c6e90a4b20d 100644
--- a/spec/frontend/merge_request_tabs_spec.js
+++ b/spec/frontend/merge_request_tabs_spec.js
@@ -333,7 +333,7 @@ describe('MergeRequestTabs', () => {
       ${'show'}    | ${false} | ${'shows'}
       ${'diffs'}   | ${true}  | ${'hides'}
       ${'commits'} | ${true}  | ${'hides'}
-    `('it $hidesText expand button on $tab tab', ({ tab, hides }) => {
+    `('$hidesText expand button on $tab tab', ({ tab, hides }) => {
       window.gon = { features: { movedMrSidebar: true } };
 
       const expandButton = document.createElement('div');
diff --git a/spec/frontend/monitoring/components/dashboard_panel_spec.js b/spec/frontend/monitoring/components/dashboard_panel_spec.js
index d797d9e2ad0..339c1710a9e 100644
--- a/spec/frontend/monitoring/components/dashboard_panel_spec.js
+++ b/spec/frontend/monitoring/components/dashboard_panel_spec.js
@@ -430,7 +430,7 @@ describe('Dashboard Panel', () => {
       expect(findTimeChart().props().projectPath).toBe(mockProjectPath);
     });
 
-    it('it renders a time series chart with no errors', () => {
+    it('renders a time series chart with no errors', () => {
       expect(wrapper.findComponent(MonitorTimeSeriesChart).exists()).toBe(true);
     });
   });
diff --git a/spec/frontend/monitoring/components/dashboard_spec.js b/spec/frontend/monitoring/components/dashboard_spec.js
index 608404e5c5b..6109b40eee2 100644
--- a/spec/frontend/monitoring/components/dashboard_spec.js
+++ b/spec/frontend/monitoring/components/dashboard_spec.js
@@ -407,7 +407,7 @@ describe('Dashboard', () => {
       await nextTick();
     });
 
-    it('it does not show loading icons in any group', async () => {
+    it('does not show loading icons in any group', async () => {
       setupStoreWithData(store);
 
       await nextTick();
@@ -614,7 +614,7 @@ describe('Dashboard', () => {
         const findFirstDraggableRemoveButton = () =>
           findDraggablePanels().at(0).find('.js-draggable-remove');
 
-        it('it enables draggables', async () => {
+        it('enables draggables', async () => {
           findRearrangeButton().vm.$emit('click');
           await nextTick();
 
@@ -656,7 +656,7 @@ describe('Dashboard', () => {
           expect(findDraggablePanels().length).toEqual(metricsDashboardPanelCount - 1);
         });
 
-        it('it disables draggables when clicked again', async () => {
+        it('disables draggables when clicked again', async () => {
           findRearrangeButton().vm.$emit('click');
           await nextTick();
 
diff --git a/spec/frontend/notes/components/discussion_resolve_with_issue_button_spec.js b/spec/frontend/notes/components/discussion_resolve_with_issue_button_spec.js
index 71406eeb7b4..a185f11ffaa 100644
--- a/spec/frontend/notes/components/discussion_resolve_with_issue_button_spec.js
+++ b/spec/frontend/notes/components/discussion_resolve_with_issue_button_spec.js
@@ -19,7 +19,7 @@ describe('ResolveWithIssueButton', () => {
     wrapper.destroy();
   });
 
-  it('it should have a link with the provided link property as href', () => {
+  it('should have a link with the provided link property as href', () => {
     const button = wrapper.findComponent(GlButton);
 
     expect(button.attributes().href).toBe(url);
diff --git a/spec/frontend/packages_and_registries/package_registry/components/details/nuget_installation_spec.js b/spec/frontend/packages_and_registries/package_registry/components/details/nuget_installation_spec.js
index d324d43258c..9449c40c7c6 100644
--- a/spec/frontend/packages_and_registries/package_registry/components/details/nuget_installation_spec.js
+++ b/spec/frontend/packages_and_registries/package_registry/components/details/nuget_installation_spec.js
@@ -71,7 +71,7 @@ describe('NugetInstallation', () => {
       });
     });
 
-    it('it has docs link', () => {
+    it('has docs link', () => {
       expect(findSetupDocsLink().attributes()).toMatchObject({
         href: NUGET_HELP_PATH,
         target: '_blank',
diff --git a/spec/frontend/packages_and_registries/package_registry/components/list/tokens/package_type_token_spec.js b/spec/frontend/packages_and_registries/package_registry/components/list/tokens/package_type_token_spec.js
index 9268dd0b049..8f3c8667c47 100644
--- a/spec/frontend/packages_and_registries/package_registry/components/list/tokens/package_type_token_spec.js
+++ b/spec/frontend/packages_and_registries/package_registry/components/list/tokens/package_type_token_spec.js
@@ -24,13 +24,13 @@ describe('packages_filter', () => {
     wrapper = null;
   });
 
-  it('it binds all of his attrs to filtered search token', () => {
+  it('binds all of his attrs to filtered search token', () => {
     mountComponent({ attrs: { foo: 'bar' } });
 
     expect(findFilteredSearchToken().attributes('foo')).toBe('bar');
   });
 
-  it('it binds all of his events to filtered search token', () => {
+  it('binds all of his events to filtered search token', () => {
     const clickListener = jest.fn();
     mountComponent({ listeners: { click: clickListener } });
 
diff --git a/spec/frontend/packages_and_registries/package_registry/pages/details_spec.js b/spec/frontend/packages_and_registries/package_registry/pages/details_spec.js
index 6078657daf4..83158d1cc5e 100644
--- a/spec/frontend/packages_and_registries/package_registry/pages/details_spec.js
+++ b/spec/frontend/packages_and_registries/package_registry/pages/details_spec.js
@@ -178,7 +178,7 @@ describe('PackagesApp', () => {
       ${PACKAGE_TYPE_PYPI}     | ${true}
       ${PACKAGE_TYPE_NPM}      | ${false}
     `(
-      `It is $visible that the component is visible when the package is $packageType`,
+      `is $visible that the component is visible when the package is $packageType`,
       async ({ packageType, visible }) => {
         createComponent({
           resolver: jest.fn().mockResolvedValue(
diff --git a/spec/frontend/pipelines/graph/graph_component_wrapper_spec.js b/spec/frontend/pipelines/graph/graph_component_wrapper_spec.js
index a2097dda860..587a3c67168 100644
--- a/spec/frontend/pipelines/graph/graph_component_wrapper_spec.js
+++ b/spec/frontend/pipelines/graph/graph_component_wrapper_spec.js
@@ -554,7 +554,7 @@ describe('Pipeline graph wrapper', () => {
           mock.restore();
         });
 
-        it('it calls reportPerformance with expected arguments', () => {
+        it('calls reportPerformance with expected arguments', () => {
           expect(markAndMeasure).toHaveBeenCalled();
           expect(reportPerformance).toHaveBeenCalled();
           expect(reportPerformance).toHaveBeenCalledWith(metricsPath, metricsData);
diff --git a/spec/frontend/pipelines/graph/job_item_spec.js b/spec/frontend/pipelines/graph/job_item_spec.js
index 4f0da09fec6..05776ec0706 100644
--- a/spec/frontend/pipelines/graph/job_item_spec.js
+++ b/spec/frontend/pipelines/graph/job_item_spec.js
@@ -59,7 +59,7 @@ describe('pipeline graph job item', () => {
       });
     });
 
-    it('it should render status and name', () => {
+    it('should render status and name', () => {
       expect(wrapper.find('.ci-status-icon-success').exists()).toBe(true);
       expect(wrapper.find('a').exists()).toBe(false);
 
@@ -72,7 +72,7 @@ describe('pipeline graph job item', () => {
   });
 
   describe('action icon', () => {
-    it('it should render the action icon', () => {
+    it('should render the action icon', () => {
       createWrapper({ job: mockJob });
 
       const actionComponent = findActionComponent();
@@ -82,7 +82,7 @@ describe('pipeline graph job item', () => {
       expect(actionComponent.attributes('disabled')).not.toBe('disabled');
     });
 
-    it('it should render disabled action icon when user cannot run the action', () => {
+    it('should render disabled action icon when user cannot run the action', () => {
       createWrapper({ job: mockJobWithUnauthorizedAction });
 
       const actionComponent = findActionComponent();
diff --git a/spec/frontend/sidebar/components/assignees/assignee_avatar_link_spec.js b/spec/frontend/sidebar/components/assignees/assignee_avatar_link_spec.js
index 517b4f12559..8cde70ff8da 100644
--- a/spec/frontend/sidebar/components/assignees/assignee_avatar_link_spec.js
+++ b/spec/frontend/sidebar/components/assignees/assignee_avatar_link_spec.js
@@ -143,7 +143,7 @@ describe('AssigneeAvatarLink component', () => {
     issuableType       | userId
     ${'merge_request'} | ${undefined}
     ${'issue'}         | ${'1'}
-  `('it sets data-user-id as $userId for $issuableType', ({ issuableType, userId }) => {
+  `('sets data-user-id as $userId for $issuableType', ({ issuableType, userId }) => {
     createComponent({
       issuableType,
     });
diff --git a/spec/frontend/vue_merge_request_widget/mr_widget_options_spec.js b/spec/frontend/vue_merge_request_widget/mr_widget_options_spec.js
index 330f5f6e036..cc894f94f80 100644
--- a/spec/frontend/vue_merge_request_widget/mr_widget_options_spec.js
+++ b/spec/frontend/vue_merge_request_widget/mr_widget_options_spec.js
@@ -845,7 +845,7 @@ describe('MrWidgetOptions', () => {
       ${'closed'} | ${false} | ${'hides'}
       ${'merged'} | ${true}  | ${'shows'}
       ${'open'}   | ${true}  | ${'shows'}
-    `('it $showText merge error when state is $state', ({ state, show }) => {
+    `('$showText merge error when state is $state', ({ state, show }) => {
       createComponent({ ...mockData, state, merge_error: 'Error!' });
 
       expect(wrapper.find('[data-testid="merge_error"]').exists()).toBe(show);
diff --git a/spec/frontend/vue_shared/components/paginated_list_spec.js b/spec/frontend/vue_shared/components/paginated_list_spec.js
index 9f819cc4e94..ae9c920ebd2 100644
--- a/spec/frontend/vue_shared/components/paginated_list_spec.js
+++ b/spec/frontend/vue_shared/components/paginated_list_spec.js
@@ -49,7 +49,7 @@ describe('Pagination links component', () => {
     });
 
     describe('rendering', () => {
-      it('it renders the gl-paginated-list', () => {
+      it('renders the gl-paginated-list', () => {
         expect(wrapper.find('ul.list-group').exists()).toBe(true);
         expect(wrapper.findAll('li.list-group-item').length).toBe(2);
       });
diff --git a/spec/frontend/vue_shared/security_reports/components/manage_via_mr_spec.js b/spec/frontend/vue_shared/security_reports/components/manage_via_mr_spec.js
index 39909e26ef0..0a5e46d9263 100644
--- a/spec/frontend/vue_shared/security_reports/components/manage_via_mr_spec.js
+++ b/spec/frontend/vue_shared/security_reports/components/manage_via_mr_spec.js
@@ -93,7 +93,7 @@ describe('ManageViaMr component', () => {
           createComponent({ apolloProvider, featureName, featureType, isFeatureConfigured: true });
         });
 
-        it('it does not render a button', () => {
+        it('does not render a button', () => {
           expect(findButton().exists()).toBe(false);
         });
       });
@@ -104,7 +104,7 @@ describe('ManageViaMr component', () => {
           createComponent({ apolloProvider, featureName, featureType, isFeatureConfigured: false });
         });
 
-        it('it does render a button', () => {
+        it('does render a button', () => {
           expect(findButton().exists()).toBe(true);
         });