diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-01-21 03:11:07 +0300 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-01-21 03:11:07 +0300 |
commit | 9f021745a60369298705393103f621ff73a2b286 (patch) | |
tree | a6e9f85a8f35245e4ccef5f532c6ca6857f08d9e /spec/helpers | |
parent | ef8c47e97e1c178291e4857314a3f53875d75062 (diff) |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/helpers')
-rw-r--r-- | spec/helpers/groups_helper_spec.rb | 78 | ||||
-rw-r--r-- | spec/helpers/invite_members_helper_spec.rb | 5 |
2 files changed, 82 insertions, 1 deletions
diff --git a/spec/helpers/groups_helper_spec.rb b/spec/helpers/groups_helper_spec.rb index 8eb1b7b3b3d..61aaa618c45 100644 --- a/spec/helpers/groups_helper_spec.rb +++ b/spec/helpers/groups_helper_spec.rb @@ -444,4 +444,82 @@ RSpec.describe GroupsHelper do end end end + + describe '#group_open_issues_count' do + let_it_be(:current_user) { create(:user) } + let_it_be(:group) { create(:group, :public) } + let_it_be(:count_service) { Groups::OpenIssuesCountService } + + before do + allow(helper).to receive(:current_user) { current_user } + end + + context 'when cached_sidebar_open_issues_count feature flag is enabled' do + before do + stub_feature_flags(cached_sidebar_open_issues_count: true) + end + + it 'returns count value from cache' do + allow_next_instance_of(count_service) do |service| + allow(service).to receive(:count).and_return(2500) + end + + expect(helper.group_open_issues_count(group)).to eq('2.5k') + end + end + + context 'when cached_sidebar_open_issues_count feature flag is disabled' do + before do + stub_feature_flags(cached_sidebar_open_issues_count: false) + end + + it 'returns not cached issues count' do + allow(helper).to receive(:group_issues_count).and_return(2500) + + expect(helper.group_open_issues_count(group)).to eq('2,500') + end + end + end + + describe '#cached_open_group_issues_count' do + let_it_be(:current_user) { create(:user) } + let_it_be(:group) { create(:group, name: 'group') } + let_it_be(:count_service) { Groups::OpenIssuesCountService } + + before do + allow(helper).to receive(:current_user) { current_user } + end + + it 'returns all digits for count value under 1000' do + allow_next_instance_of(count_service) do |service| + allow(service).to receive(:count).and_return(999) + end + + expect(helper.cached_open_group_issues_count(group)).to eq('999') + end + + it 'returns truncated digits for count value over 1000' do + allow_next_instance_of(count_service) do |service| + allow(service).to receive(:count).and_return(2300) + end + + expect(helper.cached_open_group_issues_count(group)).to eq('2.3k') + end + + it 'returns truncated digits for count value over 10000' do + allow_next_instance_of(count_service) do |service| + allow(service).to receive(:count).and_return(12560) + end + + expect(helper.cached_open_group_issues_count(group)).to eq('12.6k') + end + + it 'returns truncated digits for count value over 100000' do + allow_next_instance_of(count_service) do |service| + allow(service).to receive(:count).and_return(112560) + end + + expect(helper.cached_open_group_issues_count(group)).to eq('112.6k') + end + end end diff --git a/spec/helpers/invite_members_helper_spec.rb b/spec/helpers/invite_members_helper_spec.rb index ee7a30cd4cb..576021b37b3 100644 --- a/spec/helpers/invite_members_helper_spec.rb +++ b/spec/helpers/invite_members_helper_spec.rb @@ -7,6 +7,10 @@ RSpec.describe InviteMembersHelper do let_it_be(:developer) { create(:user, developer_projects: [project]) } let(:owner) { project.owner } + before do + helper.extend(Gitlab::Experimentation::ControllerConcern) + end + context 'with project' do before do assign(:project, project) @@ -202,7 +206,6 @@ RSpec.describe InviteMembersHelper do before do allow(helper).to receive(:experiment_tracking_category_and_group) { '_track_property_' } - allow(helper).to receive(:tracking_label) allow(helper).to receive(:current_user) { owner } end |